Bumped version

* Ensured thumbnail is converted to jpg before embedding

* Ensured media indexing doesn't fail if an upload date can't be parsed

.credo.exs

@@ -128,7 +128,7 @@
           {Credo.Check.Refactor.MatchInCondition, []},
           {Credo.Check.Refactor.NegatedConditionsInUnless, []},
           {Credo.Check.Refactor.NegatedConditionsWithElse, []},
-          {Credo.Check.Refactor.Nesting, [max_nesting: 4]},
+          {Credo.Check.Refactor.Nesting, []},
           {Credo.Check.Refactor.RedundantWithClauseResult, []},
           {Credo.Check.Refactor.RejectReject, []},
           {Credo.Check.Refactor.UnlessWithElse, []},

.github/pull_request_template.md

@@ -13,5 +13,3 @@ N/A
 ## Any other comments?
 
 N/A
-
-- [ ] I am the original author of this code and I am giving it freely to the community and Pinchflat project maintainers

.github/workflows/build_and_push_docker.yml

@@ -0,0 +1,32 @@
+name: Build and Push Docker Image
+
+on:
+  workflow_dispatch:
+    inputs:
+      image_tag:
+        description: 'Docker Image Tag'
+        required: true
+        default: 'dev'
+
+jobs:
+  docker:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Login to Docker Hub
+        uses: docker/login-action@v3
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      - name: Build and push
+        uses: docker/build-push-action@v5
+        with:
+          push: true
+          file: ./selfhosted.Dockerfile
+          tags: 'keglin/pinchflat:${{ github.event.inputs.image_tag }}'

.github/workflows/docker_release.yml

@@ -1,81 +0,0 @@
-name: Docker Release
-
-on:
-  workflow_dispatch:
-    inputs:
-      platforms:
-        type: choice
-        description: 'Build Platforms'
-        required: true
-        default: 'linux/amd64'
-        options:
-          - 'linux/amd64'
-          - 'linux/amd64,linux/arm64'
-  push:
-    branches:
-      - master
-  release:
-    types:
-      - published
-
-jobs:
-  build_and_push_docker:
-    runs-on: ubuntu-latest
-    env:
-      dev_arch: 'linux/amd64'
-      release_arch: 'linux/amd64,linux/arm64'
-    permissions:
-      contents: read
-      packages: write
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Docker meta
-        id: meta
-        uses: docker/metadata-action@v5
-        with:
-          images: |
-            docker.io/keglin/pinchflat
-            ghcr.io/${{ github.repository }}
-          # All non-release actions will be tagged as `dev` (ie: push, workflow_dispatch)
-          tags: |
-            type=semver,pattern={{version}},prefix=v
-            type=semver,pattern={{major}}.{{minor}},prefix=v
-            type=semver,pattern={{major}},prefix=v
-            type=raw,value=dev,enable=${{ github.event_name != 'release' }}
-          flavor: |
-            latest=auto
-
-      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
-
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
-
-      - name: Login to Docker Hub
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
-
-      - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
-        with:
-          registry: ghcr.io
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Build and Push
-        uses: docker/build-push-action@v5
-        with:
-          context: .
-          file: ./selfhosted.Dockerfile
-          # If the event is a release, use the release_arch, otherwise use the
-          # platforms input if present, falling back to dev_arch
-          platforms: ${{ github.event_name == 'release' && env.release_arch || (github.event.inputs.platforms || env.dev_arch) }}
-          push: true
-          tags: ${{ steps.meta.outputs.tags }}
-          labels: ${{ steps.meta.outputs.labels }}
-          cache-from: type=gha
-          cache-to: type=gha,mode=max

.iex.exs

@@ -22,4 +22,42 @@ alias Pinchflat.Metadata.MetadataFileHelpers
 
 alias Pinchflat.SlowIndexing.FileFollowerServer
 
-Pinchflat.Release.check_file_permissions()
+defmodule IexHelpers do
+  def playlist_url do
+    "https://www.youtube.com/playlist?list=PLmqC3wPkeL8kSlTCcSMDD63gmSi7evcXS"
+  end
+
+  def channel_url do
+    "https://www.youtube.com/c/TheUselessTrials"
+  end
+
+  def video_url do
+    "https://www.youtube.com/watch?v=bR52O78ZIUw"
+  end
+
+  def last_media_item do
+    Repo.one(from m in MediaItem, limit: 1)
+  end
+
+  def details(type) do
+    source =
+      case type do
+        :playlist -> playlist_url()
+        :channel -> channel_url()
+      end
+
+    YtDlpCollection.get_source_details(source)
+  end
+
+  def ids(type) do
+    source =
+      case type do
+        :playlist -> playlist_url()
+        :channel -> channel_url()
+      end
+
+    YtDlpCollection.get_media_attributes_for_collection(source)
+  end
+end
+
+import IexHelpers

.sobelow-conf

@@ -9,15 +9,7 @@
   threshold: :low,
   # All of these are ignorable because this app is intended to be single-user and self-hosted.
   # There is an expectation that the user won't intentionally run a FS Traversal on themselves
-  ignore:
-    [
-      "CI.System",
-      "Traversal.FileModule",
-      "Config.HTTPS",
-      "Config.CSP",
-      "XSS.ContentType",
-      "Traversal.SendFile"
-    ],
+  ignore: ["CI.System", "Traversal.FileModule", "Config.HTTPS", "Config.CSP"],
   ignore_files: [],
   version: false
 ]

README.md

@@ -1,129 +1,39 @@
-<p align="center">  
-  <img 
-    src="priv/static/images/originals/logo-white-wordmark-with-background.png" 
-    alt="Pinchflat Logo by @hernandito"
-    width="700" 
-  />
-</p>
+# Pinchflat (Alpha)
 
-<p align="center">  
-  <sup>
-    <em>logo by <a href="https://github.com/hernandito" target="_blank">@hernandito</a></em>
-  </sup>
-</p>
+This is alpha software and anything can break at any time. I make not guarantees about the stability of this software, forward-compatibility of updates, or integrity (both related to and independent of Pinchflat). Essentially, use at your own risk and expect there will be rough edges.
 
-# Your next YouTube media manager
+## What is Pinchflat?
 
-## Table of contents:
+TODO: expand on this.
 
-- [What it does](#what-it-does)
-- [Features](#features)
-- [Screenshots](#screenshots)
-- [Installation](#installation)
-  - [Unraid](#unraid)
-  - [Docker](#docker)
-- [Username and Password (authentication)](https://github.com/kieraneglin/pinchflat/wiki/Username-and-Password)
-- [Frequently asked questions](https://github.com/kieraneglin/pinchflat/wiki/Frequently-Asked-Questions)
-- [Documentation](https://github.com/kieraneglin/pinchflat/wiki)
-- [EFF donations](#eff-donations)
-- [Pre-release disclaimer](#pre-release-disclaimer)
-- [Development and Contributing](https://github.com/kieraneglin/pinchflat/wiki/Development-and-Contributing)
+Pinchflat is a lightweight self-contained app for downloading YouTube content. For now, it is not intended as a way to consume content, but instead as a way to download content to disk using specified rules and schedules.
 
-## What it does
-
-Pinchflat is a self-hosted app for downloading YouTube content built using [yt-dlp](https://github.com/yt-dlp/yt-dlp). It's designed to be lightweight, self-contained, and easy to use. You set up rules for how to download content from YouTube channels or playlists and it'll do the rest, checking periodically for new content. It's perfect for people who want to download content for use in with a media center app (Plex, Jellyfin, Kodi) or for those who want to archive media!
-
-It's _not_ great for downloading one-off videos - it's built to download large amounts of content and keep it up to date. It's also not meant for consuming content in-app - Pinchflat downloads content to disk where you can then watch it with a media center app or VLC.
-
-If it doesn't work for your use case, please make a feature request! You can also check out these great alternatives: [Tube Archivist](https://github.com/tubearchivist/tubearchivist), [ytdl-sub](https://github.com/jmbannon/ytdl-sub), and [TubeSync](https://github.com/meeb/tubesync)
-
-## Features
-
-- Self-contained - just one Docker container with no external dependencies
-- Powerful naming system so content is stored where and how you want it
-- Easy-to-use web interface with presets to get you started right away
-- First-class support for media center apps like Plex, Jellyfin, and Kodi
-- Supports serving RSS feeds to your favourite podcast app (beta - [docs](<https://github.com/kieraneglin/pinchflat/wiki/Podcast-RSS-Feeds-(beta)>))
-- Automatically downloads new content from channels and playlists
-  - Uses a novel approach to download new content more quickly than other apps
-- Supports downloading audio content
-- Custom rules for handling YouTube Shorts and livestreams
-- Optionally automatically delete old content ([docs](https://github.com/kieraneglin/pinchflat/wiki/Automatically-Delete-Media))
-- Advanced options like setting cutoff dates and filtering by title
-- Reliable hands-off operation
-- Can pass cookies to YouTube to download your private playlists ([docs](https://github.com/kieraneglin/pinchflat/wiki/YouTube-Cookies))
-- Sponsorblock integration
-
-## Screenshots
-
-<img src="priv/static/images/app-form-screenshot.png" alt="Pinchflat screenshot" width="700" />
-<img src="priv/static/images/app-screenshot.png" alt="Pinchflat screenshot" width="700" />
+I have plans for more to come, but for now this is the focus. Think of Pinchflat as nothing more than an automated way to get content from YouTube to your disk.
 
 ## Installation
 
-### Unraid
+Pinchflat is designed to be self-hosted. I'm building it for my own needs which means it's designed to work well with Unraid, but it should work on any computer/server that can run Docker images.
 
-Simply search for Pinchflat in the Community Apps store!
-
-### Portainer
-
-Important: See the note below about storing config on a network file share. It's preferred to store the config on a local disk if at all possible.
-
-Docker Compose file:
-
-```yaml
-version: '3'
-services:
-  pinchflat:
-    image: keglin/pinchflat:latest
-    ports:
-      - '8945:8945'
-    volumes:
-      - /host/path/to/config:/config
-      - /host/path/to/downloads:/downloads
-```
-
-### Docker
-
-1. Create two directories on your host machine: one for storing config and one for storing downloaded media. Make sure they're both writable by the user running the Docker container.
-2. Prepare the docker image in one of the two ways below:
-   - **From GHCR:** `docker pull ghcr.io/kieraneglin/pinchflat:latest`
-     - NOTE: also available on Docker Hub at `keglin/pinchflat:latest`
-   - **Building locally:** `docker build . --file selfhosted.Dockerfile -t ghcr.io/kieraneglin/pinchflat:latest`
-3. Run the container:
+I'll update with Unraid instructions once I get something in the Community Apps store. Until then, here's how you build it with Docker:
 
 ```bash
-# Be sure to replace /host/path/to/config and /host/path/to/downloads below with
-# the paths to the directories you created in step 1
+docker build . --file selfhosted.Dockerfile -t pinchflat:dev
+
 docker run \
   -p 8945:8945 \
-  -v /host/path/to/config:/config \
-  -v /host/path/to/downloads:/downloads \
-  ghcr.io/kieraneglin/pinchflat:latest
+  -v /Users/work/Desktop/test_volumes/config:/config \
+  -v /Users/work/Desktop/test_volumes/downloads:/downloads \
+  pinchflat:dev
 ```
 
-### IMPORTANT: File permissions
+## Authentication
 
-You _must_ ensure the host directories you've mounted are writable by the user running the Docker container. If you get a permission error follow the steps it suggests. See [#106](https://github.com/kieraneglin/pinchflat/issues/106) for more.
-
-It's recommended to not run the container as root. Doing so can create permission issues if other apps need to work with the downloaded media. If you need to run any command as root, you can run `su` from the container's shell as there is no password set for the root user.
-
-### Advanced: storing Pinchflat config directory on a network share
-
-README: This is currently in the testing phase and not a recommended option (yet). The implications of changing this setting isn't clear and this could, conceivably, result in data loss. Only change this setting if you know what you're doing, why this is important, and are okay with possible data loss or DB corruption. This may become the default in the future once it's been tested more thoroughly.
-
-As pointed out in [#137](https://github.com/kieraneglin/pinchflat/issues/137), SQLite doesn't like being run in WAL mode on network shares. If you're running Pinchflat on a network share, you can disable WAL mode by setting the `JOURNAL_MODE` environment variable to `delete`. This will make Pinchflat run in rollback journal mode which is less performant but should work on network shares.
-
-If you change this setting and it works well for you, please leave a comment on [#137](https://github.com/kieraneglin/pinchflat/issues/137)! Doubly so if it does _not_ work well.
-
-## EFF donations
-
-A portion of all donations to Pinchflat will be donated to the [Electronic Frontier Foundation](https://www.eff.org/). The EFF defends your online liberties and [backed](https://github.com/github/dmca/blob/9a85e0f021f7967af80e186b890776a50443f06c/2020/11/2020-11-16-RIAA-reversal-effletter.pdf) `youtube-dl` when Google took them down. [See here](https://github.com/kieraneglin/pinchflat/wiki/EFF-Donation-Receipts) for a list of donation receipts.
-
-## Pre-release disclaimer
-
-This is pre-release software and anything can break at any time. I make not guarantees about the stability of this software, forward-compatibility of updates, or integrity (both related to and independent of Pinchflat). Essentially, use at your own risk and expect there will be rough edges for now.
+Currently HTTP basic auth is optionally supported. To use it, set the `BASIC_AUTH_USERNAME` and `BASIC_AUTH_PASSWORD` environment variables when starting the container. If you don't set both of these, no authentication will be required.
 
 ## License
 
 See `LICENSE` file
+
+```
+
+```

assets/js/app.js

@@ -22,7 +22,6 @@ import { Socket } from 'phoenix'
 import { LiveSocket } from 'phoenix_live_view'
 import topbar from '../vendor/topbar'
 import Alpine from 'alpinejs'
-import './tabs'
 
 window.Alpine = Alpine
 Alpine.start()
@@ -39,30 +38,6 @@ let liveSocket = new LiveSocket('/live', Socket, {
   }
 })
 
-window.copyTextToClipboard = async (text) => {
-  // Navigator clipboard api needs a secure context (https)
-  if (navigator.clipboard && window.isSecureContext) {
-    await navigator.clipboard.writeText(text)
-  } else {
-    const textArea = document.createElement('textarea')
-    textArea.value = text
-    // Move textarea out of the viewport so it's not visible
-    textArea.style.position = 'absolute'
-    textArea.style.left = '-999999px'
-
-    document.body.prepend(textArea)
-    textArea.select()
-
-    try {
-      document.execCommand('copy')
-    } catch (error) {
-      console.error(error)
-    } finally {
-      textArea.remove()
-    }
-  }
-}
-
 // Show progress bar on live navigation and form submits
 topbar.config({ barColors: { 0: '#29d' }, shadowColor: 'rgba(0, 0, 0, .3)' })
 window.addEventListener('phx:page-loading-start', (_info) => topbar.show(300))

assets/js/tabs.js

@@ -1,20 +0,0 @@
-window.setTabIndex = (index) => {
-  window.location.hash = `tab-${index}`
-
-  return index
-}
-
-// The conditionals and currIndex stuff ensures that
-// the tab index is always set to 0 if the hash is empty
-// AND other hash values are ignored
-window.getTabIndex = (currIndex) => {
-  if (window.location.hash === '' || window.location.hash === '#') {
-    return 0
-  }
-
-  if (window.location.hash.startsWith('#tab-')) {
-    return parseInt(window.location.hash.replace('#tab-', ''))
-  }
-
-  return currIndex
-}

config/config.exs

@@ -16,19 +16,13 @@ config :pinchflat,
   media_directory: "/downloads",
   # The user may or may not store metadata for their needs, but the app will always store its copy
   metadata_directory: "/config/metadata",
-  extras_directory: "/config/extras",
   tmpfile_directory: Path.join([System.tmp_dir!(), "pinchflat", "data"]),
   # Setting BASIC_AUTH_USERNAME and BASIC_AUTH_PASSWORD implies you want to use basic auth.
   # If either is unset, basic auth will not be used.
-  basic_auth_username: "",
-  basic_auth_password: "",
-  expose_feed_endpoints: false,
+  basic_auth_username: System.get_env("BASIC_AUTH_USERNAME"),
+  basic_auth_password: System.get_env("BASIC_AUTH_PASSWORD"),
   file_watcher_poll_interval: 1000
 
-config :pinchflat, Pinchflat.Repo,
-  journal_mode: :wal,
-  pool_size: 5
-
 # Configures the endpoint
 config :pinchflat, PinchflatWeb.Endpoint,
   url: [host: "localhost", port: 8945],
@@ -46,13 +40,7 @@ config :pinchflat, Oban,
   engine: Oban.Engines.Lite,
   repo: Pinchflat.Repo,
   # Keep old jobs for 30 days for display in the UI
-  plugins: [
-    {Oban.Plugins.Pruner, max_age: 30 * 24 * 60 * 60},
-    {Oban.Plugins.Cron,
-     crontab: [
-       {"@daily", Pinchflat.Downloading.MediaRetentionWorker}
-     ]}
-  ],
+  plugins: [{Oban.Plugins.Pruner, max_age: 30 * 24 * 60 * 60}],
   # TODO: consider making this an env var or something?
   queues: [
     default: 10,
@@ -60,8 +48,7 @@ config :pinchflat, Oban,
     media_indexing: 2,
     media_collection_indexing: 2,
     media_fetching: 2,
-    local_metadata: 8,
-    remote_metadata: 4
+    media_local_metadata: 8
   ]
 
 # Configures the mailer
@@ -85,7 +72,7 @@ config :esbuild,
 
 # Configure tailwind (the version is required)
 config :tailwind,
-  version: "3.4.3",
+  version: "3.3.2",
   default: [
     args: ~w(
       --config=tailwind.config.js

config/dev.exs

@@ -3,7 +3,6 @@ import Config
 config :pinchflat,
   media_directory: Path.join([File.cwd!(), "tmp", "media"]),
   metadata_directory: Path.join([File.cwd!(), "tmp", "metadata"]),
-  extras_directory: Path.join([File.cwd!(), "tmp", "extras"]),
   tmpfile_directory: Path.join([File.cwd!(), "tmp", "tmpfiles"])
 
 # Configure your database

config/runtime.exs

@@ -25,48 +25,37 @@ config :pinchflat,
   basic_auth_username: System.get_env("BASIC_AUTH_USERNAME"),
   basic_auth_password: System.get_env("BASIC_AUTH_PASSWORD")
 
-arch_string = to_string(:erlang.system_info(:system_architecture))
-
-system_arch =
-  cond do
-    String.contains?(arch_string, "arm") -> "arm"
-    String.contains?(arch_string, "aarch") -> "arm"
-    String.contains?(arch_string, "x86") -> "x86"
-    true -> "unknown"
-  end
-
-config :pinchflat, Pinchflat.Repo,
-  load_extensions: [
-    Path.join([:code.priv_dir(:pinchflat), "repo", "extensions", "sqlean-linux-#{system_arch}", "sqlean"])
-  ]
-
 if config_env() == :prod do
-  config_path = "/config"
+  config_path =
+    System.get_env("CONFIG_PATH") ||
+      raise """
+      environment variable CONFIG_PATH is missing.
+      For example: /etc/pinchflat/config
+      """
+
   db_path = System.get_env("DATABASE_PATH", Path.join([config_path, "db", "pinchflat.db"]))
   log_path = System.get_env("LOG_PATH", Path.join([config_path, "logs", "pinchflat.log"]))
   metadata_path = System.get_env("METADATA_PATH", Path.join([config_path, "metadata"]))
-  extras_path = System.get_env("EXTRAS_PATH", Path.join([config_path, "extras"]))
 
-  # For running PF as a podcast host on self-hosted environments
-  expose_feed_endpoints = String.length(System.get_env("EXPOSE_FEED_ENDPOINTS", "")) > 0
+  # We want to force _some_ level of useful logging in production
+  acceptable_log_levels = ~w(debug info)a
+  log_level = String.to_existing_atom(System.get_env("LOG_LEVEL", "info"))
 
-  # For testing alternate journal modes (see issue #137)
-  journal_mode = String.to_existing_atom(System.get_env("JOURNAL_MODE", "wal"))
-
-  config :logger, level: String.to_existing_atom(System.get_env("LOG_LEVEL", "info"))
+  if log_level in acceptable_log_levels do
+    config :logger, level: log_level
+  else
+    Logger.error("Invalid log level: #{log_level}. Defaulting to info.")
+    config :logger, level: :info
+  end
 
   config :pinchflat,
     yt_dlp_executable: System.find_executable("yt-dlp"),
-    media_directory: "/downloads",
     metadata_directory: metadata_path,
-    extras_directory: extras_path,
-    tmpfile_directory: Path.join([System.tmp_dir!(), "pinchflat", "data"]),
-    dns_cluster_query: System.get_env("DNS_CLUSTER_QUERY"),
-    expose_feed_endpoints: expose_feed_endpoints
+    dns_cluster_query: System.get_env("DNS_CLUSTER_QUERY")
 
   config :pinchflat, Pinchflat.Repo,
     database: db_path,
-    journal_mode: journal_mode
+    pool_size: String.to_integer(System.get_env("POOL_SIZE") || "5")
 
   # The secret key base is used to sign/encrypt cookies and other secrets.
   # A default value is used in config/dev.exs and config/test.exs but you
@@ -100,7 +89,7 @@ if config_env() == :prod do
       # Set it to  {0, 0, 0, 0, 0, 0, 0, 1} for local network only access.
       # See the documentation on https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html
       # for details about using IPv6 vs IPv4 and loopback vs public addresses.
-      ip: {0, 0, 0, 0},
+      ip: {0, 0, 0, 0, 0, 0, 0, 0},
       port: String.to_integer(System.get_env("PORT") || "4000")
     ],
     secret_key_base: secret_key_base
@@ -119,4 +108,54 @@ if config_env() == :prod do
        formatter: Logger.Formatter.new()
      }}
   ]
+
+  # ## SSL Support
+  #
+  # To get SSL working, you will need to add the `https` key
+  # to your endpoint configuration:
+  #
+  #     config :pinchflat, PinchflatWeb.Endpoint,
+  #       https: [
+  #         ...,
+  #         port: 443,
+  #         cipher_suite: :strong,
+  #         keyfile: System.get_env("SOME_APP_SSL_KEY_PATH"),
+  #         certfile: System.get_env("SOME_APP_SSL_CERT_PATH")
+  #       ]
+  #
+  # The `cipher_suite` is set to `:strong` to support only the
+  # latest and more secure SSL ciphers. This means old browsers
+  # and clients may not be supported. You can set it to
+  # `:compatible` for wider support.
+  #
+  # `:keyfile` and `:certfile` expect an absolute path to the key
+  # and cert in disk or a relative path inside priv, for example
+  # "priv/ssl/server.key". For all supported SSL configuration
+  # options, see https://hexdocs.pm/plug/Plug.SSL.html#configure/1
+  #
+  # We also recommend setting `force_ssl` in your endpoint, ensuring
+  # no data is ever sent via http, always redirecting to https:
+  #
+  #     config :pinchflat, PinchflatWeb.Endpoint,
+  #       force_ssl: [hsts: true]
+  #
+  # Check `Plug.SSL` for all available options in `force_ssl`.
+
+  # ## Configuring the mailer
+  #
+  # In production you need to configure the mailer to use a different adapter.
+  # Also, you may need to configure the Swoosh API client of your choice if you
+  # are not using SMTP. Here is an example of the configuration:
+  #
+  #     config :pinchflat, Pinchflat.Mailer,
+  #       adapter: Swoosh.Adapters.Mailgun,
+  #       api_key: System.get_env("MAILGUN_API_KEY"),
+  #       domain: System.get_env("MAILGUN_DOMAIN")
+  #
+  # For this example you need include a HTTP client required by Swoosh API client.
+  # Swoosh supports Hackney and Finch out of the box:
+  #
+  #     config :swoosh, :api_client, Swoosh.ApiClient.Hackney
+  #
+  # See https://hexdocs.pm/swoosh/Swoosh.html#module-installation for details.
 end

config/test.exs

@@ -17,6 +17,7 @@ config :pinchflat, Oban, testing: :manual
 # Run `mix help test` for more information.
 config :pinchflat, Pinchflat.Repo,
   database: Path.expand("../priv/repo/pinchflat_test.db", Path.dirname(__ENV__.file)),
+  pool_size: 5,
   pool: Ecto.Adapters.SQL.Sandbox
 
 # We don't run a server during test. If one is required,
@@ -32,7 +33,8 @@ config :pinchflat, Pinchflat.Mailer, adapter: Swoosh.Adapters.Test
 # Disable swoosh api client as it is only required for production adapters.
 config :swoosh, :api_client, false
 
-config :logger, level: :critical
+# Print only warnings and errors during test
+config :logger, level: :warning
 
 # Initialize plugs at runtime for faster test compilation
 config :phoenix, :plug_init_mode, :runtime

lib/pinchflat/boot/data_backfill_worker.ex

@@ -0,0 +1,75 @@
+defmodule Pinchflat.Boot.DataBackfillWorker do
+  @moduledoc false
+
+  use Oban.Worker,
+    queue: :media_local_metadata,
+    unique: [period: :infinity, states: [:available, :scheduled, :retryable]],
+    tags: ["media_item", "media_metadata", "local_metadata", "data_backfill"]
+
+  # This one is going to be a little more self-contained
+  # instead of relying on outside modules for the methods.
+  # That's because, for now, these methods are not intended
+  # to be used elsewhere.
+  #
+  # I'm just trying out that pattern and seeing if I like it better
+  # so this may change.
+  import Ecto.Query, warn: false
+  require Logger
+
+  alias __MODULE__
+  alias Pinchflat.Repo
+  alias Pinchflat.Media.MediaItem
+
+  @doc """
+  Cancels all pending backfill jobs. Useful for ensuring worker runs immediately
+  on app boot.
+
+  Returns {:ok, integer()}
+  """
+  def cancel_pending_backfill_jobs do
+    Oban.Job
+    |> where(worker: "Pinchflat.Boot.DataBackfillWorker")
+    |> Oban.cancel_all_jobs()
+  end
+
+  @impl Oban.Worker
+  @doc """
+  Performs one-off tasks to get data in the right shape.
+  This can be needed when we add new features or change the way
+  we store data. Must be idempotent. All new data should already
+  conform to the expected schema so this should only be needed
+  for existing data. Still runs periodically to be safe.
+
+  Returns :ok
+  """
+  def perform(%Oban.Job{}) do
+    Logger.info("Running data backfill worker")
+    backfill_shorts_data()
+
+    reschedule_backfill()
+
+    :ok
+  end
+
+  defp backfill_shorts_data do
+    query =
+      from(
+        m in MediaItem,
+        where: fragment("? like ?", m.original_url, "%/shorts/%"),
+        where: m.short_form_content == false
+      )
+
+    {count, _} = Repo.update_all(query, set: [short_form_content: true])
+
+    Logger.info("Backfill worker set short_form_content to true for #{count} media items.")
+  end
+
+  defp reschedule_backfill do
+    # Run hourly
+    next_run_in = 60 * 60
+
+    %{}
+    |> DataBackfillWorker.new(schedule_in: next_run_in)
+    |> Repo.insert_unique_job()
+  end
+end

lib/pinchflat/boot/nfo_backfill_worker.ex

@@ -1,70 +0,0 @@
-defmodule Pinchflat.Boot.NfoBackfillWorker do
-  @moduledoc false
-
-  use Oban.Worker,
-    queue: :local_metadata,
-    # This should have it running once _ever_ (until the job is pruned, anyway)
-    # NOTE: remove within the next month
-    unique: [period: :infinity, states: Oban.Job.states()],
-    tags: ["media_item", "media_metadata", "local_metadata", "data_backfill"]
-
-  import Ecto.Query, warn: false
-  require Logger
-
-  alias Pinchflat.Repo
-  alias Pinchflat.Media
-  alias Pinchflat.Media.MediaItem
-  alias Pinchflat.Metadata.NfoBuilder
-  alias Pinchflat.Metadata.MetadataFileHelpers
-
-  @doc """
-  Runs a one-off backfill job to regenerate NFO files for media items that have
-  both an NFO file and a metadata file. This is needed because NFO files weren't
-  escaping characters properly so we need to regenerate them.
-
-  This job will only run once as long as I remove it before the jobs are pruned in a month.
-
-  Returns :ok
-  """
-  @impl Oban.Worker
-  def perform(%Oban.Job{}) do
-    Logger.info("Running NFO backfill worker")
-
-    media_items = get_media_items_to_backfill()
-
-    Enum.each(media_items, fn media_item ->
-      nfo_exists = File.exists?(media_item.nfo_filepath)
-      metadata_exists = File.exists?(media_item.metadata.metadata_filepath)
-
-      if nfo_exists && metadata_exists do
-        Logger.info("NFO and metadata exist for media item #{media_item.id} - proceeding")
-
-        regenerate_nfo_for_media_item(media_item)
-      end
-    end)
-
-    :ok
-  end
-
-  defp get_media_items_to_backfill do
-    from(m in MediaItem, where: not is_nil(m.nfo_filepath))
-    |> Repo.all()
-    |> Repo.preload([:metadata, source: :media_profile])
-  end
-
-  defp regenerate_nfo_for_media_item(media_item) do
-    try do
-      case MetadataFileHelpers.read_compressed_metadata(media_item.metadata.metadata_filepath) do
-        {:ok, metadata} ->
-          Media.update_media_item(media_item, %{
-            nfo_filepath: NfoBuilder.build_and_store_for_media_item(media_item.nfo_filepath, metadata)
-          })
-
-        _err ->
-          Logger.error("Failed to read metadata for media item #{media_item.id}")
-      end
-    rescue
-      e -> Logger.error("Unknown error regenerating NFO file for MI ##{media_item.id}: #{inspect(e)}")
-    end
-  end
-end

lib/pinchflat/boot/post_job_startup_tasks.ex

@@ -7,13 +7,13 @@ defmodule Pinchflat.Boot.PostJobStartupTasks do
   Phoenix supervision tree.
   """
 
-  alias Pinchflat.Repo
-  alias Pinchflat.Boot.NfoBackfillWorker
-
   # restart: :temporary means that this process will never be restarted (ie: will run once and then die)
   use GenServer, restart: :temporary
   import Ecto.Query, warn: false
 
+  alias Pinchflat.Repo
+  alias Pinchflat.Boot.DataBackfillWorker
+
   def start_link(opts \\ []) do
     GenServer.start_link(__MODULE__, %{}, opts)
   end
@@ -29,8 +29,16 @@ defmodule Pinchflat.Boot.PostJobStartupTasks do
   """
   @impl true
   def init(state) do
-    Repo.insert_unique_job(NfoBackfillWorker.new(%{}))
+    enqueue_backfill_worker()
 
     {:ok, state}
   end
+
+  defp enqueue_backfill_worker do
+    DataBackfillWorker.cancel_pending_backfill_jobs()
+
+    %{}
+    |> DataBackfillWorker.new()
+    |> Repo.insert_unique_job()
+  end
 end

lib/pinchflat/boot/pre_job_startup_tasks.ex

@@ -14,8 +14,6 @@ defmodule Pinchflat.Boot.PreJobStartupTasks do
 
   alias Pinchflat.Repo
   alias Pinchflat.Settings
-  alias Pinchflat.YtDlp.CommandRunner
-  alias Pinchflat.Filesystem.FilesystemHelpers
 
   def start_link(opts \\ []) do
     GenServer.start_link(__MODULE__, %{}, opts)
@@ -32,39 +30,44 @@ defmodule Pinchflat.Boot.PreJobStartupTasks do
   """
   @impl true
   def init(state) do
-    reset_executing_jobs()
-    create_blank_cookie_file()
     apply_default_settings()
+    rename_old_job_workers()
 
     {:ok, state}
   end
 
-  # If a node cannot gracefully shut down, the currently executing jobs get stuck
-  # in the "executing" state. This is a problem because the job runner will not
-  # pick them up again
-  defp reset_executing_jobs do
-    {count, _} =
-      Oban.Job
-      |> where(state: "executing")
-      |> Repo.update_all(set: [state: "retryable"])
-
-    Logger.info("Reset #{count} executing jobs")
-  end
-
-  defp create_blank_cookie_file do
-    base_dir = Application.get_env(:pinchflat, :extras_directory)
-    filepath = Path.join(base_dir, "cookies.txt")
-
-    if !File.exists?(filepath) do
-      Logger.info("Cookies does not exist - creating it")
-
-      FilesystemHelpers.write_p!(filepath, "")
-    end
-  end
-
   defp apply_default_settings do
-    {:ok, yt_dlp_version} = CommandRunner.version()
+    Settings.fetch!(:onboarding, true)
+    Settings.fetch!(:pro_enabled, false)
+  end
 
-    Settings.set(yt_dlp_version: yt_dlp_version)
+  # As part of a large refactor, I ended up moving a bunch of workers around. This
+  # is a problem because the workers are stored in the database and the runner
+  # will try to run the OLD jobs. This is also why these tasks run before the job
+  # runner starts up.
+  #
+  # Can be removed after a few months (created: 2024-03-12)
+  defp rename_old_job_workers do
+    # [ [old_name, new_name], ...]
+    rename_map = [
+      ["Pinchflat.Workers.MediaIndexingWorker", "Pinchflat.FastIndexing.MediaIndexingWorker"],
+      ["Pinchflat.Workers.MediaDownloadWorker", "Pinchflat.Downloading.MediaDownloadWorker"],
+      ["Pinchflat.Workers.FilesystemDataWorker", "Pinchflat.Filesystem.FilesystemDataWorker"],
+      ["Pinchflat.Workers.FastIndexingWorker", "Pinchflat.FastIndexing.FastIndexingWorker"],
+      ["Pinchflat.Workers.MediaCollectionIndexingWorker", "Pinchflat.SlowIndexing.MediaCollectionIndexingWorker"],
+      ["Pinchflat.Workers.DataBackfillWorker", "Pinchflat.Boot.DataBackfillWorker"]
+    ]
+
+    jobs_renamed =
+      Enum.reduce(rename_map, 0, fn [old_name, new_name], acc ->
+        {count, _} =
+          Oban.Job
+          |> where(worker: ^old_name)
+          |> Repo.update_all(set: [worker: new_name])
+
+        acc + count
+      end)
+
+    Logger.info("Renamed #{jobs_renamed} old job workers")
   end
 end

lib/pinchflat/downloading/download_option_builder.ex

@@ -3,7 +3,6 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do
   Builds the options for yt-dlp to download media based on the given media profile.
   """
 
-  alias Pinchflat.Sources.Source
   alias Pinchflat.Media.MediaItem
   alias Pinchflat.Downloading.OutputPathBuilder
 
@@ -19,27 +18,14 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do
     built_options =
       default_options() ++
         subtitle_options(media_profile) ++
-        thumbnail_options(media_item_with_preloads) ++
+        thumbnail_options(media_profile) ++
         metadata_options(media_profile) ++
         quality_options(media_profile) ++
-        sponsorblock_options(media_profile) ++
         output_options(media_item_with_preloads)
 
     {:ok, built_options}
   end
 
-  @doc """
-  Builds the output path for yt-dlp to download media based on the given source's
-  media profile.
-
-  Returns binary()
-  """
-  def build_output_path_for(%Source{} = source_with_preloads) do
-    output_path_template = source_with_preloads.media_profile.output_path_template
-
-    build_output_path(output_path_template, source_with_preloads)
-  end
-
   defp default_options do
     [:no_progress, :windows_filenames]
   end
@@ -71,16 +57,13 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do
     end)
   end
 
-  defp thumbnail_options(media_item_with_preloads) do
-    media_profile = media_item_with_preloads.source.media_profile
+  defp thumbnail_options(media_profile) do
     mapped_struct = Map.from_struct(media_profile)
 
     Enum.reduce(mapped_struct, [], fn attr, acc ->
       case attr do
         {:download_thumbnail, true} ->
-          thumbnail_save_location = determine_thumbnail_location(media_item_with_preloads)
-
-          acc ++ [:write_thumbnail, convert_thumbnail: "jpg", output: "thumbnail:#{thumbnail_save_location}"]
+          acc ++ [:write_thumbnail, convert_thumbnail: "jpg"]
 
         {:embed_thumbnail, true} ->
           acc ++ [:embed_thumbnail, convert_thumbnail: "jpg"]
@@ -113,54 +96,30 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do
       :"480p" -> [format_sort: "res:480,#{video_codec_options}"]
       :"720p" -> [format_sort: "res:720,#{video_codec_options}"]
       :"1080p" -> [format_sort: "res:1080,#{video_codec_options}"]
+      :"1440p" -> [format_sort: "res:1440,#{video_codec_options}"]
       :"2160p" -> [format_sort: "res:2160,#{video_codec_options}"]
     end
   end
 
-  defp sponsorblock_options(media_profile) do
-    categories = media_profile.sponsorblock_categories
-    behaviour = media_profile.sponsorblock_behaviour
-
-    case {behaviour, categories} do
-      {_, []} -> []
-      {:remove, _} -> [sponsorblock_remove: Enum.join(categories, ",")]
-      {:disabled, _} -> []
-    end
-  end
-
   defp output_options(media_item_with_preloads) do
+    media_profile = media_item_with_preloads.source.media_profile
+    additional_options_map = output_options_map(media_item_with_preloads)
+    {:ok, output_path} = OutputPathBuilder.build(media_profile.output_path_template, additional_options_map)
+
     [
-      output: build_output_path_for(media_item_with_preloads.source)
+      output: Path.join(base_directory(), output_path)
     ]
   end
 
-  defp build_output_path(string, source) do
-    additional_options_map = output_options_map(source)
-    {:ok, output_path} = OutputPathBuilder.build(string, additional_options_map)
+  defp output_options_map(media_item_with_preloads) do
+    source = media_item_with_preloads.source
 
-    Path.join(base_directory(), output_path)
-  end
-
-  defp output_options_map(source) do
     %{
       "source_custom_name" => source.custom_name,
       "source_collection_type" => source.collection_type
     }
   end
 
-  # I don't love the string manipulation here, but what can ya' do.
-  # It's dependent on the output_path_template being a string ending `.{{ ext }}`
-  # (or equivalent), but that's validated by the MediaProfile schema.
-  defp determine_thumbnail_location(media_item_with_preloads) do
-    output_path_template = media_item_with_preloads.source.media_profile.output_path_template
-
-    output_path_template
-    |> String.split(~r{\.}, include_captures: true)
-    |> List.insert_at(-3, "-thumb")
-    |> Enum.join()
-    |> build_output_path(media_item_with_preloads.source)
-  end
-
   defp base_directory do
     Application.get_env(:pinchflat, :media_directory)
   end

lib/pinchflat/downloading/downloading_helpers.ex

@@ -26,7 +26,11 @@ defmodule Pinchflat.Downloading.DownloadingHelpers do
   def enqueue_pending_download_tasks(%Source{download_media: true} = source) do
     source
     |> Media.list_pending_media_items_for()
-    |> Enum.each(&MediaDownloadWorker.kickoff_with_task/1)
+    |> Enum.each(fn media_item ->
+      %{id: media_item.id}
+      |> MediaDownloadWorker.new()
+      |> Tasks.create_job_with_task(media_item)
+    end)
   end
 
   def enqueue_pending_download_tasks(%Source{download_media: false}) do

lib/pinchflat/downloading/media_download_worker.ex

@@ -6,73 +6,51 @@ defmodule Pinchflat.Downloading.MediaDownloadWorker do
     unique: [period: :infinity, states: [:available, :scheduled, :retryable, :executing]],
     tags: ["media_item", "media_fetching"]
 
-  require Logger
-
-  alias __MODULE__
-  alias Pinchflat.Tasks
   alias Pinchflat.Repo
   alias Pinchflat.Media
+  alias Pinchflat.Tasks
   alias Pinchflat.Downloading.MediaDownloader
+  alias Pinchflat.Filesystem.FilesystemDataWorker
 
-  @doc """
-  Starts the media_item media download worker and creates a task for the media_item.
-
-  Returns {:ok, %Task{}} | {:error, :duplicate_job} | {:error, %Ecto.Changeset{}}
-  """
-  def kickoff_with_task(media_item, job_args \\ %{}, job_opts \\ []) do
-    %{id: media_item.id}
-    |> Map.merge(job_args)
-    |> MediaDownloadWorker.new(job_opts)
-    |> Tasks.create_job_with_task(media_item)
-  end
-
+  @impl Oban.Worker
   @doc """
   For a given media item, download the media alongside any options.
-  Does not download media if its source is set to not download media
-  (unless forced).
+  Does not download media if its source is set to not download media.
 
   Returns :ok | {:ok, %MediaItem{}} | {:error, any, ...any}
   """
-  @impl Oban.Worker
-  def perform(%Oban.Job{args: %{"id" => media_item_id} = args}) do
+  def perform(%Oban.Job{args: %{"id" => media_item_id}}) do
     media_item =
       media_item_id
       |> Media.get_media_item!()
       |> Repo.preload(:source)
 
-    # If the source or media item is set to not download media, perform a no-op unless forced
-    if (media_item.source.download_media && !media_item.prevent_download) || args["force"] do
+    # If the source is set to not download media, perform a no-op
+    if media_item.source.download_media do
       download_media_and_schedule_jobs(media_item)
     else
       :ok
     end
-  rescue
-    Ecto.NoResultsError -> Logger.info("#{__MODULE__} discarded: media item #{media_item_id} not found")
-    Ecto.StaleEntryError -> Logger.info("#{__MODULE__} discarded: media item #{media_item_id} stale")
   end
 
   defp download_media_and_schedule_jobs(media_item) do
     case MediaDownloader.download_for_media_item(media_item) do
-      {:ok, updated_media_item} ->
-        compute_and_save_media_filesize(updated_media_item)
+      {:ok, _} ->
+        schedule_filesystem_data_worker(media_item)
+        {:ok, media_item}
 
-        {:ok, updated_media_item}
-
-      {:recovered, _} ->
-        {:error, :retry}
-
-      {:error, _message} ->
-        {:error, :download_failed}
+      err ->
+        err
     end
   end
 
-  defp compute_and_save_media_filesize(media_item) do
-    case File.stat(media_item.media_filepath) do
-      {:ok, %{size: size}} ->
-        Media.update_media_item(media_item, %{media_size_bytes: size})
-
-      _ ->
-        :ok
+  defp schedule_filesystem_data_worker(media_item) do
+    %{id: media_item.id}
+    |> FilesystemDataWorker.new()
+    |> Tasks.create_job_with_task(media_item)
+    |> case do
+      {:ok, task} -> {:ok, task}
+      {:error, :duplicate_job} -> {:ok, :job_exists}
     end
   end
 end

lib/pinchflat/downloading/media_downloader.ex

@@ -5,18 +5,14 @@ defmodule Pinchflat.Downloading.MediaDownloader do
   to download the media with the desired options.
   """
 
-  require Logger
-
   alias Pinchflat.Repo
   alias Pinchflat.Media
   alias Pinchflat.Media.MediaItem
-  alias Pinchflat.Metadata.NfoBuilder
-  alias Pinchflat.Metadata.MetadataParser
-  alias Pinchflat.Metadata.MetadataFileHelpers
-  alias Pinchflat.Filesystem.FilesystemHelpers
-  alias Pinchflat.Downloading.DownloadOptionBuilder
 
   alias Pinchflat.YtDlp.Media, as: YtDlpMedia
+  alias Pinchflat.Downloading.DownloadOptionBuilder, as: YtDlpDownloadOptionBuilder
+  alias Pinchflat.Metadata.MetadataParser, as: YtDlpMetadataParser
+  alias Pinchflat.Metadata.MetadataFileHelpers, as: YtDlpMetadataHelpers
 
   @doc """
   Downloads media for a media item, updating the media item based on the metadata
@@ -30,88 +26,40 @@ defmodule Pinchflat.Downloading.MediaDownloader do
   Returns {:ok, %MediaItem{}} | {:error, any, ...any}
   """
   def download_for_media_item(%MediaItem{} = media_item) do
-    output_filepath = FilesystemHelpers.generate_metadata_tmpfile(:json)
-    media_with_preloads = Repo.preload(media_item, [:metadata, source: :media_profile])
+    item_with_preloads = Repo.preload(media_item, [:metadata, source: :media_profile])
 
-    case download_with_options(media_item.original_url, media_with_preloads, output_filepath) do
+    case download_with_options(media_item.original_url, item_with_preloads) do
       {:ok, parsed_json} ->
-        update_media_item_from_parsed_json(media_with_preloads, parsed_json)
+        {parser, helpers} = {YtDlpMetadataParser, YtDlpMetadataHelpers}
 
-      {:error, message, _exit_code} ->
-        Logger.error("yt-dlp download error for media item ##{media_with_preloads.id}: #{inspect(message)}")
+        parsed_attrs =
+          parsed_json
+          |> parser.parse_for_media_item()
+          |> Map.merge(%{
+            media_downloaded_at: DateTime.utc_now(),
+            metadata: %{
+              metadata_filepath: helpers.compress_and_store_metadata_for(media_item, parsed_json),
+              thumbnail_filepath: helpers.download_and_store_thumbnail_for(media_item, parsed_json)
+            }
+          })
 
-        if String.contains?(to_string(message), recoverable_errors()) do
-          attempt_update_media_item(media_with_preloads, output_filepath)
-
-          {:recovered, message}
-        else
-          {:error, message}
-        end
+        # Don't forgor to use preloaded associations or updates to
+        # associations won't work!
+        Media.update_media_item(item_with_preloads, parsed_attrs)
 
       err ->
-        Logger.error("Unknown error downloading media item ##{media_with_preloads.id}: #{inspect(err)}")
-
-        {:error, "Unknown error: #{inspect(err)}"}
+        err
     end
   end
 
-  defp attempt_update_media_item(media_with_preloads, output_filepath) do
-    with {:ok, contents} <- File.read(output_filepath),
-         {:ok, parsed_json} <- Phoenix.json_library().decode(contents) do
-      Logger.info("""
-      Recovery from yt-dlp error seems possible. Updating media item ##{media_with_preloads.id}
-      with parsed JSON from partial download attempt. Full download will be re-attemted in future
-      anyway
-      """)
+  # def download_for_source(source, url) do
+  #   # Create MI from source and URL
+  #   media_item = nil
+  # end
 
-      update_media_item_from_parsed_json(media_with_preloads, parsed_json)
-    else
-      err ->
-        Logger.error("Unable to recover error for media item ##{media_with_preloads.id}: #{inspect(err)}")
+  defp download_with_options(url, item_with_preloads) do
+    {:ok, options} = YtDlpDownloadOptionBuilder.build(item_with_preloads)
 
-        {:error, :retry_failed}
-    end
-  end
-
-  defp update_media_item_from_parsed_json(media_with_preloads, parsed_json) do
-    parsed_attrs =
-      parsed_json
-      |> MetadataParser.parse_for_media_item()
-      |> Map.merge(%{
-        media_downloaded_at: DateTime.utc_now(),
-        nfo_filepath: determine_nfo_filepath(media_with_preloads, parsed_json),
-        metadata: %{
-          # IDEA: might be worth kicking off a job for this since thumbnail fetching
-          # could fail and I want to handle that in isolation
-          metadata_filepath: MetadataFileHelpers.compress_and_store_metadata_for(media_with_preloads, parsed_json),
-          thumbnail_filepath: MetadataFileHelpers.download_and_store_thumbnail_for(media_with_preloads, parsed_json)
-        }
-      })
-
-    # Don't forgor to use preloaded associations or updates to
-    # associations won't work!
-    Media.update_media_item(media_with_preloads, parsed_attrs)
-  end
-
-  defp determine_nfo_filepath(media_item, parsed_json) do
-    if media_item.source.media_profile.download_nfo do
-      filepath = Path.rootname(parsed_json["filepath"]) <> ".nfo"
-
-      NfoBuilder.build_and_store_for_media_item(filepath, parsed_json)
-    else
-      nil
-    end
-  end
-
-  defp download_with_options(url, item_with_preloads, output_filepath) do
-    {:ok, options} = DownloadOptionBuilder.build(item_with_preloads)
-
-    YtDlpMedia.download(url, options, output_filepath: output_filepath)
-  end
-
-  defp recoverable_errors do
-    [
-      "Unable to communicate with SponsorBlock"
-    ]
+    YtDlpMedia.download(url, options)
   end
 end

lib/pinchflat/downloading/media_retention_worker.ex

@@ -1,33 +0,0 @@
-defmodule Pinchflat.Downloading.MediaRetentionWorker do
-  @moduledoc false
-
-  use Oban.Worker,
-    queue: :local_metadata,
-    unique: [period: :infinity, states: [:available, :scheduled, :retryable, :executing]],
-    tags: ["media_item", "local_metadata"]
-
-  require Logger
-
-  alias Pinchflat.Media
-
-  @doc """
-  Deletes media items that are past their retention date and prevents
-  them from being re-downloaded.
-
-  This worker is scheduled to run daily via the Oban Cron plugin.
-
-  Returns :ok
-  """
-  @impl Oban.Worker
-  def perform(%Oban.Job{}) do
-    cullable_media = Media.list_cullable_media_items()
-    Logger.info("Culling #{length(cullable_media)} media items past their retention date")
-
-    Enum.each(cullable_media, fn media_item ->
-      Media.delete_media_files(media_item, %{
-        prevent_download: true,
-        culled_at: DateTime.utc_now()
-      })
-    end)
-  end
-end

lib/pinchflat/downloading/output_path_builder.ex

@@ -40,10 +40,7 @@ defmodule Pinchflat.Downloading.OutputPathBuilder do
       "upload_year" => "%(upload_date>%Y)S",
       "upload_month" => "%(upload_date>%m)S",
       "upload_day" => "%(upload_date>%d)S",
-      "upload_yyyy_mm_dd" => "%(upload_date>%Y-%m-%d)S",
-      "season_from_date" => "%(upload_date>%Y)S",
-      "season_episode_from_date" => "s%(upload_date>%Y)Se%(upload_date>%m%d)S",
-      "artist_name" => "%(artist,creator,uploader,uploader_id)S"
+      "upload_yyyy_mm_dd" => "%(upload_date>%Y)S-%(upload_date>%m)S-%(upload_date>%d)S"
     }
   end
 end

lib/pinchflat/fast_indexing/fast_indexing_helpers.ex

@@ -5,16 +5,35 @@ defmodule Pinchflat.FastIndexing.FastIndexingHelpers do
   Many of these methods are made to be kickoff or be consumed by workers.
   """
 
-  alias Pinchflat.Repo
   alias Pinchflat.Media
+  alias Pinchflat.Tasks
   alias Pinchflat.Sources.Source
-  alias Pinchflat.Media.MediaQuery
   alias Pinchflat.FastIndexing.YoutubeRss
+  alias Pinchflat.FastIndexing.FastIndexingWorker
   alias Pinchflat.Downloading.MediaDownloadWorker
   alias Pinchflat.FastIndexing.MediaIndexingWorker
 
   alias Pinchflat.YtDlp.Media, as: YtDlpMedia
 
+  @doc """
+  Starts tasks for running a fast indexing task for a source's media
+  regardless of the source's fast_index state. It's assumed the
+  caller will check for fast_index.
+
+  This is used for running fast index tasks on update. On creation, the
+  fast index is enqueued after the slow index is complete.
+
+  Returns {:ok, %Task{}}.
+  """
+  def kickoff_fast_indexing_task(%Source{} = source) do
+    Tasks.delete_pending_tasks_for(source, "FastIndexingWorker")
+
+    %{id: source.id}
+    # Schedule this one immediately, but future ones will be on an interval
+    |> FastIndexingWorker.new()
+    |> Tasks.create_job_with_task(source)
+  end
+
   @doc """
   Fetches new media IDs from a source's YouTube RSS feed and kicks off indexing tasks
   for any new media items. See comments in `MediaIndexingWorker` for more info on the
@@ -29,13 +48,15 @@ defmodule Pinchflat.FastIndexing.FastIndexingHelpers do
   """
   def kickoff_indexing_tasks_from_youtube_rss_feed(%Source{} = source) do
     {:ok, media_ids} = YoutubeRss.get_recent_media_ids_from_rss(source)
-    existing_media_items = list_media_items_by_media_id_for(source, media_ids)
+    existing_media_items = Media.list_media_items_by_media_id_for(source, media_ids)
     new_media_ids = media_ids -- Enum.map(existing_media_items, & &1.media_id)
 
     Enum.each(new_media_ids, fn media_id ->
       url = "https://www.youtube.com/watch?v=#{media_id}"
 
-      MediaIndexingWorker.kickoff_with_task(source, url)
+      %{id: source.id, media_url: url}
+      |> MediaIndexingWorker.new()
+      |> Tasks.create_job_with_task(source)
     end)
   end
 
@@ -53,7 +74,9 @@ defmodule Pinchflat.FastIndexing.FastIndexingHelpers do
     case maybe_media_item do
       {:ok, media_item} ->
         if source.download_media && Media.pending_download?(media_item) do
-          MediaDownloadWorker.kickoff_with_task(media_item)
+          %{id: media_item.id}
+          |> MediaDownloadWorker.new()
+          |> Tasks.create_job_with_task(media_item)
         end
 
         {:ok, media_item}
@@ -63,13 +86,6 @@ defmodule Pinchflat.FastIndexing.FastIndexingHelpers do
     end
   end
 
-  defp list_media_items_by_media_id_for(source, media_ids) do
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> MediaQuery.with_media_ids(media_ids)
-    |> Repo.all()
-  end
-
   defp create_media_item_from_url(source, url) do
     {:ok, media_attrs} = YtDlpMedia.get_media_attributes(url)
 

lib/pinchflat/fast_indexing/fast_indexing_worker.ex

@@ -6,25 +6,13 @@ defmodule Pinchflat.FastIndexing.FastIndexingWorker do
     unique: [period: :infinity, states: [:available, :scheduled, :retryable]],
     tags: ["media_source", "fast_indexing"]
 
-  require Logger
-
   alias __MODULE__
   alias Pinchflat.Tasks
   alias Pinchflat.Sources
   alias Pinchflat.Sources.Source
   alias Pinchflat.FastIndexing.FastIndexingHelpers
 
-  @doc """
-  Starts the source fast indexing worker and creates a task for the source.
-
-  Returns {:ok, %Task{}} | {:error, :duplicate_job} | {:error, %Ecto.Changeset{}}
-  """
-  def kickoff_with_task(source, opts \\ []) do
-    %{id: source.id}
-    |> FastIndexingWorker.new(opts)
-    |> Tasks.create_job_with_task(source)
-  end
-
+  @impl Oban.Worker
   @doc """
   Kicks off the fast indexing process for a source, reschedules the job to run again
   once complete. See `MediaCollectionIndexingWorker` and `MediaIndexingWorker` comments
@@ -32,7 +20,6 @@ defmodule Pinchflat.FastIndexing.FastIndexingWorker do
 
   Returns :ok | {:ok, :job_exists} | {:ok, %Task{}}
   """
-  @impl Oban.Worker
   def perform(%Oban.Job{args: %{"id" => source_id}}) do
     source = Sources.get_source!(source_id)
 
@@ -43,15 +30,15 @@ defmodule Pinchflat.FastIndexing.FastIndexingWorker do
     else
       :ok
     end
-  rescue
-    Ecto.NoResultsError -> Logger.info("#{__MODULE__} discarded: source #{source_id} not found")
-    Ecto.StaleEntryError -> Logger.info("#{__MODULE__} discarded: source #{source_id} stale")
   end
 
   defp reschedule_indexing(source) do
     next_run_in = Source.fast_index_frequency() * 60
 
-    case kickoff_with_task(source, schedule_in: next_run_in) do
+    %{id: source.id}
+    |> FastIndexingWorker.new(schedule_in: next_run_in)
+    |> Tasks.create_job_with_task(source)
+    |> case do
       {:ok, task} -> {:ok, task}
       {:error, :duplicate_job} -> {:ok, :job_exists}
     end

lib/pinchflat/fast_indexing/media_indexing_worker.ex

@@ -8,22 +8,10 @@ defmodule Pinchflat.FastIndexing.MediaIndexingWorker do
 
   require Logger
 
-  alias __MODULE__
-  alias Pinchflat.Tasks
   alias Pinchflat.Sources
   alias Pinchflat.FastIndexing.FastIndexingHelpers
 
-  @doc """
-  Starts the fast media indexing worker and creates a task for the source.
-
-  Returns {:ok, %Task{}} | {:error, :duplicate_job} | {:error, %Ecto.Changeset{}}
-  """
-  def kickoff_with_task(source, media_url, opts \\ []) do
-    %{id: source.id, media_url: media_url}
-    |> MediaIndexingWorker.new(opts)
-    |> Tasks.create_job_with_task(source)
-  end
-
+  @impl Oban.Worker
   @doc """
   Similar to `MediaCollectionIndexingWorker`, but for individual media items.
   Does not reschedule or check anything to do with a source's indexing
@@ -49,7 +37,6 @@ defmodule Pinchflat.FastIndexing.MediaIndexingWorker do
 
   Returns :ok
   """
-  @impl Oban.Worker
   def perform(%Oban.Job{args: %{"id" => source_id, "media_url" => media_url}}) do
     source = Sources.get_source!(source_id)
 
@@ -62,8 +49,5 @@ defmodule Pinchflat.FastIndexing.MediaIndexingWorker do
     end
 
     :ok
-  rescue
-    Ecto.NoResultsError -> Logger.info("#{__MODULE__} discarded: source #{source_id} not found")
-    Ecto.StaleEntryError -> Logger.info("#{__MODULE__} discarded: source #{source_id} stale")
   end
 end

lib/pinchflat/filesystem/filesystem_data_worker.ex

@@ -0,0 +1,27 @@
+defmodule Pinchflat.Filesystem.FilesystemDataWorker do
+  @moduledoc false
+
+  use Oban.Worker,
+    queue: :media_local_metadata,
+    tags: ["media_item", "media_metadata", "local_metadata"],
+    max_attempts: 1
+
+  alias Pinchflat.Media
+  alias Pinchflat.Filesystem.FilesystemHelpers
+
+  @impl Oban.Worker
+  @doc """
+  For a given media item, compute and save metadata about the file on-disk.
+
+  Returns :ok
+  """
+  def perform(%Oban.Job{args: %{"id" => media_item_id}}) do
+    media_item = Media.get_media_item!(media_item_id)
+
+    FilesystemHelpers.compute_and_save_media_filesize(media_item)
+
+    # Don't retry on failure - if it didn't work immediately there's no
+    # reason to believe it will work later.
+    :ok
+  end
+end

lib/pinchflat/filesystem/filesystem_helpers.ex

@@ -15,49 +15,12 @@ defmodule Pinchflat.Filesystem.FilesystemHelpers do
     tmpfile_directory = Application.get_env(:pinchflat, :tmpfile_directory)
     filepath = Path.join([tmpfile_directory, "#{StringUtils.random_string(64)}.#{type}"])
 
-    :ok = write_p!(filepath, "")
+    :ok = File.mkdir_p!(Path.dirname(filepath))
+    :ok = File.write(filepath, "")
 
     filepath
   end
 
-  @doc """
-  Writes content to a file, creating directories as needed.
-  Takes the same args as File.write/3.
-
-  Returns :ok | {:error, any()}
-  """
-  def write_p(file, content, modes \\ []) do
-    dirname = Path.dirname(file)
-
-    case File.mkdir_p(dirname) do
-      :ok -> File.write(file, content, modes)
-      err -> err
-    end
-  end
-
-  @doc """
-  Writes content to a file, creating directories as needed.
-  Takes the same args as File.write!/3.
-
-  Returns :ok | raises on error
-  """
-  def write_p!(filepath, content, modes \\ []) do
-    :ok = write_p(filepath, content, modes)
-  end
-
-  @doc """
-  Copies a file from source to destination, creating directories as needed.
-
-  Returns :ok | raises on error
-  """
-  def cp_p!(source, destination) do
-    destination
-    |> Path.dirname()
-    |> File.mkdir_p!()
-
-    File.cp!(source, destination)
-  end
-
   @doc """
   Fetches the file size of a media item and saves it to the database.
 
@@ -72,36 +35,4 @@ defmodule Pinchflat.Filesystem.FilesystemHelpers do
         err
     end
   end
-
-  @doc """
-  Deletes a file and removes any empty directories in the path.
-  Does NOT remove any directories that are not empty.
-
-  Returns :ok | {:error, any()}
-  """
-  def delete_file_and_remove_empty_directories(filepath) do
-    case File.rm(filepath) do
-      :ok ->
-        filepath
-        |> Path.dirname()
-        |> recursively_delete_empty_directories()
-
-      err ->
-        err
-    end
-  end
-
-  defp recursively_delete_empty_directories(directory) do
-    case File.rmdir(directory) do
-      :ok ->
-        directory
-        |> Path.dirname()
-        |> recursively_delete_empty_directories()
-
-      err ->
-        err
-    end
-
-    :ok
-  end
 end

lib/pinchflat/media/media.ex

@@ -7,11 +7,9 @@ defmodule Pinchflat.Media do
 
   alias Pinchflat.Repo
   alias Pinchflat.Tasks
-  alias Pinchflat.Sources.Source
   alias Pinchflat.Media.MediaItem
-  alias Pinchflat.Media.MediaQuery
+  alias Pinchflat.Sources.Source
   alias Pinchflat.Metadata.MediaMetadata
-  alias Pinchflat.Filesystem.FilesystemHelpers
 
   @doc """
   Returns the list of media_items.
@@ -23,32 +21,65 @@ defmodule Pinchflat.Media do
   end
 
   @doc """
-  Returns a list of media_items that are cullable based on the retention period
-  of the source they belong to.
+  Returns a list of media_items for a given source.
 
-  Returns [%MediaItem{}, ...]
+  Returns [%MediaItem{}, ...].
   """
-  def list_cullable_media_items do
-    MediaQuery.new()
-    |> MediaQuery.with_media_filepath()
-    |> MediaQuery.with_passed_retention_period()
-    |> MediaQuery.with_no_culling_prevention()
+  def list_media_items_for(%Source{} = source) do
+    MediaItem
+    |> where([mi], mi.source_id == ^source.id)
+    |> Repo.all()
+  end
+
+  @doc """
+  Fetches all media items belonging to a given source that have a media_id in the given list.
+  Useful for determining the what media items we DON'T already have for fast indexing.
+
+  NOTE: These queries are getting a little tedious. When I have the time, I should see about
+  implementing a query pattern and having these compose queries from a common base. This would
+  also let me compose simple queries in the module using them for one-off methods
+
+  Returns [%MediaItem{}, ...].
+  """
+  def list_media_items_by_media_id_for(%Source{} = source, media_ids) do
+    MediaItem
+    |> where([mi], mi.source_id == ^source.id and mi.media_id in ^media_ids)
     |> Repo.all()
   end
 
   @doc """
   Returns a list of pending media_items for a given source, where
   pending means the `media_filepath` is `nil` AND the media_item
-  matches satisfies `MediaQuery.with_media_pending_download`. You
-  should really check out that function if you need to know more
-  because it has a lot going on.
+  matches the format selection rules of the parent media_profile.
+
+  See `build_format_clauses` but tl;dr is it _may_ filter based
+  on shorts or livestreams depending on the media_profile settings.
 
   Returns [%MediaItem{}, ...].
   """
-  def list_pending_media_items_for(%Source{} = source) do
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> MediaQuery.with_media_pending_download()
+  def list_pending_media_items_for(%Source{} = source, opts \\ []) do
+    limit = Keyword.get(opts, :limit, nil)
+    media_profile = Repo.preload(source, :media_profile).media_profile
+
+    MediaItem
+    |> where([mi], mi.source_id == ^source.id and is_nil(mi.media_filepath))
+    |> where(^build_format_clauses(media_profile))
+    |> where(^maybe_apply_cutoff_date(source))
+    |> Repo.maybe_limit(limit)
+    |> Repo.all()
+  end
+
+  @doc """
+  Returns a list of downloaded media_items for a given source.
+
+  Returns [%MediaItem{}, ...].
+  """
+  def list_downloaded_media_items_for(%Source{} = source, opts \\ []) do
+    limit = Keyword.get(opts, :limit, nil)
+
+    MediaItem
+    |> where([mi], mi.source_id == ^source.id and not is_nil(mi.media_filepath))
+    |> Repo.maybe_limit(limit)
     |> Repo.all()
   end
 
@@ -64,9 +95,10 @@ defmodule Pinchflat.Media do
   def pending_download?(%MediaItem{} = media_item) do
     media_item = Repo.preload(media_item, source: :media_profile)
 
-    MediaQuery.new()
-    |> MediaQuery.with_id(media_item.id)
-    |> MediaQuery.with_media_pending_download()
+    MediaItem
+    |> where([mi], mi.id == ^media_item.id and is_nil(mi.media_filepath))
+    |> where(^build_format_clauses(media_item.source.media_profile))
+    |> where(^maybe_apply_cutoff_date(media_item.source))
     |> Repo.exists?()
   end
 
@@ -85,9 +117,20 @@ defmodule Pinchflat.Media do
   def search(search_term, opts) do
     limit = Keyword.get(opts, :limit, 50)
 
-    MediaQuery.new()
-    |> MediaQuery.matching_search_term(search_term)
-    |> Repo.maybe_limit(limit)
+    from(mi in MediaItem,
+      join: mi_search_index in assoc(mi, :media_items_search_index),
+      where: fragment("media_items_search_index MATCH ?", ^search_term),
+      select_merge: %{
+        matching_search_term:
+          fragment("""
+            coalesce(snippet(media_items_search_index, 0, '[PF_HIGHLIGHT]', '[/PF_HIGHLIGHT]', '...', 20), '') ||
+            ' ' ||
+            coalesce(snippet(media_items_search_index, 1, '[PF_HIGHLIGHT]', '[/PF_HIGHLIGHT]', '...', 20), '')
+          """)
+      },
+      order_by: [desc: fragment("rank")],
+      limit: ^limit
+    )
     |> Repo.all()
   end
 
@@ -98,6 +141,38 @@ defmodule Pinchflat.Media do
   """
   def get_media_item!(id), do: Repo.get!(MediaItem, id)
 
+  @doc """
+  Produces a flat list of the filesystem paths for a media_item's downloaded files
+
+  Returns [binary()]
+  """
+  def media_filepaths(media_item) do
+    mapped_struct = Map.from_struct(media_item)
+
+    MediaItem.filepath_attributes()
+    |> Enum.map(fn
+      :subtitle_filepaths = field -> Enum.map(mapped_struct[field], fn [_, filepath] -> filepath end)
+      field -> List.wrap(mapped_struct[field])
+    end)
+    |> List.flatten()
+    |> Enum.filter(&is_binary/1)
+  end
+
+  @doc """
+  Produces a flat list of the filesystem paths for a media_item's metadata files.
+  Returns an empty list if the media_item has no metadata.
+
+  Returns [binary()] | []
+  """
+  def metadata_filepaths(media_item) do
+    metadata = Repo.preload(media_item, :metadata).metadata || %MediaMetadata{}
+    mapped_struct = Map.from_struct(metadata)
+
+    MediaMetadata.filepath_attributes()
+    |> Enum.map(fn field -> mapped_struct[field] end)
+    |> Enum.filter(&is_binary/1)
+  end
+
   @doc """
   Creates a media_item.
 
@@ -144,42 +219,20 @@ defmodule Pinchflat.Media do
   end
 
   @doc """
-  Deletes a media_item, its associated tasks, and our internal metadata files.
-  Can optionally delete the media_item's media files (media, thumbnail, subtitles, etc).
+  Deletes a media_item and its associated tasks.
+  Can optionally delete the media_item's files.
 
   Returns {:ok, %MediaItem{}} | {:error, %Ecto.Changeset{}}
   """
   def delete_media_item(%MediaItem{} = media_item, opts \\ []) do
     delete_files = Keyword.get(opts, :delete_files, false)
 
-    Tasks.delete_tasks_for(media_item)
-
     if delete_files do
-      {:ok, _} = do_delete_media_files(media_item)
+      {:ok, _} = delete_all_attachments(media_item)
     end
 
-    # Should delete these no matter what
-    delete_internal_metadata_files(media_item)
-    Repo.delete(media_item)
-  end
-
-  @doc """
-  Deletes the tasks and media files associated with a media_item but leaves the
-  media_item in the database. Does not delete anything to do with associated metadata.
-
-  Optionally accepts a second argument `addl_attrs` which will be merged into the
-  media_item before it is updated. Useful for setting things like `prevent_download`
-  and `culled_at`, if wanted
-
-  Returns {:ok, %MediaItem{}} | {:error, %Ecto.Changeset{}}
-  """
-  def delete_media_files(%MediaItem{} = media_item, addl_attrs \\ %{}) do
-    filepath_attrs = MediaItem.filepath_attribute_defaults()
-
     Tasks.delete_tasks_for(media_item)
-    {:ok, _} = do_delete_media_files(media_item)
-
-    update_media_item(media_item, Map.merge(filepath_attrs, addl_attrs))
+    Repo.delete(media_item)
   end
 
   @doc """
@@ -189,28 +242,66 @@ defmodule Pinchflat.Media do
     MediaItem.changeset(media_item, attrs)
   end
 
-  defp do_delete_media_files(media_item) do
-    mapped_struct = Map.from_struct(media_item)
+  defp delete_all_attachments(media_item) do
+    media_item = Repo.preload(media_item, :metadata)
 
-    MediaItem.filepath_attributes()
-    |> Enum.map(fn
-      :subtitle_filepaths = field -> Enum.map(mapped_struct[field], fn [_, filepath] -> filepath end)
-      field -> List.wrap(mapped_struct[field])
-    end)
-    |> List.flatten()
-    |> Enum.filter(&is_binary/1)
-    |> Enum.each(&FilesystemHelpers.delete_file_and_remove_empty_directories/1)
+    media_item
+    |> media_filepaths()
+    |> Enum.concat(metadata_filepaths(media_item))
+    |> Enum.each(&File.rm/1)
+
+    # rmdir will attempt to delete the directory, but only if it is empty
+    if media_item.media_filepath do
+      File.rmdir(Path.dirname(media_item.media_filepath))
+    end
+
+    if media_item.metadata && media_item.metadata.metadata_filepath do
+      File.rmdir(Path.dirname(media_item.metadata.metadata_filepath))
+    end
 
     {:ok, media_item}
   end
 
-  defp delete_internal_metadata_files(media_item) do
-    metadata = Repo.preload(media_item, :metadata).metadata || %MediaMetadata{}
-    mapped_struct = Map.from_struct(metadata)
+  defp maybe_apply_cutoff_date(source) do
+    if source.download_cutoff_date do
+      dynamic([mi], mi.upload_date >= ^source.download_cutoff_date)
+    else
+      dynamic(true)
+    end
+  end
 
-    MediaMetadata.filepath_attributes()
-    |> Enum.map(fn field -> mapped_struct[field] end)
-    |> Enum.filter(&is_binary/1)
-    |> Enum.each(&FilesystemHelpers.delete_file_and_remove_empty_directories/1)
+  defp build_format_clauses(media_profile) do
+    mapped_struct = Map.from_struct(media_profile)
+
+    Enum.reduce(mapped_struct, dynamic(true), fn attr, dynamic ->
+      case {attr, media_profile} do
+        {{:shorts_behaviour, :only}, %{livestream_behaviour: :only}} ->
+          dynamic(
+            [mi],
+            ^dynamic and (mi.livestream == true or mi.short_form_content == true)
+          )
+
+        # Technically redundant, but makes the other clauses easier to parse
+        # (redundant because this condition is the same as the condition above, just flipped)
+        {{:livestream_behaviour, :only}, %{shorts_behaviour: :only}} ->
+          dynamic
+
+        {{:shorts_behaviour, :only}, _} ->
+          dynamic([mi], ^dynamic and mi.short_form_content == true)
+
+        {{:livestream_behaviour, :only}, _} ->
+          dynamic([mi], ^dynamic and mi.livestream == true)
+
+        {{:shorts_behaviour, :exclude}, %{livestream_behaviour: lb}} when lb != :only ->
+          dynamic([mi], ^dynamic and mi.short_form_content == false)
+
+        {{:livestream_behaviour, :exclude}, %{shorts_behaviour: sb}} when sb != :only ->
+          # return records with livestream: false
+          dynamic([mi], ^dynamic and mi.livestream == false)
+
+        _ ->
+          dynamic
+      end
+    end)
   end
 end

lib/pinchflat/media/media_item.ex

@@ -5,7 +5,6 @@ defmodule Pinchflat.Media.MediaItem do
 
   use Ecto.Schema
   import Ecto.Changeset
-  import Pinchflat.Utils.ChangesetUtils
 
   alias Pinchflat.Tasks.Task
   alias Pinchflat.Sources.Source
@@ -22,23 +21,16 @@ defmodule Pinchflat.Media.MediaItem do
     :source_id,
     :short_form_content,
     :upload_date,
-    :duration_seconds,
     # these fields are captured only on download
     :media_downloaded_at,
     :media_filepath,
     :media_size_bytes,
     :subtitle_filepaths,
     :thumbnail_filepath,
-    :metadata_filepath,
-    :nfo_filepath,
-    # These are user or system controlled fields
-    :prevent_download,
-    :prevent_culling,
-    :culled_at
+    :metadata_filepath
   ]
   # Pretty much all the fields captured at index are required.
   @required_fields ~w(
-    uuid
     title
     original_url
     livestream
@@ -46,14 +38,9 @@ defmodule Pinchflat.Media.MediaItem do
     source_id
     upload_date
     short_form_content
-  )a
+    )a
 
   schema "media_items" do
-    # This is _not_ used as the primary key or internally in the database
-    # relations. This is only used to prevent an enumeration attack on the streaming
-    # and RSS feed endpoints since those _must_ be public (ie: no basic auth)
-    field :uuid, Ecto.UUID
-
     field :title, :string
     field :media_id, :string
     field :description, :string
@@ -62,22 +49,16 @@ defmodule Pinchflat.Media.MediaItem do
     field :short_form_content, :boolean, default: false
     field :media_downloaded_at, :utc_datetime
     field :upload_date, :date
-    field :duration_seconds, :integer
 
     field :media_filepath, :string
     field :media_size_bytes, :integer
     field :thumbnail_filepath, :string
     field :metadata_filepath, :string
-    field :nfo_filepath, :string
     # This is an array of [iso-2 language, filepath] pairs. Probably could
     # be an associated record, but I don't see the benefit right now.
     # Will very likely revisit because I can't leave well-enough alone.
     field :subtitle_filepaths, {:array, {:array, :string}}, default: []
 
-    field :prevent_download, :boolean, default: false
-    field :prevent_culling, :boolean, default: false
-    field :culled_at, :utc_datetime
-
     field :matching_search_term, :string, virtual: true
 
     belongs_to :source, Source
@@ -95,23 +76,12 @@ defmodule Pinchflat.Media.MediaItem do
     media_item
     |> cast(attrs, @allowed_fields)
     |> cast_assoc(:metadata, with: &MediaMetadata.changeset/2, required: false)
-    |> dynamic_default(:uuid, fn _ -> Ecto.UUID.generate() end)
     |> validate_required(@required_fields)
     |> unique_constraint([:media_id, :source_id])
   end
 
   @doc false
   def filepath_attributes do
-    ~w(media_filepath thumbnail_filepath metadata_filepath subtitle_filepaths nfo_filepath)a
-  end
-
-  @doc false
-  def filepath_attribute_defaults do
-    filepath_attributes()
-    |> Enum.map(fn
-      :subtitle_filepaths -> {:subtitle_filepaths, []}
-      field -> {field, nil}
-    end)
-    |> Enum.into(%{})
+    ~w(media_filepath thumbnail_filepath metadata_filepath subtitle_filepaths)a
   end
 end

lib/pinchflat/media/media_query.ex

@@ -1,158 +0,0 @@
-defmodule Pinchflat.Media.MediaQuery do
-  @moduledoc """
-  Query helpers for the Media context.
-
-  These methods are made to be one-ish liners used
-  to compose queries. Each method should strive to do
-  _one_ thing. These don't need to be tested as
-  they are just building blocks for other functionality
-  which, itself, will be tested.
-  """
-  import Ecto.Query, warn: false
-
-  alias Pinchflat.Media.MediaItem
-
-  # Prefixes:
-  # - for_* - belonging to a certain record
-  # - join_* - for joining on a certain record
-  # - with_* - for filtering based on full, concrete attributes
-  # - matching_* - for filtering based on partial attributes (e.g. LIKE, regex, full-text search)
-  #
-  # Suffixes:
-  # - _for - the arg passed is an association record
-
-  def new do
-    MediaItem
-  end
-
-  def for_source(query, source) do
-    where(query, [mi], mi.source_id == ^source.id)
-  end
-
-  def join_sources(query) do
-    from(mi in query, join: s in assoc(mi, :source), as: :sources)
-  end
-
-  def with_passed_retention_period(query) do
-    query
-    |> require_assoc(:source)
-    |> where(
-      [mi, source],
-      fragment(
-        "IFNULL(?, 0) > 0 AND DATETIME('now', '-' || ? || ' day') > ?",
-        source.retention_period_days,
-        source.retention_period_days,
-        mi.media_downloaded_at
-      )
-    )
-  end
-
-  def with_no_culling_prevention(query) do
-    where(query, [mi], mi.prevent_culling == false)
-  end
-
-  def with_id(query, id) do
-    where(query, [mi], mi.id == ^id)
-  end
-
-  def with_media_ids(query, media_ids) do
-    where(query, [mi], mi.media_id in ^media_ids)
-  end
-
-  def with_media_filepath(query) do
-    where(query, [mi], not is_nil(mi.media_filepath))
-  end
-
-  def with_no_media_filepath(query) do
-    where(query, [mi], is_nil(mi.media_filepath))
-  end
-
-  def with_upload_date_after_source_cutoff(query) do
-    query
-    |> require_assoc(:source)
-    |> where([mi, source], is_nil(source.download_cutoff_date) or mi.upload_date >= source.download_cutoff_date)
-  end
-
-  def with_no_prevented_download(query) do
-    where(query, [mi], mi.prevent_download == false)
-  end
-
-  def matching_source_title_regex(query) do
-    query
-    |> require_assoc(:source)
-    |> where(
-      [mi, source],
-      is_nil(source.title_filter_regex) or fragment("regexp_like(?, ?)", mi.title, source.title_filter_regex)
-    )
-  end
-
-  def matching_search_term(query, nil), do: query
-
-  def matching_search_term(query, term) do
-    from(mi in query,
-      join: mi_search_index in assoc(mi, :media_items_search_index),
-      where: fragment("media_items_search_index MATCH ?", ^term),
-      select_merge: %{
-        matching_search_term:
-          fragment("""
-            coalesce(snippet(media_items_search_index, 0, '[PF_HIGHLIGHT]', '[/PF_HIGHLIGHT]', '...', 20), '') ||
-            ' ' ||
-            coalesce(snippet(media_items_search_index, 1, '[PF_HIGHLIGHT]', '[/PF_HIGHLIGHT]', '...', 20), '')
-          """)
-      },
-      order_by: [desc: fragment("rank")]
-    )
-  end
-
-  def with_format_matching_profile_preference(query) do
-    query
-    |> require_assoc(:media_profile)
-    |> where(
-      fragment("""
-        CASE
-          WHEN shorts_behaviour = 'only' AND livestream_behaviour = 'only' THEN
-            livestream = true OR short_form_content = true
-          WHEN shorts_behaviour = 'only' THEN
-            short_form_content = true
-          WHEN livestream_behaviour = 'only' THEN
-            livestream = true
-          WHEN shorts_behaviour = 'exclude' AND livestream_behaviour = 'exclude' THEN
-            short_form_content = false AND livestream = false
-          WHEN shorts_behaviour = 'exclude' THEN
-            short_form_content = false
-          WHEN livestream_behaviour = 'exclude' THEN
-            livestream = false
-          ELSE
-            true
-        END
-      """)
-    )
-  end
-
-  def with_media_pending_download(query) do
-    query
-    |> with_no_prevented_download()
-    |> with_no_media_filepath()
-    |> with_upload_date_after_source_cutoff()
-    |> with_format_matching_profile_preference()
-    |> matching_source_title_regex()
-  end
-
-  defp require_assoc(query, identifier) do
-    if has_named_binding?(query, identifier) do
-      query
-    else
-      do_require_assoc(query, identifier)
-    end
-  end
-
-  defp do_require_assoc(query, :source) do
-    from(mi in query, join: s in assoc(mi, :source), as: :source)
-  end
-
-  defp do_require_assoc(query, :media_profile) do
-    query
-    |> require_assoc(:source)
-    |> join(:inner, [mi, source], mp in assoc(source, :media_profile), as: :media_profile)
-  end
-end

lib/pinchflat/metadata/metadata_file_helpers.ex

@@ -9,24 +9,6 @@ defmodule Pinchflat.Metadata.MetadataFileHelpers do
   needed
   """
 
-  alias Pinchflat.Filesystem.FilesystemHelpers
-
-  @doc """
-  Returns the directory where metadata for a database record should be stored.
-
-  Returns binary()
-  """
-  def metadata_directory_for(database_record) do
-    metadata_directory = Application.get_env(:pinchflat, :metadata_directory)
-    record_table_name = database_record.__meta__.source
-
-    Path.join([
-      metadata_directory,
-      record_table_name,
-      to_string(database_record.id)
-    ])
-  end
-
   @doc """
   Compresses and stores metadata for a media item, returning the filepath.
 
@@ -36,7 +18,8 @@ defmodule Pinchflat.Metadata.MetadataFileHelpers do
     filepath = generate_filepath_for(database_record, "metadata.json.gz")
     {:ok, json} = Phoenix.json_library().encode(metadata_map)
 
-    :ok = FilesystemHelpers.write_p!(filepath, json, [:compressed])
+    File.mkdir_p!(Path.dirname(filepath))
+    :ok = File.write(filepath, json, [:compressed])
 
     filepath
   end
@@ -62,60 +45,12 @@ defmodule Pinchflat.Metadata.MetadataFileHelpers do
     filepath = generate_filepath_for(database_record, Path.basename(thumbnail_url))
     thumbnail_blob = fetch_thumbnail_from_url(thumbnail_url)
 
-    :ok = FilesystemHelpers.write_p!(filepath, thumbnail_blob)
+    File.mkdir_p!(Path.dirname(filepath))
+    :ok = File.write(filepath, thumbnail_blob)
 
     filepath
   end
 
-  @doc """
-  Parses an upload date from the YYYYMMDD string returned in yt-dlp metadata
-  and returns a Date struct.
-
-  Returns Date.t()
-  """
-  def parse_upload_date(upload_date) do
-    <<year::binary-size(4)>> <> <<month::binary-size(2)>> <> <<day::binary-size(2)>> = upload_date
-
-    Date.from_iso8601!("#{year}-#{month}-#{day}")
-  end
-
-  @doc """
-  Attempts to determine the series directory from a media filepath.
-  The series directory is the "root" directory for a given source
-  which should contain all the season-level folders of that source.
-
-  Used for determining where to store things like NFO data and banners
-  for media center apps. Not useful without a media center app.
-
-  Returns {:ok, binary()} | {:error, :indeterminable}
-  """
-  def series_directory_from_media_filepath(media_filepath) do
-    # Matches "s" or "season" (case-insensitive)
-    # followed by an optional non-word character (. or _ or <space>, etc)
-    # followed by at least one digit
-    # followed immediately by the end of the string
-    # Example matches: s1, s.1, s01 season 1, Season.01, Season_1, Season 1, Season1
-    # Example non-matches: s01e01, season, series 1,
-    season_regex = ~r/^s(eason)?(\W|_)?\d{1,}$/i
-
-    {series_directory, found_series_directory} =
-      media_filepath
-      |> Path.split()
-      |> Enum.reduce_while({[], false}, fn part, {directory_acc, _} ->
-        if String.match?(part, season_regex) do
-          {:halt, {directory_acc, true}}
-        else
-          {:cont, {directory_acc ++ [part], false}}
-        end
-      end)
-
-    if found_series_directory do
-      {:ok, Path.join(series_directory)}
-    else
-      {:error, :indeterminable}
-    end
-  end
-
   defp fetch_thumbnail_from_url(url) do
     http_client = Application.get_env(:pinchflat, :http_client, Pinchflat.HTTP.HTTPClient)
     {:ok, body} = http_client.get(url, [], body_format: :binary)
@@ -124,8 +59,13 @@ defmodule Pinchflat.Metadata.MetadataFileHelpers do
   end
 
   defp generate_filepath_for(database_record, filename) do
+    metadata_directory = Application.get_env(:pinchflat, :metadata_directory)
+    record_table_name = database_record.__meta__.source
+
     Path.join([
-      metadata_directory_for(database_record),
+      metadata_directory,
+      record_table_name,
+      to_string(database_record.id),
       filename
     ])
   end

lib/pinchflat/metadata/metadata_parser.ex

@@ -30,8 +30,7 @@ defmodule Pinchflat.Metadata.MetadataParser do
       original_url: metadata["original_url"],
       description: metadata["description"],
       media_filepath: metadata["filepath"],
-      livestream: metadata["was_live"],
-      duration_seconds: metadata["duration"] && round(metadata["duration"])
+      livestream: metadata["was_live"]
     }
   end
 
@@ -55,42 +54,14 @@ defmodule Pinchflat.Metadata.MetadataParser do
       |> Enum.reverse()
       |> Enum.find_value(fn attrs -> attrs["filepath"] end)
 
-    if thumbnail_filepath do
-      # NOTE: whole ordeal needed due to a bug I found in yt-dlp
-      # https://github.com/yt-dlp/yt-dlp/issues/9445
-      # Can be reverted to remove this entire conditional once fixed
-      filepath =
-        thumbnail_filepath
-        |> String.split(~r{\.}, include_captures: true)
-        |> List.insert_at(-3, "-thumb")
-        |> Enum.join()
-
-      %{
-        thumbnail_filepath: filepath_if_exists(filepath)
-      }
-    else
-      %{
-        thumbnail_filepath: nil
-      }
-    end
+    %{
+      thumbnail_filepath: thumbnail_filepath
+    }
   end
 
   defp parse_infojson_metadata(metadata) do
     %{
-      metadata_filepath: filepath_if_exists(metadata["infojson_filename"])
+      metadata_filepath: metadata["infojson_filename"]
     }
   end
-
-  # NOTE: this should not be needed, but it is due to a bug in yt-dlp.
-  # Can remove once this is resolved:
-  # https://github.com/yt-dlp/yt-dlp/issues/9445#issuecomment-2018724344
-  defp filepath_if_exists(nil), do: nil
-
-  defp filepath_if_exists(filepath) do
-    if File.exists?(filepath) do
-      filepath
-    else
-      nil
-    end
-  end
 end

lib/pinchflat/metadata/nfo_builder.ex

@@ -1,70 +0,0 @@
-defmodule Pinchflat.Metadata.NfoBuilder do
-  @moduledoc """
-  Provides methods for building and storing NFO files for
-  use by Kodi/Jellyfin and other media center software.
-  """
-
-  import Pinchflat.Utils.XmlUtils, only: [safe: 1]
-
-  alias Pinchflat.Metadata.MetadataFileHelpers
-  alias Pinchflat.Filesystem.FilesystemHelpers
-
-  @doc """
-  Builds an NFO file for a media item (read: single "episode") and
-  stores it at the specified location.
-
-  Returns the filepath of the NFO file.
-  """
-  def build_and_store_for_media_item(filepath, metadata) do
-    nfo = build_for_media_item(metadata)
-
-    FilesystemHelpers.write_p!(filepath, nfo)
-
-    filepath
-  end
-
-  @doc """
-  Builds an NFO file for a souce and stores it at the specified location.
-  Technically works for playlists, but it's really made for channels.
-
-  Returns the filepath of the NFO file.
-  """
-  def build_and_store_for_source(filepath, metadata) do
-    nfo = build_for_source(metadata)
-
-    FilesystemHelpers.write_p!(filepath, nfo)
-
-    filepath
-  end
-
-  defp build_for_media_item(metadata) do
-    upload_date = MetadataFileHelpers.parse_upload_date(metadata["upload_date"])
-    # Cribbed from a combination of the Kodi wiki, ytdl-nfo, and ytdl-sub.
-    # WHO NEEDS A FANCY XML PARSER ANYWAY?!
-    """
-    <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
-    <episodedetails>
-      <title>#{safe(metadata["title"])}</title>
-      <showtitle>#{safe(metadata["uploader"])}</showtitle>
-      <uniqueid type="youtube" default="true">#{safe(metadata["id"])}</uniqueid>
-      <plot>#{safe(metadata["description"])}</plot>
-      <aired>#{safe(upload_date)}</aired>
-      <season>#{safe(upload_date.year)}</season>
-      <episode>#{Calendar.strftime(upload_date, "%m%d")}</episode>
-      <genre>YouTube</genre>
-    </episodedetails>
-    """
-  end
-
-  defp build_for_source(metadata) do
-    """
-    <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
-    <tvshow>
-      <title>#{safe(metadata["title"])}</title>
-      <plot>#{safe(metadata["description"])}</plot>
-      <uniqueid type="youtube" default="true">#{safe(metadata["id"])}</uniqueid>
-      <genre>YouTube</genre>
-    </tvshow>
-    """
-  end
-end

lib/pinchflat/metadata/source_image_parser.ex

@@ -1,69 +0,0 @@
-defmodule Pinchflat.Metadata.SourceImageParser do
-  @moduledoc """
-  Functions for parsing and storing source images.
-  """
-  alias Pinchflat.Filesystem.FilesystemHelpers
-
-  @doc """
-  Given a base directory and source metadata, look for the appropriate images
-  and move them to the base directory. Returns a map of image types and their
-  filepaths (specifically for a source). If a given image type is not found,
-  the key will not be present in the map.
-
-  The metadata is expected to contain the `filepath` key for images, implying
-  that the images have already been downloaded by yt-dlp. This method will NOT
-  download images from the internet - it just copys them around.
-
-  Returns a map with the possible keys :poster_filepath, :fanart_filepath, and
-  :banner_filepath.
-  """
-  def store_source_images(base_directory, source_metadata) do
-    (source_metadata["thumbnails"] || [])
-    |> Enum.filter(&(&1["filepath"] != nil))
-    |> select_useful_images()
-    |> Enum.map(&move_image(&1, base_directory))
-    |> Enum.into(%{})
-  end
-
-  defp select_useful_images(images) do
-    labelled_images =
-      Enum.reduce(images, [], fn image_map, acc ->
-        case image_map do
-          %{"id" => "avatar_uncropped"} ->
-            acc ++ [{:poster, :poster_filepath, image_map["filepath"]}]
-
-          %{"id" => "banner_uncropped"} ->
-            acc ++ [{:fanart, :fanart_filepath, image_map["filepath"]}]
-
-          _ ->
-            acc
-        end
-      end)
-
-    labelled_images
-    |> Enum.concat([{:banner, :banner_filepath, determine_best_banner(images)}])
-    |> Enum.filter(fn {_, _, tmp_filepath} -> tmp_filepath end)
-  end
-
-  defp determine_best_banner(images) do
-    best_candidate =
-      images
-      # Filter out images that don't have a width and height attribute
-      |> Enum.filter(&(&1["width"] && &1["height"]))
-      # Sort images with the highest width first
-      |> Enum.sort(&(&1["width"] >= &2["width"]))
-      # Find the first image where the ratio of width to height is greater than 3
-      |> Enum.find(&(&1["width"] / &1["height"] > 3))
-
-    Map.get(best_candidate || %{}, "filepath")
-  end
-
-  defp move_image({filename, source_attr_name, tmp_filepath}, base_directory) do
-    extension = Path.extname(tmp_filepath)
-    final_filepath = Path.join([base_directory, "#{filename}#{extension}"])
-
-    FilesystemHelpers.cp_p!(tmp_filepath, final_filepath)
-
-    {source_attr_name, final_filepath}
-  end
-end

lib/pinchflat/metadata/source_metadata.ex

@@ -1,50 +0,0 @@
-defmodule Pinchflat.Metadata.SourceMetadata do
-  @moduledoc """
-  The SourceMetadata schema.
-
-  Look. Don't @ me about Metadata vs. Metadatum. I'm very sensitive.
-  """
-
-  use Ecto.Schema
-  import Ecto.Changeset
-
-  alias Pinchflat.Sources.Source
-
-  @allowed_fields ~w(
-    metadata_filepath
-    fanart_filepath
-    poster_filepath
-    banner_filepath
-  )a
-
-  @required_fields ~w(metadata_filepath)a
-
-  schema "source_metadata" do
-    field :metadata_filepath, :string
-    field :fanart_filepath, :string
-    field :poster_filepath, :string
-    field :banner_filepath, :string
-
-    belongs_to :source, Source
-
-    timestamps(type: :utc_datetime)
-  end
-
-  @doc false
-  def changeset(source_metadata, attrs) do
-    source_metadata
-    |> cast(attrs, @allowed_fields)
-    |> validate_required(@required_fields)
-    |> unique_constraint([:source_id])
-  end
-
-  @doc false
-  def filepath_attributes do
-    ~w(
-      metadata_filepath
-      fanart_filepath
-      poster_filepath
-      banner_filepath
-    )a
-  end
-end

lib/pinchflat/metadata/source_metadata_storage_worker.ex

@@ -1,116 +0,0 @@
-defmodule Pinchflat.Metadata.SourceMetadataStorageWorker do
-  @moduledoc false
-
-  use Oban.Worker,
-    queue: :remote_metadata,
-    tags: ["media_source", "source_metadata", "remote_metadata"],
-    max_attempts: 3
-
-  require Logger
-
-  alias __MODULE__
-  alias Pinchflat.Repo
-  alias Pinchflat.Tasks
-  alias Pinchflat.Sources
-  alias Pinchflat.Utils.StringUtils
-  alias Pinchflat.Metadata.NfoBuilder
-  alias Pinchflat.YtDlp.MediaCollection
-  alias Pinchflat.Metadata.SourceImageParser
-  alias Pinchflat.Metadata.MetadataFileHelpers
-  alias Pinchflat.Downloading.DownloadOptionBuilder
-
-  @doc """
-  Starts the source metadata storage worker and creates a task for the source.
-
-  Returns {:ok, %Task{}} | {:error, :duplicate_job} | {:error, %Ecto.Changeset{}}
-  """
-  def kickoff_with_task(source, opts \\ []) do
-    %{id: source.id}
-    |> SourceMetadataStorageWorker.new(opts)
-    |> Tasks.create_job_with_task(source)
-  end
-
-  @doc """
-  Fetches and stores various forms of metadata for a source:
-    - Attributes like `description`
-    - JSON metadata for internal use
-    - The series directory for the source
-    - The NFO file for the source (if specified)
-    - Downloads and stores source images (if specified)
-
-  The worker is kicked off after a source is inserted/updated - this can
-  take an unknown amount of time so don't rely on this data being here
-  before, say, the first indexing or downloading task is complete.
-
-  Returns :ok
-  """
-  @impl Oban.Worker
-  def perform(%Oban.Job{args: %{"id" => source_id}}) do
-    source = Repo.preload(Sources.get_source!(source_id), [:metadata, :media_profile])
-    series_directory = determine_series_directory(source)
-
-    {source_metadata, source_image_attrs, metadata_image_attrs} =
-      fetch_source_metadata_and_images(series_directory, source)
-
-    source_metadata_filepath = MetadataFileHelpers.compress_and_store_metadata_for(source, source_metadata)
-
-    Sources.update_source(
-      source,
-      Map.merge(
-        %{
-          series_directory: series_directory,
-          nfo_filepath: store_source_nfo(source, series_directory, source_metadata),
-          description: source_metadata["description"],
-          metadata: Map.merge(%{metadata_filepath: source_metadata_filepath}, metadata_image_attrs)
-        },
-        source_image_attrs
-      ),
-      # `run_post_commit_tasks: false` prevents this from running in an infinite loop
-      run_post_commit_tasks: false
-    )
-
-    :ok
-  rescue
-    Ecto.NoResultsError -> Logger.info("#{__MODULE__} discarded: source #{source_id} not found")
-    Ecto.StaleEntryError -> Logger.info("#{__MODULE__} discarded: source #{source_id} stale")
-  end
-
-  defp fetch_source_metadata_and_images(series_directory, source) do
-    metadata_directory = MetadataFileHelpers.metadata_directory_for(source)
-    tmp_output_path = "#{tmp_directory()}/#{StringUtils.random_string(16)}/source_image.%(ext)S"
-    opts = [:write_all_thumbnails, convert_thumbnails: "jpg", output: tmp_output_path]
-
-    {:ok, metadata} = MediaCollection.get_source_metadata(source.original_url, opts)
-    metadata_image_attrs = SourceImageParser.store_source_images(metadata_directory, metadata)
-
-    if source.media_profile.download_source_images && series_directory do
-      source_image_attrs = SourceImageParser.store_source_images(series_directory, metadata)
-
-      {metadata, source_image_attrs, metadata_image_attrs}
-    else
-      {metadata, %{}, metadata_image_attrs}
-    end
-  end
-
-  defp determine_series_directory(source) do
-    output_path = DownloadOptionBuilder.build_output_path_for(source)
-    {:ok, %{filepath: filepath}} = MediaCollection.get_source_details(source.original_url, output: output_path)
-
-    case MetadataFileHelpers.series_directory_from_media_filepath(filepath) do
-      {:ok, series_directory} -> series_directory
-      {:error, _} -> nil
-    end
-  end
-
-  defp store_source_nfo(source, series_directory, metadata) do
-    if source.media_profile.download_nfo && series_directory do
-      nfo_filepath = Path.join(series_directory, "tvshow.nfo")
-
-      NfoBuilder.build_and_store_for_source(nfo_filepath, metadata)
-    end
-  end
-
-  defp tmp_directory do
-    Application.get_env(:pinchflat, :tmpfile_directory)
-  end
-end

lib/pinchflat/podcasts/podcast_helpers.ex

@@ -1,78 +0,0 @@
-defmodule Pinchflat.Podcasts.PodcastHelpers do
-  @moduledoc """
-  Methods for fetching postcast-related data from a source
-  or its media items
-  """
-
-  alias Pinchflat.Repo
-  alias Pinchflat.Media.MediaQuery
-  alias Pinchflat.Metadata.MediaMetadata
-  alias Pinchflat.Metadata.SourceMetadata
-
-  @doc """
-  Returns a list of media items that have been downloaded to disk
-  and have been proven to still exist there.
-
-  Useful for podcasts since we don't want to serve media that
-  has been deleted or moved, but it's also fairly generally useful
-  so I could see this being moved in the future.
-
-  Options:
-    - limit: integer - the maximum number of media items to return
-
-  Returns: [%MediaItem{}]
-  """
-  def persisted_media_items_for(source, opts \\ []) do
-    limit = Keyword.get(opts, :limit, 500)
-
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> MediaQuery.with_media_filepath()
-    |> Repo.maybe_limit(limit)
-    |> Repo.all()
-    |> Enum.filter(fn media_item -> File.exists?(media_item.media_filepath) end)
-  end
-
-  @doc """
-  Selects a cover image for a source based on the source's metadata
-  and the metadata of the media items associated with the source. Also
-  ensures images exist on disk.
-
-  Only one media item should need to be returned since this is using the
-  internal metadata which, so long as the media_item was _downloaded_, should
-  be guaranteed to exist.
-
-  Prefers the source's poster, then fanart, then the media item's thumbnail.
-
-  Returns: {:ok, filepath} | {:error, :no_suitable_image}
-  """
-  def select_cover_image(source, media_items) do
-    source_with_preloads = Repo.preload(source, :metadata)
-
-    source_with_preloads
-    |> get_images_by_preference(media_items)
-    |> Enum.reject(&is_nil(&1))
-    |> Enum.find(&File.exists?/1)
-    |> case do
-      nil -> {:error, :no_suitable_image}
-      filepath -> {:ok, filepath}
-    end
-  end
-
-  defp get_images_by_preference(source_with_preloads, []) do
-    source_metadata = source_with_preloads.metadata || %SourceMetadata{}
-
-    [
-      source_metadata.poster_filepath,
-      source_metadata.fanart_filepath
-    ]
-  end
-
-  defp get_images_by_preference(source_with_preloads, [media_item | _]) do
-    media_item_with_preloads = Repo.preload(media_item, :metadata)
-    media_item_metadata = media_item_with_preloads.metadata || %MediaMetadata{}
-    source_images = get_images_by_preference(source_with_preloads, [])
-
-    source_images ++ [media_item_metadata.thumbnail_filepath]
-  end
-end

lib/pinchflat/podcasts/rss_feed_builder.ex

@@ -1,133 +0,0 @@
-defmodule Pinchflat.Podcasts.RssFeedBuilder do
-  @moduledoc """
-  Methods for building an RSS feed for a source and its media items.
-  """
-
-  @datetime_format "%a, %d %b %Y %H:%M:%S %z"
-
-  import Pinchflat.Utils.XmlUtils, only: [safe: 1]
-
-  alias Pinchflat.Utils.DatetimeUtils
-  alias Pinchflat.Podcasts.PodcastHelpers
-  alias PinchflatWeb.Router.Helpers, as: Routes
-
-  @doc """
-  Builds an RSS feed for a given source and its media items.
-  Only MediaItems that have been persisted will be included in the feed.
-
-  ## Options:
-    - `:limit` - The maximum number of media items to include in the feed. Defaults to 300.
-
-  Returns an XML document as a string.
-  """
-  def build(source, opts \\ []) do
-    limit = Keyword.get(opts, :limit, 300)
-    url_base = Keyword.get(opts, :url_base, PinchflatWeb.Endpoint.url())
-
-    media_items = PodcastHelpers.persisted_media_items_for(source, limit: limit)
-    build_source_xml(source, media_items, url_base)
-  end
-
-  defp build_source_xml(source, media_items, url_base) do
-    media_item_xml = Enum.map(media_items, &build_media_item_xml(source, &1, url_base))
-    # "caching" the image path since it requires some DB calls and is used twice
-    feed_image_path = feed_image_path(url_base, source, media_items)
-
-    # Useful: resources:
-    #   - https://validator.w3.org/feed/#validate_by_input
-    #   - https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md
-    #   - https://podba.se/validate
-    """
-    <?xml version="1.0" encoding="UTF-8"?>
-    <rss version="2.0"
-      xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd"
-      xmlns:podcast="https://podcastindex.org/namespace/1.0"
-      xmlns:atom="http://www.w3.org/2005/Atom">
-      <channel>
-        <title>#{safe(source.custom_name)}</title>
-        <link>#{safe(source.original_url)}</link>
-        <description>#{safe(source.description)}</description>
-        <category>TV &amp; Film</category>
-        <generator>Generated by Pinchflat</generator>
-        <language>en-us</language>
-        <lastBuildDate>#{Calendar.strftime(source.updated_at, @datetime_format)}</lastBuildDate>
-        <pubDate>#{Calendar.strftime(source.inserted_at, @datetime_format)}</pubDate>
-        <atom:link href="#{safe(generate_self_link(url_base, source))}" rel="self" type="application/rss+xml" />
-        <podcast:locked>yes</podcast:locked>
-        <podcast:guid>#{source.uuid}</podcast:guid>
-        <image>
-          <url>#{safe(feed_image_path)}</url>
-          <title>#{safe(source.custom_name)}</title>
-          <link>#{safe(source.original_url)}</link>
-        </image>
-        <itunes:author>#{safe(source.custom_name)}</itunes:author>
-        <itunes:subtitle>#{safe(source.custom_name)}</itunes:subtitle>
-        <itunes:block>yes</itunes:block>
-        <itunes:image href="#{safe(feed_image_path)}"></itunes:image>
-        <itunes:explicit>false</itunes:explicit>
-        <itunes:category text="TV &amp; Film"></itunes:category>
-
-        #{Enum.join(media_item_xml, "\n")}
-
-      </channel>
-    </rss>
-    """
-  end
-
-  defp build_media_item_xml(source, media_item, url_base) do
-    """
-    <item>
-      <guid isPermaLink="false">#{media_item.uuid}</guid>
-      <title>#{safe(media_item.title)}</title>
-      <link>#{safe(media_item.original_url)}</link>
-      <description>#{safe(media_item.description)}</description>
-      <pubDate>#{generate_upload_date(media_item)}</pubDate>
-      <itunes:duration>#{media_item.duration_seconds}</itunes:duration>
-      <enclosure
-        url="#{media_stream_path(url_base, media_item)}"
-        length="#{media_item.media_size_bytes}"
-        type="#{MIME.from_path(media_item.media_filepath)}"
-      />
-      <itunes:author>#{safe(source.custom_name)}</itunes:author>
-      <itunes:subtitle>#{safe(media_item.title)}</itunes:subtitle>
-      <itunes:summary><![CDATA[#{media_item.description}]]></itunes:summary>
-      <itunes:explicit>false</itunes:explicit>
-    </item>
-    """
-  end
-
-  defp generate_self_link(url_base, source) do
-    Path.join(url_base, "#{podcast_route(:rss_feed, source.uuid)}.xml")
-  end
-
-  defp media_stream_path(url_base, media_item) do
-    extension = Path.extname(media_item.media_filepath)
-
-    Path.join(url_base, "#{media_route(:stream, media_item.uuid)}#{extension}")
-  end
-
-  defp feed_image_path(url_base, source, media_items) do
-    case PodcastHelpers.select_cover_image(source, media_items) do
-      {:error, _} ->
-        ""
-
-      {:ok, filepath} ->
-        extension = Path.extname(filepath)
-        Path.join(url_base, "#{podcast_route(:feed_image, source.uuid)}#{extension}")
-    end
-  end
-
-  defp generate_upload_date(media_item) do
-    media_item.upload_date
-    |> DatetimeUtils.date_to_datetime()
-    |> Calendar.strftime(@datetime_format)
-  end
-
-  defp podcast_route(action, params) do
-    Routes.podcast_path(PinchflatWeb.Endpoint, action, params)
-  end
-
-  defp media_route(action, params) do
-    Routes.media_item_path(PinchflatWeb.Endpoint, action, params)
-  end
-end

lib/pinchflat/profiles/media_profile.ex

@@ -17,12 +17,8 @@ defmodule Pinchflat.Profiles.MediaProfile do
     sub_langs
     download_thumbnail
     embed_thumbnail
-    download_source_images
     download_metadata
     embed_metadata
-    download_nfo
-    sponsorblock_behaviour
-    sponsorblock_categories
     shorts_behaviour
     livestream_behaviour
     preferred_resolution
@@ -36,21 +32,17 @@ defmodule Pinchflat.Profiles.MediaProfile do
     field :output_path_template, :string,
       default: "/{{ source_custom_name }}/{{ upload_yyyy_mm_dd }} {{ title }}/{{ title }} [{{ id }}].{{ ext }}"
 
-    field :download_subs, :boolean, default: false
-    field :download_auto_subs, :boolean, default: false
-    field :embed_subs, :boolean, default: false
+    field :download_subs, :boolean, default: true
+    field :download_auto_subs, :boolean, default: true
+    field :embed_subs, :boolean, default: true
     field :sub_langs, :string, default: "en"
 
-    field :download_thumbnail, :boolean, default: false
-    field :embed_thumbnail, :boolean, default: false
-    field :download_source_images, :boolean, default: false
+    field :download_thumbnail, :boolean, default: true
+    field :embed_thumbnail, :boolean, default: true
 
-    field :download_metadata, :boolean, default: false
-    field :embed_metadata, :boolean, default: false
+    field :download_metadata, :boolean, default: true
+    field :embed_metadata, :boolean, default: true
 
-    field :download_nfo, :boolean, default: false
-    field :sponsorblock_behaviour, Ecto.Enum, values: [:disabled, :remove], default: :disabled
-    field :sponsorblock_categories, {:array, :string}, default: []
     # NOTE: these do NOT speed up indexing - the indexer still has to go
     # through the entire collection to determine if a media is a short or
     # a livestream.
@@ -73,12 +65,6 @@ defmodule Pinchflat.Profiles.MediaProfile do
     media_profile
     |> cast(attrs, @allowed_fields)
     |> validate_required(@required_fields)
-    # Ensures it ends with `.{{ ext }}` or `.%(ext)s` or similar (with a little wiggle room)
-    |> validate_format(:output_path_template, ext_regex(), message: "must end with .{{ ext }}")
     |> unique_constraint(:name)
   end
-
-  defp ext_regex do
-    ~r/\.({{ ?ext ?}}|%\( ?ext ?\)[sS])$/
-  end
 end

lib/pinchflat/release.ex

@@ -5,10 +5,6 @@ defmodule Pinchflat.Release do
   """
   @app :pinchflat
 
-  require Logger
-
-  alias Pinchflat.Filesystem.FilesystemHelpers
-
   def migrate do
     load_app()
 
@@ -22,38 +18,6 @@ defmodule Pinchflat.Release do
     {:ok, _, _} = Ecto.Migrator.with_repo(repo, &Ecto.Migrator.run(&1, :down, to: version))
   end
 
-  def check_file_permissions do
-    load_app()
-
-    directories =
-      Enum.uniq([
-        "/config",
-        "/downloads",
-        Application.get_env(:pinchflat, :media_directory),
-        Application.get_env(:pinchflat, :tmpfile_directory),
-        Application.get_env(:pinchflat, :extras_directory),
-        Application.get_env(:pinchflat, :metadata_directory)
-      ])
-
-    Enum.each(directories, fn dir ->
-      Logger.info("Checking permissions for #{dir}")
-      filepath = Path.join([dir, ".keep"])
-
-      case FilesystemHelpers.write_p(filepath, "") do
-        :ok ->
-          Logger.info("Permissions OK")
-
-        {:error, :eacces} ->
-          Logger.error(permission_denied_screed(dir))
-          raise "Permission denied"
-
-        err ->
-          Logger.error("Permissions check failed: #{inspect(err)}")
-          raise "Unknown error"
-      end
-    end)
-  end
-
   defp repos do
     Application.fetch_env!(@app, :ecto_repos)
   end
@@ -61,31 +25,4 @@ defmodule Pinchflat.Release do
   defp load_app do
     Application.load(@app)
   end
-
-  defp permission_denied_screed(dir) do
-    """
-    The directory "#{dir}" is not writeable by the Docker container.
-
-    Please ensure that the directory exists and is writeable by the Docker
-    container. All setups are different, but you may be able to run something
-    like this on the *host*:
-
-      chown nobody -R <host path that maps to #{dir}>
-      chmod 755 -R <host path that maps to #{dir}>
-
-    Swapping in your real host path. Then, you should set the user running
-    this container by editing your `docker run` command like so:
-
-        docker run --user 99:100 <rest of the command>
-
-    Or adding `user: '99:100'` to the Pinchflat service of your Docker Compose
-    file. Again, there are many ways to do this depending on your setup and
-    this is just one example. See issue #106 in the Pinchflat Github for more.
-
-    No matter the case, this _is_ a permissions error and allowing the container
-    to write to the directory is the only way to fix it. It is not recommended
-    to run the container as `root` because files created by Pinchflat may not
-    be accessible to other apps that want to modify them.
-    """
-  end
 end

lib/pinchflat/settings/setting.ex

@@ -1,32 +1,24 @@
 defmodule Pinchflat.Settings.Setting do
   @moduledoc """
-  The Setting schema.
+  A Setting is a key-value pair with a datatype used to track user-level settings.
   """
 
   use Ecto.Schema
   import Ecto.Changeset
 
-  @allowed_fields [
-    :onboarding,
-    :pro_enabled,
-    :yt_dlp_version
-  ]
-
-  @required_fields ~w(
-    onboarding
-    pro_enabled
-  )a
-
   schema "settings" do
-    field :onboarding, :boolean, default: true
-    field :pro_enabled, :boolean, default: false
-    field :yt_dlp_version, :string
+    field :name, :string
+    field :value, :string
+    field :datatype, Ecto.Enum, values: ~w(boolean string integer float)a
+
+    timestamps(type: :utc_datetime)
   end
 
   @doc false
   def changeset(setting, attrs) do
     setting
-    |> cast(attrs, @allowed_fields)
-    |> validate_required(@required_fields)
+    |> cast(attrs, [:name, :value, :datatype])
+    |> validate_required([:name, :value, :datatype])
+    |> unique_constraint([:name])
   end
 end

lib/pinchflat/settings/settings.ex

@@ -2,63 +2,94 @@ defmodule Pinchflat.Settings do
   @moduledoc """
   The Settings context.
   """
-  import Ecto.Query, warn: false
 
+  import Ecto.Query, warn: false
   alias Pinchflat.Repo
+
   alias Pinchflat.Settings.Setting
 
   @doc """
-  Returns the only setting record. It _should_ be impossible
-  to create or delete this record, so it's assertive about
-  assuming it's the only one.
+  Returns the list of settings.
 
-  Returns %Setting{}
+  Returns [%Setting{}, ...]
   """
-  def record do
-    Setting
-    |> limit(1)
-    |> Repo.one()
+  def list_settings do
+    Repo.all(Setting)
   end
 
   @doc """
-  Updates a setting, returning the new value.
-  Is setup to take a keyword list argument so you
-  can call it like `Settings.set(onboarding: true)`
+  Creates or updates a setting, returning the parsed value.
+  Raises if an unsupported datatype is used. Optionally allows
+  specifying the datatype.
 
-  Returns {:ok, value} | {:error, :invalid_key} | {:error, %Ecto.Changeset{}}
+  Returns value in type of `Ecto.Enum.mappings(Setting, :datatype)`
   """
-  def set([{attr, value}]) do
-    record()
-    |> Setting.changeset(%{attr => value})
-    |> Repo.update()
-    |> case do
-      {:ok, %{^attr => _}} -> {:ok, value}
-      {:ok, _} -> {:error, :invalid_key}
-      {:error, changeset} -> {:error, changeset}
+  def set!(name, value) do
+    set!(name, value, infer_datatype(value))
+  end
+
+  def set!(name, value, datatype) do
+    # Only create if doesn't exist
+    case Repo.get_by(Setting, name: to_string(name)) do
+      nil -> create_setting!(name, value, datatype)
+      setting -> update_setting!(setting, value, datatype)
     end
   end
 
   @doc """
-  Gets the value of a setting.
+  Gets the parsed value of a setting. Raises if the setting does not exist.
 
-  Returns {:ok, value} | {:error, :invalid_key}
-  """
-  def get(name) do
-    case Map.fetch(record(), name) do
-      {:ok, value} -> {:ok, value}
-      :error -> {:error, :invalid_key}
-    end
-  end
-
-  @doc """
-  Gets the value of a setting, raising if it doesn't exist.
-
-  Returns value
+  Returns value in type of `Ecto.Enum.mappings(Setting, :datatype)`
   """
   def get!(name) do
-    case get(name) do
-      {:ok, value} -> value
-      {:error, _} -> raise "Setting `#{name}` not found"
+    Setting
+    |> Repo.get_by!(name: to_string(name))
+    |> read_setting()
+  end
+
+  @doc """
+  Attempts to find a setting by name or creates a setting with value
+  if one doesn't exist, returning the parsed value. Optionally allows
+  specifying the datatype.
+
+  Returns value in type of `Ecto.Enum.mappings(Setting, :datatype)`
+  """
+  def fetch!(name, value) do
+    fetch!(name, value, infer_datatype(value))
+  end
+
+  def fetch!(name, value, datatype) do
+    case Repo.get_by(Setting, name: to_string(name)) do
+      nil -> create_setting!(name, value, datatype)
+      setting -> read_setting(setting)
     end
   end
+
+  defp change_setting(setting, attrs) do
+    Setting.changeset(setting, attrs)
+  end
+
+  defp create_setting!(name, value, datatype) do
+    %Setting{}
+    |> change_setting(%{name: to_string(name), value: to_string(value), datatype: datatype})
+    |> Repo.insert!()
+    |> read_setting()
+  end
+
+  defp update_setting!(setting, value, datatype) do
+    setting
+    |> change_setting(%{value: to_string(value), datatype: datatype})
+    |> Repo.update!()
+    |> read_setting()
+  end
+
+  defp read_setting(%{value: value, datatype: :string}), do: value
+  defp read_setting(%{value: value, datatype: :boolean}), do: value in ["true", "t", "1"]
+  defp read_setting(%{value: value, datatype: :integer}), do: String.to_integer(value)
+  defp read_setting(%{value: value, datatype: :float}), do: String.to_float(value)
+
+  defp infer_datatype(value) when is_boolean(value), do: :boolean
+  defp infer_datatype(value) when is_integer(value), do: :integer
+  defp infer_datatype(value) when is_float(value), do: :float
+  defp infer_datatype(value) when is_binary(value), do: :string
 end

lib/pinchflat/slow_indexing/file_follower_server.ex

@@ -9,7 +9,7 @@ defmodule Pinchflat.SlowIndexing.FileFollowerServer do
   require Logger
 
   @poll_interval_ms Application.compile_env(:pinchflat, :file_watcher_poll_interval)
-  @activity_timeout_ms 600_000
+  @activity_timeout_ms 60_000
 
   # Client API
   @doc """

lib/pinchflat/slow_indexing/media_collection_indexing_worker.ex

@@ -6,8 +6,6 @@ defmodule Pinchflat.SlowIndexing.MediaCollectionIndexingWorker do
     unique: [period: :infinity, states: [:available, :scheduled, :retryable]],
     tags: ["media_source", "media_collection_indexing"]
 
-  require Logger
-
   alias __MODULE__
   alias Pinchflat.Tasks
   alias Pinchflat.Sources
@@ -15,24 +13,13 @@ defmodule Pinchflat.SlowIndexing.MediaCollectionIndexingWorker do
   alias Pinchflat.FastIndexing.FastIndexingWorker
   alias Pinchflat.SlowIndexing.SlowIndexingHelpers
 
-  @doc """
-  Starts the source slow indexing worker and creates a task for the source.
-
-  Returns {:ok, %Task{}} | {:error, :duplicate_job} | {:error, %Ecto.Changeset{}}
-  """
-  def kickoff_with_task(source, job_args \\ %{}, job_opts \\ []) do
-    %{id: source.id}
-    |> Map.merge(job_args)
-    |> MediaCollectionIndexingWorker.new(job_opts)
-    |> Tasks.create_job_with_task(source)
-  end
-
+  @impl Oban.Worker
   @doc """
   The ID is that of a source _record_, not a YouTube channel/playlist ID. Indexes
   the provided source, kicks off downloads for each new MediaItem, and
   reschedules the job to run again in the future. It will ALWAYS index a source
-  if it's never been indexed before or if `force` is set to `true`, but rescheduling
-  is determined by the `index_frequency_minutes` field.
+  if it's never been indexed before, but rescheduling is determined by the
+  `index_frequency_minutes` field.
 
   README: Re-scheduling here works a little different than you may expect.
   The reschedule time is relative to the time the job has actually _completed_.
@@ -71,8 +58,7 @@ defmodule Pinchflat.SlowIndexing.MediaCollectionIndexingWorker do
 
   Returns :ok | {:ok, %Task{}}
   """
-  @impl Oban.Worker
-  def perform(%Oban.Job{args: %{"id" => source_id} = args}) do
+  def perform(%Oban.Job{args: %{"id" => source_id}}) do
     source = Sources.get_source!(source_id)
 
     case {source.index_frequency_minutes, source.last_indexed_at} do
@@ -90,16 +76,9 @@ defmodule Pinchflat.SlowIndexing.MediaCollectionIndexingWorker do
 
       _ ->
         # If the source HAS been indexed and is not meant to reschedule,
-        # perform a no-op (unless forced)
-        if args["force"] do
-          SlowIndexingHelpers.index_and_enqueue_download_for_media_items(source)
-        end
-
+        # perform a no-op
         :ok
     end
-  rescue
-    Ecto.NoResultsError -> Logger.info("#{__MODULE__} discarded: source #{source_id} not found")
-    Ecto.StaleEntryError -> Logger.info("#{__MODULE__} discarded: source #{source_id} stale")
   end
 
   defp reschedule_indexing(source) do

lib/pinchflat/slow_indexing/slow_indexing_helpers.ex

@@ -7,7 +7,6 @@ defmodule Pinchflat.SlowIndexing.SlowIndexingHelpers do
 
   require Logger
 
-  alias Pinchflat.Repo
   alias Pinchflat.Media
   alias Pinchflat.Tasks
   alias Pinchflat.Sources
@@ -27,12 +26,15 @@ defmodule Pinchflat.SlowIndexing.SlowIndexingHelpers do
 
   Returns {:ok, %Task{}}.
   """
-  def kickoff_indexing_task(%Source{} = source, job_args \\ %{}, job_opts \\ []) do
+  def kickoff_indexing_task(%Source{} = source) do
     Tasks.delete_pending_tasks_for(source, "FastIndexingWorker")
     Tasks.delete_pending_tasks_for(source, "MediaIndexingWorker")
     Tasks.delete_pending_tasks_for(source, "MediaCollectionIndexingWorker")
 
-    MediaCollectionIndexingWorker.kickoff_with_task(source, job_args, job_opts)
+    %{id: source.id}
+    # Schedule this one immediately, but future ones will be on an interval
+    |> MediaCollectionIndexingWorker.new()
+    |> Tasks.create_job_with_task(source)
   end
 
   @doc """
@@ -61,9 +63,6 @@ defmodule Pinchflat.SlowIndexing.SlowIndexingHelpers do
     # See the method definition below for more info on how file watchers work
     # (important reading if you're not familiar with it)
     {:ok, media_attributes} = get_media_attributes_for_collection_and_setup_file_watcher(source)
-    # Reload because the source may have been updated during the (long-running) indexing process
-    # and important settings like `download_media` may have changed.
-    source = Repo.reload!(source)
 
     result =
       Enum.map(media_attributes, fn media_attrs ->
@@ -121,16 +120,14 @@ defmodule Pinchflat.SlowIndexing.SlowIndexingHelpers do
   end
 
   defp create_media_item_and_enqueue_download(source, media_attrs) do
-    # Reload because the source may have been updated during the (long-running) indexing process
-    # and important settings like `download_media` may have changed.
-    source = Repo.reload!(source)
-
     case Media.create_media_item_from_backend_attrs(source, media_attrs) do
       {:ok, %MediaItem{} = media_item} ->
         if source.download_media && Media.pending_download?(media_item) do
           Logger.debug("FileFollowerServer Handler: Enqueuing download task for #{inspect(media_attrs)}")
 
-          MediaDownloadWorker.kickoff_with_task(media_item)
+          %{id: media_item.id}
+          |> MediaDownloadWorker.new()
+          |> Tasks.create_job_with_task(media_item)
         end
 
       {:error, changeset} ->

lib/pinchflat/sources/source.ex

@@ -10,35 +10,25 @@ defmodule Pinchflat.Sources.Source do
   alias Pinchflat.Tasks.Task
   alias Pinchflat.Media.MediaItem
   alias Pinchflat.Profiles.MediaProfile
-  alias Pinchflat.Metadata.SourceMetadata
 
   @allowed_fields ~w(
     collection_name
     collection_id
     collection_type
     custom_name
-    description
-    nfo_filepath
-    poster_filepath
-    fanart_filepath
-    banner_filepath
-    series_directory
     index_frequency_minutes
     fast_index
     download_media
     last_indexed_at
     original_url
     download_cutoff_date
-    retention_period_days
-    title_filter_regex
     media_profile_id
   )a
 
   # Expensive API calls are made when a source is inserted/updated so
   # we want to ensure that the source is valid before making the call.
   # This way, we check that the other attributes are valid before ensuring
-  # that all fields are valid. This is still only one DB insert but it's
-  # a two-stage validation process to fail fast before the API call.
+  # that all fields are valid.
   @initially_required_fields ~w(
     index_frequency_minutes
     fast_index
@@ -49,7 +39,6 @@ defmodule Pinchflat.Sources.Source do
 
   @pre_insert_required_fields @initially_required_fields ++
                                 ~w(
-                                  uuid
                                   custom_name
                                   collection_name
                                   collection_id
@@ -57,13 +46,7 @@ defmodule Pinchflat.Sources.Source do
                                 )a
 
   schema "sources" do
-    # This is _not_ used as the primary key or internally in the database
-    # relations. This is only used to prevent an enumeration attack on the streaming
-    # and RSS feed endpoints since those _must_ be public (ie: no basic auth)
-    field :uuid, Ecto.UUID
-
     field :custom_name, :string
-    field :description, :string
     field :collection_name, :string
     field :collection_id, :string
     field :collection_type, Ecto.Enum, values: [:channel, :playlist]
@@ -73,20 +56,10 @@ defmodule Pinchflat.Sources.Source do
     field :last_indexed_at, :utc_datetime
     # Only download media items that were published after this date
     field :download_cutoff_date, :date
-    field :retention_period_days, :integer
     field :original_url, :string
-    field :title_filter_regex, :string
-
-    field :series_directory, :string
-    field :nfo_filepath, :string
-    field :poster_filepath, :string
-    field :fanart_filepath, :string
-    field :banner_filepath, :string
 
     belongs_to :media_profile, MediaProfile
 
-    has_one :metadata, SourceMetadata, on_replace: :update
-
     has_many :tasks, Task
     has_many :media_items, MediaItem, foreign_key: :source_id
 
@@ -106,11 +79,8 @@ defmodule Pinchflat.Sources.Source do
     source
     |> cast(attrs, @allowed_fields)
     |> dynamic_default(:custom_name, fn cs -> get_field(cs, :collection_name) end)
-    |> dynamic_default(:uuid, fn _ -> Ecto.UUID.generate() end)
     |> validate_required(required_fields)
-    |> validate_number(:retention_period_days, greater_than_or_equal_to: 0)
-    |> cast_assoc(:metadata, with: &SourceMetadata.changeset/2, required: false)
-    |> unique_constraint([:collection_id, :media_profile_id, :title_filter_regex], error_key: :original_url)
+    |> unique_constraint([:collection_id, :media_profile_id])
   end
 
   @doc false
@@ -124,9 +94,4 @@ defmodule Pinchflat.Sources.Source do
     # minutes
     15
   end
-
-  @doc false
-  def filepath_attributes do
-    ~w(nfo_filepath fanart_filepath poster_filepath banner_filepath)a
-  end
 end

lib/pinchflat/sources/sources.ex

@@ -9,15 +9,11 @@ defmodule Pinchflat.Sources do
   alias Pinchflat.Media
   alias Pinchflat.Tasks
   alias Pinchflat.Sources.Source
-  alias Pinchflat.Media.MediaQuery
   alias Pinchflat.Profiles.MediaProfile
   alias Pinchflat.YtDlp.MediaCollection
-  alias Pinchflat.Metadata.SourceMetadata
-  alias Pinchflat.Filesystem.FilesystemHelpers
   alias Pinchflat.Downloading.DownloadingHelpers
-  alias Pinchflat.FastIndexing.FastIndexingWorker
+  alias Pinchflat.FastIndexing.FastIndexingHelpers
   alias Pinchflat.SlowIndexing.SlowIndexingHelpers
-  alias Pinchflat.Metadata.SourceMetadataStorageWorker
 
   @doc """
   Returns the list of sources. Returns [%Source{}, ...]
@@ -52,19 +48,15 @@ defmodule Pinchflat.Sources do
   though we know it's going to fail so it picks up any addl. database errors
   and fulfills our return contract.
 
-  You can pass options to control the behavior of the function:
-    - `run_post_commit_tasks` (default: true) - If false, the function will not
-      enqueue any tasks in `commit_and_handle_tasks`.
-
   Returns {:ok, %Source{}} | {:error, %Ecto.Changeset{}}
   """
-  def create_source(attrs, opts \\ []) do
+  def create_source(attrs) do
     case change_source(%Source{}, attrs, :initial) do
       %Ecto.Changeset{valid?: true} ->
         %Source{}
-        |> maybe_change_source_from_url(attrs)
+        |> change_source_from_url(attrs)
         |> maybe_change_indexing_frequency()
-        |> commit_and_handle_tasks(opts)
+        |> commit_and_handle_tasks()
 
       changeset ->
         Repo.insert(changeset)
@@ -84,19 +76,15 @@ defmodule Pinchflat.Sources do
   though we know it's going to fail so it picks up any addl. database errors
   and fulfills our return contract.
 
-  You can pass options to control the behavior of the function:
-    - `run_post_commit_tasks` (default: true) - If false, the function will not
-      enqueue any tasks in `commit_and_handle_tasks`.
-
   Returns {:ok, %Source{}} | {:error, %Ecto.Changeset{}}
   """
-  def update_source(%Source{} = source, attrs, opts \\ []) do
+  def update_source(%Source{} = source, attrs) do
     case change_source(source, attrs, :initial) do
       %Ecto.Changeset{valid?: true} ->
         source
-        |> maybe_change_source_from_url(attrs)
+        |> change_source_from_url(attrs)
         |> maybe_change_indexing_frequency()
-        |> commit_and_handle_tasks(opts)
+        |> commit_and_handle_tasks()
 
       changeset ->
         Repo.update(changeset)
@@ -111,20 +99,14 @@ defmodule Pinchflat.Sources do
   """
   def delete_source(%Source{} = source, opts \\ []) do
     delete_files = Keyword.get(opts, :delete_files, false)
-    Tasks.delete_tasks_for(source)
 
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> Repo.all()
+    source
+    |> Media.list_media_items_for()
     |> Enum.each(fn media_item ->
       Media.delete_media_item(media_item, delete_files: delete_files)
     end)
 
-    if delete_files do
-      delete_source_files(source)
-    end
-
-    delete_internal_metadata_files(source)
+    Tasks.delete_tasks_for(source)
     Repo.delete(source)
   end
 
@@ -135,9 +117,19 @@ defmodule Pinchflat.Sources do
     Source.changeset(source, attrs, validation_stage)
   end
 
-  # NOTE: When operating in the ideal path, this effectively adds an API call
-  # to the source creation/update process. Should be used only when needed.
-  defp maybe_change_source_from_url(%Source{} = source, attrs) do
+  @doc """
+  Returns an `%Ecto.Changeset{}` for tracking source changes and additionally
+  fetches source details from the original_url (if provided). If the source
+  details cannot be fetched, an error is added to the changeset.
+
+  Note that this fetches source details as long as the `original_url` is present.
+  This means that it'll go for it even if a changeset is otherwise invalid. This
+  is pretty easy to change, but for MVP I'm not concerned.
+
+  NOTE: When operating in the ideal path, this effectively adds an API call
+  to the source creation/update process. Should be used only when needed.
+  """
+  def change_source_from_url(%Source{} = source, attrs) do
     case change_source(source, attrs) do
       %Ecto.Changeset{changes: %{original_url: _}} = changeset ->
         add_source_details_to_changeset(source, changeset)
@@ -147,27 +139,10 @@ defmodule Pinchflat.Sources do
     end
   end
 
-  defp delete_source_files(source) do
-    mapped_struct = Map.from_struct(source)
-
-    Source.filepath_attributes()
-    |> Enum.map(fn field -> mapped_struct[field] end)
-    |> Enum.filter(&is_binary/1)
-    |> Enum.each(&FilesystemHelpers.delete_file_and_remove_empty_directories/1)
-  end
-
-  defp delete_internal_metadata_files(source) do
-    metadata = Repo.preload(source, :metadata).metadata || %SourceMetadata{}
-    mapped_struct = Map.from_struct(metadata)
-
-    SourceMetadata.filepath_attributes()
-    |> Enum.map(fn field -> mapped_struct[field] end)
-    |> Enum.filter(&is_binary/1)
-    |> Enum.each(&FilesystemHelpers.delete_file_and_remove_empty_directories/1)
-  end
-
   defp add_source_details_to_changeset(source, changeset) do
-    case MediaCollection.get_source_details(changeset.changes.original_url) do
+    %Ecto.Changeset{changes: changes} = changeset
+
+    case MediaCollection.get_source_details(changes.original_url) do
       {:ok, source_details} ->
         add_source_details_by_collection_type(source, changeset, source_details)
 
@@ -216,18 +191,11 @@ defmodule Pinchflat.Sources do
     end
   end
 
-  defp commit_and_handle_tasks(changeset, opts) do
-    run_post_commit_tasks = Keyword.get(opts, :run_post_commit_tasks, true)
-
+  defp commit_and_handle_tasks(changeset) do
     case Repo.insert_or_update(changeset) do
       {:ok, %Source{} = source} ->
-        if run_post_commit_tasks do
-          maybe_handle_media_tasks(changeset, source)
-          maybe_run_indexing_task(changeset, source)
-          run_metadata_storage_task(source)
-        end
-
-        {:ok, source}
+        maybe_handle_media_tasks(changeset, source)
+        maybe_run_indexing_task(changeset, source)
 
       err ->
         err
@@ -247,6 +215,8 @@ defmodule Pinchflat.Sources do
       _ ->
         :ok
     end
+
+    {:ok, source}
   end
 
   defp maybe_run_indexing_task(changeset, source) do
@@ -261,11 +231,8 @@ defmodule Pinchflat.Sources do
         maybe_update_slow_indexing_task(changeset, source)
         maybe_update_fast_indexing_task(changeset, source)
     end
-  end
 
-  # This runs every time to pick up any changes to the metadata
-  defp run_metadata_storage_task(source) do
-    SourceMetadataStorageWorker.kickoff_with_task(source)
+    {:ok, source}
   end
 
   defp maybe_update_slow_indexing_task(changeset, source) do
@@ -286,8 +253,7 @@ defmodule Pinchflat.Sources do
   defp maybe_update_fast_indexing_task(changeset, source) do
     case changeset.changes do
       %{fast_index: true} ->
-        Tasks.delete_pending_tasks_for(source, "FastIndexingWorker")
-        FastIndexingWorker.kickoff_with_task(source)
+        FastIndexingHelpers.kickoff_fast_indexing_task(source)
 
       %{fast_index: false} ->
         Tasks.delete_pending_tasks_for(source, "FastIndexingWorker")

lib/pinchflat/sources/sources_query.ex

@@ -1,31 +0,0 @@
-defmodule Pinchflat.Sources.SourcesQuery do
-  @moduledoc """
-  Query helpers for the Sources context.
-
-  These methods are made to be one-ish liners used
-  to compose queries. Each method should strive to do
-  _one_ thing. These don't need to be tested as
-  they are just building blocks for other functionality
-  which, itself, will be tested.
-  """
-  import Ecto.Query, warn: false
-
-  alias Pinchflat.Sources.Source
-
-  # Prefixes:
-  # - for_* - belonging to a certain record
-  # - join_* - for joining on a certain record
-  # - with_* - for filtering based on full, concrete attributes
-  # - matching_* - for filtering based on partial attributes (e.g. LIKE, regex, full-text search)
-  #
-  # Suffixes:
-  # - _for - the arg passed is an association record
-
-  def new do
-    Source
-  end
-
-  def for_media_profile(query, media_profile) do
-    where(query, [s], s.media_profile_id == ^media_profile.id)
-  end
-end

lib/pinchflat/tasks/tasks.ex

@@ -22,15 +22,9 @@ defmodule Pinchflat.Tasks do
 
   Returns [%Task{}, ...]
   """
-  def list_tasks_for(record, worker_name \\ nil, job_states \\ Oban.Job.states()) do
+  def list_tasks_for(attached_record_type, attached_record_id, worker_name \\ nil, job_states \\ Oban.Job.states()) do
     stringified_states = Enum.map(job_states, &to_string/1)
 
-    record_type =
-      case record do
-        %Source{} -> :source_id
-        %MediaItem{} -> :media_item_id
-      end
-
     worker_name_finder =
       if worker_name do
         # Workers are the full module name - we want to match on the string ENDING with
@@ -47,7 +41,7 @@ defmodule Pinchflat.Tasks do
     Repo.all(
       from t in Task,
         join: j in assoc(t, :job),
-        where: field(t, ^record_type) == ^record.id,
+        where: field(t, ^attached_record_type) == ^attached_record_id,
         where: ^worker_name_finder,
         where: j.state in ^stringified_states
     )
@@ -59,9 +53,10 @@ defmodule Pinchflat.Tasks do
 
   Returns [%Task{}, ...]
   """
-  def list_pending_tasks_for(record, worker_name \\ nil) do
+  def list_pending_tasks_for(attached_record_type, attached_record_id, worker_name \\ nil) do
     list_tasks_for(
-      record,
+      attached_record_type,
+      attached_record_id,
       worker_name,
       [:available, :scheduled, :retryable]
     )
@@ -131,10 +126,14 @@ defmodule Pinchflat.Tasks do
 
   Returns :ok
   """
-  def delete_tasks_for(record, worker_name \\ nil) do
-    record
-    |> list_tasks_for(worker_name)
-    |> Enum.each(&delete_task/1)
+  def delete_tasks_for(attached_record, worker_name \\ nil) do
+    tasks =
+      case attached_record do
+        %Source{} = source -> list_tasks_for(:source_id, source.id, worker_name)
+        %MediaItem{} = media_item -> list_tasks_for(:media_item_id, media_item.id, worker_name)
+      end
+
+    Enum.each(tasks, &delete_task/1)
   end
 
   @doc """
@@ -143,10 +142,14 @@ defmodule Pinchflat.Tasks do
 
   Returns :ok
   """
-  def delete_pending_tasks_for(record, worker_name \\ nil) do
-    record
-    |> list_pending_tasks_for(worker_name)
-    |> Enum.each(&delete_task/1)
+  def delete_pending_tasks_for(attached_record, worker_name \\ nil) do
+    tasks =
+      case attached_record do
+        %Source{} = source -> list_pending_tasks_for(:source_id, source.id, worker_name)
+        %MediaItem{} = media_item -> list_pending_tasks_for(:media_item_id, media_item.id, worker_name)
+      end
+
+    Enum.each(tasks, &delete_task/1)
   end
 
   @doc """

lib/pinchflat/utils/datetime_utils.ex

@@ -1,17 +0,0 @@
-defmodule Pinchflat.Utils.DatetimeUtils do
-  @moduledoc """
-  Utility methods for working with dates and datetimes
-  """
-
-  @doc """
-  Converts a Date to a DateTime
-
-  Returns %DateTime{}
-  """
-  def date_to_datetime(date) do
-    date
-    |> Date.to_gregorian_days()
-    |> Kernel.*(86_400)
-    |> DateTime.from_gregorian_seconds()
-  end
-end

lib/pinchflat/utils/xml_utils.ex

@@ -1,17 +0,0 @@
-defmodule Pinchflat.Utils.XmlUtils do
-  @moduledoc """
-  Utility methods for working with XML documents
-  """
-
-  @doc """
-  Escapes invalid XML characters in a string
-
-  Returns binary()
-  """
-  def safe(value) do
-    value
-    |> to_string()
-    |> Phoenix.HTML.html_escape()
-    |> Phoenix.HTML.safe_to_string()
-  end
-end

lib/pinchflat/yt_dlp/backend_command_runner.ex

@@ -8,5 +8,4 @@ defmodule Pinchflat.YtDlp.BackendCommandRunner do
 
   @callback run(binary(), keyword(), binary()) :: {:ok, binary()} | {:error, binary(), integer()}
   @callback run(binary(), keyword(), binary(), keyword()) :: {:ok, binary()} | {:error, binary(), integer()}
-  @callback version() :: {:ok, binary()} | {:error, binary()}
 end

lib/pinchflat/yt_dlp/command_runner.ex

@@ -29,17 +29,15 @@ defmodule Pinchflat.YtDlp.CommandRunner do
     command = backend_executable()
     # These must stay in exactly this order, hence why I'm giving it its own variable.
     # Also, can't use RAM file since yt-dlp needs a concrete filepath.
-    output_filepath = generate_output_filepath(addl_opts)
+    output_filepath = Keyword.get(addl_opts, :output_filepath, FSUtils.generate_metadata_tmpfile(:json))
     print_to_file_opts = [{:print_to_file, output_template}, output_filepath]
-    cookie_opts = build_cookie_options()
-    formatted_command_opts = [url] ++ parse_options(command_opts ++ print_to_file_opts ++ cookie_opts)
+    formatted_command_opts = [url] ++ parse_options(command_opts ++ print_to_file_opts)
 
     Logger.info("[yt-dlp] called with: #{Enum.join(formatted_command_opts, " ")}")
 
     case System.cmd(command, formatted_command_opts, stderr_to_stdout: true) do
       {_, 0} ->
-        # IDEA: consider deleting the file after reading it. It's in the tmp dir, so it's not
-        # a huge deal, but it's still a good idea to clean up after ourselves.
+        # IDEA: consider deleting the file after reading it
         # (even on error? especially on error?)
         File.read(output_filepath)
 
@@ -48,39 +46,6 @@ defmodule Pinchflat.YtDlp.CommandRunner do
     end
   end
 
-  @impl BackendCommandRunner
-  def version do
-    command = backend_executable()
-
-    case System.cmd(command, ["--version"]) do
-      {output, 0} ->
-        {:ok, String.trim(output)}
-
-      {output, _} ->
-        {:error, output}
-    end
-  end
-
-  defp generate_output_filepath(addl_opts) do
-    case Keyword.get(addl_opts, :output_filepath) do
-      nil -> FSUtils.generate_metadata_tmpfile(:json)
-      path -> path
-    end
-  end
-
-  defp build_cookie_options do
-    base_dir = Application.get_env(:pinchflat, :extras_directory)
-    cookie_file = Path.join(base_dir, "cookies.txt")
-
-    case File.read(cookie_file) do
-      {:ok, cookie_data} ->
-        if String.trim(cookie_data) != "", do: [cookies: cookie_file], else: []
-
-      {:error, _} ->
-        []
-    end
-  end
-
   # We want to satisfy the following behaviours:
   #
   # 1. If the key is an atom, convert it to a string and convert it to kebab case (for convenience)

lib/pinchflat/yt_dlp/media.ex

@@ -10,8 +10,7 @@ defmodule Pinchflat.YtDlp.Media do
     :original_url,
     :livestream,
     :short_form_content,
-    :upload_date,
-    :duration_seconds
+    :upload_date
   ]
 
   defstruct [
@@ -21,13 +20,11 @@ defmodule Pinchflat.YtDlp.Media do
     :original_url,
     :livestream,
     :short_form_content,
-    :upload_date,
-    :duration_seconds
+    :upload_date
   ]
 
   alias __MODULE__
   alias Pinchflat.Utils.FunctionUtils
-  alias Pinchflat.Metadata.MetadataFileHelpers
 
   @doc """
   Downloads a single piece of media (and possibly its metadata) directly to its
@@ -35,10 +32,10 @@ defmodule Pinchflat.YtDlp.Media do
 
   Returns {:ok, map()} | {:error, any, ...}.
   """
-  def download(url, command_opts \\ [], addl_opts \\ []) do
+  def download(url, command_opts \\ []) do
     opts = [:no_simulate] ++ command_opts
 
-    with {:ok, output} <- backend_runner().run(url, opts, "after_move:%()j", addl_opts),
+    with {:ok, output} <- backend_runner().run(url, opts, "after_move:%()j"),
          {:ok, parsed_json} <- Phoenix.json_library().decode(output) do
       {:ok, parsed_json}
     else
@@ -88,9 +85,8 @@ defmodule Pinchflat.YtDlp.Media do
       description: response["description"],
       original_url: response["webpage_url"],
       livestream: response["was_live"],
-      duration_seconds: response["duration"] && round(response["duration"]),
       short_form_content: response["webpage_url"] && short_form_content?(response),
-      upload_date: response["upload_date"] && MetadataFileHelpers.parse_upload_date(response["upload_date"])
+      upload_date: response["upload_date"] && parse_upload_date(response["upload_date"])
     }
   end
 
@@ -110,6 +106,12 @@ defmodule Pinchflat.YtDlp.Media do
     end
   end
 
+  defp parse_upload_date(upload_date) do
+    <<year::binary-size(4)>> <> <<month::binary-size(2)>> <> <<day::binary-size(2)>> = upload_date
+
+    Date.from_iso8601!("#{year}-#{month}-#{day}")
+  end
+
   defp backend_runner do
     # This approach lets us mock the command for testing
     Application.get_env(:pinchflat, :yt_dlp_runner)

lib/pinchflat/yt_dlp/media_collection.ex

@@ -6,6 +6,7 @@ defmodule Pinchflat.YtDlp.MediaCollection do
 
   require Logger
 
+  alias Pinchflat.Utils.FunctionUtils
   alias Pinchflat.Filesystem.FilesystemHelpers
   alias Pinchflat.YtDlp.Media, as: YtDlpMedia
 
@@ -35,20 +36,11 @@ defmodule Pinchflat.YtDlp.MediaCollection do
 
     case runner.run(url, command_opts, output_template, output_filepath: output_filepath) do
       {:ok, output} ->
-        parsed_lines =
-          output
-          |> String.split("\n", trim: true)
-          |> Enum.map(fn line ->
-            case Phoenix.json_library().decode(line) do
-              {:ok, parsed_json} ->
-                YtDlpMedia.response_to_struct(parsed_json)
-
-              _ ->
-                nil
-            end
-          end)
-
-        {:ok, Enum.filter(parsed_lines, &(&1 != nil))}
+        output
+        |> String.split("\n", trim: true)
+        |> Enum.map(&Phoenix.json_library().decode!/1)
+        |> Enum.map(&YtDlpMedia.response_to_struct/1)
+        |> FunctionUtils.wrap_ok()
 
       res ->
         res
@@ -58,20 +50,20 @@ defmodule Pinchflat.YtDlp.MediaCollection do
   @doc """
   Gets a source's ID and name from its URL.
 
-  yt-dlp does not _really_ have source-specific functions that return what
-  we need, so instead we're fetching just the first video (using playlist_end: 1)
+  yt-dlp does not _really_ have source-specific functions, so
+  instead we're fetching just the first video (using playlist_end: 1)
   and parsing the source ID and name from _its_ metadata
 
   Returns {:ok, map()} | {:error, any, ...}.
   """
-  def get_source_details(source_url, addl_opts \\ []) do
+  def get_source_details(source_url) do
     # `ignore_no_formats_error` is necessary because yt-dlp will error out if
     # the first video has not released yet (ie: is a premier). We don't care about
     # available formats since we're just getting the source details
-    command_opts = [:simulate, :skip_download, :ignore_no_formats_error, playlist_end: 1] ++ addl_opts
-    output_template = "%(.{channel,channel_id,playlist_id,playlist_title,filename})j"
+    opts = [:simulate, :skip_download, :ignore_no_formats_error, playlist_end: 1]
+    output_template = "%(.{channel,channel_id,playlist_id,playlist_title})j"
 
-    with {:ok, output} <- backend_runner().run(source_url, command_opts, output_template),
+    with {:ok, output} <- backend_runner().run(source_url, opts, output_template),
          {:ok, parsed_json} <- Phoenix.json_library().decode(output) do
       {:ok, format_source_details(parsed_json)}
     else
@@ -79,44 +71,12 @@ defmodule Pinchflat.YtDlp.MediaCollection do
     end
   end
 
-  @doc """
-  Gets a source's metadata from its URL.
-
-  This is mostly for things like getting the source's avatar and banner image
-  (if applicable). However, this yt-dlp call doesn't have enough overlap with
-  `get_source_details/1` to allow combining them - this one has _almost_ everything
-  we need, but it doesn't contain enough information to tell 100% if the url is a channel
-  or a playlist.
-
-  The main purpose of this (past using as a fetcher for _other_ metadata) is to live
-  as a compressed blob for possible future use. That's why it's not getting formatted like
-  `get_source_details/1`
-
-  Returns {:ok, map()} | {:error, any, ...}.
-  """
-  def get_source_metadata(source_url, addl_opts \\ []) do
-    opts = [playlist_items: 0] ++ addl_opts
-    output_template = "playlist:%()j"
-
-    with {:ok, output} <- backend_runner().run(source_url, opts, output_template),
-         {:ok, parsed_json} <- Phoenix.json_library().decode(output) do
-      {:ok, parsed_json}
-    else
-      err -> err
-    end
-  end
-
   defp format_source_details(response) do
-    # NOTE: I should probably make this a struct some day
     %{
       channel_id: response["channel_id"],
       channel_name: response["channel"],
       playlist_id: response["playlist_id"],
-      playlist_name: response["playlist_title"],
-      # It's not a name, it's a path dammit!
-      # This actually isn't used for the inital response - it's
-      # used later to update a source's metadata
-      filepath: response["filename"]
+      playlist_name: response["playlist_title"]
     }
   end
 

lib/pinchflat_web.ex

@@ -21,7 +21,7 @@ defmodule PinchflatWeb do
 
   def router do
     quote do
-      use Phoenix.Router, helpers: true
+      use Phoenix.Router, helpers: false
 
       # Import common connection and controller functions to use in pipelines
       import Plug.Conn

lib/pinchflat_web/components/core_components.ex

@@ -14,7 +14,7 @@ defmodule PinchflatWeb.CoreComponents do
 
   Icons are provided by [heroicons](https://heroicons.com). See `icon/1` for usage.
   """
-  use Phoenix.Component, global_prefixes: ~w(x-)
+  use Phoenix.Component
 
   import PinchflatWeb.Gettext
 
@@ -251,7 +251,7 @@ defmodule PinchflatWeb.CoreComponents do
   attr :type, :string,
     default: "text",
     values: ~w(checkbox color date datetime-local email file hidden month number password
-            checkbox_group toggle range radio search select tel text textarea time url week)
+               toggle range radio search select tel text textarea time url week)
 
   attr :field, Phoenix.HTML.FormField, doc: "a form field struct retrieved from the form, for example: @form[:email]"
 
@@ -304,33 +304,6 @@ defmodule PinchflatWeb.CoreComponents do
     """
   end
 
-  def input(%{type: "checkbox_group"} = assigns) do
-    ~H"""
-    <div phx-feedback-for={@name}>
-      <.label for={@id}>
-        <%= @label %><span :if={@label_suffix} class="text-xs text-bodydark"><%= @label_suffix %></span>
-      </.label>
-      <section class="grid grid-cols-1 gap-2 md:grid-cols-2 max-w-prose mb-4 ml-1">
-        <div :for={{option_name, option_value} <- @options} class="flex items-center">
-          <input
-            type="checkbox"
-            id={"#{@id}-#{option_value}"}
-            name={"#{@name}[]"}
-            value={option_value}
-            checked={option_value in @value}
-            class={["rounded focus:ring-offset-0 ring-offset-0 focus:ring-0 h-5 w-5 ", @inputclass]}
-          />
-          <label for={"#{@id}-#{option_value}"} class="ml-2 cursor-pointer select-none">
-            <%= option_name %>
-          </label>
-        </div>
-      </section>
-      <.help :if={@help}><%= @help %></.help>
-      <.error :for={msg <- @errors}><%= msg %></.error>
-    </div>
-    """
-  end
-
   def input(%{type: "toggle"} = assigns) do
     assigns =
       assign_new(assigns, :checked, fn ->
@@ -344,7 +317,17 @@ defmodule PinchflatWeb.CoreComponents do
         <span :if={@label_suffix} class="text-xs text-bodydark"><%= @label_suffix %></span>
       </.label>
       <div class="relative">
-        <input type="hidden" id={@id} name={@name} x-bind:value="enabled" {@rest} />
+        <input type="hidden" name={@name} value="false" />
+        <input
+          type="checkbox"
+          id={@id}
+          name={@name}
+          value="true"
+          x-bind:checked="enabled"
+          class="sr-only"
+          @change="enabled = !enabled"
+          {@rest}
+        />
         <div class="inline-block cursor-pointer" @click="enabled = !enabled">
           <div x-bind:class="enabled && '!bg-primary'" class="block h-8 w-14 rounded-full bg-black"></div>
           <div
@@ -366,27 +349,23 @@ defmodule PinchflatWeb.CoreComponents do
   def input(%{type: "select"} = assigns) do
     ~H"""
     <div phx-feedback-for={@name}>
-      <.label :if={@label} for={@id}>
+      <.label for={@id}>
         <%= @label %><span :if={@label_suffix} class="text-xs text-bodydark"><%= @label_suffix %></span>
       </.label>
-      <div class="flex">
-        <select
-          id={@id}
-          name={@name}
-          class={[
-            "relative z-20 w-full appearance-none rounded border border-form-strokedark py-3 pl-5 pr-12 outline-none transition",
-            "focus:border-primary active:border-primary bg-form-input text-black text-white",
-            "disabled:text-opacity-50 disabled:cursor-not-allowed disabled:border-black",
-            @inputclass
-          ]}
-          multiple={@multiple}
-          {@rest}
-        >
-          <option :if={@prompt} value=""><%= @prompt %></option>
-          <%= Phoenix.HTML.Form.options_for_select(@options, @value) %>
-        </select>
-        <%= render_slot(@inner_block) %>
-      </div>
+      <select
+        id={@id}
+        name={@name}
+        class={[
+          "relative z-20 w-full appearance-none rounded border border-stroke bg-transparent py-3 pl-5 pr-12 outline-none transition",
+          "focus:border-primary active:border-primary dark:border-form-strokedark dark:bg-form-input text-black dark:text-white",
+          @inputclass
+        ]}
+        multiple={@multiple}
+        {@rest}
+      >
+        <option :if={@prompt} value=""><%= @prompt %></option>
+        <%= Phoenix.HTML.Form.options_for_select(@options, @value) %>
+      </select>
       <.help :if={@help}><%= @help %></.help>
       <.error :for={msg <- @errors}><%= msg %></.error>
     </div>
@@ -628,10 +607,6 @@ defmodule PinchflatWeb.CoreComponents do
         _ ->
           true
       end)
-      |> Enum.map(fn
-        {k, v} when is_list(v) -> {k, Enum.join(v, ", ")}
-        rest -> rest
-      end)
 
     assigns = assign(assigns, iterable_attributes: attrs)
 
@@ -686,11 +661,10 @@ defmodule PinchflatWeb.CoreComponents do
   """
   attr :name, :string, required: true
   attr :class, :string, default: nil
-  attr :rest, :global
 
   def icon(%{name: "hero-" <> _} = assigns) do
     ~H"""
-    <span class={[@name, @class]} {@rest} />
+    <span class={[@name, @class]} />
     """
   end
 

lib/pinchflat_web/components/custom_components/button_components.ex

@@ -1,8 +1,6 @@
 defmodule PinchflatWeb.CustomComponents.ButtonComponents do
   @moduledoc false
-  use Phoenix.Component, global_prefixes: ~w(x-)
-
-  alias PinchflatWeb.CoreComponents
+  use Phoenix.Component
 
   @doc """
   Render a button
@@ -30,10 +28,9 @@ defmodule PinchflatWeb.CustomComponents.ButtonComponents do
         "#{@rounding} inline-flex items-center justify-center px-8 py-4",
         "#{@color}",
         "hover:bg-opacity-90 lg:px-8 xl:px-10",
-        "disabled:bg-opacity-50 disabled:cursor-not-allowed disabled:text-grey-5",
+        "disabled:bg-opacity-50 disabled:cursor-not-allowed disabled:text-gray-2",
         @class
       ]}
-      type={@type}
       disabled={@disabled}
       {@rest}
     >
@@ -41,52 +38,4 @@ defmodule PinchflatWeb.CustomComponents.ButtonComponents do
     </button>
     """
   end
-
-  @doc """
-  Render a dropdown based off a button
-
-  ## Examples
-
-      <.button_dropdown text="Actions">
-        <:option>TEST</:option>
-      </.button_dropdown>
-  """
-  attr :text, :string, required: true
-  attr :class, :string, default: ""
-
-  slot :option, required: true
-
-  def button_dropdown(assigns) do
-    ~H"""
-    <div x-data="{ dropdownOpen: false }" class={["relative flex", @class]}>
-      <span
-        x-on:click.prevent="dropdownOpen = !dropdownOpen"
-        class={[
-          "cursor-pointer inline-flex gap-2.5 rounded-md bg-primary px-5.5 py-3",
-          "font-medium text-white hover:bg-opacity-95"
-        ]}
-      >
-        <%= @text %>
-        <CoreComponents.icon
-          name="hero-chevron-down"
-          class="fill-current duration-200 ease-linear mt-1"
-          x-bind:class="dropdownOpen && 'rotate-180'"
-        />
-      </span>
-      <div
-        x-show="dropdownOpen"
-        x-on:click.outside="dropdownOpen = false"
-        class="absolute left-0 top-full z-40 mt-2 w-full rounded-md bg-black py-3 shadow-card"
-      >
-        <ul class="flex flex-col">
-          <li :for={option <- @option}>
-            <span class="flex px-5 py-2 font-medium text-bodydark2 hover:text-white cursor-pointer">
-              <%= render_slot(option) %>
-            </span>
-          </li>
-        </ul>
-      </div>
-    </div>
-    """
-  end
 end

lib/pinchflat_web/components/custom_components/tab_components.ex

@@ -9,32 +9,24 @@ defmodule PinchflatWeb.CustomComponents.TabComponents do
     attr :title, :string, required: true
   end
 
-  slot :tab_append, required: false
-
   def tabbed_layout(assigns) do
     ~H"""
     <div
-      x-data="{ openTab: getTabIndex(0), activeClasses: 'text-meta-5 border-meta-5', inactiveClasses: 'border-transparent' }"
-      @hashchange.window="openTab = getTabIndex(openTab)"
+      x-data="{ openTab: 0, activeClasses: 'text-meta-5 border-meta-5', inactiveClasses: 'border-transparent' }"
       class="w-full"
     >
-      <header class="flex flex-col md:flex-row md:justify-between border-b border-strokedark">
-        <div class="flex flex-wrap gap-5 sm:gap-10">
-          <a
-            :for={{tab, idx} <- Enum.with_index(@tab)}
-            href="#"
-            @click.prevent={"openTab = setTabIndex(#{idx})"}
-            x-bind:class={"openTab === #{idx} ? activeClasses : inactiveClasses"}
-            class="border-b-2 py-4 w-full sm:w-fit text-sm font-medium hover:text-meta-5 md:text-base"
-          >
-            <span class="text-xl"><%= tab.title %></span>
-          </a>
-        </div>
-        <div class="mx-4 my-4 lg:my-0 flex gap-5 sm:gap-10 items-center">
-          <%= render_slot(@tab_append) %>
-        </div>
-      </header>
-      <div class="mt-4 min-h-60">
+      <div class="mb-6 flex flex-wrap gap-5 border-b border-strokedark sm:gap-10">
+        <a
+          :for={{tab, idx} <- Enum.with_index(@tab)}
+          href="#"
+          @click.prevent={"openTab = #{idx}"}
+          x-bind:class={"openTab === #{idx} ? activeClasses : inactiveClasses"}
+          class="border-b-2 py-4 text-sm font-medium hover:text-meta-5 md:text-base"
+        >
+          <span class="text-xl"><%= tab.title %></span>
+        </a>
+      </div>
+      <div>
         <div :for={{tab, idx} <- Enum.with_index(@tab)} x-show={"openTab === #{idx}"} class="font-medium leading-relaxed">
           <%= render_slot(tab) %>
         </div>

lib/pinchflat_web/components/custom_components/text_components.ex

@@ -31,20 +31,6 @@ defmodule PinchflatWeb.CustomComponents.TextComponents do
     """
   end
 
-  @doc """
-  Renders a subtle link with the given href and content.
-  """
-  attr :href, :string, required: true
-  slot :inner_block
-
-  def subtle_link(assigns) do
-    ~H"""
-    <.link href={@href} class="underline decoration-bodydark decoration-1 hover:decoration-white">
-      <%= render_slot(@inner_block) %>
-    </.link>
-    """
-  end
-
   @doc """
   Renders an icon as a link with the given href.
   """

lib/pinchflat_web/components/layouts/onboarding.html.heex

@@ -1,9 +1,10 @@
 <div class="flex h-screen overflow-hidden">
   <div class="relative flex flex-1 flex-col overflow-y-auto overflow-x-hidden">
     <header class="sticky top-0 z-999 flex w-full bg-white drop-shadow-1 dark:bg-boxdark dark:drop-shadow-none">
-      <div class="w-65 px-4 py-2 shadow-2 md:px-6">
-        <div class="flex items-center gap-2 py-2">
-          <img src={~p"/images/logo.png?cachebust=2024-03-20"} alt="Pinchflat" class="w-auto" />
+      <div class="flex flex-grow items-center px-4 py-4 shadow-2 md:px-6 2xl:px-11">
+        <div class="flex items-center">
+          <img src={~p"/images/logo.png?cachebust=2024-02-29"} alt="Pinchflat" class="w-9 h-9" />
+          <h2 class="text-xl font-bold text-white pl-2">Pinchflat</h2>
         </div>
       </div>
     </header>

lib/pinchflat_web/components/layouts/partials/header.html.heex

@@ -1,18 +1,18 @@
-<header class="sticky top-0 z-999 flex h-20 w-full bg-white drop-shadow-1 dark:bg-boxdark dark:drop-shadow-none">
+<header class="sticky top-0 z-999 flex w-full bg-white drop-shadow-1 dark:bg-boxdark dark:drop-shadow-none">
   <div class="flex flex-grow items-center justify-between lg:justify-end px-4 py-4 shadow-2 md:px-6 2xl:px-11">
-    <div class="flex items-center gap-2 sm:gap-4 lg:hidden w-2/6">
-      <section class="pr-1">
-        <img src={~p"/images/icon.png?cachebust=2024-03-20"} alt="Pinchflat" class="w-10" />
-      </section>
-
+    <div class="flex items-center gap-2 sm:gap-4 lg:hidden">
       <button
-        class="z-99999 block mx-2 rounded-sm border border-stroke bg-white p-1.5 shadow-sm dark:border-strokedark dark:bg-boxdark lg:hidden"
+        class="z-99999 block rounded-sm border border-stroke bg-white p-1.5 shadow-sm dark:border-strokedark dark:bg-boxdark lg:hidden"
         @click.stop="sidebarVisible = !sidebarVisible"
       >
         <.icon name="hero-bars-3" />
       </button>
+      <a class="hidden sm:flex items-center lg:hidden" href="/">
+        <img src={~p"/images/logo.png?cachebust=2024-02-29"} alt="Pinchflat" class="w-9 h-9" />
+        <h2 class="text-xl font-bold text-white pl-2">Pinchflat</h2>
+      </a>
     </div>
-    <div class="bg-meta-4 rounded-md w-4/6 lg:w-3/6 xl:w-2/6">
+    <div class="bg-meta-4 rounded-md">
       <div class="relative">
         <span class="absolute left-2 top-1/2 -translate-y-1/2 flex">
           <.icon name="hero-magnifying-glass" />
@@ -23,7 +23,7 @@
             name="q"
             value={@params["q"]}
             placeholder="Type to search..."
-            class="w-full bg-transparent pl-9 pr-4 border-0 focus:ring-0 focus:outline-none"
+            class="w-full bg-transparent pl-9 pr-4 border-0 focus:ring-0 focus:outline-none lg:w-125"
           />
         </form>
       </div>

lib/pinchflat_web/components/layouts/partials/sidebar.html.heex

@@ -1,23 +1,24 @@
 <aside
   x-bind:class="sidebarVisible ? 'translate-x-0' : '-translate-x-full'"
   class={[
-    "-translate-x-full absolute left-0 top-0 z-9999 flex h-screen w-65 flex-col overflow-y-hidden justify-between",
+    "-translate-x-full absolute left-0 top-0 z-9999 flex h-screen w-60 flex-col overflow-y-hidden justify-between",
     "bg-black duration-300 ease-linear shadow-lg sm:shadow-none dark:bg-boxdark lg:static lg:translate-x-0"
   ]}
   @click.outside="sidebarVisible = false"
 >
   <section>
-    <div class="flex items-center justify-between gap-2 px-6 py-4">
+    <div class="flex items-center justify-between gap-2 px-6 py-5.5 lg:py-6.5">
       <a href="/" class="flex items-center">
-        <img src={~p"/images/logo.png?cachebust=2024-03-20"} alt="Pinchflat" class="w-auto" />
+        <img src={~p"/images/logo.png?cachebust=2024-02-29"} alt="Pinchflat" class="w-9 h-9" />
+        <h2 class="text-xl font-bold text-white pl-2">Pinchflat</h2>
       </a>
 
-      <button class="block mt-3 lg:hidden" @click.stop="sidebarVisible = !sidebarVisible">
+      <button class="block lg:hidden" @click.stop="sidebarVisible = !sidebarVisible">
         <.icon name="hero-arrow-left" class="fill-current" />
       </button>
     </div>
     <div class="no-scrollbar flex flex-col overflow-y-auto duration-300 ease-linear">
-      <nav class="mt-3 px-4 py-4 lg:px-6">
+      <nav class="mt-5 px-4 py-4 lg:mt-9 lg:px-6">
         <h3 class="mb-4 ml-4 text-sm font-medium text-bodydark2">MENU</h3>
         <div class="flex flex-col justify-between">
           <ul class="mb-6 flex flex-col gap-1.5">
@@ -30,14 +31,8 @@
     </div>
   </section>
   <section>
-    <nav class="px-4 py-4 lg:px-6">
+    <nav class="mt-5 px-4 py-4 lg:mt-9 lg:px-6">
       <ul class="mb-6 flex flex-col gap-1.5">
-        <.sidebar_item
-          icon="hero-book-open"
-          text="Docs"
-          target="_blank"
-          href="https://github.com/kieraneglin/pinchflat/wiki"
-        />
         <.sidebar_item
           icon="hero-code-bracket"
           text="Github"
@@ -57,14 +52,6 @@
             <.icon name="hero-currency-dollar" /> Donate
           </span>
         </li>
-        <li>
-          <span class="group relative flex items-center gap-2.5 px-4 pt-2 text-sm">
-            Pinchflat v<%= Application.spec(:pinchflat)[:vsn] %>
-          </span>
-          <span class="group relative flex items-center gap-2.5 px-4 text-sm">
-            yt-dlp <%= Settings.get!(:yt_dlp_version) %>
-          </span>
-        </li>
       </ul>
     </nav>
   </section>

lib/pinchflat_web/components/layouts/partials/upgrade_button_live.ex

@@ -30,7 +30,7 @@ defmodule Pinchflat.UpgradeButtonLive do
       |> String.downcase()
 
     if normalized_text == "got it!" do
-      Settings.set(pro_enabled: true)
+      Settings.set!(:pro_enabled, true)
 
       {:noreply, update(socket, :button_disabled, fn _ -> false end)}
     else

lib/pinchflat_web/components/layouts/root.html.heex

@@ -8,7 +8,7 @@
       <%= assigns[:page_title] || "Pinchflat" %>
     </.live_title>
     <link phx-track-static rel="stylesheet" href={~p"/assets/app.css"} />
-    <link rel="icon" type="image/x-icon" href={~p"/favicon.ico?cachebust=2024-03-20"} />
+    <link rel="icon" type="image/x-icon" href={~p"/favicon.ico?cachebust=2024-02-29"} />
     <script defer phx-track-static type="text/javascript" src={~p"/assets/app.js"}>
     </script>
   </head>

lib/pinchflat_web/controllers/health_controller.ex

@@ -1,9 +0,0 @@
-defmodule PinchflatWeb.HealthController do
-  use PinchflatWeb, :controller
-
-  def check(conn, _params) do
-    conn
-    |> put_status(:ok)
-    |> json(%{status: "ok"})
-  end
-end

lib/pinchflat_web/controllers/media_items/media_item_controller.ex

@@ -1,12 +1,8 @@
 defmodule PinchflatWeb.MediaItems.MediaItemController do
   use PinchflatWeb, :controller
 
-  require Logger
-
   alias Pinchflat.Repo
   alias Pinchflat.Media
-  alias Pinchflat.Media.MediaItem
-  alias Pinchflat.Downloading.MediaDownloadWorker
 
   def show(conn, %{"id" => id}) do
     media_item =
@@ -17,108 +13,20 @@ defmodule PinchflatWeb.MediaItems.MediaItemController do
     render(conn, :show, media_item: media_item)
   end
 
-  def edit(conn, %{"id" => id}) do
-    media_item = Media.get_media_item!(id)
-    changeset = Media.change_media_item(media_item)
-
-    render(conn, :edit, media_item: media_item, changeset: changeset)
-  end
-
-  def update(conn, %{"id" => id, "media_item" => params}) do
-    media_item = Media.get_media_item!(id)
-
-    case Media.update_media_item(media_item, params) do
-      {:ok, media_item} ->
-        conn
-        |> put_flash(:info, "Media Item updated successfully.")
-        |> redirect(to: ~p"/sources/#{media_item.source_id}/media/#{media_item}")
-
-      {:error, %Ecto.Changeset{} = changeset} ->
-        render(conn, :edit, media_item: media_item, changeset: changeset)
-    end
-  end
-
   def delete(conn, %{"id" => id} = params) do
-    prevent_download = Map.get(params, "prevent_download", false)
+    delete_files = Map.get(params, "delete_files", false)
     media_item = Media.get_media_item!(id)
-    {:ok, _} = Media.delete_media_files(media_item, %{prevent_download: prevent_download})
+    {:ok, _} = Media.delete_media_item(media_item, delete_files: delete_files)
+
+    flash_message =
+      if delete_files do
+        "Record and files deleted successfully."
+      else
+        "Record deleted successfully. Files were not deleted."
+      end
 
     conn
-    |> put_flash(:info, "Files deleted successfully.")
+    |> put_flash(:info, flash_message)
     |> redirect(to: ~p"/sources/#{media_item.source_id}")
   end
-
-  def force_download(conn, %{"media_item_id" => id}) do
-    media_item = Media.get_media_item!(id)
-    {:ok, _} = MediaDownloadWorker.kickoff_with_task(media_item, %{force: true})
-
-    conn
-    |> put_flash(:info, "Download task enqueued.")
-    |> redirect(to: ~p"/sources/#{media_item.source_id}/media/#{media_item}")
-  end
-
-  # See here for details on streaming files and range requests:
-  # https://www.zeng.dev/post/2023-http-range-and-play-mp4-in-browser/
-  #
-  # Uses the UUID instead of the ID to avoid enumeration attacks
-  # since streaming is a public endpoint (ie: no auth required)
-  def stream(conn, %{"uuid" => uuid}) do
-    media_item = Repo.get_by!(MediaItem, uuid: uuid)
-
-    if File.exists?(media_item.media_filepath) do
-      file_size = File.stat!(media_item.media_filepath).size
-      mime_type = MIME.from_path(media_item.media_filepath)
-
-      case parse_range(conn, file_size) do
-        {:ok, {start_pos, end_pos}} ->
-          Logger.debug("Streaming media item: #{media_item.uuid} from #{start_pos} to #{end_pos}")
-          length = end_pos - start_pos + 1
-
-          conn
-          |> put_resp_content_type(mime_type)
-          |> put_resp_header("accept-ranges", "bytes")
-          |> put_resp_header("content-range", "bytes #{start_pos}-#{end_pos}/#{file_size}")
-          |> put_resp_header("content-length", to_string(length))
-          |> send_file(206, media_item.media_filepath, start_pos, length)
-
-        {:error, :invalid_range} ->
-          Logger.debug("Invalid range request for media item: #{media_item.uuid} - serving full file")
-
-          conn
-          |> put_resp_content_type(mime_type)
-          |> put_resp_header("content-length", to_string(file_size))
-          |> put_resp_header("accept-ranges", "bytes")
-          |> send_file(200, media_item.media_filepath)
-      end
-    else
-      send_resp(conn, 404, "File not found")
-    end
-  end
-
-  defp parse_range(conn, file_size) do
-    with [range_header | _] <- get_req_header(conn, "range"),
-         ["bytes", range] <- String.split(range_header, "="),
-         [start_pos, end_pos] <- String.split(range, "-") do
-      validate_range(start_pos, end_pos, file_size)
-    else
-      _ -> {:error, :invalid_range}
-    end
-  end
-
-  defp validate_range(start_pos, end_pos, file_size) do
-    case {Integer.parse(start_pos), Integer.parse(end_pos)} do
-      {:error, :error} ->
-        {:error, :invalid_range}
-
-      {{start_pos, _}, :error} ->
-        {:ok, {start_pos, file_size - 1}}
-
-      # See RFC7233
-      {{start_pos, _}, {end_pos, _}} when end_pos >= file_size ->
-        {:ok, {start_pos, file_size - 1}}
-
-      {{start_pos, _}, {end_pos, _}} ->
-        {:ok, {start_pos, end_pos}}
-    end
-  end
 end

lib/pinchflat_web/controllers/media_items/media_item_html.ex

@@ -2,24 +2,4 @@ defmodule PinchflatWeb.MediaItems.MediaItemHTML do
   use PinchflatWeb, :html
 
   embed_templates "media_item_html/*"
-
-  @doc """
-  Renders a media item form.
-  """
-  attr :changeset, Ecto.Changeset, required: true
-  attr :action, :string, required: true
-
-  def media_item_form(assigns)
-
-  def media_file_exists?(media_item) do
-    !!media_item.media_filepath and File.exists?(media_item.media_filepath)
-  end
-
-  def media_type(media_item) do
-    case Path.extname(media_item.media_filepath) do
-      ext when ext in [".mp4", ".webm", ".mkv"] -> :video
-      ext when ext in [".mp3", ".m4a"] -> :audio
-      _ -> :unknown
-    end
-  end
 end

lib/pinchflat_web/controllers/media_items/media_item_html/actions_dropdown.html.heex

@@ -1,32 +0,0 @@
-<.button_dropdown text="Actions" class="justify-center w-full sm:w-50">
-  <:option>
-    <.link
-      href={~p"/sources/#{@media_item.source_id}/media/#{@media_item}/force_download"}
-      method="post"
-      data-confirm="Are you sure you force a download of this media?"
-    >
-      Force Download
-    </.link>
-  </:option>
-  <:option>
-    <div class="h-px w-full bg-bodydark2"></div>
-  </:option>
-  <:option>
-    <.link
-      href={~p"/sources/#{@media_item.source_id}/media/#{@media_item}"}
-      method="delete"
-      data-confirm="Are you sure you want to delete all files for this media item? This cannot be undone."
-    >
-      Delete Files
-    </.link>
-  </:option>
-  <:option>
-    <.link
-      href={~p"/sources/#{@media_item.source_id}/media/#{@media_item}?prevent_download=true"}
-      method="delete"
-      data-confirm="Are you sure you want to delete all files for this media item and prevent it from re-downloading in the future? This cannot be undone."
-    >
-      Delete and Ignore
-    </.link>
-  </:option>
-</.button_dropdown>

lib/pinchflat_web/controllers/media_items/media_item_html/edit.html.heex

@@ -1,13 +0,0 @@
-<div class="mb-6 flex gap-3 flex-row items-center">
-  <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">
-    Editing "<%= StringUtils.truncate(@media_item.title, 35) %>"
-  </h2>
-</div>
-
-<div class="rounded-sm border border-stroke bg-white px-5 pb-2.5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5 xl:pb-1">
-  <div class="max-w-full overflow-x-auto">
-    <div class="flex flex-col gap-10">
-      <.media_item_form changeset={@changeset} action={~p"/sources/#{@media_item.source_id}/media/#{@media_item}"} />
-    </div>
-  </div>
-</div>

lib/pinchflat_web/controllers/media_items/media_item_html/media_item_form.html.heex

@@ -1,31 +0,0 @@
-<.simple_form
-  :let={f}
-  for={@changeset}
-  action={@action}
-  x-data="{ advancedMode: !!JSON.parse(localStorage.getItem('advancedMode')) }"
-  x-init="$watch('advancedMode', value => localStorage.setItem('advancedMode', JSON.stringify(value)))"
->
-  <.error :if={@changeset.action}>
-    Oops, something went wrong! Please check the errors below.
-  </.error>
-
-  <h3 class=" text-2xl text-black dark:text-white">
-    General Options
-  </h3>
-
-  <.input
-    field={f[:prevent_download]}
-    type="toggle"
-    label="Prevent Download"
-    help="Checking excludes this media item from automatic download. Download can still be manually forced"
-  />
-
-  <.input
-    field={f[:prevent_culling]}
-    type="toggle"
-    label="Prevent Automatic Deletion"
-    help="Checking excludes media from being automatically deleted based on media retention rules"
-  />
-
-  <.button class="my-10 sm:mb-7.5 w-full sm:w-auto" rounding="rounded-lg">Save Media Item</.button>
-</.simple_form>

lib/pinchflat_web/controllers/media_items/media_item_html/media_preview.heex

@@ -1,13 +0,0 @@
-<%= if media_type(@media_item) == :video do %>
-  <video controls class="max-h-96 w-full lg:w-2/3 xl:w-1/2">
-    <source src={~p"/media/#{@media_item.uuid}/stream"} type="video/mp4" />
-    Your browser does not support the video element.
-  </video>
-<% end %>
-
-<%= if media_type(@media_item) == :audio do %>
-  <audio controls class="w-full lg:w-2/3 xl:w-1/2">
-    <source src={~p"/media/#{@media_item.uuid}/stream"} type="audio/mpeg" />
-    Your browser does not support the audio element.
-  </audio>
-<% end %>

lib/pinchflat_web/controllers/media_items/media_item_html/show.html.heex

@@ -4,43 +4,37 @@
       <.icon name="hero-arrow-left" class="w-10 h-10 hover:dark:text-white" />
     </.link>
     <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">
-      <%= StringUtils.truncate(@media_item.title, 35) %>
+      Media Item #<%= @media_item.id %>
     </h2>
   </div>
-
-  <nav>
-    <.link href={~p"/sources/#{@media_item.source_id}/media/#{@media_item}/edit"}>
-      <.button color="bg-primary" rounding="rounded-lg">
-        <.icon name="hero-pencil-square" class="mr-2" /> Edit
-      </.button>
-    </.link>
-  </nav>
 </div>
-<div class="rounded-sm border border-stroke bg-white py-5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark px-7.5">
+<div class="rounded-sm border border-stroke bg-white py-5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5">
   <div class="max-w-full overflow-x-auto">
     <.tabbed_layout>
-      <:tab_append>
-        <.actions_dropdown media_item={@media_item} />
-      </:tab_append>
-
       <:tab title="Attributes">
         <div class="flex flex-col gap-10 dark:text-white">
-          <%= if media_file_exists?(@media_item) do %>
-            <h3 class="font-bold text-xl">Preview</h3>
-            <.media_preview media_item={@media_item} />
-          <% end %>
-
-          <h2 class="font-bold text-2xl"><%= @media_item.title %></h2>
           <h3 class="font-bold text-xl">Attributes</h3>
           <section>
             <strong>Source:</strong>
-            <.subtle_link href={~p"/sources/#{@media_item.source_id}"}>
+            <.inline_link href={~p"/sources/#{@media_item.source_id}"}>
               <%= @media_item.source.custom_name %>
-            </.subtle_link>
+            </.inline_link>
           </section>
 
           <.list_items_from_map map={Map.from_struct(@media_item)} />
         </div>
+
+        <section class="flex justify-center my-10">
+          <.link
+            href={~p"/sources/#{@media_item.source_id}/media/#{@media_item}?delete_files=true"}
+            method="delete"
+            data-confirm="Are you sure you want to delete this record and all associated files on disk? This cannot be undone."
+          >
+            <.button color="bg-meta-1" rounding="rounded-full">
+              Delete Files
+            </.button>
+          </.link>
+        </section>
       </:tab>
       <:tab title="Tasks">
         <%= if match?([_|_], @media_item.tasks) do %>

lib/pinchflat_web/controllers/media_profiles/media_profile_controller.ex

@@ -1,19 +1,12 @@
 defmodule PinchflatWeb.MediaProfiles.MediaProfileController do
   use PinchflatWeb, :controller
 
-  import Ecto.Query, warn: false
-
   alias Pinchflat.Repo
   alias Pinchflat.Profiles
-  alias Pinchflat.Sources.SourcesQuery
   alias Pinchflat.Profiles.MediaProfile
 
   def index(conn, _params) do
-    media_profiles =
-      MediaProfile
-      |> order_by(asc: :name)
-      |> Repo.all()
-
+    media_profiles = Profiles.list_media_profiles()
     render(conn, :index, media_profiles: media_profiles)
   end
 
@@ -39,15 +32,12 @@ defmodule PinchflatWeb.MediaProfiles.MediaProfileController do
   end
 
   def show(conn, %{"id" => id}) do
-    media_profile = Profiles.get_media_profile!(id)
+    media_profile =
+      id
+      |> Profiles.get_media_profile!()
+      |> Repo.preload(:sources)
 
-    sources =
-      SourcesQuery.new()
-      |> SourcesQuery.for_media_profile(media_profile)
-      |> order_by(asc: :custom_name)
-      |> Repo.all()
-
-    render(conn, :show, media_profile: media_profile, sources: sources)
+    render(conn, :show, media_profile: media_profile)
   end
 
   def edit(conn, %{"id" => id}) do

lib/pinchflat_web/controllers/media_profiles/media_profile_html.ex

@@ -1,8 +1,6 @@
 defmodule PinchflatWeb.MediaProfiles.MediaProfileHTML do
   use PinchflatWeb, :html
 
-  alias Pinchflat.Profiles.MediaProfile
-
   embed_templates "media_profile_html/*"
 
   @doc """
@@ -32,26 +30,6 @@ defmodule PinchflatWeb.MediaProfiles.MediaProfileHTML do
     ]
   end
 
-  def friendly_sponsorblock_options do
-    [
-      {"Disabled (default)", "disabled"},
-      {"Remove Segments", "remove"}
-    ]
-  end
-
-  def frieldly_sponsorblock_categories do
-    [
-      {"Sponsor", "sponsor"},
-      {"Intro/Intermission", "intro"},
-      {"Outro/Credits", "outro"},
-      {"Self Promotion", "selfpromo"},
-      {"Preview/Recap", "preview"},
-      {"Filler Tangent", "filler"},
-      {"Interaction Reminder", "interaction"},
-      {"Non-music Section", "music_offtopic"}
-    ]
-  end
-
   def custom_output_template_options do
     %{
       upload_day: nil,
@@ -59,8 +37,7 @@ defmodule PinchflatWeb.MediaProfiles.MediaProfileHTML do
       upload_year: nil,
       upload_yyyy_mm_dd: "the upload date in the format YYYY-MM-DD",
       source_custom_name: "the name of the sources that use this profile",
-      source_collection_type: "the collection type of the sources using this profile. Either 'channel' or 'playlist'",
-      artist_name: "the name of the artist with fallbacks to other uploader fields"
+      source_collection_type: "the collection type of the sources that use this profile. Either 'channel' or 'playlist'"
     }
   end
 
@@ -76,25 +53,4 @@ defmodule PinchflatWeb.MediaProfiles.MediaProfileHTML do
       duration_string
     )a
   end
-
-  def preset_options do
-    [
-      {"Default", "default"},
-      {"Media Center (Plex, Jellyfin, Kodi, etc.)", "media_center"},
-      {"Music", "audio"},
-      {"Archiving", "archiving"}
-    ]
-  end
-
-  defp default_output_template do
-    %MediaProfile{}.output_path_template
-  end
-
-  defp media_center_output_template do
-    "/shows/{{ source_custom_name }}/Season {{ season_from_date }}/{{ season_episode_from_date }} - {{ title }}.{{ ext }}"
-  end
-
-  defp audio_output_template do
-    "/music/{{ artist_name }}/{{ title }}.{{ ext }}"
-  end
 end

lib/pinchflat_web/controllers/media_profiles/media_profile_html/edit.html.heex

@@ -2,9 +2,7 @@
   <.link href={~p"/media_profiles"}>
     <.icon name="hero-arrow-left" class="w-10 h-10 hover:dark:text-white" />
   </.link>
-  <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">
-    Editing "<%= @media_profile.name %>"
-  </h2>
+  <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">Edit Media Profile</h2>
 </div>
 
 <div class="rounded-sm border border-stroke bg-white px-5 pb-2.5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5 xl:pb-1">

lib/pinchflat_web/controllers/media_profiles/media_profile_html/index.html.heex

@@ -4,7 +4,7 @@
   </h2>
   <nav>
     <.link href={~p"/media_profiles/new"}>
-      <.button color="bg-primary" rounding="rounded-lg">
+      <.button color="bg-primary" rounding="rounded-full">
         <span class="font-bold text-xl mx-2">+</span> New <span class="hidden sm:inline pl-1">Media Profile</span>
       </.button>
     </.link>
@@ -16,9 +16,10 @@
     <div class="flex flex-col gap-10 min-w-max">
       <.table rows={@media_profiles} table_class="text-black dark:text-white">
         <:col :let={media_profile} label="Name">
-          <.subtle_link href={~p"/media_profiles/#{media_profile.id}"}>
-            <%= media_profile.name %>
-          </.subtle_link>
+          <%= media_profile.name %>
+        </:col>
+        <:col :let={media_profile} label="Output Template">
+          <code class="text-sm"><%= media_profile.output_path_template %></code>
         </:col>
         <:col :let={media_profile} label="Preferred Resolution">
           <%= media_profile.preferred_resolution %>

lib/pinchflat_web/controllers/media_profiles/media_profile_html/media_profile_form.html.heex

@@ -3,273 +3,116 @@
     Oops, something went wrong! Please check the errors below.
   </.error>
 
-  <section x-data="{ selectedPreset: null }">
-    <h3 class="my-4 text-2xl text-black dark:text-white">
-      Use a Preset
-    </h3>
-    <section x-data="{ selection: null }">
-      <.input
-        prompt="Select preset"
-        name="media_profile_preset"
-        value=""
-        options={preset_options()}
-        type="select"
-        x-model="selection"
-        inputclass="w-full"
-        help="You can further customize the settings after selecting a preset. This is just a starting point"
-      >
-        <.button
-          class="h-13 w-2/5 lg:w-1/5 ml-2 md:ml-4"
-          rounding="rounded"
-          type="button"
-          x-on:click="selectedPreset = selection; selection = null"
-          x-bind:disabled="!selection"
-        >
-          <span x-text="selection ? 'Load' : 'Select'">Select</span><span class="hidden lg:inline ml-1">Preset</span>
-        </.button>
-      </.input>
-    </section>
+  <h3 class="my-4 text-2xl text-black dark:text-white">
+    General Options
+  </h3>
+  <.input
+    field={f[:name]}
+    type="text"
+    label="Name"
+    placeholder="New Profile"
+    help="Something descriptive. Does not impact indexing or downloading (required)"
+  />
 
-    <h3 class="mt-8 text-2xl text-black dark:text-white">
-      General Options
-    </h3>
+  <.input
+    field={f[:output_path_template]}
+    type="text"
+    inputclass="font-mono"
+    label="Output path template"
+    help="Must end with .{{ ext }}. See below for more details. The default is good for most cases (required)"
+  />
 
-    <section x-data="{ 
-        presets: { 
-          default: 'Default',
-          media_center: 'TV Shows',
-          audio: 'Music',
-          archiving: 'Archiving'
-        }
-    }">
-      <.input
-        field={f[:name]}
-        type="text"
-        label="Name"
-        placeholder="New Profile"
-        help="Something descriptive. Does not impact indexing or downloading (required)"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    Subtitle Options
+  </h3>
+  <.input
+    field={f[:download_subs]}
+    type="toggle"
+    label="Download Subtitles"
+    help="Downloads subtitle files alongside media file"
+  />
+  <.input
+    field={f[:download_auto_subs]}
+    type="toggle"
+    label="Download Autogenerated Subtitles"
+    help="Prefers normal subs but will download autogenerated if needed"
+  />
+  <.input
+    field={f[:embed_subs]}
+    type="toggle"
+    label="Embed Subtitles"
+    help="Embeds subtitles in the video file itself, if supported (recommended)"
+  />
+  <.input
+    field={f[:sub_langs]}
+    type="text"
+    label="Subtitle Languages"
+    help="Use commas for multiple languages (eg: en,de)"
+  />
 
-    <section x-data={"{ 
-        presets: { 
-          default: '#{default_output_template()}',
-          media_center: '#{media_center_output_template()}',
-          audio: '#{audio_output_template()}',
-          archiving: '#{default_output_template()}'
-        }
-    }"}>
-      <.input
-        field={f[:output_path_template]}
-        type="text"
-        inputclass="font-mono"
-        label="Output path template"
-        help="Must end with .{{ ext }}. See below for more details. The default is good for most cases (required)"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    Thumbnail Options
+  </h3>
+  <.input
+    field={f[:download_thumbnail]}
+    type="toggle"
+    label="Download Thumbnail"
+    help="Downloads thumbnail alongside media file"
+  />
+  <.input
+    field={f[:embed_thumbnail]}
+    type="toggle"
+    label="Embed Thumbnail"
+    help="Embeds thumbnail in the video file itself, if supported (recommended)"
+  />
 
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      Subtitle Options
-    </h3>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    Metadata Options
+  </h3>
+  <.input
+    field={f[:download_metadata]}
+    type="toggle"
+    label="Download Metadata"
+    help="Downloads metadata file alongside media file"
+  />
+  <.input
+    field={f[:embed_metadata]}
+    type="toggle"
+    label="Embed Metadata"
+    help="Embeds metadata in the video file itself, if supported (recommended)"
+  />
 
-    <section x-data="{ presets: { default: true, media_center: true, audio: false, archiving: true } }">
-      <.input
-        field={f[:download_subs]}
-        type="toggle"
-        label="Download Subtitles"
-        help="Downloads subtitle files alongside media file"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    Release Format Options
+  </h3>
 
-    <section x-data="{ presets: { default: false, media_center: false, audio: false, archiving: false } }">
-      <.input
-        field={f[:download_auto_subs]}
-        type="toggle"
-        label="Download Autogenerated Subtitles"
-        help="Prefers normal subs but will download autogenerated if needed. Requires 'Download Subtitles' to be enabled"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
+  <.input
+    field={f[:shorts_behaviour]}
+    options={friendly_format_type_options()}
+    type="select"
+    label="Include Shorts?"
+    help="Experimental. Please report any issues on GitHub"
+  />
+  <.input
+    field={f[:livestream_behaviour]}
+    options={friendly_format_type_options()}
+    type="select"
+    label="Include Livestreams?"
+  />
 
-    <section x-data="{ presets: { default: true, media_center: true, audio: false, archiving: true } }">
-      <.input
-        field={f[:embed_subs]}
-        type="toggle"
-        label="Embed Subtitles"
-        help="Downloads and embeds subtitles in the media file itself, if supported. Uneffected by 'Download Subtitles' (recommended)"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    Quality Options
+  </h3>
 
-    <section x-data="{ presets: { default: 'en', media_center: 'en', audio: '', archiving: 'all' } }">
-      <.input
-        field={f[:sub_langs]}
-        type="text"
-        label="Subtitle Languages"
-        help="Use commas for multiple languages (eg: en,de)"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
+  <.input
+    field={f[:preferred_resolution]}
+    options={friendly_resolution_options()}
+    type="select"
+    label="Preferred Resolution"
+    help="Will grab the closest available resolution if your preferred is not available"
+  />
 
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      Thumbnail Options
-    </h3>
-
-    <section x-data="{ presets: { default: true, media_center: true, audio: false, archiving: true } }">
-      <.input
-        field={f[:download_thumbnail]}
-        type="toggle"
-        label="Download Thumbnail"
-        help="Downloads thumbnail alongside media file"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <section x-data="{ presets: { default: true, media_center: true, audio: true, archiving: true } }">
-      <.input
-        field={f[:embed_thumbnail]}
-        type="toggle"
-        label="Embed Thumbnail"
-        help="Downloads and embeds thumbnail in the media file itself, if supported. Uneffected by 'Download Thumbnail' (recommended)"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      Metadata Options
-    </h3>
-
-    <section x-data="{ presets: { default: false, media_center: false, audio: false, archiving: true } }">
-      <.input
-        field={f[:download_metadata]}
-        type="toggle"
-        label="Download Metadata"
-        help="Downloads metadata file alongside media file"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <section x-data="{ presets: { default: true, media_center: true, audio: true, archiving: true } }">
-      <.input
-        field={f[:embed_metadata]}
-        type="toggle"
-        label="Embed Metadata"
-        help="Downloads and embeds metadata in the media file itself, if supported. Uneffected by 'Download Metadata' (recommended)"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      Release Format Options
-    </h3>
-
-    <section x-data="{ presets: { default: 'include', media_center: 'exclude', audio: 'exclude', archiving: 'include' } }">
-      <.input
-        field={f[:shorts_behaviour]}
-        options={friendly_format_type_options()}
-        type="select"
-        label="Include Shorts"
-        help="Experimental. Please report any issues on GitHub"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
-
-    <section x-data="{ presets: { default: 'exclude', media_center: 'exclude', audio: 'exclude', archiving: 'include' } }">
-      <.input
-        field={f[:livestream_behaviour]}
-        options={friendly_format_type_options()}
-        type="select"
-        label="Include Livestreams"
-        help="Excludes media that comes from a past livestream"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
-
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      Quality Options
-    </h3>
-
-    <section x-data="{ presets: { default: '1080p', media_center: '1080p', audio: 'audio', archiving: '2160p' } }">
-      <.input
-        field={f[:preferred_resolution]}
-        options={friendly_resolution_options()}
-        type="select"
-        label="Preferred Resolution"
-        help="Will grab the closest available resolution if your preferred is not available. 'Audio Only' grabs the highest quality m4a"
-        x-init="$watch('selectedPreset', p => p && ($el.value = presets[p]))"
-      />
-    </section>
-
-    <h3 class="mt-8 text-2xl text-black dark:text-white">
-      Media Center Options
-    </h3>
-    <p class="text-sm mt-2 max-w-prose">
-      Everything in this section is experimental - please open a GitHub issue if you see something odd.
-      <strong>
-        These options only work if this Media Profile's output template is set to split media into seasons.
-      </strong>
-      Try the "Media Center" preset if you're not sure.
-    </p>
-
-    <section
-      phx-click={show_modal("upgrade-modal")}
-      x-data="{ presets: { default: false, media_center: true, audio: false, archiving: false } }"
-    >
-      <.input
-        field={f[:download_nfo]}
-        type="toggle"
-        label="Download NFO data"
-        label_suffix="(pro)"
-        help="Downloads NFO data alongside media file for use with Jellyfin, Kodi, etc."
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <section x-data="{ presets: { default: false, media_center: true, audio: false, archiving: true } }">
-      <.input
-        field={f[:download_source_images]}
-        type="toggle"
-        label="Download Series Images"
-        help="Downloads poster and banner images for use with Plex, Jellyfin, Kodi, etc. Only works for full channels (not playlists)"
-        x-init="$watch('selectedPreset', p => p && (enabled = presets[p]))"
-      />
-    </section>
-
-    <h3 class="mt-10 text-2xl text-black dark:text-white">
-      SponsorBlock Options
-    </h3>
-
-    <section x-data="{ sponsorblockBehaviour: null }">
-      <section x-data="{ presets: { default: 'disabled', media_center: 'disabled', audio: 'disabled', archiving: 'disabled' } }">
-        <.input
-          field={f[:sponsorblock_behaviour]}
-          options={friendly_sponsorblock_options()}
-          type="select"
-          label="SponsorBlock Behaviour"
-          help="Action to take when SponsorBlock segments are found. 'Disabled' won't take any action"
-          x-model="sponsorblockBehaviour"
-          x-init="
-            sponsorblockBehaviour = $el.value
-            $watch('selectedPreset', p => p && ($el.value = presets[p]))
-          "
-        />
-      </section>
-
-      <section x-show="sponsorblockBehaviour !== 'disabled'" x-transition>
-        <.input
-          field={f[:sponsorblock_categories]}
-          options={frieldly_sponsorblock_categories()}
-          type="checkbox_group"
-          label="SponsorBlock Categories"
-        />
-      </section>
-    </section>
-
-    <.button class="my-10 sm:mb-7.5 w-full sm:w-auto" rounding="rounded-lg">Save Media profile</.button>
-  </section>
+  <.button class="my-10 sm:mb-7.5 w-full sm:w-auto">Save Media profile</.button>
 
   <div class="rounded-sm dark:bg-meta-4 p-4 md:p-6 mb-5">
     <.output_template_help />

lib/pinchflat_web/controllers/media_profiles/media_profile_html/show.html.heex

@@ -4,13 +4,13 @@
       <.icon name="hero-arrow-left" class="w-10 h-10 hover:dark:text-white" />
     </.link>
     <h2 class="text-title-md2 font-bold text-black dark:text-white ml-2">
-      <%= @media_profile.name %>
+      Media Profile <span class="hidden sm:inline">#<%= @media_profile.id %></span>
     </h2>
   </div>
 
   <nav>
     <.link href={~p"/media_profiles/#{@media_profile}/edit"}>
-      <.button color="bg-primary" rounding="rounded-lg">
+      <.button color="bg-primary" rounding="rounded-full">
         <.icon name="hero-pencil-square" class="mr-2" />Edit <span class="hidden sm:inline pl-1">Media Profile</span>
       </.button>
     </.link>
@@ -19,42 +19,38 @@
 <div class="rounded-sm border border-stroke bg-white px-5 pb-2.5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5 xl:pb-1">
   <div class="max-w-full overflow-x-auto">
     <.tabbed_layout>
-      <:tab_append>
-        <.button_dropdown text="Actions" class="justify-center w-full sm:w-50">
-          <:option>
-            <.link
-              href={~p"/media_profiles/#{@media_profile}"}
-              method="delete"
-              data-confirm="Are you sure you want to delete this profile and all its sources (leaving files in place)? This cannot be undone."
-            >
-              Delete Profile
-            </.link>
-          </:option>
-          <:option>
-            <.link
-              href={~p"/media_profiles/#{@media_profile}?delete_files=true"}
-              method="delete"
-              data-confirm="Are you sure you want to delete this profile, all its sources, and its files on disk? This cannot be undone."
-              class="mt-5 md:mt-0"
-            >
-              Delete Profile + Files
-            </.link>
-          </:option>
-        </.button_dropdown>
-      </:tab_append>
-
       <:tab title="Attributes">
         <div class="flex flex-col gap-10 text-white">
           <h3 class="font-bold text-xl">Attributes for "<%= @media_profile.name %>"</h3>
           <.list_items_from_map map={Map.from_struct(@media_profile)} />
         </div>
+
+        <section class="flex flex-col md:flex-row items-center md:justify-around my-10">
+          <.link
+            href={~p"/media_profiles/#{@media_profile}"}
+            method="delete"
+            data-confirm="Are you sure you want to delete this profile and all its sources (leaving files in place)? This cannot be undone."
+          >
+            <.button color="bg-meta-1" rounding="rounded-full">
+              Delete Profile and its Sources
+            </.button>
+          </.link>
+          <.link
+            href={~p"/media_profiles/#{@media_profile}?delete_files=true"}
+            method="delete"
+            data-confirm="Are you sure you want to delete this profile, all its sources, and its files on disk? This cannot be undone."
+            class="mt-5 md:mt-0"
+          >
+            <.button color="bg-meta-1" rounding="rounded-full">
+              Delete Profile, Sources, and Files
+            </.button>
+          </.link>
+        </section>
       </:tab>
       <:tab title="Sources">
-        <.table rows={@sources} table_class="text-black dark:text-white">
+        <.table rows={@media_profile.sources} table_class="text-black dark:text-white">
           <:col :let={source} label="Name">
-            <.subtle_link href={~p"/sources/#{source.id}"}>
-              <%= source.custom_name || source.collection_name %>
-            </.subtle_link>
+            <%= source.custom_name || source.collection_name %>
           </:col>
           <:col :let={source} label="Type"><%= source.collection_type %></:col>
           <:col :let={source} label="Should Download?">

lib/pinchflat_web/controllers/pages/page_controller.ex

@@ -11,7 +11,7 @@ defmodule PinchflatWeb.Pages.PageController do
     done_onboarding = params["onboarding"] == "0"
     force_onboarding = params["onboarding"] == "1"
 
-    if done_onboarding, do: Settings.set(onboarding: false)
+    if done_onboarding, do: Settings.set!(:onboarding, false)
 
     if force_onboarding || Settings.get!(:onboarding) do
       render_onboarding_page(conn)
@@ -30,7 +30,7 @@ defmodule PinchflatWeb.Pages.PageController do
   end
 
   defp render_onboarding_page(conn) do
-    Settings.set(onboarding: true)
+    Settings.set!(:onboarding, true)
 
     conn
     |> render(:onboarding_checklist,

lib/pinchflat_web/controllers/pages/page_html/home.html.heex

@@ -1,27 +1,27 @@
 <div class="grid grid-cols-1 gap-4 md:grid-cols-3">
   <div class="rounded-sm border px-7.5 py-6 shadow-default border-strokedark bg-boxdark">
-    <a href={~p"/media_profiles"} class="mt-4 flex flex-col items-center justify-center">
+    <div class="mt-4 flex flex-col items-center justify-center">
       <span class="text-md font-medium">Media Profile(s)</span>
       <h4 class="text-title-md font-bold text-white">
         <%= @media_profile_count %>
       </h4>
-    </a>
+    </div>
   </div>
   <div class="rounded-sm border px-7.5 py-6 shadow-default border-strokedark bg-boxdark">
-    <a href={~p"/sources"} class="mt-4 flex flex-col items-center justify-center">
+    <div class="mt-4 flex flex-col items-center justify-center">
       <span class="text-md font-medium">Source(s)</span>
       <h4 class="text-title-md font-bold text-white">
         <%= @source_count %>
       </h4>
-    </a>
+    </div>
   </div>
   <div class="rounded-sm border px-7.5 py-6 shadow-default border-strokedark bg-boxdark">
-    <a href="#" class="mt-4 flex flex-col items-center justify-center">
+    <div class="mt-4 flex flex-col items-center justify-center">
       <span class="text-md font-medium">Media Item(s)</span>
       <h4 class="text-title-md font-bold text-white">
         <%= @media_item_count %>
       </h4>
-    </a>
+    </div>
   </div>
   <span class="text-strokedark">I know this page isn't super useful yet, but give it time :&rpar;</span>
 </div>

lib/pinchflat_web/controllers/pages/page_html/onboarding_checklist.html.heex

@@ -11,7 +11,7 @@
         <p class="text-md text-bodydark">Don't worry, you can create more Media Profiles later!</p>
         <div class="mt-8">
           <.link href={~p"/media_profiles/new"}>
-            <.button color="bg-primary" rounding="rounded-lg" disabled={@media_profiles_exist}>
+            <.button color="bg-primary" rounding="rounded-full" disabled={@media_profiles_exist}>
               <span class="font-bold mx-2">+</span> New Media Profile
             </.button>
           </.link>
@@ -25,7 +25,7 @@
         </p>
         <div class="mt-8">
           <.link href={~p"/sources/new"}>
-            <.button color="bg-primary" rounding="rounded-lg" disabled={not @media_profiles_exist}>
+            <.button color="bg-primary" rounding="rounded-full" disabled={not @media_profiles_exist}>
               <span class="font-bold mx-2">+</span> New Source
             </.button>
           </.link>
@@ -40,7 +40,7 @@
         <p class="text-md text-bodydark">Feel free to add more Media Profiles or Sources in the meantime!</p>
         <div class="mt-8">
           <.link href={~p"/?onboarding=0"}>
-            <.button color="bg-primary" rounding="rounded-lg" disabled={not @sources_exist}>
+            <.button color="bg-primary" rounding="rounded-full" disabled={not @sources_exist}>
               Let's Go <span class="font-bold mx-2">🚀</span>
             </.button>
           </.link>

lib/pinchflat_web/controllers/podcasts/podcast_controller.ex

@@ -1,43 +0,0 @@
-defmodule PinchflatWeb.Podcasts.PodcastController do
-  use PinchflatWeb, :controller
-
-  alias Pinchflat.Repo
-  alias Pinchflat.Media.MediaQuery
-  alias Pinchflat.Sources.Source
-  alias Pinchflat.Podcasts.RssFeedBuilder
-  alias Pinchflat.Podcasts.PodcastHelpers
-
-  def rss_feed(conn, %{"uuid" => uuid}) do
-    source = Repo.get_by!(Source, uuid: uuid)
-    url_base = url(conn, ~p"/")
-    xml = RssFeedBuilder.build(source, limit: 300, url_base: url_base)
-
-    conn
-    |> put_resp_content_type("application/rss+xml")
-    |> put_resp_header("content-disposition", "inline")
-    |> send_resp(200, xml)
-  end
-
-  def feed_image(conn, %{"uuid" => uuid}) do
-    source = Repo.get_by!(Source, uuid: uuid)
-
-    # This is used to fetch a fallback cover image
-    # if the source doesn't have any usable images
-    media_items =
-      MediaQuery.new()
-      |> MediaQuery.for_source(source)
-      |> MediaQuery.with_media_filepath()
-      |> Repo.maybe_limit(1)
-      |> Repo.all()
-
-    case PodcastHelpers.select_cover_image(source, media_items) do
-      {:error, _} ->
-        send_resp(conn, 404, "Image not found")
-
-      {:ok, filepath} ->
-        conn
-        |> put_resp_content_type(MIME.from_path(filepath))
-        |> send_file(200, filepath)
-    end
-  end
-end

lib/pinchflat_web/controllers/searches/search_html/show.html.heex

@@ -1,6 +1,6 @@
 <div class="mb-6 flex gap-3 flex-row items-center justify-between">
   <h2 class="text-title-md2 font-bold text-black dark:text-white">
-    Results for "<%= StringUtils.truncate(@search_term, 50) %>"
+    <span class="hidden sm:inline">Search </span>Results for "<%= StringUtils.truncate(@search_term, 50) %>"
   </h2>
 </div>
 
@@ -10,7 +10,7 @@
       <%= if match?([_|_], @search_results) do %>
         <.table rows={@search_results} table_class="text-black dark:text-white">
           <:col :let={result} label="Title">
-            <%= result.title %>
+            <%= StringUtils.truncate(result.title, 40) %>
           </:col>
           <:col :let={result} label="Excerpt">
             <.highlight_search_terms text={result.matching_search_term} />

lib/pinchflat_web/controllers/sources/source_controller.ex

@@ -1,24 +1,15 @@
 defmodule PinchflatWeb.Sources.SourceController do
   use PinchflatWeb, :controller
 
-  import Ecto.Query, warn: false
-
   alias Pinchflat.Repo
+  alias Pinchflat.Media
   alias Pinchflat.Tasks
   alias Pinchflat.Sources
-  alias Pinchflat.MediaQuery
+  alias Pinchflat.Profiles
   alias Pinchflat.Sources.Source
-  alias Pinchflat.Media.MediaQuery
-  alias Pinchflat.Profiles.MediaProfile
-  alias Pinchflat.Downloading.DownloadingHelpers
-  alias Pinchflat.SlowIndexing.SlowIndexingHelpers
 
   def index(conn, _params) do
-    sources =
-      Source
-      |> order_by(asc: :custom_name)
-      |> Repo.all()
-      |> Repo.preload(:media_profile)
+    sources = Repo.preload(Sources.list_sources(), :media_profile)
 
     render(conn, :index, sources: sources)
   end
@@ -55,33 +46,15 @@ defmodule PinchflatWeb.Sources.SourceController do
   def show(conn, %{"id" => id}) do
     source = Repo.preload(Sources.get_source!(id), :media_profile)
 
-    pending_tasks =
-      source
-      |> Tasks.list_tasks_for(nil, [:executing, :available, :scheduled, :retryable])
-      |> Repo.preload(:job)
-
-    pending_media =
-      MediaQuery.new()
-      |> MediaQuery.for_source(source)
-      |> MediaQuery.with_media_pending_download()
-      |> order_by(desc: :id)
-      |> limit(100)
-      |> Repo.all()
-
-    downloaded_media =
-      MediaQuery.new()
-      |> MediaQuery.for_source(source)
-      |> MediaQuery.with_media_filepath()
-      |> order_by(desc: :id)
-      |> limit(100)
-      |> Repo.all()
+    pending_tasks = Repo.preload(Tasks.list_pending_tasks_for(:source_id, source.id), :job)
+    pending_media = Media.list_pending_media_items_for(source, limit: 100)
+    downloaded_media = Media.list_downloaded_media_items_for(source, limit: 100)
 
     render(conn, :show,
       source: source,
       pending_tasks: pending_tasks,
       pending_media: pending_media,
-      downloaded_media: downloaded_media,
-      total_downloaded: total_downloaded_for(source)
+      downloaded_media: downloaded_media
     )
   end
 
@@ -127,35 +100,8 @@ defmodule PinchflatWeb.Sources.SourceController do
     |> redirect(to: ~p"/sources")
   end
 
-  def force_download(conn, %{"source_id" => id}) do
-    source = Sources.get_source!(id)
-    DownloadingHelpers.enqueue_pending_download_tasks(source)
-
-    conn
-    |> put_flash(:info, "Forced download of pending media items.")
-    |> redirect(to: ~p"/sources/#{source}")
-  end
-
-  def force_index(conn, %{"source_id" => id}) do
-    source = Sources.get_source!(id)
-    SlowIndexingHelpers.kickoff_indexing_task(source, %{force: true})
-
-    conn
-    |> put_flash(:info, "Index enqueued.")
-    |> redirect(to: ~p"/sources/#{source}")
-  end
-
   defp media_profiles do
-    MediaProfile
-    |> order_by(asc: :name)
-    |> Repo.all()
-  end
-
-  defp total_downloaded_for(source) do
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> MediaQuery.with_media_filepath()
-    |> Repo.aggregate(:count, :id)
+    Profiles.list_media_profiles()
   end
 
   defp get_onboarding_layout do

lib/pinchflat_web/controllers/sources/source_html.ex

@@ -14,7 +14,7 @@ defmodule PinchflatWeb.Sources.SourceHTML do
 
   def friendly_index_frequencies do
     [
-      {"Only once when first created", -1},
+      {"On Create", -1},
       {"1 Hour", 60},
       {"3 Hours", 3 * 60},
       {"6 Hours", 6 * 60},
@@ -24,8 +24,4 @@ defmodule PinchflatWeb.Sources.SourceHTML do
       {"Monthly", 30 * 24 * 60}
     ]
   end
-
-  def rss_feed_url(conn, source) do
-    url(conn, ~p"/sources/#{source.uuid}/feed") <> ".xml"
-  end
 end

lib/pinchflat_web/controllers/sources/source_html/actions_dropdown.html.heex

@@ -1,55 +0,0 @@
-<.button_dropdown text="Actions" class="justify-center w-full sm:w-50">
-  <:option>
-    <span
-      x-data="{ copied: false }"
-      x-on:click={"
-                window.copyTextToClipboard('#{rss_feed_url(@conn, @source)}')
-                copied = true
-                setTimeout(() => copied = false, 4000)
-              "}
-    >
-      Copy RSS Feed
-      <span x-show="copied" x-transition.duration.150ms><.icon name="hero-check" class="ml-2 h-4 w-4" /></span>
-    </span>
-  </:option>
-  <:option :if={@source.download_media}>
-    <.link
-      href={~p"/sources/#{@source}/force_download"}
-      method="post"
-      data-confirm="Are you sure you want to force a download of all *pending* media items? This isn't normally needed."
-    >
-      Force Download
-    </.link>
-  </:option>
-  <:option>
-    <.link
-      href={~p"/sources/#{@source}/force_index"}
-      method="post"
-      data-confirm="Are you sure you want to force an index of this source? This isn't normally needed."
-    >
-      Force Index
-    </.link>
-  </:option>
-  <:option>
-    <div class="h-px w-full bg-bodydark2"></div>
-  </:option>
-  <:option>
-    <.link
-      href={~p"/sources/#{@source}"}
-      method="delete"
-      data-confirm="Are you sure you want to delete this source (leaving files in place)? This cannot be undone."
-    >
-      Delete Source
-    </.link>
-  </:option>
-  <:option>
-    <.link
-      href={~p"/sources/#{@source}?delete_files=true"}
-      method="delete"
-      data-confirm="Are you sure you want to delete this source and it's files on disk? This cannot be undone."
-      class="mt-5 md:mt-0"
-    >
-      Delete Source + Files
-    </.link>
-  </:option>
-</.button_dropdown>

lib/pinchflat_web/controllers/sources/source_html/edit.html.heex

@@ -2,9 +2,7 @@
   <.link href={~p"/sources"}>
     <.icon name="hero-arrow-left" class="w-10 h-10 hover:dark:text-white" />
   </.link>
-  <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">
-    Editing "<%= @source.custom_name %>"
-  </h2>
+  <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">Edit Source</h2>
 </div>
 
 <div class="rounded-sm border border-stroke bg-white px-5 pb-2.5 pt-6 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5 xl:pb-1">

lib/pinchflat_web/controllers/sources/source_html/index.html.heex

@@ -2,7 +2,7 @@
   <h2 class="text-title-md2 font-bold text-black dark:text-white">Sources</h2>
   <nav>
     <.link href={~p"/sources/new"}>
-      <.button color="bg-primary" rounding="rounded-lg">
+      <.button color="bg-primary" rounding="rounded-full">
         <span class="font-bold mx-2">+</span> New <span class="hidden sm:inline pl-1">Source</span>
       </.button>
     </.link>
@@ -14,25 +14,19 @@
     <div class="flex flex-col gap-10 min-w-max">
       <.table rows={@sources} table_class="text-black dark:text-white">
         <:col :let={source} label="Name">
-          <.subtle_link href={~p"/sources/#{source.id}"}>
-            <%= source.custom_name || source.collection_name %>
-          </.subtle_link>
+          <%= source.custom_name || source.collection_name %>
         </:col>
         <:col :let={source} label="Type"><%= source.collection_type %></:col>
         <:col :let={source} label="Should Download?">
           <.icon name={if source.download_media, do: "hero-check", else: "hero-x-mark"} />
         </:col>
-        <:col :let={source} label="Retention">
-          <%= if source.retention_period_days && source.retention_period_days > 0 do %>
-            <%= source.retention_period_days %> day(s)
-          <% else %>
-            <span class="text-lg">∞</span>
-          <% end %>
-        </:col>
         <:col :let={source} label="Media Profile">
-          <.subtle_link href={~p"/media_profiles/#{source.media_profile_id}"}>
+          <.link
+            href={~p"/media_profiles/#{source.media_profile_id}"}
+            class="hover:text-secondary duration-200 ease-in-out"
+          >
             <%= source.media_profile.name %>
-          </.subtle_link>
+          </.link>
         </:col>
         <:col :let={source} label="" class="flex place-content-evenly">
           <.icon_link href={~p"/sources/#{source.id}"} icon="hero-eye" class="mx-1" />

lib/pinchflat_web/controllers/sources/source_html/show.html.heex

@@ -4,13 +4,13 @@
       <.icon name="hero-arrow-left" class="w-10 h-10 hover:dark:text-white" />
     </.link>
     <h2 class="text-title-md2 font-bold text-black dark:text-white ml-4">
-      <%= @source.custom_name %>
+      Source <span class="hidden sm:inline">#<%= @source.id %></span>
     </h2>
   </div>
 
   <nav>
     <.link href={~p"/sources/#{@source}/edit"}>
-      <.button color="bg-primary" rounding="rounded-lg">
+      <.button color="bg-primary" rounding="rounded-full">
         <.icon name="hero-pencil-square" class="mr-2" /> Edit <span class="hidden sm:inline pl-1">Source</span>
       </.button>
     </.link>
@@ -19,39 +19,50 @@
 <div class="rounded-sm border border-stroke bg-white px-5 py-5 shadow-default dark:border-strokedark dark:bg-boxdark sm:px-7.5">
   <div class="max-w-full overflow-x-auto">
     <.tabbed_layout>
-      <:tab_append>
-        <.actions_dropdown source={@source} conn={@conn} />
-      </:tab_append>
-
       <:tab title="Attributes">
         <div class="flex flex-col gap-10 text-white">
           <h3 class="font-bold text-lg">Attributes</h3>
           <section>
             <strong>Media Profile:</strong>
-            <.subtle_link href={~p"/media_profiles/#{@source.media_profile_id}"}>
+            <.inline_link href={~p"/media_profiles/#{@source.media_profile_id}"}>
               <%= @source.media_profile.name %>
-            </.subtle_link>
+            </.inline_link>
           </section>
 
           <.list_items_from_map map={Map.from_struct(@source)} />
         </div>
+
+        <section class="flex flex-col md:flex-row items-center md:justify-around mt-10">
+          <.link
+            href={~p"/sources/#{@source}"}
+            method="delete"
+            data-confirm="Are you sure you want to delete this source (leaving files in place)? This cannot be undone."
+          >
+            <.button color="bg-meta-1" rounding="rounded-full">
+              Delete Source
+            </.button>
+          </.link>
+          <.link
+            href={~p"/sources/#{@source}?delete_files=true"}
+            method="delete"
+            data-confirm="Are you sure you want to delete this source and it's files on disk? This cannot be undone."
+            class="mt-5 md:mt-0"
+          >
+            <.button color="bg-meta-1" rounding="rounded-full">
+              Delete Source and Files
+            </.button>
+          </.link>
+        </section>
       </:tab>
       <:tab title="Pending Media">
         <%= if match?([_|_], @pending_media) do %>
           <h4 class="text-white text-lg mb-6">Shows a maximum of 100 media items</h4>
           <.table rows={@pending_media} table_class="text-black dark:text-white">
             <:col :let={media_item} label="Title">
-              <.subtle_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"}>
-                <%= StringUtils.truncate(media_item.title, 50) %>
-              </.subtle_link>
+              <%= StringUtils.truncate(media_item.title, 50) %>
             </:col>
             <:col :let={media_item} label="" class="flex place-content-evenly">
-              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" class="mx-1" />
-              <.icon_link
-                href={~p"/sources/#{@source.id}/media/#{media_item.id}/edit"}
-                icon="hero-pencil-square"
-                class="mx-1"
-              />
+              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" />
             </:col>
           </.table>
         <% else %>
@@ -60,20 +71,13 @@
       </:tab>
       <:tab title="Downloaded Media">
         <%= if match?([_|_], @downloaded_media) do %>
-          <h4 class="text-white text-lg mb-6">Shows a maximum of 100 media items (<%= @total_downloaded %> total)</h4>
+          <h4 class="text-white text-lg mb-6">Shows a maximum of 100 media items</h4>
           <.table rows={@downloaded_media} table_class="text-black dark:text-white">
             <:col :let={media_item} label="Title">
-              <.subtle_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"}>
-                <%= StringUtils.truncate(media_item.title, 50) %>
-              </.subtle_link>
+              <%= StringUtils.truncate(media_item.title, 50) %>
             </:col>
             <:col :let={media_item} label="" class="flex place-content-evenly">
-              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" class="mx-1" />
-              <.icon_link
-                href={~p"/sources/#{@source.id}/media/#{media_item.id}/edit"}
-                icon="hero-pencil-square"
-                class="mx-1"
-              />
+              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" />
             </:col>
           </.table>
         <% else %>

lib/pinchflat_web/controllers/sources/source_html/source_form.html.heex

@@ -1,22 +1,11 @@
-<.simple_form
-  :let={f}
-  for={@changeset}
-  action={@action}
-  x-data="{ advancedMode: !!JSON.parse(localStorage.getItem('advancedMode')) }"
-  x-init="$watch('advancedMode', value => localStorage.setItem('advancedMode', JSON.stringify(value)))"
->
+<.simple_form :let={f} for={@changeset} action={@action}>
   <.error :if={@changeset.action}>
     Oops, something went wrong! Please check the errors below.
   </.error>
 
-  <section class="flex justify-between items-center mt-8">
-    <h3 class=" text-2xl text-black dark:text-white">
-      General Options
-    </h3>
-    <span class="cursor-pointer hover:underline" x-on:click="advancedMode = !advancedMode">
-      Editing Mode: <span x-text="advancedMode ? 'Advanced' : 'Basic'"></span>
-    </span>
-  </section>
+  <h3 class="mt-8 text-2xl text-black dark:text-white">
+    General Options
+  </h3>
 
   <.input
     field={f[:custom_name]}
@@ -32,39 +21,30 @@
     options={Enum.map(@media_profiles, &{&1.name, &1.id})}
     type="select"
     label="Media Profile"
-    help="Sets your preferences for what media to look for and how to store it"
   />
 
   <h3 class="mt-8 text-2xl text-black dark:text-white">
     Indexing Options
   </h3>
 
-  <section x-data="{ fastIndexingEnabled: null }">
-    <.input
-      field={f[:index_frequency_minutes]}
-      options={friendly_index_frequencies()}
-      type="select"
-      label="Index Frequency"
-      x-bind:disabled="fastIndexingEnabled == true"
-      x-init="$watch('fastIndexingEnabled', v => v && ($el.value = 30 * 24 * 60))"
-      help="Indexing is the process of checking for media to download. Sets the time between one index of this source finishing and the next one starting"
-    />
+  <.input
+    field={f[:index_frequency_minutes]}
+    options={friendly_index_frequencies()}
+    type="select"
+    label="Index Frequency"
+    help="Time between one index of this source finishing and the next one starting. Setting to 'On Create' will still run an initial index but no subsequent ones"
+  />
 
-    <div phx-click={show_modal("upgrade-modal")}>
-      <.input
-        field={f[:fast_index]}
-        type="toggle"
-        label="Use Fast Indexing"
-        label_suffix="(pro)"
-        help="Experimental. Overrides 'Index Frequency'. Recommended for large channels that upload frequently. See below for more info"
-        x-init="
-          // `enabled` is the data attribute that the toggle uses internally
-          fastIndexingEnabled = enabled
-          $watch('enabled', value => fastIndexingEnabled = !!value)
-        "
-      />
-    </div>
-  </section>
+  <%!-- TODO: use Alpine to disable the index frequency when fast indexing is enabled --%>
+  <div phx-click={show_modal("upgrade-modal")}>
+    <.input
+      field={f[:fast_index]}
+      type="toggle"
+      label="Use Fast Indexing?"
+      label_suffix="(pro)"
+      help="Experimental. Ignores 'Index Frequency'. Recommended for large channels that upload frequently. See below for more info"
+    />
+  </div>
 
   <h3 class="mt-8 text-2xl text-black dark:text-white">
     Downloading Options
@@ -73,7 +53,7 @@
   <.input
     field={f[:download_media]}
     type="toggle"
-    label="Download Media"
+    label="Download Media?"
     help="Unchecking still indexes media but it won't be downloaded until you enable this option"
   />
 
@@ -88,32 +68,7 @@
     help="Only download media uploaded after this date. Leave blank to download all media. Must be in YYYY-MM-DD format"
   />
 
-  <.input
-    field={f[:retention_period_days]}
-    type="number"
-    label="Retention Period (days)"
-    min="0"
-    help="Days between when media is *downloaded* and when it's deleted. Leave blank to keep media indefinitely"
-  />
-
-  <section x-show="advancedMode">
-    <h3 class="mt-8 text-2xl text-black dark:text-white">
-      Advanced Options
-    </h3>
-    <p class="text-sm mt-2">
-      Tread carefully
-    </p>
-
-    <.input
-      field={f[:title_filter_regex]}
-      type="text"
-      label="Title Filter Regex"
-      placeholder="(?i)^How to Bike$"
-      help="A PCRE-compatible regex. Only media with titles that match this regex will be downloaded. Look up 'SQLean Regex docs' for more"
-    />
-  </section>
-
-  <.button class="my-10 sm:mb-7.5 w-full sm:w-auto" rounding="rounded-lg">Save Source</.button>
+  <.button class="my-10 sm:mb-7.5 w-full sm:w-auto">Save Source</.button>
 
   <div class="rounded-sm dark:bg-meta-4 p-4 md:p-6 mb-5">
     <.fast_indexing_help />

lib/pinchflat_web/endpoint.ex

@@ -20,7 +20,7 @@ defmodule PinchflatWeb.Endpoint do
   plug Plug.Static,
     at: "/",
     from: :pinchflat,
-    gzip: Mix.env() == :prod,
+    gzip: false,
     only: PinchflatWeb.static_paths()
 
   # Code reloading can be explicitly enabled under the
@@ -47,54 +47,5 @@ defmodule PinchflatWeb.Endpoint do
   plug Plug.MethodOverride
   plug Plug.Head
   plug Plug.Session, @session_options
-
-  plug :override_base_url
-  plug :strip_trailing_extension
-
   plug PinchflatWeb.Router
-
-  # URLs need to be generated using the host of the current page being accessed
-  # for things like Podcast RSS feeds to contain links to the right location.
-  #
-  # Normally you'd set the `url` option in the Endpoint configuration, but
-  # since this is self-hosted and often accessed at multiple different URLs,
-  # that would probably be more difficult for end-users to set up than just
-  # having the application figure it out.
-  defp override_base_url(conn, _opts) do
-    new_scheme =
-      case get_req_header(conn, "x-forwarded-proto") do
-        [scheme] -> scheme
-        _ -> to_string(conn.scheme)
-      end
-
-    new_port = if conn.port in [80, 443], do: "", else: ":#{conn.port}"
-    new_base_url = "#{new_scheme}://#{conn.host}#{new_port}"
-
-    Phoenix.Controller.put_router_url(conn, new_base_url)
-  end
-
-  defp strip_trailing_extension(%{path_info: []} = conn, _opts), do: conn
-
-  defp strip_trailing_extension(conn, _opts) do
-    path =
-      conn.path_info
-      |> List.last()
-      |> String.split(".")
-      |> Enum.reverse()
-
-    case path do
-      [_] ->
-        conn
-
-      [_format | fragments] ->
-        new_path =
-          fragments
-          |> Enum.reverse()
-          |> Enum.join(".")
-
-        path_fragments = List.replace_at(conn.path_info, -1, new_path)
-
-        %{conn | path_info: path_fragments}
-    end
-  end
 end

lib/pinchflat_web/router.ex

@@ -1,9 +1,6 @@
 defmodule PinchflatWeb.Router do
   use PinchflatWeb, :router
-  import Phoenix.LiveDashboard.Router
 
-  # IMPORTANT: `strip_trailing_extension` in endpoint.ex removes
-  # the extension from the path
   pipeline :browser do
     plug :basic_auth
     plug :accepts, ["html"]
@@ -12,17 +9,12 @@ defmodule PinchflatWeb.Router do
     plug :put_root_layout, html: {PinchflatWeb.Layouts, :root}
     plug :protect_from_forgery
     plug :put_secure_browser_headers
-    plug :allow_iframe_embed
   end
 
   pipeline :api do
     plug :accepts, ["json"]
   end
 
-  pipeline :feeds do
-    plug :maybe_basic_auth
-  end
-
   scope "/", PinchflatWeb do
     pipe_through :browser
 
@@ -32,46 +24,29 @@ defmodule PinchflatWeb.Router do
     resources "/search", Searches.SearchController, only: [:show], singleton: true
 
     resources "/sources", Sources.SourceController do
-      post "/force_download", Sources.SourceController, :force_download
-      post "/force_index", Sources.SourceController, :force_index
-
-      resources "/media", MediaItems.MediaItemController, only: [:show, :edit, :update, :delete] do
-        post "/force_download", MediaItems.MediaItemController, :force_download
-      end
+      resources "/media", MediaItems.MediaItemController, only: [:show, :delete]
     end
   end
 
-  # Routes in here _may not be_ protected by basic auth. This is necessary for
-  # media streaming to work for RSS podcast feeds.
-  scope "/", PinchflatWeb do
-    pipe_through :feeds
+  # Other scopes may use custom stacks.
+  # scope "/api", PinchflatWeb do
+  #   pipe_through :api
+  # end
 
-    get "/sources/:uuid/feed", Podcasts.PodcastController, :rss_feed
-    get "/sources/:uuid/feed_image", Podcasts.PodcastController, :feed_image
+  # Enable LiveDashboard and Swoosh mailbox preview in development
+  if Application.compile_env(:pinchflat, :dev_routes) do
+    # If you want to use the LiveDashboard in production, you should put
+    # it behind authentication and allow only admins to access it.
+    # If your application does not have an admins-only section yet,
+    # you can use Plug.BasicAuth to set up some basic authentication
+    # as long as you are also using SSL (which you should anyway).
+    import Phoenix.LiveDashboard.Router
 
-    get "/media/:uuid/stream", MediaItems.MediaItemController, :stream
-  end
+    scope "/dev" do
+      pipe_through :browser
 
-  # No auth or CSRF protection for the health check endpoint
-  scope "/", PinchflatWeb do
-    pipe_through :api
-
-    get "/healthcheck", HealthController, :check
-  end
-
-  scope "/dev" do
-    pipe_through :browser
-
-    live_dashboard "/dashboard",
-      metrics: PinchflatWeb.Telemetry,
-      ecto_repos: [Pinchflat.Repo]
-  end
-
-  defp maybe_basic_auth(conn, opts) do
-    if Application.get_env(:pinchflat, :expose_feed_endpoints) do
-      conn
-    else
-      basic_auth(conn, opts)
+      live_dashboard "/dashboard", metrics: PinchflatWeb.Telemetry
+      forward "/mailbox", Plug.Swoosh.MailboxPreview
     end
   end
 
@@ -89,8 +64,4 @@ defmodule PinchflatWeb.Router do
   defp credential_set?(credential) do
     credential && credential != ""
   end
-
-  defp allow_iframe_embed(conn, _opts) do
-    delete_resp_header(conn, "x-frame-options")
-  end
 end

mix.exs

@@ -4,7 +4,7 @@ defmodule Pinchflat.MixProject do
   def project do
     [
       app: :pinchflat,
-      version: "0.1.9",
+      version: "0.1.0-alpha.4",
       elixir: "~> 1.16",
       elixirc_paths: elixirc_paths(Mix.env()),
       start_permanent: Mix.env() == :prod,
@@ -13,16 +13,6 @@ defmodule Pinchflat.MixProject do
       preferred_cli_env: [
         check: :test,
         credo: :test
-      ],
-      test_coverage: [
-        ignore_modules: [
-          Pinchflat.HTTP.HTTPClient,
-          PinchflatWeb.Layouts,
-          Pinchflat.DataCase,
-          Pinchflat.Release,
-          ~r/Fixtures/,
-          ~r/HTML$/
-        ]
       ]
     ]
   end
@@ -33,7 +23,7 @@ defmodule Pinchflat.MixProject do
   def application do
     [
       mod: {Pinchflat.Application, []},
-      extra_applications: [:logger, :runtime_tools, :inets, :os_mon]
+      extra_applications: [:logger, :runtime_tools, :inets]
     ]
   end
 
@@ -50,7 +40,6 @@ defmodule Pinchflat.MixProject do
       {:phoenix_ecto, "~> 4.4"},
       {:ecto_sql, "~> 3.10"},
       {:ecto_sqlite3, ">= 0.0.0"},
-      {:ecto_sqlite3_extras, "~> 1.2.0"},
       {:phoenix_html, "~> 3.3"},
       {:phoenix_live_reload, "~> 1.2", only: :dev},
       {:phoenix_live_view, "~> 0.20.1"},

mix.lock

@@ -13,7 +13,6 @@
   "ecto": {:hex, :ecto, "3.11.1", "4b4972b717e7ca83d30121b12998f5fcdc62ba0ed4f20fd390f16f3270d85c3e", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ebd3d3772cd0dfcd8d772659e41ed527c28b2a8bde4b00fe03e0463da0f1983b"},
   "ecto_sql": {:hex, :ecto_sql, "3.11.1", "e9abf28ae27ef3916b43545f9578b4750956ccea444853606472089e7d169470", [:mix], [{:db_connection, "~> 2.4.1 or ~> 2.5", [hex: :db_connection, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11.0", [hex: :ecto, repo: "hexpm", optional: false]}, {:myxql, "~> 0.6.0", [hex: :myxql, repo: "hexpm", optional: true]}, {:postgrex, "~> 0.16.0 or ~> 0.17.0 or ~> 1.0", [hex: :postgrex, repo: "hexpm", optional: true]}, {:tds, "~> 2.1.1 or ~> 2.2", [hex: :tds, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "ce14063ab3514424276e7e360108ad6c2308f6d88164a076aac8a387e1fea634"},
   "ecto_sqlite3": {:hex, :ecto_sqlite3, "0.15.1", "40f2fbd9e246455f8c42e7e0a77009ef806caa1b3ce6f717b2a0a80e8432fcfd", [:mix], [{:decimal, "~> 1.6 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:ecto, "~> 3.11", [hex: :ecto, repo: "hexpm", optional: false]}, {:ecto_sql, "~> 3.11", [hex: :ecto_sql, repo: "hexpm", optional: false]}, {:exqlite, "~> 0.19", [hex: :exqlite, repo: "hexpm", optional: false]}], "hexpm", "28b16e177123c688948357176662bf9ff9084daddf950ef5b6baf3ee93707064"},
-  "ecto_sqlite3_extras": {:hex, :ecto_sqlite3_extras, "1.2.2", "36e60b561a11441d15f26c791817999269fb578b985162207ebb08b04ca71e40", [:mix], [{:exqlite, ">= 0.13.2", [hex: :exqlite, repo: "hexpm", optional: false]}, {:table_rex, "~> 4.0", [hex: :table_rex, repo: "hexpm", optional: false]}], "hexpm", "2b66ba7246bb4f7e39e2578acd4a0e4e4be54f60ff52d450a01be95eeb78ff1e"},
   "elixir_make": {:hex, :elixir_make, "0.7.8", "505026f266552ee5aabca0b9f9c229cbb496c689537c9f922f3eb5431157efc7", [:mix], [{:castore, "~> 0.1 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:certifi, "~> 2.0", [hex: :certifi, repo: "hexpm", optional: true]}], "hexpm", "7a71945b913d37ea89b06966e1342c85cfe549b15e6d6d081e8081c493062c07"},
   "esbuild": {:hex, :esbuild, "0.8.1", "0cbf919f0eccb136d2eeef0df49c4acf55336de864e63594adcea3814f3edf41", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.4", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "25fc876a67c13cb0a776e7b5d7974851556baeda2085296c14ab48555ea7560f"},
   "ex_check": {:hex, :ex_check, "0.14.0", "d6fbe0bcc51cf38fea276f5bc2af0c9ae0a2bb059f602f8de88709421dae4f0e", [:mix], [], "hexpm", "8a602e98c66e6a4be3a639321f1f545292042f290f91fa942a285888c6868af0"},
@@ -47,7 +46,6 @@
   "ranch": {:hex, :ranch, "1.8.0", "8c7a100a139fd57f17327b6413e4167ac559fbc04ca7448e9be9057311597a1d", [:make, :rebar3], [], "hexpm", "49fbcfd3682fab1f5d109351b61257676da1a2fdbe295904176d5e521a2ddfe5"},
   "sobelow": {:hex, :sobelow, "0.13.0", "218afe9075904793f5c64b8837cc356e493d88fddde126a463839351870b8d1e", [:mix], [{:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "cd6e9026b85fc35d7529da14f95e85a078d9dd1907a9097b3ba6ac7ebbe34a0d"},
   "swoosh": {:hex, :swoosh, "1.14.4", "94e9dba91f7695a10f49b0172c4a4cb658ef24abef7e8140394521b7f3bbb2d4", [:mix], [{:cowboy, "~> 1.1 or ~> 2.4", [hex: :cowboy, repo: "hexpm", optional: true]}, {:ex_aws, "~> 2.1", [hex: :ex_aws, repo: "hexpm", optional: true]}, {:finch, "~> 0.6", [hex: :finch, repo: "hexpm", optional: true]}, {:gen_smtp, "~> 0.13 or ~> 1.0", [hex: :gen_smtp, repo: "hexpm", optional: true]}, {:hackney, "~> 1.9", [hex: :hackney, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:mail, "~> 0.2", [hex: :mail, repo: "hexpm", optional: true]}, {:mime, "~> 1.1 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug, "~> 1.9", [hex: :plug, repo: "hexpm", optional: true]}, {:plug_cowboy, ">= 1.0.0", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:req, "~> 0.4 or ~> 1.0", [hex: :req, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4.2 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "081c5a590e4ba85cc89baddf7b2beecf6c13f7f84a958f1cd969290815f0f026"},
-  "table_rex": {:hex, :table_rex, "4.0.0", "3c613a68ebdc6d4d1e731bc973c233500974ec3993c99fcdabb210407b90959b", [:mix], [], "hexpm", "c35c4d5612ca49ebb0344ea10387da4d2afe278387d4019e4d8111e815df8f55"},
   "tailwind": {:hex, :tailwind, "0.2.2", "9e27288b568ede1d88517e8c61259bc214a12d7eed271e102db4c93fcca9b2cd", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}], "hexpm", "ccfb5025179ea307f7f899d1bb3905cd0ac9f687ed77feebc8f67bdca78565c4"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},
   "telemetry_metrics": {:hex, :telemetry_metrics, "0.6.2", "2caabe9344ec17eafe5403304771c3539f3b6e2f7fb6a6f602558c825d0d0bfb", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "9b43db0dc33863930b9ef9d27137e78974756f5f198cae18409970ed6fa5b561"},