Release v1.19.2

Closes #14875.

.github/workflows/release.yml

@@ -309,7 +309,6 @@ jobs:
       AWS_SECRET_ACCESS_KEY: ${{ secrets.HEX_AWS_SECRET_ACCESS_KEY }}
       AWS_REGION: ${{ vars.HEX_AWS_REGION }}
       AWS_S3_BUCKET: ${{ vars.HEX_AWS_S3_BUCKET }}
-      OTP_GENERIC_VERSION: "25"
     steps:
       - name: "Check if variables are set up"
         if: "${{ ! vars.HEX_AWS_REGION }}"
@@ -330,6 +329,8 @@ jobs:
         run: |
           ref_name=${{ github.ref_name }}
 
+          oldest_otp=$(find . -type f -name 'elixir-otp-*.zip' | sed -r 's/^.*elixir-otp-([[:digit:]]+)\.zip$/\1/' | sort -n | head -n 1)
+
           for zip in $(find . -type f -name 'elixir-otp-*.zip' | sed 's/^\.\///'); do
             dest=${zip/elixir/${ref_name}}
             surrogate_key=${dest/.zip$/}
@@ -339,7 +340,7 @@ jobs:
               --metadata "{\"surrogate-key\":\"builds builds/elixir builds/elixir/${surrogate_key}\",\"surrogate-control\":\"public,max-age=604800\"}"
             echo "builds/elixir/${surrogate_key}" >> purge_keys.txt
 
-            if [ "$zip" == "elixir-otp-${OTP_GENERIC_VERSION}.zip" ]; then
+            if [ "$zip" == "elixir-otp-${oldest_otp}.zip" ]; then
               aws s3 cp "${zip}" "s3://${AWS_S3_BUCKET}/builds/elixir/${ref_name}.zip" \
                 --cache-control "public,max-age=3600" \
                 --metadata "{\"surrogate-key\":\"builds builds/elixir builds/elixir/${ref_name}\",\"surrogate-control\":\"public,max-age=604800\"}"
@@ -372,6 +373,8 @@ jobs:
           date="$(date -u '+%Y-%m-%dT%H:%M:%SZ')"
           ref_name=${{ github.ref_name }}
 
+          oldest_otp=$(find . -name 'elixir-otp-*.zip.sha256sum' | sed -r 's/^.*elixir-otp-([[:digit:]]+)\.zip\.sha256sum$/\1/' | sort -n | head -n 1)
+
           aws s3 cp "s3://${AWS_S3_BUCKET}/builds/elixir/builds.txt" builds.txt || true
           touch builds.txt
 
@@ -382,7 +385,7 @@ jobs:
             sed -i "/^${ref_name}-${otp_version} /d" builds.txt
             echo -e "${ref_name}-${otp_version} ${{ github.sha }} ${date} ${build_sha256} \n$(cat builds.txt)" > builds.txt
 
-            if [ "${otp_version}" == "otp-${OTP_GENERIC_VERSION}" ]; then
+            if [ "${otp_version}" == "otp-${oldest_otp}" ]; then
               sed -i "/^${ref_name} /d" builds.txt
               echo -e "${ref_name} ${{ github.sha }} ${date} ${build_sha256} \n$(cat builds.txt)" > builds.txt
             fi

CHANGELOG.md

@@ -234,6 +234,56 @@ These additions offer greater transparency into the components and licenses of e
 
 This work was performed by [Jonatan Männchen](https://maennchen.dev) and sponsored by the [Erlang Ecosystem Foundation](https://erlef.org).
 
+## v1.19.2 (2025-11-02)
+
+### 1. Enhancements
+
+#### Elixir
+
+  * [Kernel] Measure and optimize writing of `.beam` files in the compiler
+  * [Kernel] Optimize rare scenarios where type checking took too long
+
+#### Mix
+
+  * [mix compile] Add flag `--no-check-cwd` to skip compiler check to aid debugging
+
+### 2. Bug fixes
+
+#### Elixir
+
+  * [IO] Fix dialyzer warning on `IO.inspect :label`
+  * [Kernel] Ensure we warn on deprecated `~~~` unary operator
+
+#### Logger
+
+  * [Logger] Reset ansi escapes before newlines in Logger
+
+#### Mix
+
+  * [mix compile] Warn if `elixirc_paths` is not a list of string paths
+  * [mix compile] Address regression where umbrella children were compiled too early and without respecting compilation flags
+  * [mix deps.compile] Improve reliability of `MIX_OS_DEPS_COMPILE_PARTITION_COUNT` across `mix escript.install`, `mix archive.install`, and others
+
+## v1.19.1 (2025-10-20)
+
+### 1. Bug fixes
+
+#### EEx
+
+  * [EEx] Address Dialyzer warnings when invoking `EEx.compile_string`
+
+#### Elixir
+
+  * [Kernel] Optimize how types are computed for pretty printing
+  * [Kernel] Optimize how differences are computed in the type system
+  * [Macro] Do not escape options given to `dbg/2`
+  * [Protocol] Improve protocol violation warnings
+
+#### Mix
+
+  * [mix compile] Do not attempt to touch deleted files when compilation fails and then resumed with missing files
+  * [mix deps.compile] Do not spawn partitions when all dependencies are local and already compiled
+
 ## v1.19.0 (2025-10-16)
 
 ### 1. Enhancements
@@ -337,7 +387,7 @@ This work was performed by [Jonatan Männchen](https://maennchen.dev) and sponso
   * [mix format] Ensure the formatter does not go over the specified limit in certain corner cases
   * [mix release] Fix `RELEASE_SYS_CONFIG` for Windows 11
   * [mix test] Ensure modules are preloaded in `mix test --slowest-modules=N`
-  * [mix xref graph] Provide more consistent output by considering strong connected components only when computing graphs
+  * [mix xref graph] Provide more consistent output by considering strong connected components when computing graphs. This means that, if you were using `mix xref graph --format cycles`, you will now get fewer but larger cycles, as cycle between `A` and `B` and another between `A` and `C` is now considered a single cycle between `A`, `B`, and `C`. Note the cycles themselves are not problematic, unless they have compile-time dependencies in them
 
 ### 3. Soft deprecations (no warnings emitted)
 

VERSION

@@ -1 +1 @@
-1.19.0
+1.19.2

bin/elixir

@@ -6,7 +6,7 @@
 
 set -e
 
-ELIXIR_VERSION=1.19.0
+ELIXIR_VERSION=1.19.2
 
 if [ $# -eq 0 ] || { [ $# -eq 1 ] && { [ "$1" = "--help" ] || [ "$1" = "-h" ]; }; }; then
   cat <<USAGE >&2

bin/elixir.bat

@@ -4,7 +4,7 @@
 :: SPDX-FileCopyrightText: 2021 The Elixir Team
 :: SPDX-FileCopyrightText: 2012 Plataformatec
 
-set ELIXIR_VERSION=1.19.0
+set ELIXIR_VERSION=1.19.2
 
 if    ""%1""==""""                if ""%2""=="""" goto documentation
 if /I ""%1""==""--help""          if ""%2""=="""" goto documentation

lib/eex/lib/eex.ex

@@ -236,7 +236,9 @@ defmodule EEx do
   """
   @spec compile_string(String.t(), [compile_opt]) :: Macro.t()
   def compile_string(source, options \\ []) when is_binary(source) and is_list(options) do
-    case tokenize(source, options) do
+    tokenize_opts = Keyword.take(options, [:file, :line, :column, :indentation, :trim])
+
+    case tokenize(source, tokenize_opts) do
       {:ok, tokens} ->
         EEx.Compiler.compile(tokens, source, options)
 

lib/elixir/lib/file.ex

@@ -706,7 +706,7 @@ defmodule File do
     path = IO.chardata_to_string(path)
 
     with {:error, :enoent} <- :elixir_utils.change_universal_time(path, time),
-         :ok <- write(path, "", [:append]),
+         :ok <- write(path, "", [:raw, :append]),
          do: :elixir_utils.change_universal_time(path, time)
   end
 
@@ -714,7 +714,7 @@ defmodule File do
     path = IO.chardata_to_string(path)
 
     with {:error, :enoent} <- :elixir_utils.change_posix_time(path, time),
-         :ok <- write(path, "", [:append]),
+         :ok <- write(path, "", [:raw, :append]),
          do: :elixir_utils.change_posix_time(path, time)
   end
 

lib/elixir/lib/io.ex

@@ -511,7 +511,8 @@ defmodule IO do
   """
   @spec inspect(device, item, inspect_opts) :: item when item: var
   def inspect(device, item, opts) when is_device(device) and is_list(opts) do
-    label = if label = opts[:label], do: [to_chardata(label), ": "], else: []
+    {label, opts} = Keyword.pop(opts, :label)
+    label = if label, do: [to_chardata(label), ": "], else: []
     opts = Inspect.Opts.new(opts)
     doc = Inspect.Algebra.group(Inspect.Algebra.to_doc(item, opts))
     chardata = Inspect.Algebra.format(doc, opts.width)

lib/elixir/lib/kernel/parallel_compiler.ex

@@ -380,27 +380,73 @@ defmodule Kernel.ParallelCompiler do
     end
   end
 
-  defp write_module_binaries(result, {:compile, path}, timestamp) do
-    File.mkdir_p!(path)
-    Code.prepend_path(path)
+  defp write_module_binaries(result, {:compile, path}, state) when map_size(result) > 0 do
+    profile(state, "writing modules to disk", fn ->
+      File.mkdir_p!(path)
+      Code.prepend_path(path)
+      timestamp = state.beam_timestamp
 
-    for {{:module, module}, {binary, _}} when is_binary(binary) <- result do
-      full_path = Path.join(path, Atom.to_string(module) <> ".beam")
-      File.write!(full_path, binary)
-      if timestamp, do: File.touch!(full_path, timestamp)
-      module
-    end
+      # We fan-out the writes as that improves performance
+      # when writing hundreds of beam files. This is cheap as
+      # we only transfer atoms and binaries across processes.
+      pool_size = min(map_size(result), state.schedulers)
+
+      pool_list =
+        for _ <- 1..pool_size do
+          spawn_link(fn -> write_loop(path, timestamp) end)
+        end
+
+      pool_tuple = List.to_tuple(pool_list)
+
+      {modules, _} =
+        Enum.flat_map_reduce(result, 0, fn
+          {{:module, module}, {binary, _}}, scheduler when is_binary(binary) ->
+            send(elem(pool_tuple, scheduler), {:write, module, binary})
+            {[module], rem(scheduler + 1, pool_size)}
+
+          _, scheduler ->
+            {[], scheduler}
+        end)
+
+      pool_refs =
+        for pid <- pool_list do
+          ref = Process.monitor(pid)
+          send(pid, :done)
+          ref
+        end
+
+      for ref <- pool_refs do
+        receive do
+          {:DOWN, ^ref, _, _, _} -> :ok
+        end
+      end
+
+      modules
+    end)
   end
 
-  defp write_module_binaries(result, _output, _timestamp) do
+  defp write_module_binaries(result, _output, _state) do
     for {{:module, module}, {binary, _}} when is_binary(binary) <- result, do: module
   end
 
+  defp write_loop(path, timestamp) do
+    receive do
+      {:write, module, binary} ->
+        full_path = Path.join(path, Atom.to_string(module) <> ".beam")
+        File.write!(full_path, binary, [:raw])
+        if timestamp, do: File.touch!(full_path, timestamp)
+        write_loop(path, timestamp)
+
+      :done ->
+        :ok
+    end
+  end
+
   ## Verification
 
   defp verify_modules(result, compile_warnings, dependent_modules, state) do
-    modules = write_module_binaries(result, state.output, state.beam_timestamp)
-    _ = state.after_compile.()
+    modules = write_module_binaries(result, state.output, state)
+    profile(state, "after compile callback", state.after_compile)
 
     runtime_warnings =
       if state.verification? do

lib/elixir/lib/macro.ex

@@ -2700,7 +2700,7 @@ defmodule Macro do
         :ok
     end
 
-    prelude = quote do: options = unquote(Macro.escape(options))
+    prelude = quote do: options = unquote(options)
     acc = {prelude, dbg_format_header(env)}
 
     {acc, nil} =

lib/elixir/lib/module/parallel_checker.ex

@@ -4,6 +4,7 @@
 
 defmodule Module.ParallelChecker do
   @moduledoc false
+  @elixir_checker_version :elixir_erl.checker_version()
 
   import Kernel, except: [spawn: 3]
 
@@ -62,14 +63,14 @@ defmodule Module.ParallelChecker do
   @doc """
   Spawns a process that runs the parallel checker.
   """
-  def spawn({pid, {checker, table}}, module, module_map, beam_location, log?) do
+  def spawn({pid, {checker, table}}, module, module_map, signatures, beam_location, log?) do
     # Protocols may have been consolidated. So if we know their beam location,
     # we discard their module map on purpose and start from file.
     info =
       if beam_location != [] and Keyword.has_key?(module_map.attributes, :__protocol__) do
         List.to_string(beam_location)
       else
-        cache_from_module_map(table, module_map)
+        cache_from_module_map(table, module_map, signatures)
       end
 
     inner_spawn(pid, checker, table, module, info, log?)
@@ -96,10 +97,12 @@ defmodule Module.ParallelChecker do
                     end
 
                   with {:ok, binary} <- File.read(location),
-                       {:ok, {_, [debug_info: chunk]}} <- :beam_lib.chunks(binary, [:debug_info]),
-                       {:debug_info_v1, backend, data} = chunk,
-                       {:ok, module_map} <- backend.debug_info(:elixir_v1, module, data, []) do
-                    cache_from_module_map(table, module_map)
+                       {:ok,
+                        {_, [{:debug_info, {:debug_info_v1, backend, data}}, {~c"ExCk", checker}]}} <-
+                         :beam_lib.chunks(binary, [:debug_info, ~c"ExCk"]),
+                       {:ok, module_map} <- backend.debug_info(:elixir_v1, module, data, []),
+                       {@elixir_checker_version, contents} <- :erlang.binary_to_term(checker) do
+                    {cache_chunk(table, module, contents), module_map_to_module_tuple(module_map)}
                   else
                     _ -> {:not_found, nil}
                   end
@@ -177,9 +180,9 @@ defmodule Module.ParallelChecker do
   end
 
   @doc """
-  Receives pairs of module maps and BEAM binaries. In parallel it verifies
-  the modules and adds the ExCk chunk to the binaries. Returns the updated
-  list of warnings from the verification.
+  Receives pairs of module maps and BEAM binaries.
+
+  Returns the updated list of warnings from the verification.
   """
   @spec verify(cache(), [{module(), Path.t()}]) :: [warning()]
   def verify({checker, table}, runtime_files) do
@@ -423,7 +426,7 @@ defmodule Module.ParallelChecker do
       mode =
         with {^module, binary, _filename} <- object_code,
              {:ok, {^module, [{~c"ExCk", chunk}]}} <- :beam_lib.chunks(binary, [~c"ExCk"]),
-             {:elixir_checker_v3, contents} <- :erlang.binary_to_term(chunk) do
+             {@elixir_checker_version, contents} <- :erlang.binary_to_term(chunk) do
           # The chunk has more information, so that's our preference
           cache_chunk(table, module, contents)
         else
@@ -474,12 +477,12 @@ defmodule Module.ParallelChecker do
     if Keyword.has_key?(attributes, :__protocol__), do: :protocol, else: :elixir
   end
 
-  defp cache_from_module_map(table, map) do
+  defp cache_from_module_map(table, map, signatures) do
     exports =
       behaviour_exports(map) ++
         for({function, :def, _meta, _clauses} <- map.definitions, do: function)
 
-    cache_info(table, map.module, exports, Map.new(map.deprecated), map.signatures)
+    cache_info(table, map.module, exports, Map.new(map.deprecated), signatures)
     {elixir_mode(map.attributes), module_map_to_module_tuple(map)}
   end
 

lib/elixir/lib/module/types/apply.ex

@@ -979,7 +979,7 @@ defmodule Module.Types.Apply do
     {mod, fun, arity, converter} = mfac
     meta = elem(expr, 1)
 
-    {banner, hints, traces} =
+    {banner, traces} =
       case Keyword.get(meta, :type_check) do
         :interpolation ->
           {_, _, [arg]} = expr
@@ -990,7 +990,7 @@ defmodule Module.Types.Apply do
                #{expr_to_string(arg) |> indent(4)}
 
            it has type:
-           """, [:interpolation], collect_traces(expr, context)}
+           """, collect_traces(expr, context)}
 
         :generator ->
           {:<-, _, [_, arg]} = expr
@@ -1001,7 +1001,7 @@ defmodule Module.Types.Apply do
                #{expr_to_string(expr) |> indent(4)}
 
            it has type:
-           """, [:generator], collect_traces(arg, context)}
+           """, collect_traces(arg, context)}
 
         :into ->
           {"""
@@ -1010,7 +1010,7 @@ defmodule Module.Types.Apply do
                into: #{expr_to_string(expr) |> indent(4)}
 
            it has type:
-           """, [:into], collect_traces(expr, context)}
+           """, collect_traces(expr, context)}
 
         _ ->
           mfa_or_fa = if mod, do: Exception.format_mfa(mod, fun, arity), else: "#{fun}/#{arity}"
@@ -1021,37 +1021,68 @@ defmodule Module.Types.Apply do
                #{expr_to_string(expr) |> indent(4)}
 
            given types:
-           """, [], collect_traces(expr, context)}
+           """, collect_traces(expr, context)}
       end
 
-    explanation =
+    {explanation, impls} =
       cond do
         reason = empty_arg_reason(converter.(args_types)) ->
-          reason
+          {reason, ""}
 
         Code.ensure_loaded?(mod) and
             Keyword.has_key?(mod.module_info(:attributes), :__protocol__) ->
           if function_exported?(mod, :__protocol__, 1) and
                mod.__protocol__(:impls) == {:consolidated, []} do
-            """
-            but the protocol was not yet implemented for any type and therefore will always fail. \
-            This error typically happens within libraries that define protocols and will disappear as \
-            soon as there is one implementation. If you expect the protocol to be implemented later on, \
-            you can define an implementation specific for development/test.
-            """
+            {"""
+             but the #{inspect(mod)} protocol was not yet implemented \
+             for any type and therefore will always fail.
+
+             This warning will disappear once you define a implementation. \
+             If the protocol is part of a library, you may define a dummy \
+             implementation for development/test.
+             """, ""}
           else
-            # Protocol errors can be very verbose, so we collapse structs
-            """
-            but expected a type that implements the #{inspect(mod)} protocol, it must be one of:
-            #{clauses_args_to_quoted_string(clauses, converter, collapse_structs: true)}
-            """
+            fix =
+              case mod do
+                String.Chars ->
+                  """
+                  You either passed the wrong value or you must:
+
+                  1. convert the given value to a string explicitly
+                     (use inspect/1 if you want to convert any data structure to a string)
+                  2. implement the String.Chars protocol
+                  """
+
+                Enumerable ->
+                  """
+                  You either passed the wrong value or you must:
+
+                  1. convert the given value to an Enumerable explicitly
+                  2. implement the Enumerable protocol
+                  """
+
+                _ ->
+                  """
+                  You either passed the wrong value or you forgot to implement the protocol.
+                  """
+              end
+
+            {"""
+             but expected a type that implements the #{inspect(mod)} protocol.
+             #{fix}\
+             """,
+             """
+
+             #{hint()} the #{inspect(mod)} protocol is implemented for the following types:
+             #{clauses_args_to_quoted_string(clauses, converter, collapse_structs: true)}
+             """}
           end
 
         true ->
-          """
-          but expected one of:
-          #{clauses_args_to_quoted_string(clauses, converter, [])}
-          """
+          {"""
+           but expected one of:
+           #{clauses_args_to_quoted_string(clauses, converter, [])}
+           """, ""}
       end
 
     %{
@@ -1066,7 +1097,7 @@ defmodule Module.Types.Apply do
           """,
           explanation,
           format_traces(traces),
-          format_hints(hints)
+          impls
         ])
     }
   end
@@ -1252,7 +1283,7 @@ defmodule Module.Types.Apply do
           common = intersection(actual, expected)
 
           uncommon_doc =
-            difference(actual, common)
+            difference(actual, expected)
             |> to_quoted()
             |> Code.Formatter.to_algebra()
             |> ansi_red()

lib/elixir/lib/module/types/descr.ex

@@ -27,11 +27,8 @@ defmodule Module.Types.Descr do
   @bit_top (1 <<< 7) - 1
   @bit_number @bit_integer ||| @bit_float
 
-  # Remark: those use AST for BDDs
-  defmacrop bdd_leaf(arg1, arg2), do: {arg1, arg2}
-
-  defmacrop domain_key(key),
-    do: {:domain_key, key}
+  defmacro bdd_leaf(arg1, arg2), do: {arg1, arg2}
+  defmacro domain_key(key), do: {:domain_key, key}
 
   @domain_key_types [
     {:domain_key, :binary},
@@ -454,11 +451,7 @@ defmodule Module.Types.Descr do
   defp intersection(:map, v1, v2), do: map_intersection(v1, v2)
   defp intersection(:optional, 1, 1), do: 1
   defp intersection(:tuple, v1, v2), do: tuple_intersection(v1, v2)
-
-  defp intersection(:fun, v1, v2) do
-    bdd = fun_intersection(v1, v2)
-    if bdd == :bdd_bot, do: 0, else: bdd
-  end
+  defp intersection(:fun, v1, v2), do: fun_intersection(v1, v2)
 
   defp intersection(:dynamic, v1, v2) do
     descr = dynamic_intersection(v1, v2)
@@ -548,11 +541,7 @@ defmodule Module.Types.Descr do
   defp difference(:map, v1, v2), do: map_difference(v1, v2)
   defp difference(:optional, 1, 1), do: 0
   defp difference(:tuple, v1, v2), do: tuple_difference(v1, v2)
-
-  defp difference(:fun, v1, v2) do
-    bdd = fun_difference(v1, v2)
-    if bdd == :bdd_bot, do: 0, else: bdd
-  end
+  defp difference(:fun, v1, v2), do: fun_difference(v1, v2)
 
   @doc """
   Compute the negation of a type.
@@ -4425,23 +4414,7 @@ defmodule Module.Types.Descr do
 
   ## BDD helpers
 
-  defp bdd_map(bdd, fun) do
-    case bdd do
-      :bdd_bot ->
-        :bdd_bot
-
-      :bdd_top ->
-        :bdd_top
-
-      {_, _} ->
-        fun.(bdd)
-
-      {literal, left, union, right} ->
-        {fun.(literal), bdd_map(left, fun), bdd_map(union, fun), bdd_map(right, fun)}
-    end
-  end
-
-  defp bdd_union(bdd1, bdd2) do
+  def bdd_union(bdd1, bdd2) do
     case {bdd1, bdd2} do
       {:bdd_top, _bdd} ->
         :bdd_top
@@ -4475,10 +4448,14 @@ defmodule Module.Types.Descr do
           {:eq, _, _} ->
             bdd1
         end
+        |> case do
+          {_, :bdd_top, _, :bdd_top} -> :bdd_top
+          other -> other
+        end
     end
   end
 
-  defp bdd_difference(bdd1, bdd2) do
+  def bdd_difference(bdd1, bdd2) do
     case {bdd1, bdd2} do
       {_bdd, :bdd_top} ->
         :bdd_bot
@@ -4495,19 +4472,58 @@ defmodule Module.Types.Descr do
       _ ->
         case bdd_compare(bdd1, bdd2) do
           {:lt, {lit1, c1, u1, d1}, bdd2} ->
-            {lit1, bdd_difference(bdd_union(c1, u1), bdd2), :bdd_bot,
-             bdd_difference(bdd_union(d1, u1), bdd2)}
+            {lit1, bdd_difference(c1, bdd2), bdd_difference(u1, bdd2), bdd_difference(d1, bdd2)}
 
           {:gt, bdd1, {lit2, c2, u2, d2}} ->
-            {lit2, bdd_difference(bdd1, bdd_union(c2, u2)), :bdd_bot,
-             bdd_difference(bdd1, bdd_union(d2, u2))}
+            # The proper formula is:
+            #
+            #     b1 and not (c2 or u2) : bdd_bot : b1 and not (d2 or u2)
+            #
+            # Both extremes have (b1 and not u2),
+            # so we compute it first and only once.
+            bdd1_minus_u2 = bdd_difference(bdd1, u2)
+            {lit2, bdd_difference(bdd1_minus_u2, c2), :bdd_bot, bdd_difference(bdd1_minus_u2, d2)}
 
           {:eq, {lit, c1, u1, d1}, {_, c2, u2, d2}} ->
             cond do
-              u2 == :bdd_bot and d2 == :bdd_bot ->
-                {lit, bdd_difference(c1, c2), bdd_difference(u1, c2), bdd_union(u1, d1)}
+              c2 == :bdd_bot and d2 == :bdd_bot ->
+                {lit, bdd_difference(c1, u2), bdd_difference(u1, u2), bdd_difference(d1, u2)}
 
-              u1 == u2 ->
+              u2 == :bdd_bot ->
+                cond do
+                  d2 == :bdd_bot ->
+                    {lit, bdd_difference(c1, c2), bdd_difference(u1, c2), bdd_union(u1, d1)}
+
+                  c2 == :bdd_bot ->
+                    {lit, bdd_union(u1, c1), bdd_difference(u1, d2), bdd_difference(c1, c2)}
+
+                  true ->
+                    # If d2 or c2 are bottom, we can remove one union.
+                    #
+                    # For example, if d2 is bottom, we have this BDD:
+                    #
+                    #   {l, (C1 or U1) and not C2, U1 and not C2, D1 or U1}
+                    #
+                    # Where the constrained part is:
+                    #
+                    #   (l and (C1 or U1) and not C2)
+                    #
+                    # Which expands to:
+                    #
+                    #   (l and C1 and not C2) or (l and U1 and not C2)
+                    #
+                    # Given (U1 and not C2) is already part of the uncertain/union,
+                    # we can skip (l and U1 and not C2), and we end up with:
+                    #
+                    #   {l, C1 and not C2, U1 and not C2, D1 or U1}
+                    #
+                    # Which are the formulas used above.
+                    {lit, bdd_difference(bdd_union(u1, c1), c2),
+                     bdd_difference(bdd_difference(u1, c2), d2),
+                     bdd_difference(bdd_union(u1, d1), d2)}
+                end
+
+              u1 == :bdd_bot or u1 == u2 ->
                 {lit, bdd_difference_union(c1, c2, u2), :bdd_bot,
                  bdd_difference_union(d1, d2, u2)}
 
@@ -4525,14 +4541,10 @@ defmodule Module.Types.Descr do
           {:eq, _, _} ->
             :bdd_bot
         end
-    end
-  end
-
-  defp bdd_compare(bdd1, bdd2) do
-    case {bdd_head(bdd1), bdd_head(bdd2)} do
-      {lit1, lit2} when lit1 < lit2 -> {:lt, bdd_expand(bdd1), bdd2}
-      {lit1, lit2} when lit1 > lit2 -> {:gt, bdd1, bdd_expand(bdd2)}
-      _ -> {:eq, bdd1, bdd2}
+        |> case do
+          {_, :bdd_bot, u, :bdd_bot} -> u
+          other -> other
+        end
     end
   end
 
@@ -4543,7 +4555,7 @@ defmodule Module.Types.Descr do
   defp bdd_difference_union(i, u1, u2),
     do: bdd_difference(i, bdd_union(u1, u2))
 
-  defp bdd_intersection(bdd1, bdd2) do
+  def bdd_intersection(bdd1, bdd2) do
     case {bdd1, bdd2} do
       {:bdd_top, bdd} ->
         bdd
@@ -4568,15 +4580,20 @@ defmodule Module.Types.Descr do
              bdd_intersection(bdd1, d2)}
 
           # Notice that (l ? c1, u1, d1) and (l ? c2, u2, d2) is, on paper, equivalent to
-          # [(l /\ c1) \/ u1 \/ (not l /\ d1)] and [(l /\ c2) \/ u2 \/ (not l /\ d2)]
+          # [(l and c1) or u1 or (not l and d1)] and [(l and c2) or u2 or (not l and d2)].
+          #
           # which is equivalent, by distributivity of intersection over union, to
-          # l /\ [(c1 /\ c2) \/ (c1 /\ u2) \/ (u1 /\ c2)]
-          #      \/ (u1 /\ u2)
-          #      \/ [(not l) /\ ((d1 /\ u2) \/ (d1 /\ d2) \/ (u1 /\ d2))]
+          #
+          # l and [(c1 and c2) or (c1 and u2) or (u1 and c2)]
+          #      or (u1 and u2)
+          #      or [(not l) and ((d1 and u2) or (d1 and d2) or (u1 and d2))]
+          #
           # which is equivalent, by factoring out c1 in the first disjunct, and d1 in the third, to
-          # l /\ [c1 /\ (c2 \/ u2)] \/ (u1 /\ c2)
-          #     \/ (u1 /\ u2)
-          #     \/ (not l) /\ [d1 /\ (u2 \/ d2) \/ (u1 /\ d2)]
+          #
+          # l and [c1 and (c2 or u2)] or (u1 and c2)
+          #     or (u1 and u2)
+          #     or (not l) and [d1 and (u2 or d2) or (u1 and d2)]
+          #
           # This last expression gives the following implementation:
           {:eq, {lit, c1, u1, d1}, {_, c2, u2, d2}} ->
             {lit, bdd_union(bdd_intersection_union(c1, c2, u2), bdd_intersection(u1, c2)),
@@ -4592,6 +4609,10 @@ defmodule Module.Types.Descr do
           {:eq, bdd, _} ->
             bdd
         end
+        |> case do
+          {_, :bdd_bot, u, :bdd_bot} -> u
+          other -> other
+        end
     end
   end
 
@@ -4603,15 +4624,15 @@ defmodule Module.Types.Descr do
     do: bdd_intersection(i, bdd_union(u1, u2))
 
   # Lazy negation: eliminate the union, then perform normal negation (switching leaves)
-  defp bdd_negation(:bdd_top), do: :bdd_bot
-  defp bdd_negation(:bdd_bot), do: :bdd_top
-  defp bdd_negation({_, _} = pair), do: {pair, :bdd_bot, :bdd_bot, :bdd_top}
+  def bdd_negation(:bdd_top), do: :bdd_bot
+  def bdd_negation(:bdd_bot), do: :bdd_top
+  def bdd_negation({_, _} = pair), do: {pair, :bdd_bot, :bdd_bot, :bdd_top}
 
-  defp bdd_negation({lit, c, u, d}) do
+  def bdd_negation({lit, c, u, d}) do
     {lit, bdd_negation(bdd_union(c, u)), :bdd_bot, bdd_negation(bdd_union(d, u))}
   end
 
-  defp bdd_to_dnf(bdd), do: bdd_to_dnf([], [], [], bdd)
+  def bdd_to_dnf(bdd), do: bdd_to_dnf([], [], [], bdd)
 
   defp bdd_to_dnf(acc, _pos, _neg, :bdd_bot), do: acc
   defp bdd_to_dnf(acc, pos, neg, :bdd_top), do: [{pos, neg} | acc]
@@ -4630,6 +4651,30 @@ defmodule Module.Types.Descr do
     |> bdd_to_dnf(pos, [lit | neg], d)
   end
 
+  defp bdd_compare(bdd1, bdd2) do
+    case {bdd_head(bdd1), bdd_head(bdd2)} do
+      {lit1, lit2} when lit1 < lit2 -> {:lt, bdd_expand(bdd1), bdd2}
+      {lit1, lit2} when lit1 > lit2 -> {:gt, bdd1, bdd_expand(bdd2)}
+      _ -> {:eq, bdd1, bdd2}
+    end
+  end
+
+  defp bdd_map(bdd, fun) do
+    case bdd do
+      :bdd_bot ->
+        :bdd_bot
+
+      :bdd_top ->
+        :bdd_top
+
+      {_, _} ->
+        fun.(bdd)
+
+      {literal, left, union, right} ->
+        {fun.(literal), bdd_map(left, fun), bdd_map(union, fun), bdd_map(right, fun)}
+    end
+  end
+
   @compile {:inline, bdd_expand: 1, bdd_head: 1}
   defp bdd_expand({_, _} = pair), do: {pair, :bdd_top, :bdd_bot, :bdd_bot}
   defp bdd_expand(bdd), do: bdd

lib/elixir/lib/module/types/helpers.ex

@@ -91,29 +91,6 @@ defmodule Module.Types.Helpers do
         "var.fun()" (with parentheses) means "var" is an atom()
         """
 
-      :interpolation ->
-        """
-
-        #{hint()} string interpolation uses the String.Chars protocol to \
-        convert a data structure into a string. Either convert the data type into a \
-        string upfront or implement the protocol accordingly
-        """
-
-      :generator ->
-        """
-
-        #{hint()} for-comprehensions use the Enumerable protocol to traverse \
-        data structures. Either convert the data type into a list (or another Enumerable) \
-        or implement the protocol accordingly
-        """
-
-      :into ->
-        """
-
-        #{hint()} the :into option in for-comprehensions use the Collectable protocol to \
-        build its result. Either pass a valid data type or implement the protocol accordingly
-        """
-
       :anonymous_rescue ->
         """
 

lib/elixir/lib/protocol.ex

@@ -267,6 +267,8 @@ defmodule Protocol do
 
   @optional_callbacks __deriving__: 2
 
+  @elixir_checker_version :elixir_erl.checker_version()
+
   @doc false
   defmacro def(signature)
 
@@ -564,31 +566,34 @@ defmodule Protocol do
     # Ensure the types are sorted so the compiled beam is deterministic
     types = Enum.sort(types)
 
-    with {:ok, any, definitions, signatures, compile_info} <- beam_protocol(protocol),
-         {:ok, definitions, signatures} <-
-           consolidate(protocol, any, definitions, signatures, types),
-         do: compile(definitions, signatures, compile_info)
+    with {:ok, any, definitions, checker, compile_info} <- beam_protocol(protocol),
+         {:ok, definitions, checker} <-
+           consolidate(protocol, any, definitions, checker, types),
+         do: compile(definitions, checker, compile_info)
   end
 
   defp beam_protocol(protocol) do
-    chunk_ids = [:debug_info, [?D, ?o, ?c, ?s]]
+    chunk_ids = [:debug_info, [?E, ?x, ?C, ?k], [?D, ?o, ?c, ?s]]
     opts = [:allow_missing_chunks]
 
     case :beam_lib.chunks(beam_file(protocol), chunk_ids, opts) do
-      {:ok, {^protocol, [{:debug_info, debug_info} | chunks]}} ->
+      {:ok, {^protocol, [{:debug_info, debug_info}, {_, checker} | chunks]}} ->
         {:debug_info_v1, _backend, {:elixir_v1, module_map, specs}} = debug_info
         %{attributes: attributes, definitions: definitions} = module_map
 
-        # Protocols in precompiled archives may not have signatures, so we default to an empty map.
-        # TODO: Remove this on Elixir v1.23.
-        signatures = Map.get(module_map, :signatures, %{})
-
-        chunks = :lists.filter(fn {_name, value} -> value != :missing_chunk end, chunks)
-        chunks = :lists.map(fn {name, value} -> {List.to_string(name), value} end, chunks)
-
         case attributes[:__protocol__] do
           [fallback_to_any: any] ->
-            {:ok, any, definitions, signatures, {module_map, specs, chunks}}
+            checker =
+              with true <- is_binary(checker),
+                   {@elixir_checker_version, contents} <- :erlang.binary_to_term(checker) do
+                contents
+              else
+                _ -> nil
+              end
+
+            chunks = :lists.filter(fn {_name, value} -> value != :missing_chunk end, chunks)
+            chunks = :lists.map(fn {name, value} -> {List.to_string(name), value} end, chunks)
+            {:ok, any, definitions, checker, {module_map, specs, chunks}}
 
           _ ->
             {:error, :not_a_protocol}
@@ -607,7 +612,7 @@ defmodule Protocol do
   end
 
   # Consolidate the protocol for faster implementations and fine-grained type information.
-  defp consolidate(protocol, fallback_to_any?, definitions, signatures, types) do
+  defp consolidate(protocol, fallback_to_any?, definitions, checker, types) do
     case List.keytake(definitions, {:__protocol__, 1}, 0) do
       {protocol_def, definitions} ->
         types = if fallback_to_any?, do: types, else: List.delete(types, Any)
@@ -623,11 +628,24 @@ defmodule Protocol do
         protocol_def = change_protocol(protocol_def, types)
         impl_for = change_impl_for(impl_for, protocol, types)
         struct_impl_for = change_struct_impl_for(struct_impl_for, protocol, types, structs)
-        new_signatures = new_signatures(definitions, protocol_funs, protocol, types)
-
         definitions = [protocol_def, impl_for, impl_for!, struct_impl_for] ++ definitions
-        signatures = Enum.into(new_signatures, signatures)
-        {:ok, definitions, signatures}
+
+        checker =
+          if checker do
+            update_in(checker.exports, fn exports ->
+              signatures = new_signatures(definitions, protocol_funs, protocol, types)
+
+              for {fun, info} <- exports do
+                if sig = Map.get(signatures, fun) do
+                  {fun, %{info | sig: sig}}
+                else
+                  {fun, info}
+                end
+              end
+            end)
+          end
+
+        {:ok, definitions, checker}
 
       nil ->
         {:error, :not_a_protocol}
@@ -680,10 +698,12 @@ defmodule Protocol do
         {fun_arity, {:strong, nil, [{[domain | rest], Descr.dynamic()}]}}
       end
 
-    [
-      {{:impl_for, 1}, {:strong, [Descr.term()], impl_for}},
-      {{:impl_for!, 1}, {:strong, [domain], impl_for!}}
-    ] ++ new_signatures
+    Map.new(
+      [
+        {{:impl_for, 1}, {:strong, [Descr.term()], impl_for}},
+        {{:impl_for!, 1}, {:strong, [domain], impl_for!}}
+      ] ++ new_signatures
+    )
   end
 
   defp get_protocol_functions({_name, _kind, _meta, clauses}) do
@@ -752,11 +772,9 @@ defmodule Protocol do
   end
 
   # Finally compile the module and emit its bytecode.
-  defp compile(definitions, signatures, {module_map, specs, docs_chunk}) do
-    # Protocols in precompiled archives may not have signatures, so we default to an empty map.
-    # TODO: Remove this on Elixir v1.23.
-    module_map = %{module_map | definitions: definitions} |> Map.put(:signatures, signatures)
-    {:ok, :elixir_erl.consolidate(module_map, specs, docs_chunk)}
+  defp compile(definitions, checker, {module_map, specs, docs_chunk}) do
+    module_map = %{module_map | definitions: definitions}
+    {:ok, :elixir_erl.consolidate(module_map, checker, specs, docs_chunk)}
   end
 
   ## Definition callbacks

lib/elixir/pages/getting-started/structs.md

@@ -86,7 +86,7 @@ iex> john = %User{name: "John", age: 27}
 iex> updates = [name: "Jane", age: 30]
 [name: "Jane", age: 30]
 iex> struct!(john, updates)
-%User{age: 27, name: "Jane"}
+%User{age: 30, name: "Jane"}
 ```
 
 `struct!/2` will raise an error if you try to set invalid fields:

lib/elixir/pages/references/compatibility-and-deprecations.md

@@ -171,7 +171,7 @@ Version | Deprecated feature                                  | Replaced by (ava
 [v1.5]  | `Atom.to_char_list/1`                               | `Atom.to_charlist/1` (v1.3)
 [v1.5]  | `Enum.filter_map/3`                                 | `Enum.filter/2` + `Enum.map/2` or `for/1` comprehensions (v1.0)
 [v1.5]  | `Float.to_char_list/1`                              | `Float.to_charlist/1` (v1.3)
-[v1.5]  | `GenEvent` module                                   | `Supervisor` and `GenServer` (v1.0);<br/>[`GenStage`](https://hex.pm/packages/gen_stage) (v1.3);<br/>[`:gen_event`](`:gen_event`) (Erlang/OTP 17)
+[v1.5]  | `GenEvent` module                                   | `Supervisor` and `GenServer` (v1.0)
 [v1.5]  | `<%=` in middle and end expressions in `EEx`        | Use `<%` (`<%=` is allowed only in start expressions) (v1.0)
 [v1.5]  | `:as_char_lists` value in `t:Inspect.Opts.t/0` type | `:as_charlists` value (v1.3)
 [v1.5]  | `:char_lists` key in `t:Inspect.Opts.t/0` type      | `:charlists` key (v1.3)

lib/elixir/src/elixir_erl.erl

@@ -5,11 +5,14 @@
 %% Compiler backend to Erlang.
 
 -module(elixir_erl).
--export([elixir_to_erl/1, elixir_to_erl/2, definition_to_anonymous/5, compile/1, consolidate/3,
-         get_ann/1, debug_info/4, scope/2, format_error/1]).
+-export([elixir_to_erl/1, elixir_to_erl/2, definition_to_anonymous/5, compile/2, consolidate/4,
+         get_ann/1, debug_info/4, scope/2, checker_version/0, format_error/1]).
 -include("elixir.hrl").
 -define(typespecs, 'Elixir.Kernel.Typespec').
 
+checker_version() ->
+  elixir_checker_v3.
+
 %% debug_info callback
 
 debug_info(elixir_v1, _Module, none, _Opts) ->
@@ -132,14 +135,14 @@ scope(_Meta, ExpandCaptures) ->
 
 %% Static compilation hook, used in protocol consolidation
 
-consolidate(Map, TypeSpecs, DocsChunk) ->
-  {Prefix, Forms, Def, _Defmacro, _Macros} = dynamic_form(Map, nil),
-  CheckerChunk = checker_chunk(Map, Def, chunk_opts(Map)),
+consolidate(Map, Checker, TypeSpecs, DocsChunk) ->
+  {Prefix, Forms, _Def, _Defmacro, _Macros} = dynamic_form(Map, nil),
+  CheckerChunk = checker_chunk(Checker, chunk_opts(Map)),
   load_form(Map, Prefix, Forms, TypeSpecs, DocsChunk ++ CheckerChunk).
 
 %% Dynamic compilation hook, used in regular compiler
 
-compile(#{module := Module, anno := Anno} = BaseMap) ->
+compile(#{module := Module, anno := Anno} = BaseMap, Signatures) ->
   Map =
     case elixir_erl_compiler:env_compiler_options() of
       [] -> BaseMap;
@@ -161,7 +164,7 @@ compile(#{module := Module, anno := Anno} = BaseMap) ->
 
   ChunkOpts = chunk_opts(Map),
   DocsChunk = docs_chunk(Map, Set, Module, Anno, Def, Defmacro, Types, Callbacks, ChunkOpts),
-  CheckerChunk = checker_chunk(Map, Def, ChunkOpts),
+  CheckerChunk = checker_chunk(Map, Def, Signatures, ChunkOpts),
   load_form(Map, Prefix, Forms, TypeSpecs, DocsChunk ++ CheckerChunk).
 
 chunk_opts(Map) ->
@@ -639,9 +642,13 @@ signature_to_binary(_, Name, Signature) ->
   Doc = 'Elixir.Inspect.Algebra':format('Elixir.Code':quoted_to_algebra(Quoted), infinity),
   'Elixir.IO':iodata_to_binary(Doc).
 
-checker_chunk(Map, Def, ChunkOpts) ->
-  #{deprecated := Deprecated, defines_behaviour := DefinesBehaviour,
-    signatures := Signatures, attributes := Attributes} = Map,
+checker_chunk(nil, _ChunkOpts) ->
+  [];
+checker_chunk(Contents, ChunkOpts) ->
+  [{<<"ExCk">>, term_to_binary({checker_version(), Contents}, ChunkOpts)}].
+
+checker_chunk(Map, Def, Signatures, ChunkOpts) ->
+  #{deprecated := Deprecated, defines_behaviour := DefinesBehaviour, attributes := Attributes} = Map,
   DeprecatedMap = maps:from_list(Deprecated),
 
   Exports =
@@ -662,7 +669,7 @@ checker_chunk(Map, Def, ChunkOpts) ->
     end
   },
 
-  [{<<"ExCk">>, term_to_binary({elixir_checker_v3, Contents}, ChunkOpts)}].
+  checker_chunk(Contents, ChunkOpts).
 
 prepend_behaviour_info(true, Def) -> [{{behaviour_info, 1}, []} | Def];
 prepend_behaviour_info(false, Def) -> Def.

lib/elixir/src/elixir_module.erl

@@ -219,14 +219,13 @@ compile(Meta, Module, ModuleAsCharlist, Block, Vars, Prune, E) ->
           deprecated => get_deprecated(DataBag),
           defines_behaviour => defines_behaviour(DataBag),
           impls => Impls,
-          unreachable => Unreachable,
-          signatures => Signatures
+          unreachable => Unreachable
         },
 
         compile_error_if_tainted(DataSet, E),
-        Binary = elixir_erl:compile(ModuleMap),
+        Binary = elixir_erl:compile(ModuleMap, Signatures),
         Autoload = Forceload or proplists:get_value(autoload, CompileOpts, false),
-        spawn_parallel_checker(CheckerInfo, Module, ModuleMap, BeamLocation),
+        spawn_parallel_checker(CheckerInfo, Module, ModuleMap, Signatures, BeamLocation),
         {Binary, PersistedAttributes, Autoload}
       end),
 
@@ -581,15 +580,15 @@ checker_info() ->
     _ -> 'Elixir.Module.ParallelChecker':get()
   end.
 
-spawn_parallel_checker({_, nil}, _Module, _ModuleMap, _BeamLocation) ->
+spawn_parallel_checker({_, nil}, _Module, _ModuleMap, _Signatures, _BeamLocation) ->
   ok;
-spawn_parallel_checker(CheckerInfo, Module, ModuleMap, BeamLocation) ->
+spawn_parallel_checker(CheckerInfo, Module, ModuleMap, Signatures, BeamLocation) ->
   Log =
     case erlang:get(elixir_code_diagnostics) of
       {_, false} -> false;
       _ -> true
     end,
-  'Elixir.Module.ParallelChecker':spawn(CheckerInfo, Module, ModuleMap, BeamLocation, Log).
+  'Elixir.Module.ParallelChecker':spawn(CheckerInfo, Module, ModuleMap, Signatures, BeamLocation, Log).
 
 make_module_available(Module, Binary, Loaded) ->
   case get(elixir_module_binaries) of

lib/elixir/src/elixir_tokenizer.erl

@@ -876,8 +876,18 @@ handle_unary_op(Rest, Line, Column, Kind, Length, Op, Scope, Tokens) ->
       Token = {identifier, {Line, Column, nil}, Op},
       tokenize(Remaining, Line, Column + Length + Extra, Scope, [Token | Tokens]);
     {Remaining, Extra} ->
+      NewScope =
+        %% TODO: Remove these deprecations on Elixir v2.0
+        case Op of
+          '~~~' ->
+            Msg = "~~~ is deprecated. Use Bitwise.bnot/1 instead for clarity",
+            prepend_warning(Line, Column, Msg, Scope);
+          _ ->
+            Scope
+        end,
+
       Token = {Kind, {Line, Column, nil}, Op},
-      tokenize(Remaining, Line, Column + Length + Extra, Scope, [Token | Tokens])
+      tokenize(Remaining, Line, Column + Length + Extra, NewScope, [Token | Tokens])
   end.
 
 handle_op([$: | Rest], Line, Column, _Kind, Length, Op, Scope, Tokens) when ?is_space(hd(Rest)) ->
@@ -897,10 +907,6 @@ handle_op(Rest, Line, Column, Kind, Length, Op, Scope, Tokens) ->
             Msg = "^^^ is deprecated. It is typically used as xor but it has the wrong precedence, use Bitwise.bxor/2 instead",
             prepend_warning(Line, Column, Msg, Scope);
 
-          '~~~' ->
-            Msg = "~~~ is deprecated. Use Bitwise.bnot/1 instead for clarity",
-            prepend_warning(Line, Column, Msg, Scope);
-
           '<|>' ->
             Msg = "<|> is deprecated. Use another pipe-like operator",
             prepend_warning(Line, Column, Msg, Scope);

lib/elixir/src/elixir_utils.erl

@@ -127,7 +127,7 @@ change_posix_time(Name, Time) when is_integer(Time) ->
 change_universal_time(Name, {{Y, M, D}, {H, Min, Sec}}=Time)
     when is_integer(Y), is_integer(M), is_integer(D),
          is_integer(H), is_integer(Min), is_integer(Sec) ->
-  file:write_file_info(Name, #file_info{mtime=Time}, [{time, universal}]).
+  file:write_file_info(Name, #file_info{mtime=Time}, [raw, {time, universal}]).
 
 relative_to_cwd(Path) ->
   try elixir_config:get(relative_paths) of

lib/elixir/test/elixir/kernel_test.exs

@@ -1484,6 +1484,11 @@ defmodule KernelTest do
       assert output =~ "3"
     end
 
+    test "prints the given expression with complex options" do
+      output = capture_io(fn -> assert dbg(123, [] ++ []) == 123 end)
+      assert output =~ "kernel_test.exs"
+    end
+
     test "doesn't print any colors if :syntax_colors is []" do
       output =
         capture_io(fn ->

lib/elixir/test/elixir/module/types/descr_test.exs

@@ -16,8 +16,6 @@ defmodule Module.Types.DescrTest do
 
   import Module.Types.Descr, except: [fun: 1]
 
-  defmacrop domain_key(key), do: {:domain_key, key}
-
   defp number(), do: union(integer(), float())
   defp empty_tuple(), do: tuple([])
   defp tuple_of_size_at_least(n) when is_integer(n), do: open_tuple(List.duplicate(term(), n))
@@ -2506,6 +2504,20 @@ defmodule Module.Types.DescrTest do
       assert subtype?(map2, map1)
     end
 
+    test "map intersection and then difference" do
+      actual = open_map(__struct__: atom(), __exception__: atom([true]))
+
+      expected =
+        for i <- 1..50 do
+          name = :"name_#{i}"
+          closed_map([__struct__: atom([name])] ++ [{name, binary()}])
+        end
+        |> Enum.reduce(&union/2)
+
+      common = intersection(actual, expected)
+      difference(actual, common)
+    end
+
     test "struct difference" do
       entries =
         [

lib/elixir/test/elixir/module/types/infer_test.exs

@@ -23,10 +23,10 @@ defmodule Module.Types.InferTest do
         []
       )
 
-    {:ok, {_, [debug_info: chunk]}} = :beam_lib.chunks(binary, [:debug_info])
-    {:debug_info_v1, backend, data} = chunk
-    {:ok, %{signatures: signatures}} = backend.debug_info(:elixir_v1, module, data, [])
-    signatures
+    version = :elixir_erl.checker_version()
+    {:ok, {_, [{~c"ExCk", chunk}]}} = :beam_lib.chunks(binary, [~c"ExCk"])
+    {^version, data} = :erlang.binary_to_term(chunk)
+    for {fun, %{sig: sig}} <- data.exports, into: %{}, do: {fun, sig}
   end
 
   test "infer types from patterns", config do

lib/elixir/test/elixir/module/types/integration_test.exs

@@ -449,10 +449,9 @@ defmodule Module.Types.IntegrationTest do
 
                 -:hello-
 
-            but the protocol was not yet implemented for any type and therefore will always fail. \
-        This error typically happens within libraries that define protocols and will disappear as \
-        soon as there is one implementation. If you expect the protocol to be implemented later on, \
-        you can define an implementation specific for development/test.
+            but the NoImplProtocol protocol was not yet implemented for any type and therefore will always fail.
+
+            This warning will disappear once you define a implementation. If the protocol is part of a library, you may define a dummy implementation for development/test.
 
             typing violation found at:
             │
@@ -478,30 +477,6 @@ defmodule Module.Types.IntegrationTest do
       }
 
       warnings = [
-        """
-            warning: incompatible value given to string interpolation:
-
-                data
-
-            it has type:
-
-                -dynamic(%Range{})-
-
-            but expected a type that implements the String.Chars protocol, it must be one of:
-
-                dynamic(
-                  %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or
-                    %Version.Requirement{}
-                ) or atom() or binary() or empty_list() or float() or integer() or non_empty_list(term(), term())
-
-            where "data" was given the type:
-
-                # type: dynamic(%Range{})
-                # from: a.ex:3:24
-                _.._//_ = data
-
-            hint: string interpolation uses the String.Chars protocol to convert a data structure into a string. Either convert the data type into a string upfront or implement the protocol accordingly
-        """,
         """
             warning: incompatible types given to String.Chars.to_string/1:
 
@@ -511,18 +486,47 @@ defmodule Module.Types.IntegrationTest do
 
                 -dynamic(%Range{})-
 
-            but expected a type that implements the String.Chars protocol, it must be one of:
+            but expected a type that implements the String.Chars protocol.
+            You either passed the wrong value or you must:
 
-                dynamic(
-                  %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or
-                    %Version.Requirement{}
-                ) or atom() or binary() or empty_list() or float() or integer() or non_empty_list(term(), term())
+            1. convert the given value to a string explicitly
+               (use inspect/1 if you want to convert any data structure to a string)
+            2. implement the String.Chars protocol
 
             where "data" was given the type:
 
                 # type: dynamic(%Range{})
                 # from: a.ex:2:24
                 _.._//_ = data
+
+            hint: the String.Chars protocol is implemented for the following types:
+
+                dynamic(
+                  %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or
+                    %Version.Requirement{}
+                ) or atom() or binary() or empty_list() or float() or integer() or non_empty_list(term(), term())
+        """,
+        """
+            warning: incompatible value given to string interpolation:
+
+                data
+
+            it has type:
+
+                -dynamic(%Range{})-
+
+            but expected a type that implements the String.Chars protocol.
+            You either passed the wrong value or you must:
+
+            1. convert the given value to a string explicitly
+               (use inspect/1 if you want to convert any data structure to a string)
+            2. implement the String.Chars protocol
+
+            where "data" was given the type:
+
+                # type: dynamic(%Range{})
+                # from: a.ex:3:24
+                _.._//_ = data
         """
       ]
 
@@ -551,12 +555,11 @@ defmodule Module.Types.IntegrationTest do
 
                 -dynamic(%Date{})-
 
-            but expected a type that implements the Enumerable protocol, it must be one of:
+            but expected a type that implements the Enumerable protocol.
+            You either passed the wrong value or you must:
 
-                dynamic(
-                  %Date.Range{} or %File.Stream{} or %GenEvent.Stream{} or %HashDict{} or %HashSet{} or
-                    %IO.Stream{} or %MapSet{} or %Range{} or %Stream{}
-                ) or empty_list() or fun() or non_empty_list(term(), term()) or non_struct_map()
+            1. convert the given value to an Enumerable explicitly
+            2. implement the Enumerable protocol
 
             where "date" was given the type:
 
@@ -564,7 +567,12 @@ defmodule Module.Types.IntegrationTest do
                 # from: a.ex:2:24
                 %Date{} = date
 
-            hint: for-comprehensions use the Enumerable protocol to traverse data structures. Either convert the data type into a list (or another Enumerable) or implement the protocol accordingly
+            hint: the Enumerable protocol is implemented for the following types:
+
+                dynamic(
+                  %Date.Range{} or %File.Stream{} or %GenEvent.Stream{} or %HashDict{} or %HashSet{} or
+                    %IO.Stream{} or %MapSet{} or %Range{} or %Stream{}
+                ) or empty_list() or fun() or non_empty_list(term(), term()) or non_struct_map()
         """,
         """
             warning: incompatible value given to :into option in for-comprehension:
@@ -572,6 +580,16 @@ defmodule Module.Types.IntegrationTest do
                 into: Date.utc_today()
 
             it has type:
+
+                -dynamic(%Date{})-
+
+            but expected a type that implements the Collectable protocol.
+            You either passed the wrong value or you forgot to implement the protocol.
+
+            hint: the Collectable protocol is implemented for the following types:
+
+                dynamic(%File.Stream{} or %HashDict{} or %HashSet{} or %IO.Stream{} or %MapSet{}) or binary() or
+                  empty_list() or non_empty_list(term(), term()) or non_struct_map()
         """,
         """
             warning: incompatible value given to :into option in for-comprehension:
@@ -582,12 +600,13 @@ defmodule Module.Types.IntegrationTest do
 
                 -integer()-
 
-            but expected a type that implements the Collectable protocol, it must be one of:
+            but expected a type that implements the Collectable protocol.
+            You either passed the wrong value or you forgot to implement the protocol.
+
+            hint: the Collectable protocol is implemented for the following types:
 
                 dynamic(%File.Stream{} or %HashDict{} or %HashSet{} or %IO.Stream{} or %MapSet{}) or binary() or
                   empty_list() or non_empty_list(term(), term()) or non_struct_map()
-
-            hint: the :into option in for-comprehensions use the Collectable protocol to build its result. Either pass a valid data type or implement the protocol accordingly
         """
       ]
 

lib/elixir/test/erlang/tokenizer_test.erl

@@ -16,6 +16,10 @@ tokenize_error(String) ->
   {error, Error, _, _, _} = elixir_tokenizer:tokenize(String, 1, []),
   Error.
 
+tokenize_warnings(String) ->
+  {ok, _Line, _Column, Warnings, Result, []} = elixir_tokenizer:tokenize(String, 1, []),
+  {lists:reverse(Result), Warnings}.
+
 type_test() ->
   [{int, {1, 1, 1}, "1"},
    {type_op, {1, 3, nil}, '::'},
@@ -279,3 +283,13 @@ sigil_heredoc_test() ->
 invalid_sigil_delimiter_test() ->
   {[{line, 1}, {column, 1}], "invalid sigil delimiter: ", Message} = tokenize_error("~s\\"),
   true = lists:prefix("\"\\\" (column 3, code point U+005C)", lists:flatten(Message)).
+
+deprecated_operators_test() ->
+  {
+    [{xor_op, {1, 1, nil}, '^^^'}, {int, {1, 4, 1}, "1"}],
+    [{{1, 1}, "^^^ is deprecated. It is typically used as xor but it has the wrong precedence, use Bitwise.bxor/2 instead"}]
+  } = tokenize_warnings("^^^1"),
+  {
+    [{unary_op, {1, 1, nil}, '~~~'}, {int, {1, 4, 1}, "1"}],
+    [{{1, 1}, "~~~ is deprecated. Use Bitwise.bnot/1 instead for clarity"}]
+  } = tokenize_warnings("~~~1").

lib/ex_unit/test/ex_unit/capture_log_test.exs

@@ -70,15 +70,15 @@ defmodule ExUnit.CaptureLogTest do
       end)
 
     assert logged
-    assert logged =~ "[info] one\n"
-    assert logged =~ "[warning] two\n"
-    assert logged =~ "[debug] three\n"
-    assert logged =~ "[error] one\n"
+    assert logged =~ "[info] one"
+    assert logged =~ "[warning] two"
+    assert logged =~ "[debug] three"
+    assert logged =~ "[error] one"
 
     receive do
       {:nested, logged} ->
-        assert logged =~ "[error] one\n"
-        refute logged =~ "[warning] two\n"
+        assert logged =~ "[error] one"
+        refute logged =~ "[warning] two"
     end
   end
 

lib/ex_unit/test/ex_unit_test.exs

@@ -375,9 +375,9 @@ defmodule ExUnitTest do
     end
 
     output = capture_io(&ExUnit.run/0)
-    refute output =~ "[debug] one\n"
-    assert output =~ "[debug] two\n"
-    assert output =~ "[debug] three\n"
+    refute output =~ "[debug] one"
+    assert output =~ "[debug] two"
+    assert output =~ "[debug] three"
   end
 
   test "supports multi errors" do

lib/logger/lib/logger.ex

@@ -126,10 +126,6 @@ defmodule Logger do
 
     * `:registered_name` - the process registered name as an atom
 
-    * `:process_label` - (available from Erlang/OTP 27+) an arbitrary term
-      which can be added to a process with `Process.set_label/1` for
-      debugging purposes
-
     * `:domain` - a list of domains for the logged message. For example,
       all Elixir reports default to `[:elixir]`. Erlang reports may start
       with `[:otp]` or `[:sasl]`

lib/logger/lib/logger/formatter.ex

@@ -244,7 +244,20 @@ defmodule Logger.Formatter do
     case if(is_function(enabled, 0), do: enabled.(), else: enabled) do
       true ->
         color = md[:ansi_color] || Map.fetch!(colors, level)
-        [IO.ANSI.format_fragment(color, true), data | IO.ANSI.reset()]
+        fragment = IO.ANSI.format_fragment(color, true)
+        data = IO.iodata_to_binary(data)
+        size = byte_size(data)
+
+        cond do
+          :binary.at(data, size - 2) == ?\r and :binary.at(data, size - 1) == ?\n ->
+            [fragment, binary_part(data, 0, size - 2), IO.ANSI.reset() | "\r\n"]
+
+          :binary.at(data, size - 1) == ?\n ->
+            [fragment, binary_part(data, 0, size - 1), IO.ANSI.reset(), ?\n]
+
+          true ->
+            [fragment, data | IO.ANSI.reset()]
+        end
 
       false ->
         data

lib/logger/test/logger/formatter_test.exs

@@ -97,6 +97,26 @@ defmodule Logger.FormatterTest do
              |> format(formatter)
              |> IO.chardata_to_string() =~ ~r"\d\d\d message"
     end
+
+    test "handles colorize with newlines" do
+      {_, formatter} =
+        new(
+          format: "$message",
+          colors: [enabled: true]
+        )
+
+      assert %{level: :warning, msg: {:string, "message"}, meta: %{}}
+             |> format(formatter)
+             |> IO.chardata_to_string() == "\e[33mmessage\e[0m"
+
+      assert %{level: :warning, msg: {:string, "message\n"}, meta: %{}}
+             |> format(formatter)
+             |> IO.chardata_to_string() == "\e[33mmessage\e[0m\n"
+
+      assert %{level: :warning, msg: {:string, "message\r\n"}, meta: %{}}
+             |> format(formatter)
+             |> IO.chardata_to_string() == "\e[33mmessage\e[0m\r\n"
+    end
   end
 
   describe "compile + format" do

lib/logger/test/logger/translator_test.exs

@@ -228,7 +228,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Process Label: {:any, \"term\"}
-           Last message \(from #PID<\d+\.\d+\.\d+>\): :error
+           Last message \(from #PID<\d+\.\d+\.\d+>\): :error\
            """s
   end
 
@@ -301,7 +301,7 @@ defmodule Logger.TranslatorTest do
            .*
            Last message \(from #PID<\d+\.\d+\.\d+>\): :error_on_down
            State: :ok
-           Client #PID<\d+\.\d+\.\d+> is dead
+           Client #PID<\d+\.\d+\.\d+> is dead\
            """s
   end
 
@@ -317,7 +317,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Last message: {:"\$gen_cast", :error}
-           State: :ok
+           State: :ok\
            """s
   end
 
@@ -384,7 +384,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Process Label: {:any, "term"}
-           Last message: :error
+           Last message: :error\
            """s
   end
 
@@ -399,7 +399,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Last message: :error
-           State: :ok
+           State: :ok\
            """s
 
     assert_receive {:event, {:report, %{label: {:gen_event, :terminate}}}, metadata}
@@ -464,7 +464,7 @@ defmodule Logger.TranslatorTest do
            .*
            Process Label: {:any, \"term\"}
            Queue: .*
-           Postponed: \[\]
+           Postponed: \[\]\
            """s
   end
 
@@ -543,7 +543,7 @@ defmodule Logger.TranslatorTest do
            Postponed: \[\]
            State: {:started, :ok}
            Callback mode: :state_functions, state_enter: false
-           Client #PID<\d+\.\d+\.\d+> is dead
+           Client #PID<\d+\.\d+\.\d+> is dead\
            """s
   end
 
@@ -561,7 +561,7 @@ defmodule Logger.TranslatorTest do
            Queue: .*
            Postponed: \[\]
            State: {:started, :ok}
-           Callback mode: :state_functions, state_enter: false
+           Callback mode: :state_functions, state_enter: false\
            """s
   end
 
@@ -619,7 +619,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Function: &Logger.TranslatorTest.task\/1
-               Args: \[#PID<\d+\.\d+\.\d+>\]
+               Args: \[#PID<\d+\.\d+\.\d+>\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -640,7 +640,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(UndefinedFunctionError\) function :module_does_not_exist.undef/0 is undefined \(module :module_does_not_exist is not available\)
            .*
            Function: &:module_does_not_exist.undef/0
-               Args: \[\]
+               Args: \[\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -660,7 +660,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(UndefinedFunctionError\) function Logger.TranslatorTest.undef/0 is undefined or private
            .*
            Function: &Logger.TranslatorTest.undef/0
-               Args: \[\]
+               Args: \[\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -688,7 +688,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(ErlangError\) Erlang error: :foo
            .*
            Function: &:erlang\.error/1
-               Args: \[%ErlangError{.*}\]
+               Args: \[%ErlangError{.*}\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -708,7 +708,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(ArgumentError\) argument error
            .*
            Function: &:erlang\.error/1
-               Args: \[:badarg\]
+               Args: \[:badarg\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -728,7 +728,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(stop\) :abnormal
            .*
            Function: &:erlang\.exit/1
-               Args: \[:abnormal\]
+               Args: \[:abnormal\]\
            """s
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -755,26 +755,22 @@ defmodule Logger.TranslatorTest do
              .*
              Process Label: {:any, \"term\"}
              Function: &Logger.TranslatorTest.task\/2
-                 Args: \[#PID<\d+\.\d+\.\d+>\, .*]
+                 Args: \[#PID<\d+\.\d+\.\d+>\, .*]\
              """s
   end
 
   test "translates application start" do
     assert capture_log(fn ->
-             Application.start(:eex)
+             :ok = Application.start(:eex)
              Application.stop(:eex)
-           end) =~ """
-           Application eex started at #{inspect(node())}
-           """
+           end) =~ "Application eex started at #{inspect(node())}"
   end
 
   test "translates application stop" do
     assert capture_log(fn ->
              :ok = Application.start(:eex)
              Application.stop(:eex)
-           end) =~ """
-           Application eex exited: :stopped
-           """
+           end) =~ "Application eex exited: :stopped"
   end
 
   test "translates bare process crashes" do
@@ -810,7 +806,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Initial Call: Logger.TranslatorTest.task/2
-           Ancestors: \[#PID<\d+\.\d+\.\d+>\]
+           Ancestors: \[#PID<\d+\.\d+\.\d+>\]\
            """s
 
     assert_receive {:event, {:report, %{label: {:proc_lib, :crash}}}, process_metadata}
@@ -854,7 +850,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(RuntimeError\) oops
            .*
            Initial Call: Logger.TranslatorTest.task/2
-           Ancestors: \[#PID<\d+\.\d+\.\d+>\]
+           Ancestors: \[#PID<\d+\.\d+\.\d+>\]\
            """s
 
     assert_receive {:event, {:report, %{label: {:proc_lib, :crash}}}, process_metadata}
@@ -881,7 +877,7 @@ defmodule Logger.TranslatorTest do
            .*
            Initial Call: Logger.TranslatorTest.task/2
            Process Label: {:any, \"term\"}
-           Ancestors: \[#PID<\d+\.\d+\.\d+>\]
+           Ancestors: \[#PID<\d+\.\d+\.\d+>\]\
            """s
 
     assert_receive {:event, {:report, %{label: {:proc_lib, :crash}}}, process_metadata}
@@ -905,7 +901,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Process #PID<\d+\.\d+\.\d+> terminating
            \*\* \(RuntimeError\) oops
            .*
-           Ancestors: \[#PID<\d+\.\d+\.\d+>\]
+           Ancestors: \[#PID<\d+\.\d+\.\d+>\]\
            """s
 
     assert_receive {:event, {:report, %{label: {:proc_lib, :crash}}}, process_metadata}
@@ -926,7 +922,7 @@ defmodule Logger.TranslatorTest do
                #PID<\d+\.\d+\.\d+>
                    Initial Call: Logger.TranslatorTest.sleep/1
                    Current Call: Logger.TranslatorTest.sleep/1
-                   Ancestors: \[#PID<\d+\.\d+\.\d+>, #PID<\d+\.\d+\.\d+>\]
+                   Ancestors: \[#PID<\d+\.\d+\.\d+>, #PID<\d+\.\d+\.\d+>\]\
            """
   end
 
@@ -949,7 +945,7 @@ defmodule Logger.TranslatorTest do
                Logger.TranslatorTest \(#PID<\d+\.\d+\.\d+>\)
                    Initial Call: Logger.TranslatorTest.sleep/1
                    Current Call: Logger.TranslatorTest.sleep/1
-                   Ancestors: \[#PID<\d+\.\d+\.\d+>, #PID<\d+\.\d+\.\d+>\]
+                   Ancestors: \[#PID<\d+\.\d+\.\d+>, #PID<\d+\.\d+\.\d+>\]\
            """
   end
 
@@ -1016,7 +1012,7 @@ defmodule Logger.TranslatorTest do
            Start Call: Task.start_link\(Logger.TranslatorTest, :sleep, \[#PID<\d+\.\d+\.\d+>\]\)
            Restart: :permanent
            Shutdown: 5000
-           Type: :worker
+           Type: :worker\
            """
   end
 
@@ -1031,7 +1027,7 @@ defmodule Logger.TranslatorTest do
            end) =~ ~r"""
            \[error\] Child Logger.TranslatorTest of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) failed to start
            \*\* \(exit\) :stop
-           Start Call: Logger.TranslatorTest.error\(\)
+           Start Call: Logger.TranslatorTest.error\(\)\
            """
   end
 
@@ -1048,7 +1044,7 @@ defmodule Logger.TranslatorTest do
            \*\* \(exit\) an exception was raised:
                \*\* \(UndefinedFunctionError\) function Logger.TranslatorTest.undef/0 is undefined or private
                .*
-           Start Call: Logger.TranslatorTest.undef\(\)
+           Start Call: Logger.TranslatorTest.undef\(\)\
            """s
 
     assert_receive {:event, {:report, %{label: {:supervisor, :start_error}}}, _child_metadata}
@@ -1065,7 +1061,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child Task of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) terminated
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Task.start_link\(Kernel, :exit, \[:stop\]\)
+           Start Call: Task.start_link\(Kernel, :exit, \[:stop\]\)\
            """
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -1087,7 +1083,7 @@ defmodule Logger.TranslatorTest do
            end) =~ ~r"""
            \[error\] Child Task of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) caused shutdown
            \*\* \(exit\) :reached_max_restart_intensity
-           Start Call: Task.start_link\(Kernel, :exit, \[:stop\]\)
+           Start Call: Task.start_link\(Kernel, :exit, \[:stop\]\)\
            """
 
     assert_receive {:event, {:report, %{label: {Task.Supervisor, :terminating}}}, task_metadata}
@@ -1108,7 +1104,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child Logger.TranslatorTest of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) shut down abnormally
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Logger.TranslatorTest.abnormal\(\)
+           Start Call: Logger.TranslatorTest.abnormal\(\)\
            """
 
     assert_receive {:event, {:report, %{label: {:supervisor, :shutdown_error}}}, _child_metadata}
@@ -1128,7 +1124,7 @@ defmodule Logger.TranslatorTest do
            Start Call: Logger.TranslatorTest.abnormal\(\)
            Restart: :permanent
            Shutdown: 5000
-           Type: :worker
+           Type: :worker\
            """
 
     assert_receive {:event, {:report, %{label: {:supervisor, :shutdown_error}}}, _child_metadata}
@@ -1147,7 +1143,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child :undefined of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) shut down abnormally
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Logger.TranslatorTest.abnormal\(\)
+           Start Call: Logger.TranslatorTest.abnormal\(\)\
            """
 
     assert_receive {:event, {:report, %{label: {:supervisor, :shutdown_error}}}, _child_metadata}
@@ -1168,7 +1164,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child :undefined of Supervisor #PID<\d+\.\d+\.\d+> \(Supervisor\.Default\) shut down abnormally
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Logger.TranslatorTest.abnormal\(:extra, :args\)
+           Start Call: Logger.TranslatorTest.abnormal\(:extra, :args\)\
            """
 
     assert_receive {:event, {:report, %{label: {:supervisor, :shutdown_error}}}, _child_metadata}
@@ -1187,7 +1183,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child :undefined of Supervisor Logger.TranslatorTest shut down abnormally
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Logger.TranslatorTest.abnormal\(\)
+           Start Call: Logger.TranslatorTest.abnormal\(\)\
            """
 
     assert_receive {:event, {:report, %{label: {:supervisor, :shutdown_error}}}, _child_metadata}
@@ -1202,7 +1198,7 @@ defmodule Logger.TranslatorTest do
            end) =~ ~r"""
            \[info\] Child of Supervisor #PID<\d+\.\d+\.\d+> \(Logger\.TranslatorTest\.MyBridge\) started
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Call: Logger.TranslatorTest.MyBridge.init\(:normal\)
+           Start Call: Logger.TranslatorTest.MyBridge.init\(:normal\)\
            """
   end
 
@@ -1216,7 +1212,7 @@ defmodule Logger.TranslatorTest do
            \[error\] Child of Supervisor #PID<\d+\.\d+\.\d+> \(Logger\.TranslatorTest\.MyBridge\) terminated
            \*\* \(exit\) :stop
            Pid: #PID<\d+\.\d+\.\d+>
-           Start Module: Logger.TranslatorTest.MyBridge
+           Start Module: Logger.TranslatorTest.MyBridge\
            """
 
     assert_receive {:event, {:report, %{label: {:proc_lib, :crash}}}, task_metadata}

lib/mix/lib/mix/cli.ex

@@ -8,18 +8,18 @@ defmodule Mix.CLI do
   @doc """
   Runs Mix according to the command line arguments.
   """
-  def main(args \\ System.argv()) do
+  def main(args \\ System.argv(), mix_exs \\ System.get_env("MIX_EXS") || "mix.exs") do
     if env_variable_activated?("MIX_DEBUG") do
       IO.puts("-> Running mix CLI")
-      {time, res} = :timer.tc(&main/2, [args, true])
+      {time, res} = :timer.tc(&main/3, [args, mix_exs, true])
       IO.puts(["<- Ran mix CLI in ", Integer.to_string(div(time, 1000)), "ms"])
       res
     else
-      main(args, false)
+      main(args, mix_exs, false)
     end
   end
 
-  defp main(args, debug?) do
+  defp main(args, mix_exs, debug?) do
     Mix.start()
 
     if debug?, do: Mix.debug(true)
@@ -46,13 +46,13 @@ defmodule Mix.CLI do
         display_version()
 
       nil ->
-        proceed(args)
+        proceed(args, mix_exs)
     end
   end
 
-  defp proceed(args) do
+  defp proceed(args, mix_exs) do
     load_dot_config()
-    load_mix_exs(args)
+    load_mix_exs(args, mix_exs)
     project = Mix.Project.get()
     {task, args} = get_task(args, project)
     ensure_hex(task)
@@ -60,14 +60,12 @@ defmodule Mix.CLI do
     run_task(task, args)
   end
 
-  defp load_mix_exs(args) do
-    file = System.get_env("MIX_EXS") || "mix.exs"
-
-    if File.regular?(file) do
+  defp load_mix_exs(args, mix_exs) do
+    if is_binary(mix_exs) and File.regular?(mix_exs) do
       Mix.ProjectStack.post_config(state_loader: {:cli, List.first(args)})
       old_undefined = Code.get_compiler_option(:no_warn_undefined)
       Code.put_compiler_option(:no_warn_undefined, :all)
-      Code.compile_file(file)
+      Code.compile_file(mix_exs)
       Code.put_compiler_option(:no_warn_undefined, old_undefined)
     end
   end

lib/mix/lib/mix/compilers/elixir.ex

@@ -5,7 +5,7 @@
 defmodule Mix.Compilers.Elixir do
   @moduledoc false
 
-  @manifest_vsn 28
+  @manifest_vsn 29
   @checkpoint_vsn 4
 
   import Record
@@ -49,8 +49,8 @@ defmodule Mix.Compilers.Elixir do
     timestamp = System.os_time(:second)
     all_paths = Mix.Utils.extract_files(srcs, [:ex])
 
-    {all_modules, all_sources, all_local_exports, old_parents, old_cache_key, old_deps_config,
-     old_project_mtime, old_config_mtime, old_protocols_and_impls} =
+    {all_modules, all_sources, all_local_exports, old_parents, old_cache_key, old_cwd,
+     old_deps_config, old_project_mtime, old_config_mtime, old_protocols_and_impls} =
       parse_manifest(manifest, dest)
 
     # In case we aborted in the middle of a verification,
@@ -100,7 +100,8 @@ defmodule Mix.Compilers.Elixir do
 
     {force?, stale, new_deps_config} =
       cond do
-        !!opts[:force] or is_nil(old_deps_config) or old_cache_key != new_cache_key ->
+        !!opts[:force] or is_nil(old_deps_config) or old_cache_key != new_cache_key or
+            (Keyword.get(opts, :check_cwd, true) and old_cwd != File.cwd!()) ->
           {true, stale, deps_config(local_deps)}
 
         deps_changed? or compile_env_apps != [] ->
@@ -313,7 +314,7 @@ defmodule Mix.Compilers.Elixir do
     rescue
       _ -> {[], []}
     else
-      {@manifest_vsn, modules, sources, _, _, _, _, _, _, _} -> {modules, sources}
+      {@manifest_vsn, modules, sources, _, _, _, _, _, _, _, _} -> {modules, sources}
       _ -> {[], []}
     end
   end
@@ -432,8 +433,9 @@ defmodule Mix.Compilers.Elixir do
                 has_any_key?(modules_to_recompile, modules) ->
               # Mark the source as changed so the combination of a timestamp
               # plus removed beam files (which are removed by update_stale_entries)
-              # causes it to be recompiled
-              File.touch!(source, timestamp + 1)
+              # causes it to be recompiled. Note we don't raise use touch! because
+              # in case of checkpoints the file may have been removed.
+              File.touch(source, timestamp + 1)
               [source]
 
             size != last_size or
@@ -880,7 +882,7 @@ defmodule Mix.Compilers.Elixir do
 
   ## Manifest handling
 
-  @default_manifest {%{}, %{}, %{}, [], nil, nil, 0, 0, {%{}, %{}}}
+  @default_manifest {%{}, %{}, %{}, [], nil, nil, nil, 0, 0, {%{}, %{}}}
 
   # Similar to read_manifest, but for internal consumption and with data migration support.
   defp parse_manifest(manifest, compile_path) do
@@ -890,9 +892,9 @@ defmodule Mix.Compilers.Elixir do
       _ ->
         @default_manifest
     else
-      {@manifest_vsn, modules, sources, local_exports, parent, cache_key, deps_config,
+      {@manifest_vsn, modules, sources, local_exports, parent, cache_key, cwd, deps_config,
        project_mtime, config_mtime, protocols_and_impls} ->
-        {modules, sources, local_exports, parent, cache_key, deps_config, project_mtime,
+        {modules, sources, local_exports, parent, cache_key, cwd, deps_config, project_mtime,
          config_mtime, protocols_and_impls}
 
       # {vsn, %{module => record}, sources, ...} v22-?
@@ -951,8 +953,8 @@ defmodule Mix.Compilers.Elixir do
     File.mkdir_p!(Path.dirname(manifest))
 
     term =
-      {@manifest_vsn, modules, sources, exports, parents, cache_key, deps_config, project_mtime,
-       config_mtime, protocols_and_impls}
+      {@manifest_vsn, modules, sources, exports, parents, cache_key, File.cwd!(), deps_config,
+       project_mtime, config_mtime, protocols_and_impls}
 
     manifest_data = :erlang.term_to_binary(term, [:compressed])
     File.write!(manifest, manifest_data)

lib/mix/lib/mix/project.ex

@@ -767,7 +767,16 @@ defmodule Mix.Project do
   """
   @spec build_path(keyword) :: Path.t()
   def build_path(config \\ config()) do
-    System.get_env("MIX_BUILD_PATH") || config[:deps_build_path] || do_build_path(config)
+    cond do
+      deps_build_path = config[:deps_build_path] ->
+        deps_build_path
+
+      build_path = System.get_env("MIX_BUILD_PATH") ->
+        Path.expand(build_path)
+
+      true ->
+        do_build_path(config)
+    end
   end
 
   defp do_build_path(config) do

lib/mix/lib/mix/tasks/compile.app.ex

@@ -187,11 +187,12 @@ defmodule Mix.Tasks.Compile.App do
         |> add_compile_env(current_properties)
         |> add_modules(modules, compile_path)
 
-      contents = :io_lib.format("~p.~n", [{:application, app, properties}])
+      contents = to_erl_term({:application, app, properties})
+      :application.unload(app)
       :application.load({:application, app, properties})
 
       Mix.Project.ensure_structure()
-      File.write!(target, IO.chardata_to_string(contents))
+      File.write!(target, [contents, ?.])
       File.touch!(target, new_mtime)
 
       # If we just created the .app file, it will have touched
@@ -208,6 +209,53 @@ defmodule Mix.Tasks.Compile.App do
     end
   end
 
+  defp to_erl_term(tuple) when is_tuple(tuple) do
+    [?{, tuple |> Tuple.to_list() |> to_erl_head(), ?}]
+  end
+
+  defp to_erl_term(list) when is_list(list) do
+    [?[, to_erl_head(list), ?]]
+  end
+
+  defp to_erl_term(map) when is_map(map) do
+    inner =
+      Enum.map_intersperse(
+        :maps.to_list(:maps.iterator(map, :reversed)),
+        ?,,
+        fn {key, value} -> [to_erl_term(key), "=>", to_erl_term(value)] end
+      )
+
+    [?#, ?{, inner, ?}]
+  end
+
+  defp to_erl_term(map) when is_map(map) do
+    inner =
+      Enum.map_intersperse(
+        :maps.to_list(:maps.iterator(map, :reversed)),
+        ?,,
+        fn {key, value} -> [to_erl_term(key), "=>", to_erl_term(value)] end
+      )
+
+    [?#, ?{, inner, ?}]
+  end
+
+  defp to_erl_term(term) when is_function(term) or is_reference(term) or is_pid(term) do
+    Mix.raise(
+      "\"def application\" has a term which cannot be written to .app files: #{inspect(term)}"
+    )
+  end
+
+  defp to_erl_term(term) do
+    :io_lib.print(term)
+  end
+
+  defp to_erl_head([]), do: []
+  defp to_erl_head([h | t]), do: [to_erl_term(h) | to_erl_tail(t)]
+
+  defp to_erl_tail([h | t]), do: [?,, to_erl_term(h) | to_erl_tail(t)]
+  defp to_erl_tail([]), do: []
+  defp to_erl_tail(other), do: [?|, to_erl_term(other)]
+
   defp current_app_properties(target) do
     case :file.consult(target) do
       {:ok, [{:application, _app, properties}]} -> properties

lib/mix/lib/mix/tasks/compile.elixir.ex

@@ -71,7 +71,11 @@ defmodule Mix.Tasks.Compile.Elixir do
     * `--long-verification-threshold N` - sets the "long verification" threshold
       (in seconds) to `N` (see the docs for `Kernel.ParallelCompiler.compile/2`)
     * `--no-verification` - disables code verification, such as unused functions,
-      deprecation warnings, and type checking. It must be used alongside `MIX_DEBUG=1`
+      deprecation warnings, and type checking. It must be used solely for debugging
+      alongside `MIX_DEBUG=1`
+    * `--no-check-cwd` - (since v1.19.2) Elixir stores absolute paths in .beam files, which means
+      that relocating the project root triggers a full build. Pass this option if you don't want
+      the current working directory to be checked
     * `--purge-consolidation-path-if-stale PATH` - deletes and purges modules in the
       given protocol consolidation path if compilation is required
     * `--profile` - if set to `time`, outputs timing information of compilation steps
@@ -109,7 +113,8 @@ defmodule Mix.Tasks.Compile.Elixir do
     profile: :string,
     all_warnings: :boolean,
     verification: :boolean,
-    tracer: :keep
+    tracer: :keep,
+    check_cwd: :boolean
   ]
 
   @impl true
@@ -121,13 +126,13 @@ defmodule Mix.Tasks.Compile.Elixir do
     dest = Mix.Project.compile_path(project)
     srcs = project[:elixirc_paths]
 
-    if not is_list(srcs) do
-      Mix.raise(":elixirc_paths should be a list of paths, got: #{inspect(srcs)}")
+    if not (is_list(srcs) and Enum.all?(srcs, &is_binary/1)) do
+      Mix.shell().error(":elixirc_paths should be a list of string paths, got: #{inspect(srcs)}")
     end
 
     manifest = manifest()
     base = xref_exclude_opts(project[:elixirc_options] || [], project)
-    cache_key = {base, srcs, File.cwd!(), "--no-optional-deps" in args}
+    cache_key = {base, srcs, "--no-optional-deps" in args}
 
     opts =
       base

lib/mix/lib/mix/tasks/deps.compile.ex

@@ -102,16 +102,20 @@ defmodule Mix.Tasks.Deps.Compile do
 
     count = System.get_env("MIX_OS_DEPS_COMPILE_PARTITION_COUNT", "0") |> String.to_integer()
 
-    compiled? =
-      if count > 1 and length(deps) > 1 do
-        Mix.shell().info("mix deps.compile running across #{count} OS processes")
-        Mix.Tasks.Deps.Partition.server(deps, count, force?)
-      else
-        config = Mix.Project.deps_config()
-        true in Enum.map(deps, &compile_single(&1, force?, config))
-      end
+    # If all dependencies are local and ok, do not bother starting
+    # processes as it will likely slow everything down.
+    if count > 1 and match?([_, _ | _], deps) and
+         not Enum.all?(deps, &(Mix.Dep.ok?(&1) and not &1.scm.fetchable?())) do
+      Mix.shell().info("mix deps.compile running across #{count} OS processes")
 
-    if compiled?, do: Mix.Task.run("will_recompile"), else: :ok
+      if Mix.Tasks.Deps.Partition.server(deps, count, force?) do
+        # Each partition will trigger will_recompile but we need to trigger it here too
+        Mix.Task.run("will_recompile")
+      end
+    else
+      config = Mix.Project.deps_config()
+      Enum.each(deps, &compile_single(&1, force?, config))
+    end
   end
 
   @doc false
@@ -166,8 +170,14 @@ defmodule Mix.Tasks.Deps.Compile do
     # We should touch fetchable dependencies even if they
     # did not compile otherwise they will always be marked
     # as stale, even when there is nothing to do.
-    fetchable? = touch_fetchable(scm, opts[:build])
-    compiled? and fetchable?
+    fetchable? = touch_fetchable(scm, opts)
+
+    if compiled? and fetchable? do
+      Mix.Task.run("will_recompile")
+      true
+    else
+      false
+    end
   end
 
   defp check_unavailable!(app, scm, {:unavailable, path}) do
@@ -189,9 +199,9 @@ defmodule Mix.Tasks.Deps.Compile do
     :ok
   end
 
-  defp touch_fetchable(scm, path) do
+  defp touch_fetchable(scm, opts) do
     if scm.fetchable?() do
-      Mix.Dep.ElixirSCM.update(Path.join(path, ".mix"), scm)
+      Mix.Dep.ElixirSCM.update(Path.join(opts[:build], ".mix"), scm)
       true
     else
       false

lib/mix/lib/mix/tasks/deps.loadpaths.ex

@@ -141,7 +141,11 @@ defmodule Mix.Tasks.Deps.Loadpaths do
   defp partition([dep | deps], not_ok, compile) do
     cond do
       Mix.Dep.compilable?(dep) or (Mix.Dep.ok?(dep) and local?(dep)) ->
-        partition(deps, not_ok, [dep | compile])
+        if from_umbrella?(dep) do
+          partition(deps, not_ok, compile)
+        else
+          partition(deps, not_ok, [dep | compile])
+        end
 
       Mix.Dep.ok?(dep) ->
         partition(deps, not_ok, compile)
@@ -155,6 +159,14 @@ defmodule Mix.Tasks.Deps.Loadpaths do
     {Enum.reverse(not_ok), Enum.reverse(compile)}
   end
 
+  # Children from the umbrella are compiled sequentially by the umbrella project itself.
+  # We could start compiling them as dependencies, and therefore in parallel, but because
+  # `mix compile` in an umbrella is expected to return the diagnostics of all children,
+  # we would need a pass after compilation to compite diagnostics.
+  defp from_umbrella?(dep) do
+    dep.opts[:from_umbrella]
+  end
+
   defp reload_deps(deps) do
     deps
     |> Enum.map(& &1.app)

lib/mix/lib/mix/tasks/deps.partition.ex

@@ -7,8 +7,6 @@ defmodule Mix.Tasks.Deps.Partition do
 
   ## Server
 
-  @deps_partition_install_mix_exs ~c"deps.partition.mix.exs"
-
   def server(deps, count, force?) do
     {:ok, socket} = :gen_tcp.listen(0, [:binary, packet: :line, active: false])
 
@@ -29,41 +27,18 @@ defmodule Mix.Tasks.Deps.Partition do
     ansi_flag = if IO.ANSI.enabled?(), do: ~c"--color", else: ~c"--no-color"
     force_flag = if force?, do: ~c"--force", else: ~c"--no-force"
 
-    env_vars =
-      if Mix.install?() do
-        blob =
-          Mix.Project.config()
-          |> :erlang.term_to_binary()
-          |> :binary.bin_to_list()
-          |> Enum.join(",")
-
-        # We replicate the initialization logic from Mix.install/2 as part of mix.exs
-        File.write!(@deps_partition_install_mix_exs, """
-        config = <<#{blob}>>
-        project = :erlang.binary_to_term(config)
-
-        if compile_config = project[:compile_config] do
-          Application.put_all_env(compile_config, persistent: true)
-        end
-
-        Mix.ProjectStack.push(Mix.InstallProject, project, "nofile")
-        """)
-
-        [{~c"MIX_EXS", @deps_partition_install_mix_exs}]
-      else
-        []
-      end
-
     args = [
       ansi_flag,
       ~c"-e",
-      ~c"Mix.CLI.main",
-      ~c"deps.partition",
+      ~c"Mix.Tasks.Deps.Partition.client",
+      ~c"--",
       force_flag,
       ~c"--port",
       Integer.to_charlist(port),
       ~c"--host",
-      ~c"127.0.0.1"
+      ~c"127.0.0.1",
+      ~c"--config",
+      Mix.ProjectStack.peek() |> :erlang.term_to_binary() |> Base.url_encode64()
     ]
 
     options = [
@@ -77,7 +52,6 @@ defmodule Mix.Tasks.Deps.Partition do
         {~c"MIX_OS_CONCURRENCY_LOCK", ~c"false"},
         {~c"MIX_ENV", Atom.to_charlist(Mix.env())},
         {~c"MIX_TARGET", Atom.to_charlist(Mix.target())}
-        | env_vars
       ]
     ]
 
@@ -241,16 +215,36 @@ defmodule Mix.Tasks.Deps.Partition do
 
   ## Client
 
-  @switches [port: :integer, host: :string, force: :boolean, index: :string]
+  @switches [port: :integer, host: :string, force: :boolean, index: :string, config: :string]
 
-  @impl true
-  def run(args) do
+  def client do
     # If stdin closes, we shutdown the VM
     spawn(fn ->
       _ = IO.gets("")
       System.halt(0)
     end)
 
+    args = System.argv()
+    {opts, []} = OptionParser.parse!(args, strict: @switches)
+    peek = Keyword.fetch!(opts, :config) |> Base.url_decode64!() |> :erlang.binary_to_term()
+
+    # This is specific to Mix.install/2 and how it handles compile-time config
+    if compile_config = peek.config[:compile_config] do
+      Application.put_all_env(compile_config, persistent: true)
+    end
+
+    partition_args =
+      opts
+      |> Keyword.take([:host, :port, :index, :force])
+      |> OptionParser.to_argv()
+
+    Mix.start()
+    Mix.ProjectStack.push(peek.name, peek.config, peek.file)
+    Mix.CLI.main(["deps.partition" | partition_args], nil)
+  end
+
+  @impl true
+  def run(args) do
     {opts, []} = OptionParser.parse!(args, strict: @switches)
     host = Keyword.fetch!(opts, :host)
     port = Keyword.fetch!(opts, :port)

lib/mix/lib/mix/tasks/format.ex

@@ -33,7 +33,7 @@ defmodule Mix.Tasks.Format do
       to be used by this task. For example, `["mix.exs", "{config,lib,test}/**/*.{ex,exs}"]`.
       Patterns are expanded with `Path.wildcard/2`.
 
-    * `:excludes` (a list of paths and patterns) - specifies the files to exclude from the
+    * `:excludes` (a list of paths and patterns) (since v1.19.0) - specifies the files to exclude from the
       list of inputs to this task. For example, `["config/runtime.exs", "test/**/*.{ex,exs}"]`.
       Patterns are expanded with `Path.wildcard/2`.
 

lib/mix/test/mix/project_test.exs

@@ -46,7 +46,7 @@ defmodule Mix.ProjectTest do
 
     test "considers MIX_BUILD_PATH" do
       System.put_env("MIX_BUILD_PATH", "_build")
-      assert Mix.Project.build_path() == "_build"
+      assert Mix.Project.build_path() == Path.join(File.cwd!(), "_build")
     after
       System.delete_env("MIX_BUILD_PATH")
     end

lib/mix/test/mix/tasks/compile.app_test.exs

@@ -7,24 +7,6 @@ Code.require_file("../../test_helper.exs", __DIR__)
 defmodule Mix.Tasks.Compile.AppTest do
   use MixTest.Case
 
-  defmodule CustomProject do
-    def project do
-      [
-        app: :custom_project,
-        version: "0.2.0",
-        description: "Some UTF-8 dëscriptión"
-      ]
-    end
-
-    def application do
-      [
-        maxT: :infinity,
-        applications: [:example_app, mix: :optional],
-        extra_applications: [:logger, ex_unit: :optional]
-      ]
-    end
-  end
-
   defmodule CustomDeps do
     def project do
       [app: :custom_deps, version: "0.2.0", deps: deps()]
@@ -51,9 +33,13 @@ defmodule Mix.Tasks.Compile.AppTest do
     end
   end
 
-  defmodule InvalidProject do
+  defmodule CustomProject do
     def project do
-      [app: :invalid_project, version: "0.3.0"]
+      [
+        app: :custom_project,
+        version: "0.3.0",
+        description: "Some UTF-8 dëscriptión"
+      ]
     end
 
     def application do
@@ -124,13 +110,21 @@ defmodule Mix.Tasks.Compile.AppTest do
   test "uses custom application settings" do
     in_fixture("no_mixfile", fn ->
       Mix.Project.push(CustomProject)
+      env = [foo: [:one, "two", 3, 4], bar: [{} | %{foo: :bar}]]
+
+      Process.put(:application,
+        maxT: :infinity,
+        applications: [:example_app, mix: :optional],
+        extra_applications: [:logger, ex_unit: :optional],
+        env: env
+      )
 
       Mix.Tasks.Compile.Elixir.run([])
       Mix.Tasks.Compile.App.run([])
 
       properties = parse_resource_file(:custom_project)
-      assert Application.spec(:custom_project, :vsn) == ~c"0.2.0"
-      assert properties[:vsn] == ~c"0.2.0"
+      assert Application.spec(:custom_project, :vsn) == ~c"0.3.0"
+      assert properties[:vsn] == ~c"0.3.0"
       assert properties[:maxT] == :infinity
       assert properties[:optional_applications] == [:ex_unit, :mix]
       assert properties[:description] == ~c"Some UTF-8 dëscriptión"
@@ -138,6 +132,8 @@ defmodule Mix.Tasks.Compile.AppTest do
       assert properties[:applications] ==
                [:kernel, :stdlib, :elixir, :logger, :ex_unit, :example_app, :mix]
 
+      assert properties[:env] == [foo: [:one, "two", 3, 4], bar: [{} | %{foo: :bar}]]
+
       refute Keyword.has_key?(properties, :extra_applications)
     end)
   end
@@ -160,7 +156,7 @@ defmodule Mix.Tasks.Compile.AppTest do
 
   test "validates properties" do
     in_fixture("no_mixfile", fn ->
-      Mix.Project.push(InvalidProject)
+      Mix.Project.push(CustomProject)
 
       Process.put(:application, [:not_a_keyword, applications: []])
       message = "Application configuration returned from application/0 should be a keyword list"
@@ -252,6 +248,15 @@ defmodule Mix.Tasks.Compile.AppTest do
       assert_raise Mix.Error, message, fn ->
         Mix.Tasks.Compile.App.run([])
       end
+
+      Process.put(:application, env: [foo: make_ref()])
+
+      message =
+        ~r"\"def application\" has a term which cannot be written to \.app files: #Reference"
+
+      assert_raise Mix.Error, message, fn ->
+        Mix.Tasks.Compile.App.run([])
+      end
     end)
   end
 

lib/mix/test/mix/tasks/compile.elixir_test.exs

@@ -118,6 +118,26 @@ defmodule Mix.Tasks.Compile.ElixirTest do
     end)
   end
 
+  test "does not recompiles project if cwd changes and --no-check-cwd is given" do
+    in_fixture("no_mixfile", fn ->
+      Mix.Project.push(MixTest.Case.Sample)
+      assert Mix.Tasks.Compile.Elixir.run(["--verbose"]) == {:ok, []}
+      assert_received {:mix_shell, :info, ["Compiled lib/a.ex"]}
+      Mix.Project.pop()
+
+      old_cwd = File.cwd!()
+
+      in_tmp("new_cwd", fn ->
+        Mix.Project.push(MixTest.Case.Sample)
+        File.cp_r!(old_cwd, File.cwd!())
+
+        purge([A, B])
+        Mix.Task.clear()
+        assert {:noop, _} = Mix.Tasks.Compile.Elixir.run(["--verbose", "--no-check-cwd"])
+      end)
+    end)
+  end
+
   test "recompiles files using Mix.Project if mix.exs changes" do
     in_fixture("no_mixfile", fn ->
       Mix.Project.push(MixTest.Case.Sample, __ENV__.file)
@@ -684,9 +704,6 @@ defmodule Mix.Tasks.Compile.ElixirTest do
       Mix.State.clear_cache()
       purge([GitRepo.MixProject, PathOnGitRepo.MixProject, PathOnGitRepo.Hello])
 
-      # Unload the git repo application so we can pick the new modules definition
-      :ok = Application.unload(:git_repo)
-
       Mix.Tasks.Deps.Update.run(["--all"])
       assert File.read!("mix.lock") =~ last
 

lib/mix/test/mix/tasks/escript_test.exs

@@ -341,48 +341,67 @@ defmodule Mix.Tasks.EscriptTest do
     end)
   end
 
-  test "escript.install from Git" do
-    in_fixture("git_repo", fn ->
-      File.mkdir_p!("config")
+  for count <- [1, 2] do
+    test "escript.install from Git (with MIX_OS_DEPS_COMPILE_PARTITION_COUNT=#{count})" do
+      System.put_env("MIX_OS_DEPS_COMPILE_PARTITION_COUNT", "#{unquote(count)}")
 
-      File.write!("config/config.exs", """
-      import Config
-      config :git_repo, :escript_config, true
-      """)
+      in_fixture("deps_status", fn ->
+        File.mkdir_p!("config")
+        File.mkdir_p!("lib")
 
-      File.write!("lib/git_repo.ex", """
-      require Application
-      true = Application.compile_env!(:git_repo, :escript_config)
+        File.write!("config/config.exs", """
+        import Config
+        config :source_repo, :escript_config, true
+        """)
 
-      defmodule GitRepo.Escript do
-        def main(_argv) do
-          IO.puts("TEST")
+        File.write!("lib/source_repo.ex", """
+        require Application
+        true = Application.compile_env!(:source_repo, :escript_config)
+
+        defmodule SourceRepo.Escript do
+          def main(_argv) do
+            IO.puts("TEST")
+          end
         end
-      end
-      """)
+        """)
 
-      File.write!("mix.exs", """
-      defmodule GitRepo.MixProject do
-        use Mix.Project
+        File.write!("mix.exs", """
+        defmodule SourceRepo.MixProject do
+          use Mix.Project
 
-        def project do
-          [app: :git_repo, version: "0.1.0", escript: [main_module: GitRepo.Escript]]
+          def project do
+            [
+              app: :source_repo,
+              version: "0.1.0",
+              escript: [main_module: SourceRepo.Escript],
+              deps: [
+                {:git_repo, path: "#{MixTest.Case.fixture_path("git_repo")}"},
+                {:git_rebar, path: "#{MixTest.Case.fixture_path("git_rebar")}", manager: :rebar3},
+                {:ok, path: "deps/ok"},
+              ]
+            ]
+          end
         end
-      end
-      """)
+        """)
 
-      System.cmd("git", ~w[add .])
-      System.cmd("git", ~w[commit -m "ok"])
+        System.cmd("git", ~w[init])
+        System.cmd("git", ~w[add .])
+        System.cmd("git", ~w[commit -m "ok"])
 
-      send(self(), {:mix_shell_input, :yes?, true})
-      Mix.Tasks.Escript.Install.run(["git", File.cwd!()])
-      assert_received {:mix_shell, :info, ["Generated escript git_repo with MIX_ENV=prod"]}
+        ExUnit.CaptureIO.capture_io(fn ->
+          send(self(), {:mix_shell_input, :yes?, true})
+          Mix.Tasks.Escript.Install.run(["git", File.cwd!()])
+        end)
 
-      escript_path = Path.join([tmp_path(".mix"), "escripts", "git_repo"])
-      assert System.cmd("escript", [escript_path]) == {"TEST\n", 0}
-    end)
-  after
-    purge([GitRepo.Escript, GitRepo.MixProject, Mix.Local.Installer.MixProject])
+        assert_received {:mix_shell, :info, ["Generated escript source_repo with MIX_ENV=prod"]}
+
+        escript_path = Path.join([tmp_path(".mix"), "escripts", "source_repo"])
+        assert System.cmd("escript", [escript_path]) == {"TEST\n", 0}
+      end)
+    after
+      System.delete_env("MIX_OS_DEPS_COMPILE_PARTITION_COUNT")
+      purge([SourceRepo.Escript, SourceRepo.MixProject, Mix.Local.Installer.MixProject])
+    end
   end
 
   defp push_project_with_config(module, config \\ []) do

lib/mix/test/mix/umbrella_test.exs

@@ -66,7 +66,7 @@ defmodule Mix.UmbrellaTest do
         # Ensure we can compile and run checks
         Mix.Task.run("deps.compile")
         Mix.Task.run("deps.loadpaths")
-        Mix.Task.run("compile", ["--verbose"])
+        Mix.Task.run("compile")
 
         # Extra applications are picked even for umbrellas
         assert :code.where_is_file(~c"runtime_tools.app") != :non_existing
@@ -83,6 +83,13 @@ defmodule Mix.UmbrellaTest do
         assert_received {:mix_shell, :info, [":foo env is dev"]}
         assert_received {:mix_shell, :info, [":bar env is dev"]}
 
+        # Ensure we can compile --force
+        Mix.Task.clear()
+        Mix.Task.run("compile", ["--force"])
+        assert_received {:mix_shell, :info, ["Generated foo app"]}
+        assert_received {:mix_shell, :info, ["Generated bar app"]}
+
+        # Ensure we can start even with --no-compile
         Mix.Task.clear()
         Mix.Task.run("app.start", ["--no-compile"])
       end)
@@ -282,23 +289,6 @@ defmodule Mix.UmbrellaTest do
     end)
   end
 
-  test "compile for umbrella as dependency with os partitions" do
-    System.put_env("MIX_OS_DEPS_COMPILE_PARTITION_COUNT", "2")
-
-    in_fixture("umbrella_dep", fn ->
-      Mix.Project.in_project(:umbrella_dep, ".", fn _ ->
-        output = ExUnit.CaptureIO.capture_io(fn -> Mix.Task.run("compile") end)
-        assert output =~ ~r/\d> :foo env is prod/
-        assert output =~ ~r/\d> :bar env is prod/
-
-        assert_received {:mix_shell, :info, ["mix deps.compile running across 2 OS processes"]}
-        assert Bar.bar() == "hello world"
-      end)
-    end)
-  after
-    System.delete_env("MIX_OS_DEPS_COMPILE_PARTITION_COUNT")
-  end
-
   defmodule CycleDeps do
     def project do
       [