Bumped version

* Stopped sources from fetching metadata on every update

* Added action button to force a metadata refresh

README.md

@@ -12,6 +12,14 @@
   </sup>
 </p>
 
+<div align="center">
+
+[![](https://img.shields.io/github/license/kieraneglin/pinchflat?style=for-the-badge&color=ee512b)](LICENSE)
+[![](https://img.shields.io/github/v/release/kieraneglin/pinchflat?style=for-the-badge)](https://github.com/kieraneglin/pinchflat/releases)
+[![](https://img.shields.io/github/actions/workflow/status/kieraneglin/pinchflat/lint_and_test.yml?style=for-the-badge)](#)
+
+</div>
+
 # Your next YouTube media manager
 
 ## Table of contents:
@@ -21,6 +29,7 @@
 - [Screenshots](#screenshots)
 - [Installation](#installation)
   - [Unraid](#unraid)
+  - [Portainer](#portainer)
   - [Docker](#docker)
 - [Username and Password (authentication)](https://github.com/kieraneglin/pinchflat/wiki/Username-and-Password)
 - [Frequently asked questions](https://github.com/kieraneglin/pinchflat/wiki/Frequently-Asked-Questions)
@@ -43,7 +52,7 @@ If it doesn't work for your use case, please make a feature request! You can als
 - Powerful naming system so content is stored where and how you want it
 - Easy-to-use web interface with presets to get you started right away
 - First-class support for media center apps like Plex, Jellyfin, and Kodi
-- Supports serving RSS feeds to your favourite podcast app (beta - [docs](<https://github.com/kieraneglin/pinchflat/wiki/Podcast-RSS-Feeds-(beta)>))
+- Supports serving RSS feeds to your favourite podcast app ([docs](https://github.com/kieraneglin/pinchflat/wiki/Podcast-RSS-Feeds))
 - Automatically downloads new content from channels and playlists
   - Uses a novel approach to download new content more quickly than other apps
 - Supports downloading audio content
@@ -71,7 +80,8 @@ Simply search for Pinchflat in the Community Apps store!
 
 ### Portainer
 
-Important: See the note below about storing config on a network file share. It's preferred to store the config on a local disk if at all possible.
+> [!IMPORTANT]  
+> See the note below about storing config on a network file share. It's preferred to store the config on a local disk if at all possible.
 
 Docker Compose file:
 
@@ -110,13 +120,18 @@ docker run \
 
 You _must_ ensure the host directories you've mounted are writable by the user running the Docker container. If you get a permission error follow the steps it suggests. See [#106](https://github.com/kieraneglin/pinchflat/issues/106) for more.
 
-It's recommended to not run the container as root. Doing so can create permission issues if other apps need to work with the downloaded media. If you need to run any command as root, you can run `su` from the container's shell as there is no password set for the root user.
+> [!IMPORTANT]
+> It's not recommended to run the container as root. Doing so can create permission issues if other apps need to work with the downloaded media.
 
-### Advanced: storing Pinchflat config directory on a network share
+> [!TIP]
+> If you need to run any command as root, you can run `su` from the container's shell as there is no password set for the root user.
+
+### ADVANCED: Storing Pinchflat config directory on a network share
 
 As pointed out in [#137](https://github.com/kieraneglin/pinchflat/issues/137), SQLite doesn't like being run in WAL mode on network shares. If you're running Pinchflat on a network share, you can disable WAL mode by setting the `JOURNAL_MODE` environment variable to `delete`. This will make Pinchflat run in rollback journal mode which is less performant but should work on network shares.
 
-Changing this setting from WAL to `delete` on an existing Pinchflat instance could, conceivably, result in data loss. Only change this setting if you know what you're doing, why this is important, and are okay with possible data loss or DB corruption. Backup your database first!
+> [!CAUTION]
+> Changing this setting from WAL to `delete` on an existing Pinchflat instance could, conceivably, result in data loss. Only change this setting if you know what you're doing, why this is important, and are okay with possible data loss or DB corruption. Backup your database first!
 
 If you change this setting and it works well for you, please leave a comment on [#137](https://github.com/kieraneglin/pinchflat/issues/137)! Doubly so if it does _not_ work well.
 
@@ -131,3 +146,8 @@ This is pre-release software and anything can break at any time. I make not guar
 ## License
 
 See `LICENSE` file
+
+<!-- Images and links -->
+
+[license-badge]: https://img.shields.io/github/license/kieraneglin/pinchflat?style=for-the-badge&color=ee512b
+[license-badge-url]: LICENSE

lib/pinchflat/boot/nfo_backfill_worker.ex

@@ -1,70 +0,0 @@
-defmodule Pinchflat.Boot.NfoBackfillWorker do
-  @moduledoc false
-
-  use Oban.Worker,
-    queue: :local_metadata,
-    # This should have it running once _ever_ (until the job is pruned, anyway)
-    # NOTE: remove within the next month
-    unique: [period: :infinity, states: Oban.Job.states()],
-    tags: ["media_item", "media_metadata", "local_metadata", "data_backfill"]
-
-  import Ecto.Query, warn: false
-  require Logger
-
-  alias Pinchflat.Repo
-  alias Pinchflat.Media
-  alias Pinchflat.Media.MediaItem
-  alias Pinchflat.Metadata.NfoBuilder
-  alias Pinchflat.Metadata.MetadataFileHelpers
-
-  @doc """
-  Runs a one-off backfill job to regenerate NFO files for media items that have
-  both an NFO file and a metadata file. This is needed because NFO files weren't
-  escaping characters properly so we need to regenerate them.
-
-  This job will only run once as long as I remove it before the jobs are pruned in a month.
-
-  Returns :ok
-  """
-  @impl Oban.Worker
-  def perform(%Oban.Job{}) do
-    Logger.info("Running NFO backfill worker")
-
-    media_items = get_media_items_to_backfill()
-
-    Enum.each(media_items, fn media_item ->
-      nfo_exists = File.exists?(media_item.nfo_filepath)
-      metadata_exists = File.exists?(media_item.metadata.metadata_filepath)
-
-      if nfo_exists && metadata_exists do
-        Logger.info("NFO and metadata exist for media item #{media_item.id} - proceeding")
-
-        regenerate_nfo_for_media_item(media_item)
-      end
-    end)
-
-    :ok
-  end
-
-  defp get_media_items_to_backfill do
-    from(m in MediaItem, where: not is_nil(m.nfo_filepath))
-    |> Repo.all()
-    |> Repo.preload([:metadata, source: :media_profile])
-  end
-
-  defp regenerate_nfo_for_media_item(media_item) do
-    try do
-      case MetadataFileHelpers.read_compressed_metadata(media_item.metadata.metadata_filepath) do
-        {:ok, metadata} ->
-          Media.update_media_item(media_item, %{
-            nfo_filepath: NfoBuilder.build_and_store_for_media_item(media_item.nfo_filepath, metadata)
-          })
-
-        _err ->
-          Logger.error("Failed to read metadata for media item #{media_item.id}")
-      end
-    rescue
-      e -> Logger.error("Unknown error regenerating NFO file for MI ##{media_item.id}: #{inspect(e)}")
-    end
-  end
-end

lib/pinchflat/boot/post_job_startup_tasks.ex

@@ -7,9 +7,6 @@ defmodule Pinchflat.Boot.PostJobStartupTasks do
   Phoenix supervision tree.
   """
 
-  alias Pinchflat.Repo
-  alias Pinchflat.Boot.NfoBackfillWorker
-
   # restart: :temporary means that this process will never be restarted (ie: will run once and then die)
   use GenServer, restart: :temporary
   import Ecto.Query, warn: false
@@ -29,7 +26,7 @@ defmodule Pinchflat.Boot.PostJobStartupTasks do
   """
   @impl true
   def init(state) do
-    Repo.insert_unique_job(NfoBackfillWorker.new(%{}))
+    # Nothing at the moment!
 
     {:ok, state}
   end

lib/pinchflat/downloading/download_option_builder.ex

@@ -44,7 +44,6 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do
   defp default_options do
     [
       :no_progress,
-      :windows_filenames,
       # Add force-overwrites to make sure redownloading works
       :force_overwrites,
       # This makes the date metadata conform to what jellyfin expects

lib/pinchflat/metadata/source_metadata_storage_worker.ex

@@ -38,9 +38,9 @@ defmodule Pinchflat.Metadata.SourceMetadataStorageWorker do
     - The NFO file for the source (if specified)
     - Downloads and stores source images (if specified)
 
-  The worker is kicked off after a source is inserted/updated - this can
-  take an unknown amount of time so don't rely on this data being here
-  before, say, the first indexing or downloading task is complete.
+  The worker is kicked off after a source is inserted or it's original_url
+  is updated - this can take an unknown amount of time so don't rely on this
+  data being here before, say, the first indexing or downloading task is complete.
 
   Returns :ok
   """

lib/pinchflat/notifications/command_runner.ex

@@ -28,8 +28,7 @@ defmodule Pinchflat.Notifications.CommandRunner do
     default_opts = [:verbose]
     parsed_opts = CliUtils.parse_options(default_opts ++ command_opts)
 
-    Logger.info("[apprise] called with: #{Enum.join(parsed_opts ++ endpoints, " ")}")
-    {output, return_code} = System.cmd(backend_executable(), parsed_opts ++ endpoints)
+    {output, return_code} = CliUtils.wrap_cmd(backend_executable(), parsed_opts ++ endpoints)
     Logger.info("[apprise] response: #{output}")
 
     case return_code do

lib/pinchflat/sources/sources.ex

@@ -237,7 +237,7 @@ defmodule Pinchflat.Sources do
         if run_post_commit_tasks do
           maybe_handle_media_tasks(changeset, source)
           maybe_run_indexing_task(changeset, source)
-          run_metadata_storage_task(source)
+          maybe_run_metadata_storage_task(changeset, source)
         end
 
         {:ok, source}
@@ -276,9 +276,20 @@ defmodule Pinchflat.Sources do
     end
   end
 
-  # This runs every time to pick up any changes to the metadata
-  defp run_metadata_storage_task(source) do
+  defp maybe_run_metadata_storage_task(changeset, source) do
+    case {changeset.data, changeset.changes} do
+      # If the changeset is new (not persisted), fetch metadata no matter what
+      {%{__meta__: %{state: :built}}, _} ->
         SourceMetadataStorageWorker.kickoff_with_task(source)
+
+      # If the record has been persisted, only fetch metadata if the
+      # original_url has changed
+      {_, %{original_url: _}} ->
+        SourceMetadataStorageWorker.kickoff_with_task(source)
+
+      _ ->
+        :ok
+    end
   end
 
   defp maybe_update_slow_indexing_task(changeset, source) do

lib/pinchflat/utils/cli_utils.ex

@@ -3,6 +3,8 @@ defmodule Pinchflat.Utils.CliUtils do
   Utility methods for working with CLI executables
   """
 
+  require Logger
+
   alias Pinchflat.Utils.StringUtils
 
   @doc """
@@ -19,6 +21,8 @@ defmodule Pinchflat.Utils.CliUtils do
     wrapper_command = Path.join(:code.priv_dir(:pinchflat), "cmd_wrapper.sh")
     actual_command = [command] ++ args
 
+    Logger.info("[command_wrapper]: #{command} called with: #{Enum.join(args, " ")}")
+
     System.cmd(wrapper_command, actual_command, opts)
   end
 

lib/pinchflat/utils/number_utils.ex

@@ -0,0 +1,16 @@
+defmodule Pinchflat.Utils.NumberUtils do
+  @moduledoc """
+  Utility methods for working with numbers
+  """
+
+  @doc """
+  Clamps a number between a minimum and maximum value
+
+  Returns integer() | float()
+  """
+  def clamp(num, minimum, maximum) do
+    num
+    |> max(minimum)
+    |> min(maximum)
+  end
+end

lib/pinchflat/yt_dlp/command_runner.ex

@@ -3,8 +3,6 @@ defmodule Pinchflat.YtDlp.CommandRunner do
   Runs yt-dlp commands using the `System.cmd/3` function
   """
 
-  require Logger
-
   alias Pinchflat.Utils.CliUtils
   alias Pinchflat.YtDlp.YtDlpCommandRunner
   alias Pinchflat.Utils.FilesystemUtils, as: FSUtils
@@ -30,12 +28,10 @@ defmodule Pinchflat.YtDlp.CommandRunner do
 
     output_filepath = generate_output_filepath(addl_opts)
     print_to_file_opts = [{:print_to_file, output_template}, output_filepath]
-    external_file_opts = build_external_file_options()
+    user_configured_opts = cookie_file_options() ++ global_options()
     # These must stay in exactly this order, hence why I'm giving it its own variable.
-    all_opts = command_opts ++ print_to_file_opts ++ external_file_opts
-
+    all_opts = command_opts ++ print_to_file_opts ++ user_configured_opts
     formatted_command_opts = [url] ++ CliUtils.parse_options(all_opts)
-    Logger.info("[yt-dlp] called with: #{Enum.join(formatted_command_opts, " ")}")
 
     case CliUtils.wrap_cmd(command, formatted_command_opts, stderr_to_stdout: true) do
       {_, 0} ->
@@ -58,7 +54,7 @@ defmodule Pinchflat.YtDlp.CommandRunner do
   def version do
     command = backend_executable()
 
-    case System.cmd(command, ["--version"]) do
+    case CliUtils.wrap_cmd(command, ["--version"]) do
       {output, 0} ->
         {:ok, String.trim(output)}
 
@@ -74,7 +70,11 @@ defmodule Pinchflat.YtDlp.CommandRunner do
     end
   end
 
-  defp build_external_file_options do
+  defp global_options do
+    [:windows_filenames]
+  end
+
+  defp cookie_file_options do
     base_dir = Application.get_env(:pinchflat, :extras_directory)
     filename_options_map = %{cookies: "cookies.txt"}
 

lib/pinchflat/yt_dlp/media.ex

@@ -63,8 +63,8 @@ defmodule Pinchflat.YtDlp.Media do
         |> response_to_struct()
         |> FunctionUtils.wrap_ok()
 
-      res ->
-        res
+      err ->
+        err
     end
   end
 

lib/pinchflat/yt_dlp/media_collection.ex

@@ -50,8 +50,8 @@ defmodule Pinchflat.YtDlp.MediaCollection do
 
         {:ok, Enum.filter(parsed_lines, &(&1 != nil))}
 
-      res ->
-        res
+      err ->
+        err
     end
   end
 
@@ -68,7 +68,14 @@ defmodule Pinchflat.YtDlp.MediaCollection do
     # `ignore_no_formats_error` is necessary because yt-dlp will error out if
     # the first video has not released yet (ie: is a premier). We don't care about
     # available formats since we're just getting the source details
-    command_opts = [:simulate, :skip_download, :ignore_no_formats_error, playlist_end: 1] ++ addl_opts
+    default_opts = [
+      :simulate,
+      :skip_download,
+      :ignore_no_formats_error,
+      playlist_end: 1
+    ]
+
+    command_opts = default_opts ++ addl_opts
     output_template = "%(.{channel,channel_id,playlist_id,playlist_title,filename})j"
 
     with {:ok, output} <- backend_runner().run(source_url, command_opts, output_template),

lib/pinchflat_web/components/core_components.ex

@@ -19,7 +19,6 @@ defmodule PinchflatWeb.CoreComponents do
   import PinchflatWeb.Gettext
 
   alias Phoenix.LiveView.JS
-  alias PinchflatWeb.CustomComponents.TextComponents
 
   @doc """
   Renders a modal.
@@ -638,9 +637,11 @@ defmodule PinchflatWeb.CoreComponents do
 
     ~H"""
     <ul>
-      <li :for={{k, v} <- @iterable_attributes} class="mb-2">
+      <li :for={{k, v} <- @iterable_attributes} class="mb-2 w-2/3">
         <strong><%= k %>:</strong>
-        <TextComponents.inline_code><%= v %></TextComponents.inline_code>
+        <code class="inline-block text-sm font-mono text-gray p-0.5 mx-0.5">
+          <%= v %>
+        </code>
       </li>
     </ul>
     """

lib/pinchflat_web/components/custom_components/table_components.ex

@@ -2,6 +2,8 @@ defmodule PinchflatWeb.CustomComponents.TableComponents do
   @moduledoc false
   use Phoenix.Component
 
+  alias PinchflatWeb.CoreComponents
+
   @doc """
   Renders a table component with the given rows and columns.
 
@@ -50,4 +52,52 @@ defmodule PinchflatWeb.CustomComponents.TableComponents do
     </table>
     """
   end
+
+  @doc """
+  Renders simple pagination controls for a table in a liveview.
+
+  ## Examples
+
+      <.live_pagination_controls page_number={@page} total_pages={@total_pages} />
+  """
+  attr :page_number, :integer, default: 1
+  attr :total_pages, :integer, default: 1
+
+  def live_pagination_controls(assigns) do
+    ~H"""
+    <nav>
+      <ul class="flex flex-wrap items-center">
+        <li>
+          <span
+            class={[
+              "flex h-8 w-8 items-center justify-center rounded",
+              @page_number != 1 && "cursor-pointer hover:bg-primary hover:text-white",
+              @page_number == 1 && "cursor-not-allowed"
+            ]}
+            phx-click={@page_number != 1 && "page_change"}
+            phx-value-direction="dec"
+          >
+            <CoreComponents.icon name="hero-chevron-left" />
+          </span>
+        </li>
+        <li>
+          <span class="mx-2">Page <%= @page_number %> of <%= @total_pages %></span>
+        </li>
+        <li>
+          <span
+            class={[
+              "flex h-8 w-8 items-center justify-center rounded",
+              @page_number != @total_pages && "cursor-pointer hover:bg-primary hover:text-white",
+              @page_number == @total_pages && "cursor-not-allowed"
+            ]}
+            phx-click={@page_number != @total_pages && "page_change"}
+            phx-value-direction="inc"
+          >
+            <CoreComponents.icon name="hero-chevron-right" />
+          </span>
+        </li>
+      </ul>
+    </nav>
+    """
+  end
 end

lib/pinchflat_web/components/custom_components/text_components.ex

@@ -35,11 +35,12 @@ defmodule PinchflatWeb.CustomComponents.TextComponents do
   Renders a subtle link with the given href and content.
   """
   attr :href, :string, required: true
+  attr :target, :string, default: "_self"
   slot :inner_block
 
   def subtle_link(assigns) do
     ~H"""
-    <.link href={@href} class="underline decoration-bodydark decoration-1 hover:decoration-white">
+    <.link href={@href} target={@target} class="underline decoration-bodydark decoration-1 hover:decoration-white">
       <%= render_slot(@inner_block) %>
     </.link>
     """
@@ -59,4 +60,22 @@ defmodule PinchflatWeb.CustomComponents.TextComponents do
     </.link>
     """
   end
+
+  @doc """
+  Renders a block of text with each line broken into a separate span.
+  """
+  attr :text, :string, required: true
+
+  def break_on_newline(assigns) do
+    broken_text =
+      assigns.text
+      |> String.split("\n", trim: false)
+      |> Enum.intersperse(Phoenix.HTML.Tag.tag(:span, class: "inline-block mt-2"))
+
+    assigns = Map.put(assigns, :text, broken_text)
+
+    ~H"""
+    <span><%= @text %></span>
+    """
+  end
 end

lib/pinchflat_web/controllers/media_items/media_item_html/media_preview.heex

@@ -1,12 +1,12 @@
 <%= if media_type(@media_item) == :video do %>
-  <video controls class="max-h-96 w-full lg:w-2/3 xl:w-1/2">
+  <video controls class="max-h-96 w-full">
     <source src={~p"/media/#{@media_item.uuid}/stream"} type="video/mp4" />
     Your browser does not support the video element.
   </video>
 <% end %>
 
 <%= if media_type(@media_item) == :audio do %>
-  <audio controls class="w-full lg:w-2/3 xl:w-1/2">
+  <audio controls class="w-full">
     <source src={~p"/media/#{@media_item.uuid}/stream"} type="audio/mpeg" />
     Your browser does not support the audio element.
   </audio>

lib/pinchflat_web/controllers/media_items/media_item_html/show.html.heex

@@ -23,23 +23,33 @@
         <.actions_dropdown media_item={@media_item} />
       </:tab_append>
 
-      <:tab title="Attributes">
+      <:tab title="Media">
         <div class="flex flex-col gap-10 dark:text-white">
           <%= if media_file_exists?(@media_item) do %>
-            <h3 class="font-bold text-xl">Preview</h3>
+            <section class="grid grid-cols-1 xl:grid-cols-2 xl:gap-6 mt-6">
+              <div>
                 <.media_preview media_item={@media_item} />
+              </div>
+              <aside class="mt-4 xl:mt-0">
+                <div>Uploaded: <%= @media_item.upload_date %></div>
+                <div>
+                  <.subtle_link href={@media_item.original_url} target="_blank">Open Original</.subtle_link>
+                </div>
+                <div class="mt-4 text-bodydark">
+                  <.break_on_newline text={@media_item.description} />
+                </div>
+              </aside>
+            </section>
           <% end %>
 
-          <h2 class="font-bold text-2xl"><%= @media_item.title %></h2>
-          <h3 class="font-bold text-xl">Attributes</h3>
+          <h3 class="font-bold text-xl mt-6">Raw Attributes</h3>
           <section>
             <strong>Source:</strong>
             <.subtle_link href={~p"/sources/#{@media_item.source_id}"}>
               <%= @media_item.source.custom_name %>
             </.subtle_link>
-          </section>
-
             <.list_items_from_map map={Map.from_struct(@media_item)} />
+          </section>
         </div>
       </:tab>
       <:tab title="Tasks">

lib/pinchflat_web/controllers/media_profiles/media_profile_html/show.html.heex

@@ -43,9 +43,9 @@
         </.button_dropdown>
       </:tab_append>
 
-      <:tab title="Attributes">
+      <:tab title="Media Profile">
         <div class="flex flex-col gap-10 text-white">
-          <h3 class="font-bold text-xl">Attributes for "<%= @media_profile.name %>"</h3>
+          <h3 class="font-bold text-xl mt-6">Raw Attributes</h3>
           <.list_items_from_map map={Map.from_struct(@media_profile)} />
         </div>
       </:tab>

lib/pinchflat_web/controllers/pages/page_html/home.html.heex

@@ -16,12 +16,12 @@
     </a>
   </div>
   <div class="rounded-sm border px-7.5 py-6 shadow-default border-strokedark bg-boxdark">
-    <a href="#" class="mt-4 flex flex-col items-center justify-center">
+    <span class="mt-4 flex flex-col items-center justify-center">
       <span class="text-md font-medium">Media Item(s)</span>
       <h4 class="text-title-md font-bold text-white">
         <%= @media_item_count %>
       </h4>
-    </a>
+    </span>
   </div>
   <span class="text-strokedark">I know this page isn't super useful yet, but give it time :&rpar;</span>
 </div>

lib/pinchflat_web/controllers/sources/source_controller.ex

@@ -6,12 +6,11 @@ defmodule PinchflatWeb.Sources.SourceController do
   alias Pinchflat.Repo
   alias Pinchflat.Tasks
   alias Pinchflat.Sources
-  alias Pinchflat.MediaQuery
   alias Pinchflat.Sources.Source
-  alias Pinchflat.Media.MediaQuery
   alias Pinchflat.Profiles.MediaProfile
   alias Pinchflat.Downloading.DownloadingHelpers
   alias Pinchflat.SlowIndexing.SlowIndexingHelpers
+  alias Pinchflat.Metadata.SourceMetadataStorageWorker
 
   def index(conn, _params) do
     sources =
@@ -60,29 +59,7 @@ defmodule PinchflatWeb.Sources.SourceController do
       |> Tasks.list_tasks_for(nil, [:executing, :available, :scheduled, :retryable])
       |> Repo.preload(:job)
 
-    pending_media =
-      MediaQuery.new()
-      |> MediaQuery.for_source(source)
-      |> MediaQuery.where_pending_download()
-      |> order_by(desc: :id)
-      |> limit(100)
-      |> Repo.all()
-
-    downloaded_media =
-      MediaQuery.new()
-      |> MediaQuery.for_source(source)
-      |> MediaQuery.with_media_filepath()
-      |> order_by(desc: :id)
-      |> limit(100)
-      |> Repo.all()
-
-    render(conn, :show,
-      source: source,
-      pending_tasks: pending_tasks,
-      pending_media: pending_media,
-      downloaded_media: downloaded_media,
-      total_downloaded: total_downloaded_for(source)
-    )
+    render(conn, :show, source: source, pending_tasks: pending_tasks)
   end
 
   def edit(conn, %{"id" => id}) do
@@ -128,20 +105,38 @@ defmodule PinchflatWeb.Sources.SourceController do
   end
 
   def force_download(conn, %{"source_id" => id}) do
-    source = Sources.get_source!(id)
-    DownloadingHelpers.enqueue_pending_download_tasks(source)
-
-    conn
-    |> put_flash(:info, "Forced download of pending media items.")
-    |> redirect(to: ~p"/sources/#{source}")
+    wrap_forced_action(
+      conn,
+      id,
+      "Forcing download of pending media items.",
+      &DownloadingHelpers.enqueue_pending_download_tasks/1
+    )
   end
 
   def force_index(conn, %{"source_id" => id}) do
-    source = Sources.get_source!(id)
-    SlowIndexingHelpers.kickoff_indexing_task(source, %{force: true})
+    wrap_forced_action(
+      conn,
+      id,
+      "Index enqueued.",
+      &SlowIndexingHelpers.kickoff_indexing_task(&1, %{force: true})
+    )
+  end
+
+  def force_metadata_refresh(conn, %{"source_id" => id}) do
+    wrap_forced_action(
+      conn,
+      id,
+      "Metadata refresh enqueued.",
+      &SourceMetadataStorageWorker.kickoff_with_task/1
+    )
+  end
+
+  defp wrap_forced_action(conn, source_id, message, fun) do
+    source = Sources.get_source!(source_id)
+    fun.(source)
 
     conn
-    |> put_flash(:info, "Index enqueued.")
+    |> put_flash(:info, message)
     |> redirect(to: ~p"/sources/#{source}")
   end
 
@@ -151,13 +146,6 @@ defmodule PinchflatWeb.Sources.SourceController do
     |> Repo.all()
   end
 
-  defp total_downloaded_for(source) do
-    MediaQuery.new()
-    |> MediaQuery.for_source(source)
-    |> MediaQuery.with_media_filepath()
-    |> Repo.aggregate(:count, :id)
-  end
-
   defp get_onboarding_layout do
     if Settings.get!(:onboarding) do
       {Layouts, :onboarding}

lib/pinchflat_web/controllers/sources/source_html.ex

@@ -36,6 +36,15 @@ defmodule PinchflatWeb.Sources.SourceHTML do
     |> Phoenix.json_library().encode!()
   end
 
+  def title_filter_regex_help do
+    url = "https://github.com/nalgeon/sqlean/blob/main/docs/regexp.md#supported-syntax"
+    classes = "underline decoration-bodydark decoration-1 hover:decoration-white"
+
+    """
+    A PCRE-compatible regex. Only media with titles that match this regex will be downloaded. <a href="#{url}" class="#{classes}" target="_blank">See here</a> for syntax
+    """
+  end
+
   def output_path_template_override_help do
     help_button_classes = "underline decoration-bodydark decoration-1 hover:decoration-white cursor-pointer"
     help_button = ~s{<span class="#{help_button_classes}" x-on:click="$dispatch('load-template')">Click here</span>}

lib/pinchflat_web/controllers/sources/source_html/actions_dropdown.html.heex

@@ -30,6 +30,15 @@
       Force Index
     </.link>
   </:option>
+  <:option>
+    <.link
+      href={~p"/sources/#{@source}/force_metadata_refresh"}
+      method="post"
+      data-confirm="Are you sure you want to refresh this source's metadata?"
+    >
+      Refresh Metadata
+    </.link>
+  </:option>
   <:option>
     <div class="h-px w-full bg-bodydark2"></div>
   </:option>

lib/pinchflat_web/controllers/sources/source_html/media_item_table_live.ex

@@ -0,0 +1,91 @@
+defmodule Pinchflat.Sources.MediaItemTableLive do
+  use PinchflatWeb, :live_view
+  import Ecto.Query, warn: false
+
+  alias Pinchflat.Repo
+  alias Pinchflat.Sources
+  alias Pinchflat.Media.MediaQuery
+  alias Pinchflat.Utils.NumberUtils
+
+  @limit 10
+
+  def render(%{records: []} = assigns) do
+    ~H"""
+    <p class="text-black dark:text-white">Nothing Here!</p>
+    """
+  end
+
+  def render(assigns) do
+    ~H"""
+    <div>
+      <span class="mb-4 inline-block">
+        Showing <%= length(@records) %> of <%= @total_record_count %>
+      </span>
+      <.table rows={@records} table_class="text-black dark:text-white">
+        <:col :let={media_item} label="Title">
+          <.subtle_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"}>
+            <%= StringUtils.truncate(media_item.title, 50) %>
+          </.subtle_link>
+        </:col>
+        <:col :let={media_item} label="" class="flex place-content-evenly">
+          <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" class="mx-1" />
+          <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}/edit"} icon="hero-pencil-square" class="mx-1" />
+        </:col>
+      </.table>
+      <section class="flex justify-center mt-5">
+        <.live_pagination_controls page_number={@page} total_pages={@total_pages} />
+      </section>
+    </div>
+    """
+  end
+
+  def mount(_params, session, socket) do
+    page = 1
+    media_state = session["media_state"]
+    source = Sources.get_source!(session["source_id"])
+    base_query = generate_base_query(source, media_state)
+    pagination_attrs = fetch_pagination_attributes(base_query, page)
+
+    {:ok, assign(socket, Map.merge(pagination_attrs, %{base_query: base_query, source: source}))}
+  end
+
+  def handle_event("page_change", %{"direction" => direction}, %{assigns: assigns} = socket) do
+    direction = if direction == "inc", do: 1, else: -1
+    new_page = assigns.page + direction
+    new_assigns = fetch_pagination_attributes(assigns.base_query, new_page)
+
+    {:noreply, assign(socket, new_assigns)}
+  end
+
+  defp fetch_pagination_attributes(base_query, page) do
+    total_record_count = Repo.aggregate(base_query, :count, :id)
+    total_pages = max(ceil(total_record_count / @limit), 1)
+    page = NumberUtils.clamp(page, 1, total_pages)
+    records = fetch_records(base_query, page)
+
+    %{page: page, total_pages: total_pages, records: records, total_record_count: total_record_count}
+  end
+
+  defp fetch_records(base_query, page) do
+    offset = (page - 1) * @limit
+
+    base_query
+    |> limit(^@limit)
+    |> offset(^offset)
+    |> Repo.all()
+  end
+
+  defp generate_base_query(source, "pending") do
+    MediaQuery.new()
+    |> MediaQuery.for_source(source)
+    |> MediaQuery.where_pending_download()
+    |> order_by(desc: :id)
+  end
+
+  defp generate_base_query(source, "downloaded") do
+    MediaQuery.new()
+    |> MediaQuery.for_source(source)
+    |> MediaQuery.with_media_filepath()
+    |> order_by(desc: :id)
+  end
+end

lib/pinchflat_web/controllers/sources/source_html/show.html.heex

@@ -23,9 +23,9 @@
         <.actions_dropdown source={@source} conn={@conn} />
       </:tab_append>
 
-      <:tab title="Attributes">
+      <:tab title="Source">
         <div class="flex flex-col gap-10 text-white">
-          <h3 class="font-bold text-lg">Attributes</h3>
+          <h3 class="font-bold text-xl mt-6">Raw Attributes</h3>
           <section>
             <strong>Media Profile:</strong>
             <.subtle_link href={~p"/media_profiles/#{@source.media_profile_id}"}>
@@ -37,48 +37,18 @@
         </div>
       </:tab>
       <:tab title="Pending Media">
-        <%= if match?([_|_], @pending_media) do %>
-          <h4 class="text-white text-lg mb-6">Shows a maximum of 100 media items</h4>
-          <.table rows={@pending_media} table_class="text-black dark:text-white">
-            <:col :let={media_item} label="Title">
-              <.subtle_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"}>
-                <%= StringUtils.truncate(media_item.title, 50) %>
-              </.subtle_link>
-            </:col>
-            <:col :let={media_item} label="" class="flex place-content-evenly">
-              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" class="mx-1" />
-              <.icon_link
-                href={~p"/sources/#{@source.id}/media/#{media_item.id}/edit"}
-                icon="hero-pencil-square"
-                class="mx-1"
-              />
-            </:col>
-          </.table>
-        <% else %>
-          <p class="text-black dark:text-white">Nothing Here!</p>
-        <% end %>
+        <%= live_render(
+          @conn,
+          Pinchflat.Sources.MediaItemTableLive,
+          session: %{"source_id" => @source.id, "media_state" => "pending"}
+        ) %>
       </:tab>
       <:tab title="Downloaded Media">
-        <%= if match?([_|_], @downloaded_media) do %>
-          <h4 class="text-white text-lg mb-6">Shows a maximum of 100 media items (<%= @total_downloaded %> total)</h4>
-          <.table rows={@downloaded_media} table_class="text-black dark:text-white">
-            <:col :let={media_item} label="Title">
-              <.subtle_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"}>
-                <%= StringUtils.truncate(media_item.title, 50) %>
-              </.subtle_link>
-            </:col>
-            <:col :let={media_item} label="" class="flex place-content-evenly">
-              <.icon_link href={~p"/sources/#{@source.id}/media/#{media_item.id}"} icon="hero-eye" class="mx-1" />
-              <.icon_link
-                href={~p"/sources/#{@source.id}/media/#{media_item.id}/edit"}
-                icon="hero-pencil-square"
-                class="mx-1"
-              />
-            </:col>
-          </.table>
-        <% else %>
-          <p class="text-black dark:text-white">Nothing Here!</p>
-        <% end %>
+        <%= live_render(
+          @conn,
+          Pinchflat.Sources.MediaItemTableLive,
+          session: %{"source_id" => @source.id, "media_state" => "downloaded"}
+        ) %>
       </:tab>
       <:tab title="Pending Tasks">
         <%= if match?([_|_], @pending_tasks) do %>

lib/pinchflat_web/controllers/sources/source_html/source_form.html.heex

@@ -23,7 +23,7 @@
       field={f[:custom_name]}
       type="text"
       label="Custom Name"
-      help="Something descriptive. Does not impact indexing or downloading"
+      help="Does not impact indexing or downloading. Will be inferred from the source if left blank"
     />
 
     <.input field={f[:original_url]} type="text" label="Source URL" help="URL of a channel or playlist (required)" />
@@ -111,7 +111,8 @@
         type="text"
         label="Title Filter Regex"
         placeholder="(?i)^How to Bike$"
-        help="A PCRE-compatible regex. Only media with titles that match this regex will be downloaded. Look up 'SQLean Regex docs' for more"
+        help={title_filter_regex_help()}
+        html_help={true}
       />
 
       <section

lib/pinchflat_web/router.ex

@@ -35,6 +35,7 @@ defmodule PinchflatWeb.Router do
     resources "/sources", Sources.SourceController do
       post "/force_download", Sources.SourceController, :force_download
       post "/force_index", Sources.SourceController, :force_index
+      post "/force_metadata_refresh", Sources.SourceController, :force_metadata_refresh
 
       resources "/media", MediaItems.MediaItemController, only: [:show, :edit, :update, :delete] do
         post "/force_download", MediaItems.MediaItemController, :force_download

mix.exs

@@ -4,7 +4,7 @@ defmodule Pinchflat.MixProject do
   def project do
     [
       app: :pinchflat,
-      version: "0.1.14",
+      version: "0.1.15",
       elixir: "~> 1.16",
       elixirc_paths: elixirc_paths(Mix.env()),
       start_permanent: Mix.env() == :prod,

test/pinchflat/downloading/download_option_builder_test.exs

@@ -53,7 +53,6 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilderTest do
       assert {:ok, res} = DownloadOptionBuilder.build(media_item)
 
       assert :no_progress in res
-      assert :windows_filenames in res
       assert :force_overwrites in res
       assert {:parse_metadata, "%(upload_date>%Y-%m-%d)s:(?P<meta_date>.+)"} in res
     end

test/pinchflat/fast_indexing/fast_indexing_helpers_test.exs

@@ -89,5 +89,25 @@ defmodule Pinchflat.FastIndexing.FastIndexingHelpersTest do
 
       refute_enqueued(worker: MediaDownloadWorker)
     end
+
+    test "does not blow up if a media item cannot be created", %{source: source} do
+      expect(HTTPClientMock, :get, fn _url -> {:ok, "<yt:videoId>test_1</yt:videoId>"} end)
+
+      stub(YtDlpRunnerMock, :run, fn _url, _opts, _ot ->
+        {:ok, "{}"}
+      end)
+
+      assert [] = FastIndexingHelpers.kickoff_download_tasks_from_youtube_rss_feed(source)
+    end
+
+    test "does not blow up if a media item causes a yt-dlp error", %{source: source} do
+      expect(HTTPClientMock, :get, fn _url -> {:ok, "<yt:videoId>test_1</yt:videoId>"} end)
+
+      stub(YtDlpRunnerMock, :run, fn _url, _opts, _ot ->
+        {:error, "message", 1}
+      end)
+
+      assert [] = FastIndexingHelpers.kickoff_download_tasks_from_youtube_rss_feed(source)
+    end
   end
 end

test/pinchflat/sources_test.exs

@@ -131,6 +131,18 @@ defmodule Pinchflat.SourcesTest do
       assert String.starts_with?(source.collection_id, "some_playlist_id_")
     end
 
+    test "adds an error if the runner fails" do
+      expect(YtDlpRunnerMock, :run, fn _url, _opts, _ot -> {:error, "some error", 1} end)
+
+      valid_attrs = %{
+        media_profile_id: media_profile_fixture().id,
+        original_url: "https://www.youtube.com/channel/abc123"
+      }
+
+      assert {:error, %Ecto.Changeset{} = changeset} = Sources.create_source(valid_attrs)
+      assert "could not fetch source details from URL" in errors_on(changeset).original_url
+    end
+
     test "you can specify a custom custom_name" do
       expect(YtDlpRunnerMock, :run, &channel_mock/3)
 
@@ -502,14 +514,24 @@ defmodule Pinchflat.SourcesTest do
       assert source.index_frequency_minutes == 0
     end
 
-    test "updating will kickoff a metadata storage worker" do
+    test "updating will kickoff a metadata storage worker if the original_url changes" do
+      expect(YtDlpRunnerMock, :run, &playlist_mock/3)
       source = source_fixture()
-      update_attrs = %{name: "some updated name"}
+      update_attrs = %{original_url: "https://www.youtube.com/channel/cba321"}
 
       assert {:ok, %Source{} = source} = Sources.update_source(source, update_attrs)
 
       assert_enqueued(worker: SourceMetadataStorageWorker, args: %{"id" => source.id})
     end
+
+    test "updating will not kickoff a metadata storage worker other attrs change" do
+      source = source_fixture()
+      update_attrs = %{name: "some new name"}
+
+      assert {:ok, %Source{}} = Sources.update_source(source, update_attrs)
+
+      refute_enqueued(worker: SourceMetadataStorageWorker)
+    end
   end
 
   describe "update_source/3 when testing options" do

test/pinchflat/utils/number_utils_test.exs

@@ -0,0 +1,19 @@
+defmodule Pinchflat.Utils.NumberUtilsTest do
+  use ExUnit.Case, async: true
+
+  alias Pinchflat.Utils.NumberUtils
+
+  describe "clamp/3" do
+    test "returns the minimum when the number is less than the minimum" do
+      assert NumberUtils.clamp(1, 2, 3) == 2
+    end
+
+    test "returns the maximum when the number is greater than the maximum" do
+      assert NumberUtils.clamp(4, 2, 3) == 3
+    end
+
+    test "returns the number when it is between the minimum and maximum" do
+      assert NumberUtils.clamp(2, 1, 3) == 2
+    end
+  end
+end

test/pinchflat/yt_dlp/command_runner_test.exs

@@ -78,6 +78,14 @@ defmodule Pinchflat.YtDlp.CommandRunnerTest do
     end
   end
 
+  describe "run/4 when testing global options" do
+    test "creates windows-safe filenames" do
+      assert {:ok, output} = Runner.run(@media_url, [], "")
+
+      assert String.contains?(output, "--windows-filenames")
+    end
+  end
+
   describe "version/0" do
     test "adds the version arg" do
       assert {:ok, output} = Runner.version()

test/pinchflat_web/controllers/source_controller_test.exs

@@ -9,6 +9,7 @@ defmodule PinchflatWeb.SourceControllerTest do
   alias Pinchflat.Repo
   alias Pinchflat.Settings
   alias Pinchflat.Downloading.MediaDownloadWorker
+  alias Pinchflat.Metadata.SourceMetadataStorageWorker
   alias Pinchflat.SlowIndexing.MediaCollectionIndexingWorker
 
   setup do
@@ -215,6 +216,23 @@ defmodule PinchflatWeb.SourceControllerTest do
     end
   end
 
+  describe "force_metadata_refresh" do
+    test "forces a metadata refresh", %{conn: conn} do
+      source = source_fixture()
+
+      assert [] = all_enqueued(worker: SourceMetadataStorageWorker)
+      post(conn, ~p"/sources/#{source.id}/force_metadata_refresh")
+      assert [_] = all_enqueued(worker: SourceMetadataStorageWorker)
+    end
+
+    test "redirects to the source page", %{conn: conn} do
+      source = source_fixture()
+
+      conn = post(conn, ~p"/sources/#{source.id}/force_metadata_refresh")
+      assert redirected_to(conn) == ~p"/sources/#{source.id}"
+    end
+  end
+
   defp create_source(_) do
     source = source_fixture()
     media_item = media_item_with_attachments(%{source_id: source.id})

test/pinchflat_web/controllers/sources/media_item_table_live_test.exs

@@ -0,0 +1,60 @@
+defmodule PinchflatWeb.Sources.MediaItemTableLiveTest do
+  use PinchflatWeb.ConnCase
+
+  import Phoenix.LiveViewTest
+  import Pinchflat.MediaFixtures
+  import Pinchflat.SourcesFixtures
+
+  alias Pinchflat.Sources.MediaItemTableLive
+
+  setup do
+    source = source_fixture()
+
+    {:ok, source: source}
+  end
+
+  describe "initial rendering" do
+    test "shows message when no records", %{conn: conn, source: source} do
+      {:ok, _view, html} = live_isolated(conn, MediaItemTableLive, session: create_session(source))
+
+      assert html =~ "Nothing Here!"
+      refute html =~ "Showing"
+    end
+
+    test "shows records when present", %{conn: conn, source: source} do
+      media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+
+      {:ok, _view, html} = live_isolated(conn, MediaItemTableLive, session: create_session(source))
+
+      assert html =~ "Showing 1 of 1"
+      assert html =~ "Title"
+      assert html =~ media_item.title
+    end
+  end
+
+  describe "media_state" do
+    test "shows pending media when pending", %{conn: conn, source: source} do
+      downloaded_media_item = media_item_fixture(source_id: source.id)
+      pending_media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+
+      {:ok, _view, html} = live_isolated(conn, MediaItemTableLive, session: create_session(source, "pending"))
+
+      assert html =~ pending_media_item.title
+      refute html =~ downloaded_media_item.title
+    end
+
+    test "shows downloaded media when downloaded", %{conn: conn, source: source} do
+      downloaded_media_item = media_item_fixture(source_id: source.id)
+      pending_media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+
+      {:ok, _view, html} = live_isolated(conn, MediaItemTableLive, session: create_session(source, "downloaded"))
+
+      assert html =~ downloaded_media_item.title
+      refute html =~ pending_media_item.title
+    end
+  end
+
+  defp create_session(source, media_state \\ "pending") do
+    %{"source_id" => source.id, "media_state" => media_state}
+  end
+end