Improved robustness of file downloads (#225)

test/pinchflat/downloading/download_option_builder_test.exs

@@ -259,7 +259,7 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilderTest do
       assert {:ok, res} = DownloadOptionBuilder.build(media_item)
 
       assert :extract_audio in res
-      assert {:format, "bestaudio[ext=m4a]"} in res
+      assert {:format, "bestaudio[ext=m4a]/bestaudio[ext=mp3]/bestaudio/best[ext=m4a]/best[ext=mp3]/best"} in res
 
       refute {:remux_video, "mp4"} in res
     end

test/pinchflat/metadata/metadata_file_helpers_test.exs

@@ -89,6 +89,48 @@ defmodule Pinchflat.Metadata.MetadataFileHelpersTest do
 
       assert filepath =~ ~r{/media_items/#{media_item.id}/img_2.jpg}
     end
+
+    test "will fall back to a non-jpg if it has to", %{media_item: media_item} do
+      metadata = %{
+        "thumbnails" => [
+          %{"url" => "https://i.ytimg.com/vi/ABC123/img_1.webp", "preference" => -1}
+        ]
+      }
+
+      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+
+      assert filepath =~ ~r{/media_items/#{media_item.id}/img_1.webp}
+    end
+
+    test "does not require a preference field", %{media_item: media_item} do
+      metadata = %{
+        "thumbnails" => [
+          %{"url" => "https://i.ytimg.com/vi/ABC123/img_1.webp"}
+        ]
+      }
+
+      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+
+      assert filepath =~ ~r{/media_items/#{media_item.id}/img_1.webp}
+    end
+  end
+
+  describe "download_and_store_thumbnail_for/2 when not downloading thumbnails" do
+    test "returns nil if there are no thumbnails", %{media_item: media_item} do
+      metadata = %{"thumbnails" => []}
+
+      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+
+      assert filepath == nil
+    end
+
+    test "returns nil if there is no thumbnail field", %{media_item: media_item} do
+      metadata = %{}
+
+      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+
+      assert filepath == nil
+    end
   end
 
   describe "parse_upload_date/1" do

test/pinchflat/metadata/metadata_parser_test.exs

@@ -46,6 +46,14 @@ defmodule Pinchflat.Metadata.MetadataParserTest do
       assert result.livestream == metadata["was_live"]
     end
 
+    test "the livestream flag defaults to false", %{metadata: metadata} do
+      metadata = Map.put(metadata, "was_live", nil)
+
+      result = Parser.parse_for_media_item(metadata)
+
+      assert result.livestream == false
+    end
+
     test "it extracts the duration in seconds", %{metadata: metadata} do
       result = Parser.parse_for_media_item(metadata)
 

test/pinchflat/yt_dlp/media_test.exs

@@ -199,5 +199,16 @@ defmodule Pinchflat.YtDlp.MediaTest do
 
       assert %Media{duration_seconds: nil} = Media.response_to_struct(response)
     end
+
+    test "sets livestream to false if the was_live field isn't present" do
+      response = %{
+        "webpage_url" => "https://www.youtube.com/watch?v=TiZPUDkDYbk",
+        "aspect_ratio" => 1.0,
+        "duration" => 60,
+        "upload_date" => "20210101"
+      }
+
+      assert %Media{livestream: false} = Media.response_to_struct(response)
+    end
   end
 end