Switched thumbnail downloading to use yt-dlp (#281)

test/pinchflat/metadata/metadata_file_helpers_test.exs

@@ -50,82 +50,37 @@ defmodule Pinchflat.Metadata.MetadataFileHelpersTest do
   end
 
   describe "download_and_store_thumbnail_for/2" do
-    setup do
-      # This tests that the HTTP endpoint is being called with every test
-      expect(HTTPClientMock, :get, fn _url, _headers, _opts ->
-        {:ok, "thumbnail data"}
+    test "returns the filepath", %{media_item: media_item} do
+      stub(YtDlpRunnerMock, :run, fn _url, _opts, _ot -> {:ok, ""} end)
+
+      filepath = Helpers.download_and_store_thumbnail_for(media_item)
+
+      assert filepath =~ ~r{/media_items/#{media_item.id}/thumbnail.jpg}
+    end
+
+    test "calls yt-dlp with the expected options", %{media_item: media_item} do
+      expect(YtDlpRunnerMock, :run, fn url, opts, ot ->
+        assert url == media_item.original_url
+        assert ot == "after_move:%()j"
+
+        assert opts == [
+                 :no_simulate,
+                 :skip_download,
+                 :write_thumbnail,
+                 convert_thumbnail: "jpg",
+                 output: "/tmp/test/metadata/media_items/1/thumbnail.%(ext)s"
+               ]
+
+        {:ok, ""}
       end)
 
-      metadata = render_parsed_metadata(:media_metadata)
-
-      {:ok, %{metadata: metadata}}
+      Helpers.download_and_store_thumbnail_for(media_item)
     end
 
-    test "returns the filepath", %{media_item: media_item, metadata: metadata} do
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+    test "returns nil if yt-dlp fails", %{media_item: media_item} do
+      stub(YtDlpRunnerMock, :run, fn _url, _opts, _ot -> {:error, "error"} end)
 
-      assert filepath =~ ~r{/media_items/#{media_item.id}/maxresdefault.jpg}
-    end
-
-    test "creates folder structure based on passed record", %{media_item: media_item, metadata: metadata} do
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
-
-      assert File.exists?(Path.dirname(filepath))
-    end
-
-    test "chooses the highest preference jpg thumbnail available", %{media_item: media_item} do
-      metadata = %{
-        "thumbnails" => [
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_1.jpg", "preference" => -1},
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_2.jpg", "preference" => 1},
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_3.jpg", "preference" => -10},
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_4.webp", "preference" => 10}
-        ]
-      }
-
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
-
-      assert filepath =~ ~r{/media_items/#{media_item.id}/img_2.jpg}
-    end
-
-    test "will fall back to a non-jpg if it has to", %{media_item: media_item} do
-      metadata = %{
-        "thumbnails" => [
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_1.webp", "preference" => -1}
-        ]
-      }
-
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
-
-      assert filepath =~ ~r{/media_items/#{media_item.id}/img_1.webp}
-    end
-
-    test "does not require a preference field", %{media_item: media_item} do
-      metadata = %{
-        "thumbnails" => [
-          %{"url" => "https://i.ytimg.com/vi/ABC123/img_1.webp"}
-        ]
-      }
-
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
-
-      assert filepath =~ ~r{/media_items/#{media_item.id}/img_1.webp}
-    end
-  end
-
-  describe "download_and_store_thumbnail_for/2 when not downloading thumbnails" do
-    test "returns nil if there are no thumbnails", %{media_item: media_item} do
-      metadata = %{"thumbnails" => []}
-
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
-
-      assert filepath == nil
-    end
-
-    test "returns nil if there is no thumbnail field", %{media_item: media_item} do
-      metadata = %{}
-
-      filepath = Helpers.download_and_store_thumbnail_for(media_item, metadata)
+      filepath = Helpers.download_and_store_thumbnail_for(media_item)
 
       assert filepath == nil
     end