[Housekeeping] Improve test stability (#232)

* Ensured all tests use at least the DataCase module

* addressed one flakey test

* More flakey tests

* Consolidated Mox usage

test/pinchflat_web/controllers/media_item_controller_test.exs

@@ -1,14 +1,11 @@
 defmodule PinchflatWeb.MediaItemControllerTest do
   use PinchflatWeb.ConnCase
 
-  import Mox
   import Pinchflat.MediaFixtures
 
   alias Pinchflat.Repo
   alias Pinchflat.Downloading.MediaDownloadWorker
 
-  setup :verify_on_exit!
-
   describe "show media" do
     setup [:create_media_item]
 

test/pinchflat_web/controllers/media_profile_controller_test.exs

@@ -1,7 +1,6 @@
 defmodule PinchflatWeb.MediaProfileControllerTest do
   use PinchflatWeb.ConnCase
 
-  import Mox
   import Pinchflat.MediaFixtures
   import Pinchflat.SourcesFixtures
   import Pinchflat.ProfilesFixtures
@@ -16,8 +15,6 @@ defmodule PinchflatWeb.MediaProfileControllerTest do
   }
   @invalid_attrs %{name: nil, output_path_template: nil}
 
-  setup :verify_on_exit!
-
   setup do
     Settings.set(onboarding: false)
 
@@ -41,7 +38,7 @@ defmodule PinchflatWeb.MediaProfileControllerTest do
       Settings.set(onboarding: true)
       conn = get(conn, ~p"/media_profiles/new")
 
-      refute html_response(conn, 200) =~ "MENU"
+      refute html_response(conn, 200) =~ "<span>MENU</span>"
     end
   end
 

test/pinchflat_web/controllers/settings/apprise_server_live_test.exs

@@ -1,13 +1,10 @@
 defmodule PinchflatWeb.Settings.AppriseServerLiveTest do
   use PinchflatWeb.ConnCase
 
-  import Mox
   import Phoenix.LiveViewTest
 
   alias Pinchflat.Settings.AppriseServerLive
 
-  setup :verify_on_exit!
-
   describe "initial rendering" do
     test "renders the input", %{conn: conn} do
       {:ok, _view, html} = live_isolated(conn, AppriseServerLive, session: create_session(""))

test/pinchflat_web/controllers/source_controller_test.exs

@@ -1,6 +1,5 @@
 defmodule PinchflatWeb.SourceControllerTest do
   use PinchflatWeb.ConnCase
-  import Mox
 
   import Pinchflat.MediaFixtures
   import Pinchflat.SourcesFixtures
@@ -32,8 +31,6 @@ defmodule PinchflatWeb.SourceControllerTest do
     }
   end
 
-  setup :verify_on_exit!
-
   describe "index" do
     test "lists all sources", %{conn: conn} do
       conn = get(conn, ~p"/sources")

test/pinchflat_web/controllers/sources/media_item_table_live_test.exs

@@ -34,8 +34,10 @@ defmodule PinchflatWeb.Sources.MediaItemTableLiveTest do
 
   describe "media_state" do
     test "shows pending media when pending", %{conn: conn, source: source} do
-      downloaded_media_item = media_item_fixture(source_id: source.id)
-      pending_media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+      downloaded_media_item = media_item_fixture(source_id: source.id, title: "DL-#{Enum.random(0..9999)}")
+
+      pending_media_item =
+        media_item_fixture(source_id: source.id, media_filepath: nil, title: "P-#{Enum.random(0..9999)}")
 
       {:ok, _view, html} = live_isolated(conn, MediaItemTableLive, session: create_session(source, "pending"))