Media item lifecycle improvements (#18)

* Added jobs for enqueuing/dequeuing media based on source's status

* adds lifecycle columns to source and media_item tables

test/pinchflat/media_client/video_downloader_test.exs

@@ -57,6 +57,12 @@ defmodule Pinchflat.MediaClient.VideoDownloaderTest do
       :ok
     end
 
+    test "it sets the media_downloaded_at", %{media_item: media_item} do
+      assert media_item.media_downloaded_at == nil
+      assert {:ok, updated_media_item} = VideoDownloader.download_for_media_item(media_item)
+      assert DateTime.diff(DateTime.utc_now(), updated_media_item.media_downloaded_at) < 1
+    end
+
     test "it extracts the title", %{media_item: media_item} do
       assert {:ok, updated_media_item} = VideoDownloader.download_for_media_item(media_item)
       assert updated_media_item.title == "Trying to Wheelie Without the Rear Brake"

test/pinchflat/media_source_test.exs

@@ -2,12 +2,15 @@ defmodule Pinchflat.MediaSourceTest do
   use Pinchflat.DataCase
   import Mox
   import Pinchflat.TasksFixtures
+  import Pinchflat.MediaFixtures
   import Pinchflat.ProfilesFixtures
   import Pinchflat.MediaSourceFixtures
 
   alias Pinchflat.MediaSource
+  alias Pinchflat.Tasks.SourceTasks
   alias Pinchflat.MediaSource.Source
   alias Pinchflat.Workers.MediaIndexingWorker
+  alias Pinchflat.Workers.VideoDownloadWorker
 
   @invalid_source_attrs %{name: nil, collection_id: nil}
 
@@ -173,6 +176,27 @@ defmodule Pinchflat.MediaSourceTest do
       refute_enqueued(worker: MediaIndexingWorker, args: %{"id" => source.id})
     end
 
+    test "enabling the download_media attribute will schedule a download task" do
+      source = source_fixture(download_media: false)
+      media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+      update_attrs = %{download_media: true}
+
+      refute_enqueued(worker: VideoDownloadWorker)
+      assert {:ok, %Source{}} = MediaSource.update_source(source, update_attrs)
+      assert_enqueued(worker: VideoDownloadWorker, args: %{"id" => media_item.id})
+    end
+
+    test "disabling the download_media attribute will cancel the download task" do
+      source = source_fixture(download_media: true)
+      media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+      update_attrs = %{download_media: false}
+      SourceTasks.enqueue_pending_media_tasks(source)
+
+      assert_enqueued(worker: VideoDownloadWorker, args: %{"id" => media_item.id})
+      assert {:ok, %Source{}} = MediaSource.update_source(source, update_attrs)
+      refute_enqueued(worker: VideoDownloadWorker)
+    end
+
     test "updates with invalid data returns error changeset" do
       source = source_fixture()
 

test/pinchflat/tasks/source_tasks_test.exs

@@ -103,14 +103,23 @@ defmodule Pinchflat.Tasks.SourceTasksTest do
       assert Enum.all?(first_run, fn %MediaItem{} -> true end)
       assert Enum.all?(duplicate_run, fn %Ecto.Changeset{} -> true end)
     end
+
+    test "it updates the source's last_indexed_at field", %{source: source} do
+      assert source.last_indexed_at == nil
+
+      SourceTasks.index_media_items(source)
+      source = Repo.reload!(source)
+
+      assert DateTime.diff(DateTime.utc_now(), source.last_indexed_at) < 1
+    end
   end
 
-  describe "enqueue_pending_media_downloads/1" do
+  describe "enqueue_pending_media_tasks/1" do
     test "it enqueues a job for each pending media item" do
       source = source_fixture()
       media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
 
-      assert :ok = SourceTasks.enqueue_pending_media_downloads(source)
+      assert :ok = SourceTasks.enqueue_pending_media_tasks(source)
 
       assert_enqueued(worker: VideoDownloadWorker, args: %{"id" => media_item.id})
     end
@@ -119,7 +128,7 @@ defmodule Pinchflat.Tasks.SourceTasksTest do
       source = source_fixture()
       _media_item = media_item_fixture(source_id: source.id, media_filepath: "some/filepath.mp4")
 
-      assert :ok = SourceTasks.enqueue_pending_media_downloads(source)
+      assert :ok = SourceTasks.enqueue_pending_media_tasks(source)
 
       refute_enqueued(worker: VideoDownloadWorker)
     end
@@ -130,7 +139,7 @@ defmodule Pinchflat.Tasks.SourceTasksTest do
 
       assert [] = Tasks.list_tasks_for(:media_item_id, media_item.id)
 
-      assert :ok = SourceTasks.enqueue_pending_media_downloads(source)
+      assert :ok = SourceTasks.enqueue_pending_media_tasks(source)
 
       assert [_] = Tasks.list_tasks_for(:media_item_id, media_item.id)
     end
@@ -138,7 +147,7 @@ defmodule Pinchflat.Tasks.SourceTasksTest do
     test "it does not create a job if the source is set to not download" do
       source = source_fixture(download_media: false)
 
-      assert :ok = SourceTasks.enqueue_pending_media_downloads(source)
+      assert :ok = SourceTasks.enqueue_pending_media_tasks(source)
 
       refute_enqueued(worker: VideoDownloadWorker)
     end
@@ -147,7 +156,22 @@ defmodule Pinchflat.Tasks.SourceTasksTest do
       source = source_fixture(download_media: false)
       media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
 
-      assert :ok = SourceTasks.enqueue_pending_media_downloads(source)
+      assert :ok = SourceTasks.enqueue_pending_media_tasks(source)
+      assert [] = Tasks.list_tasks_for(:media_item_id, media_item.id)
+    end
+  end
+
+  describe "dequeue_pending_media_tasks/1" do
+    test "it deletes all pending tasks for a source's media items" do
+      source = source_fixture()
+      media_item = media_item_fixture(source_id: source.id, media_filepath: nil)
+
+      SourceTasks.enqueue_pending_media_tasks(source)
+      assert_enqueued(worker: VideoDownloadWorker, args: %{"id" => media_item.id})
+
+      assert :ok = SourceTasks.dequeue_pending_media_tasks(source)
+
+      refute_enqueued(worker: VideoDownloadWorker)
       assert [] = Tasks.list_tasks_for(:media_item_id, media_item.id)
     end
   end