José Valim
5edb1d2739
When you are working on large files and you add new code,
you may forget to add a `do` or an `end`. In those cases,
the error message usually points to the first `do` or the
last `end` in the file, which are usually far away from
the source of the error.
This pull request adds a simple heuristic based on the
indentation of the tokens, to try to provide hints of
where the source may be. Those hints are not deterministic
but they may be able to point users to the source of the
problem.
For example, in this case:
defmodule MyApp do
def one do
# end
def two do
end
end
we know that we now that `def two do` is happening on the
same indentation as `def one do`, which may mean that
`def one do` was not closed properly. We store this as a
hint in case the terminators do not match later.
Similarly, in the case below:
defmodule MyApp do
def one
end
def two do
end
end
The `end` on line 3 will end-up closing the defmodule `do`,
on line 1. Because their indentation do not match, it may
be that there is a missing `do`, where the `end` was supposed
to align.
Some basic testing show those heuristics work on the majority
of the cases, but we will only be sure when we have enough
feedback from the community.
189 lines
6.1 KiB
Erlang
189 lines
6.1 KiB
Erlang
-module(string_test).
|
|
-include("../../src/elixir.hrl").
|
|
-include_lib("eunit/include/eunit.hrl").
|
|
|
|
eval(Content) ->
|
|
{Value, Binding, _, _} = elixir:eval(Content, []),
|
|
{Value, Binding}.
|
|
|
|
extract_interpolations(String) ->
|
|
Tokenizer = #elixir_tokenizer{file = <<"nofile">>},
|
|
case elixir_interpolation:extract(1, 1, Tokenizer, true, String ++ [$"], $") of
|
|
{error, Error} ->
|
|
Error;
|
|
{_, _, Z, _} ->
|
|
Z
|
|
end.
|
|
|
|
% Interpolations
|
|
|
|
extract_interpolations_without_interpolation_test() ->
|
|
[<<"foo">>] = extract_interpolations("foo").
|
|
|
|
extract_interpolations_with_escaped_interpolation_test() ->
|
|
[<<"f\\#{o}o">>] = extract_interpolations("f\\#{o}o"),
|
|
{1, 8, [<<"f\\#{o}o">>], []} = elixir_interpolation:extract(1, 2,
|
|
#elixir_tokenizer{file = <<"nofile">>}, true, "f\\#{o}o\"", $").
|
|
|
|
extract_interpolations_with_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{atom, {1, 4, nil}, o}]},
|
|
<<"o">>] = extract_interpolations("f#{:o}o").
|
|
|
|
extract_interpolations_with_two_interpolations_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{atom, {1, 4, nil}, o}]}, {{1, 7, 1}, [{atom, {1, 9, nil}, o}]},
|
|
<<"o">>] = extract_interpolations("f#{:o}#{:o}o").
|
|
|
|
extract_interpolations_with_only_two_interpolations_test() ->
|
|
[{{1, 1, 1}, [{atom, {1, 3, nil}, o}]},
|
|
{{1, 6, 1}, [{atom, {1, 8, nil}, o}]}] = extract_interpolations("#{:o}#{:o}").
|
|
|
|
extract_interpolations_with_tuple_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{'{', {1, 4, nil}}, {int, {1, 5, 1}, "1"}, {'}', {1, 6, nil}}]},
|
|
<<"o">>] = extract_interpolations("f#{{1}}o").
|
|
|
|
extract_interpolations_with_many_expressions_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 2}, [{int, {1, 4, 1}, "1"}, {eol, {1, 5, 1}}, {int, {2, 1, 2}, "2"}]},
|
|
<<"o">>] = extract_interpolations("f#{1\n2}o").
|
|
|
|
extract_interpolations_with_right_curly_inside_string_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{bin_string, {1, 4, nil}, [<<"f}o">>]}]},
|
|
<<"o">>] = extract_interpolations("f#{\"f}o\"}o").
|
|
|
|
extract_interpolations_with_left_curly_inside_string_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{bin_string, {1, 4, nil}, [<<"f{o">>]}]},
|
|
<<"o">>] = extract_interpolations("f#{\"f{o\"}o").
|
|
|
|
extract_interpolations_with_escaped_quote_inside_string_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{bin_string, {1, 4, nil}, [<<"f\"o">>]}]},
|
|
<<"o">>] = extract_interpolations("f#{\"f\\\"o\"}o").
|
|
|
|
extract_interpolations_with_less_than_operation_inside_interpolation_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{int, {1, 4, 1}, "1"}, {rel_op, {1, 5, nil}, '<'}, {int, {1, 6, 2}, "2"}]},
|
|
<<"o">>] = extract_interpolations("f#{1<2}o").
|
|
|
|
extract_interpolations_with_an_escaped_character_test() ->
|
|
[<<"f">>,
|
|
{{1, 2, 1}, [{char, {1, 4, "?\\a"}, 7}, {rel_op, {1, 8, nil}, '>'}, {char, {1, 10, "?\\a"}, 7}]}
|
|
] = extract_interpolations("f#{?\\a > ?\\a }").
|
|
|
|
extract_interpolations_with_invalid_expression_inside_interpolation_test() ->
|
|
{1, 4, "unexpected token: ", _} = extract_interpolations("f#{:1}o").
|
|
|
|
%% Bin strings
|
|
|
|
empty_bin_string_test() ->
|
|
{<<"">>, _} = eval("\"\"").
|
|
|
|
simple_bin_string_test() ->
|
|
{<<"foo">>, _} = eval("\"foo\"").
|
|
|
|
bin_string_with_double_quotes_test() ->
|
|
{<<"f\"o\"o">>, _} = eval("\"f\\\"o\\\"o\"").
|
|
|
|
bin_string_with_newline_test() ->
|
|
{<<"f\no">>, _} = eval("\"f\no\"").
|
|
|
|
bin_string_with_slash_test() ->
|
|
{<<"f\\o">>, _} = eval("\"f\\\\o\"").
|
|
|
|
bin_string_with_bell_character_test() ->
|
|
{<<"f\ao">>, _} = eval("\"f\ao\"").
|
|
|
|
bin_string_with_interpolation_test() ->
|
|
{<<"foo">>, _} = eval("\"f#{\"o\"}o\"").
|
|
|
|
bin_string_with_another_string_inside_string_inside_interpolation_test() ->
|
|
{<<"fbaro">>, _} = eval("\"f#{\"b#{\"a\"}r\"}o\"").
|
|
|
|
bin_string_with_another_string_with_curly_inside_interpolation_test() ->
|
|
{<<"fb}ro">>, _} = eval("\"f#{\"b}r\"}o\"").
|
|
|
|
bin_string_with_atom_with_separator_inside_interpolation_test() ->
|
|
{<<"f}o">>, _} = eval("\"f#{\"}\"}o\"").
|
|
|
|
bin_string_with_lower_case_hex_interpolation_test() ->
|
|
{<<"jklmno">>, _} = eval("\"\\x6a\\x6b\\x6c\\x6d\\x6e\\x6f\"").
|
|
|
|
bin_string_with_upper_case_hex_interpolation_test() ->
|
|
{<<"jklmno">>, _} = eval("\"\\x6A\\x6B\\x6C\\x6D\\x6E\\x6F\"").
|
|
|
|
bin_string_without_interpolation_and_escaped_test() ->
|
|
{<<"f#o">>, _} = eval("\"f\\#o\"").
|
|
|
|
bin_string_with_escaped_interpolation_test() ->
|
|
{<<"f#{'o}o">>, _} = eval("\"f\\#{'o}o\"").
|
|
|
|
bin_string_with_the_end_of_line_slash_test() ->
|
|
{<<"fo">>, _} = eval("\"f\\\no\""),
|
|
{<<"fo">>, _} = eval("\"f\\\r\no\"").
|
|
|
|
invalid_string_interpolation_test() ->
|
|
?assertError(#{'__struct__' := 'Elixir.TokenMissingError'}, eval("\"f#{some\"")),
|
|
?assertError(#{'__struct__' := 'Elixir.TokenMissingError'}, eval("\"f#{1+")).
|
|
|
|
unterminated_string_interpolation_test() ->
|
|
?assertError(#{'__struct__' := 'Elixir.TokenMissingError'}, eval("\"foo")).
|
|
|
|
%% List strings
|
|
|
|
empty_list_string_test() ->
|
|
{[], _} = eval("\'\'").
|
|
|
|
simple_list_string_test() ->
|
|
{"foo", _} = eval("'foo'").
|
|
|
|
list_string_with_double_quotes_test() ->
|
|
{"f'o'o", _} = eval("'f\\'o\\'o'").
|
|
|
|
list_string_with_newline_test() ->
|
|
{"f\no", _} = eval("'f\no'").
|
|
|
|
list_string_with_slash_test() ->
|
|
{"f\\o", _} = eval("'f\\\\o'").
|
|
|
|
list_string_with_bell_character_test() ->
|
|
{"f\ao", _} = eval("'f\ao'").
|
|
|
|
list_string_with_interpolation_test() ->
|
|
{"foo", _} = eval("'f#{\"o\"}o'").
|
|
|
|
list_string_with_another_string_with_curly_inside_interpolation_test() ->
|
|
{"fb}ro", _} = eval("'f#{\"b}r\"}o'").
|
|
|
|
list_string_with_atom_with_separator_inside_interpolation_test() ->
|
|
{"f}o", _} = eval("'f#{\"}\"}o'").
|
|
|
|
list_string_with_lower_case_hex_interpolation_test() ->
|
|
{"JKLMNO", _} = eval("'\\x4a\\x4b\\x4c\\x4d\\x4e\\x4f'").
|
|
|
|
list_string_with_upper_case_hex_interpolation_test() ->
|
|
{"JKLMNO", _} = eval("'\\x4A\\x4B\\x4C\\x4D\\x4E\\x4F'").
|
|
|
|
list_string_without_interpolation_and_escaped_test() ->
|
|
{"f#o", _} = eval("'f\\#o'").
|
|
|
|
list_string_with_escaped_interpolation_test() ->
|
|
{"f#{\"o}o", _} = eval("'f\\#{\"o}o'").
|
|
|
|
list_string_with_the_end_of_line_slash_test() ->
|
|
{"fo", _} = eval("'f\\\no'"),
|
|
{"fo", _} = eval("'f\\\r\no'").
|
|
|
|
char_test() ->
|
|
{99, []} = eval("?1 + ?2"),
|
|
{10, []} = eval("?\\n"),
|
|
{40, []} = eval("?\\(").
|
|
|
|
%% Binaries
|
|
|
|
bitstr_with_int_test() ->
|
|
{<<"fdo">>, _} = eval("<< \"f\", 50+50, \"o\" >>").
|