Michał Muskała
399769d1cd
orelse may lead to better code in many occasions - Since we're comparing
to literals, there's no semantic difference.
This also means, the compiler is able to figure out more "will always match"
checks. For example in a situation like the following a warning will be emitted.
This pull request also fixes such warnings in the test suite.
if true do
IO.puts("true")
end
One problem with using `orelse` is that it will short-circuit and not evaluate
some side-effecting things, for example:
1 in [1, send(self(), :foo)]
To remedy this, we'll traverse the right side of `in` and extract any things
that are not simple literals to variables, so that the above example expands
to something like the following:
var0 = send(seld(), :foo)
var = 1
var === 1 or var === var0
This guarantees all side-effects are performed and we still retain benefits of
the short-circuiting comparisons in the end.
231 lines
7.0 KiB
Erlang
231 lines
7.0 KiB
Erlang
-module(control_test).
|
|
-include_lib("eunit/include/eunit.hrl").
|
|
|
|
eval(Content) ->
|
|
{Value, Binding, _, _} = elixir:eval(Content, []),
|
|
{Value, Binding}.
|
|
|
|
to_erl(String) ->
|
|
Forms = elixir:'string_to_quoted!'(String, 1, <<"nofile">>, []),
|
|
{Expr, _, _} = elixir:quoted_to_erl(Forms, elixir:env_for_eval([])),
|
|
Expr.
|
|
|
|
% Booleans
|
|
|
|
booleans_test() ->
|
|
{nil, _} = eval("nil"),
|
|
{true, _} = eval("true"),
|
|
{false, _} = eval("false").
|
|
|
|
% If
|
|
|
|
if_else_kv_args_test() ->
|
|
{1, _} = eval("if(true, do: 1)"),
|
|
{nil, _} = eval("if(false, do: 1)"),
|
|
{2, _} = eval("if(false, do: 1, else: 2)").
|
|
|
|
if_else_kv_blocks_test() ->
|
|
{2, _} = eval("if(false) do\n1\nelse\n2\nend"),
|
|
{2, _} = eval("if(false) do 1 else 2 end"),
|
|
{2, _} = eval("if(false) do 1;else 2; end").
|
|
|
|
multi_line_if_test() ->
|
|
{1, _} = eval("if true\ndo\n1\nelse\n2\nend").
|
|
|
|
% Try
|
|
|
|
try_test() ->
|
|
{2, _} = eval("try do\n:foo.bar\ncatch\n:error, :undef -> 2\nend").
|
|
|
|
try_else_test() ->
|
|
{true, _} = eval("try do\n1\nelse 2 -> false\n1 -> true\nrescue\nErlangError -> nil\nend"),
|
|
{true, _} = eval("try do\n1\nelse {x, y} -> false\nx -> true\nrescue\nErlangError -> nil\nend"),
|
|
{true, _} = eval("try do\n{1, 2}\nelse {3, 4} -> false\n_ -> true\nrescue\nErlangError -> nil\nend").
|
|
|
|
% Receive
|
|
|
|
receive_test() ->
|
|
{10, _} = eval("send self(), :foo\nreceive do\n:foo -> 10\nend"),
|
|
{20, _} = eval("send self(), :bar\nreceive do\n:foo -> 10\n_ -> 20\nend"),
|
|
{30, _} = eval("receive do\nafter 1 -> 30\nend").
|
|
|
|
% Case
|
|
|
|
case_test() ->
|
|
{true, []} = eval("case 1 do\n2 -> false\n1 -> true\nend"),
|
|
{true, []} = eval("case 1 do\n{x, y} -> false\nx -> true\nend"),
|
|
{true, []} = eval("case {1, 2} do; {3, 4} -> false\n_ -> true\nend").
|
|
|
|
case_with_do_ambiguity_test() ->
|
|
{true, _} = eval("case Atom.to_charlist(true) do\n_ -> true\nend").
|
|
|
|
case_with_match_do_ambiguity_test() ->
|
|
{true, _} = eval("case x = Atom.to_charlist(true) do\n_ -> true\nend").
|
|
|
|
case_with_unary_do_ambiguity_test() ->
|
|
{false, _} = eval("! case Atom.to_charlist(true) do\n_ -> true\nend").
|
|
|
|
% Comparison
|
|
|
|
equal_test() ->
|
|
{true, _} = eval(":a == :a"),
|
|
{true, _} = eval("1 == 1"),
|
|
{true, _} = eval("{1, 2} == {1, 2}"),
|
|
{false, _} = eval("1 == 2"),
|
|
{false, _} = eval("{1, 2} == {1, 3}").
|
|
|
|
not_equal_test() ->
|
|
{false, _} = eval(":a != :a"),
|
|
{false, _} = eval("1 != 1"),
|
|
{false, _} = eval("{1, 2} != {1, 2}"),
|
|
{true, _} = eval("1 != 2"),
|
|
{true, _} = eval("{1, 2} != {1, 3}").
|
|
|
|
not_exclamation_mark_test() ->
|
|
{false, _} = eval("! :a"),
|
|
{false, _} = eval("!true"),
|
|
{false, _} = eval("!1"),
|
|
{false, _} = eval("![]"),
|
|
{true, _} = eval("!nil"),
|
|
{true, _} = eval("!false").
|
|
|
|
notnot_exclamation_mark_test() ->
|
|
{true, _} = eval("!! :a"),
|
|
{true, _} = eval("!!true"),
|
|
{true, _} = eval("!!1"),
|
|
{true, _} = eval("!![]"),
|
|
{false, _} = eval("!!nil"),
|
|
{false, _} = eval("!!false").
|
|
|
|
less_greater_test() ->
|
|
{true, _} = eval("1 < 2"),
|
|
{true, _} = eval("1 < :a"),
|
|
{false, _} = eval("1 < 1.0"),
|
|
{false, _} = eval("1 < 1"),
|
|
{true, _} = eval("1 <= 1.0"),
|
|
{true, _} = eval("1 <= 1"),
|
|
{true, _} = eval("1 <= :a"),
|
|
{false, _} = eval("1 > 2"),
|
|
{false, _} = eval("1 > :a"),
|
|
{false, _} = eval("1 > 1.0"),
|
|
{false, _} = eval("1 > 1"),
|
|
{true, _} = eval("1 >= 1.0"),
|
|
{true, _} = eval("1 >= 1"),
|
|
{false, _} = eval("1 >= :a").
|
|
|
|
integer_and_float_test() ->
|
|
{true, _} = eval("1 == 1"),
|
|
{false, _} = eval("1 != 1"),
|
|
{true, _} = eval("1 == 1.0"),
|
|
{false, _} = eval("1 != 1.0"),
|
|
{true, _} = eval("1 === 1"),
|
|
{false, _} = eval("1 !== 1"),
|
|
{false, _} = eval("1 === 1.0"),
|
|
{true, _} = eval("1 !== 1.0").
|
|
|
|
not_test() ->
|
|
{false, _} = eval("not true"),
|
|
{true, _} = eval("not false"),
|
|
?assertError(badarg, eval("not 1")).
|
|
|
|
rearrange_not_left_in_right_test() ->
|
|
%% TODO: Deprecate "not left in right" rearrangement.
|
|
{true, _} = eval("not false in []"),
|
|
{false, _} = eval("not true in [true]").
|
|
|
|
rearrange_left_not_in_right_test() ->
|
|
{true, _} = eval("false not in []"),
|
|
{false, _} = eval("true not in [true]").
|
|
|
|
andand_test() ->
|
|
F = fun() ->
|
|
eval("defmodule Bar do\ndef foo, do: true\ndef bar, do: false\n def baz(x), do: x == 1\nend"),
|
|
{true, _} = eval("Kernel.&&(true, true)"),
|
|
{true, _} = eval("true && true"),
|
|
{false, _} = eval("true && false"),
|
|
{false, _} = eval("false && true"),
|
|
{false, _} = eval("false && false"),
|
|
{nil, _} = eval("true && nil"),
|
|
{nil, _} = eval("nil && true"),
|
|
{false, _} = eval("false && nil"),
|
|
{true, _} = eval("Bar.foo && Bar.foo"),
|
|
{false, _} = eval("Bar.foo && Bar.bar"),
|
|
{true, _} = eval("Bar.foo && Bar.baz 1"),
|
|
{false, _} = eval("Bar.foo && Bar.baz 2"),
|
|
{true, _} = eval("1 == 1 && 2 < 3"),
|
|
{3, _} = eval("Bar.foo && 1 + 2"),
|
|
{false, _} = eval("Bar.bar && :erlang.error(:bad)"),
|
|
{2, _} = eval("1 && 2"),
|
|
{nil, _} = eval("nil && 2")
|
|
end,
|
|
test_helper:run_and_remove(F, ['Elixir.Bar']).
|
|
|
|
andand_with_literal_test() ->
|
|
{[nil, nil, nil], _} = eval("[nil && 2, nil && 3, nil && 4]").
|
|
|
|
oror_test() ->
|
|
F = fun() ->
|
|
eval("defmodule Bar do\ndef foo, do: true\ndef bar, do: false\n def baz(x), do: x == 1\nend"),
|
|
{true, _} = eval("Kernel.||(false, true)"),
|
|
{true, _} = eval("true || true"),
|
|
{true, _} = eval("true || false"),
|
|
{true, _} = eval("false || true"),
|
|
{false, _} = eval("false || false"),
|
|
{false, _} = eval("nil || false"),
|
|
{nil, _} = eval("false || nil"),
|
|
{true, _} = eval("false || nil || true"),
|
|
{true, _} = eval("Bar.foo || Bar.foo"),
|
|
{true, _} = eval("Bar.foo || Bar.bar"),
|
|
{false, _} = eval("Bar.bar || Bar.bar"),
|
|
{true, _} = eval("Bar.bar || Bar.baz 1"),
|
|
{false, _} = eval("Bar.bar || Bar.baz 2"),
|
|
{false, _} = eval("1 == 2 || 2 > 3"),
|
|
{3, _} = eval("Bar.bar || 1 + 2"),
|
|
{true, _} = eval("Bar.foo || :erlang.error(:bad)"),
|
|
{1, _} = eval("1 || 2"),
|
|
{2, _} = eval("nil || 2"),
|
|
{true, _} = eval("false && false || true")
|
|
end,
|
|
test_helper:run_and_remove(F, ['Elixir.Bar']).
|
|
|
|
cond_line_test() ->
|
|
{'case', 1, _,
|
|
[{clause, 2, _, _, _},
|
|
{clause, 3, _, _, _}]
|
|
} = to_erl("cond do\n 1 -> :ok\n 2 -> :ok\nend").
|
|
|
|
% Optimized
|
|
|
|
optimized_if_test() ->
|
|
{'case', _, _,
|
|
[{clause, _, [{atom, _, false}], [], [{atom, _, else}]},
|
|
{clause, _, [{atom, _, true}], [], [{atom, _, do}]}]
|
|
} = to_erl("if is_list([]), do: :do, else: :else").
|
|
|
|
optimized_andand_test() ->
|
|
{'case', _, _,
|
|
[{clause, _,
|
|
[{var, _, Var}],
|
|
[[{op, _, 'orelse', _, _}]],
|
|
[{var, _, Var}]},
|
|
{clause, _, [{var, _, '_'}], [], [{atom, 0, done}]}]
|
|
} = to_erl("is_list([]) && :done").
|
|
|
|
optimized_oror_test() ->
|
|
{'case', _, _,
|
|
[{clause, 1,
|
|
[{var, 1, _}],
|
|
[[{op, 1, 'orelse', _, _}]],
|
|
[{atom, 0, done}]},
|
|
{clause, 1, [{var, 1, Var}], [], [{var, 1, Var}]}]
|
|
} = to_erl("is_list([]) || :done").
|
|
|
|
no_after_in_try_test() ->
|
|
{'try', _, [_], [_], _, []} = to_erl("try do :foo.bar() else _ -> :ok end").
|
|
|
|
optimized_inspect_interpolation_test() ->
|
|
{bin, _,
|
|
[{bin_element, _,
|
|
{call, _, {remote, _,{atom, _, 'Elixir.Kernel'}, {atom, _, inspect}}, [_]},
|
|
default, [binary]}]} = to_erl("\"#{inspect(1)}\"").
|