Revert "Get rid of defp in favor of data and @visibility :private."

This reverts commit 20e4b3a5f9.
This commit is contained in:
José Valim
2012-01-20 22:55:03 +01:00
parent c318731c1e
commit ee2c03217e
27 changed files with 199 additions and 227 deletions
+10 -12
View File
@@ -29,24 +29,22 @@ defimpl String::Inspect, for: Atom do
atom_to_binary(atom, :utf8)
end
@visibility :private
# Detect if atom is a module reference (::Foo::Bar::Baz)
def valid_const_identifier?([?:,?:,h|t]) when h >= ?A & h <= ?Z do
defp valid_const_identifier?([?:,?:,h|t]) when h >= ?A & h <= ?Z do
valid_const_identifier? valid_identifier?(t)
end
def valid_const_identifier?(else), do: else
defp valid_const_identifier?(else), do: else
# Detect if atom is :letter_or_underscore
def valid_identifier?([h|t]) when
defp valid_identifier?([h|t]) when
(h >= ?a & h <= ?z) | (h >= ?A & h <= ?Z) | (h == ?_) do
valid_identifier? t
end
def valid_identifier?(else), do: else
defp valid_identifier?(else), do: else
end
defimpl String::Inspect, for: BitString do
@@ -71,17 +69,17 @@ defimpl String::Inspect, for: BitString do
as_bitstring(thing)
end
@visibility :private
## Helpers
def as_bitstring(thing) do
defp as_bitstring(thing) do
erlang = Erlang.io_lib.format('~p', [thing])
list_to_binary List.reverse(replace(erlang, []))
end
def replace([?:|t], acc), do: replace(t, [?||acc])
def replace([h|t], acc) when is_list(h), do: replace(t, replace(h, acc))
def replace([h|t], acc), do: replace(t, [h|acc])
def replace([], acc), do: acc
defp replace([?:|t], acc), do: replace(t, [?||acc])
defp replace([h|t], acc) when is_list(h), do: replace(t, replace(h, acc))
defp replace([h|t], acc), do: replace(t, [h|acc])
defp replace([], acc), do: acc
end
defimpl String::Inspect, for: List do