From cdf2d3932fe646ea5eb195c9e69cfb5fbb7cf5ee Mon Sep 17 00:00:00 2001 From: Eksperimental Date: Fri, 23 Apr 2021 15:03:13 +0000 Subject: [PATCH] Refrain GitHub CI from failing in development branches (#10948) Move continue-on-error to step level. Apparently this setting works different when set at the task and the step level https://github.com/actions/toolkit/issues/399#issuecomment-738700569 Now the CI will be considered as successful if the development branches fail. --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fe1b08f4de..cbf6ca2184 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,6 @@ env: jobs: test_linux: name: Linux, ${{ matrix.otp_release }}, Ubuntu 16.04 - continue-on-error: ${{ matrix.development }} strategy: fail-fast: false matrix: @@ -47,8 +46,10 @@ jobs: run: dialyzer -pa lib/elixir/ebin --build_plt --output_plt elixir.plt --apps lib/elixir/ebin/elixir.beam lib/elixir/ebin/Elixir.Kernel.beam - name: Erlang test suite run: make test_erlang + continue-on-error: ${{ matrix.development }} - name: Elixir test suite run: make test_elixir + continue-on-error: ${{ matrix.development }} - name: Check reproducible builds run: taskset 1 make check_reproducible if: matrix.otp_release == 'OTP-23.0'