Hide Logs button for unrun jobs; remove inbox filter bar; bump to 1.8
Build iOS App / Build .ipa and publish source (push) Successful in 23s
Build iOS App / Build .ipa and publish source (push) Successful in 23s
- Checks: only show the Logs button once a job has actually run (terminal conclusion). Queued/running jobs are grey with no logs, so the button was useless there. - Inbox: remove the segmented filter bar (All/Assigned/By me/Review) — not useful yet. Bump to 1.8.
This commit is contained in:
1 parent
9f3fb95cbe
commit
de9729b898
3 files changed
+24
-25
No files matched your search
@@ -19,9 +19,7 @@ struct InboxView: View {
|
||||
ContentUnavailableView(
|
||||
"No open PRs",
|
||||
systemImage: "tray",
|
||||
description: Text(vm.filter == .all
|
||||
? "Nothing to review."
|
||||
: "No PRs match this filter."))
|
||||
description: Text("Nothing to review."))
|
||||
} else {
|
||||
List {
|
||||
ForEach(vm.displayedRows) { row in
|
||||
@@ -38,17 +36,6 @@ struct InboxView: View {
|
||||
.toolbar {
|
||||
ToolbarItem(placement: .primaryAction) { settingsButton }
|
||||
}
|
||||
.toolbar {
|
||||
ToolbarItemGroup(placement: .bottomBar) {
|
||||
Picker("Filter", selection: $vm.filter) {
|
||||
ForEach(InboxFilter.allCases) { f in
|
||||
Text(f.rawValue).tag(f)
|
||||
}
|
||||
}
|
||||
.pickerStyle(.segmented)
|
||||
.disabled(vm.displayedRows.isEmpty && vm.isLoading)
|
||||
}
|
||||
}
|
||||
.navigationDestination(for: PRRow.self) { row in
|
||||
PRDetailView(repo: row.repo, prNumber: row.pr.number)
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user