Hide Logs button for unrun jobs; remove inbox filter bar; bump to 1.8
Build iOS App / Build .ipa and publish source (push) Successful in 23s
Build iOS App / Build .ipa and publish source (push) Successful in 23s
- Checks: only show the Logs button once a job has actually run (terminal conclusion). Queued/running jobs are grey with no logs, so the button was useless there. - Inbox: remove the segmented filter bar (All/Assigned/By me/Review) — not useful yet. Bump to 1.8.
This commit is contained in:
1 parent
9f3fb95cbe
commit
de9729b898
3 files changed
+24
-25
No files matched your search
@@ -218,14 +218,16 @@ struct ChecksTab: View {
|
||||
.font(.caption)
|
||||
.buttonStyle(.bordered)
|
||||
}
|
||||
NavigationLink {
|
||||
JobLogsView(repo: vm.repo, runID: run.id, jobID: job.id,
|
||||
jobName: job.name)
|
||||
} label: {
|
||||
Text("Logs")
|
||||
.font(.caption)
|
||||
if hasRun(job) {
|
||||
NavigationLink {
|
||||
JobLogsView(repo: vm.repo, runID: run.id, jobID: job.id,
|
||||
jobName: job.name)
|
||||
} label: {
|
||||
Text("Logs")
|
||||
.font(.caption)
|
||||
}
|
||||
.buttonStyle(.bordered)
|
||||
}
|
||||
.buttonStyle(.bordered)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -263,4 +265,14 @@ struct ChecksTab: View {
|
||||
let c = (job.conclusion ?? "").lowercased()
|
||||
return c == "failure" || c == "cancelled"
|
||||
}
|
||||
|
||||
/// A job has run only once it has a terminal conclusion. Queued/running
|
||||
/// jobs (grey, no logs yet) hide the Logs button.
|
||||
private func hasRun(_ job: ActionJob) -> Bool {
|
||||
let s = job.status.lowercased()
|
||||
if s == "queued" || s == "running" || s == "waiting" || s == "requested" {
|
||||
return false
|
||||
}
|
||||
return (job.conclusion ?? "").lowercased() != ""
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user