From 43f4d763569a226bb75866b3fcae18253cdbf4ae Mon Sep 17 00:00:00 2001
From: Hermes <hermes@bueso.me>
Date: Wed, 12 Aug 2026 18:01:35 +0000
Subject: [PATCH] Bump to 1.1 and read version from built app in CI

SideStore only shows an update when the version changes; the previous build
stayed at 1.0 so no update appeared. Bump MARKETING_VERSION to 1.1 and have
the workflow read CFBundleShortVersionString from the built app's Info.plist
instead of a hardcoded VERSION, so the metadata can never drift from the
pbxproj again.
---
 .gitea/workflows/build.yml        | 9 ++++++++-
 GiteaPR.xcodeproj/project.pbxproj | 8 ++++----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/.gitea/workflows/build.yml b/.gitea/workflows/build.yml
index 260590a..cae851f 100644
--- a/.gitea/workflows/build.yml
+++ b/.gitea/workflows/build.yml
@@ -54,9 +54,16 @@ jobs:
 
       - name: Generate app metadata
         run: |
-          VERSION="1.0"
+          # Read the version from the built app's Info.plist so it can never
+          # drift from MARKETING_VERSION in the pbxproj. SideStore only shows an
+          # update when the version changes, so a stale hardcoded version here
+          # silently hides new builds.
+          APP_PATH=$(find build/Build/Products -name "*.app" -type d | head -1)
+          VERSION=$(/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$APP_PATH/Info.plist")
+          BUILD=$(/usr/libexec/PlistBuddy -c "Print :CFBundleVersion" "$APP_PATH/Info.plist")
           SIZE=$(stat -f%z $APP_NAME.ipa)
           DATE=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
+          echo "version=$VERSION build=$BUILD"
           # Per-app metadata file. The perlis aggregator folds this into the
           # root source.json at https://apps.bueso.eu/source.json.
           cat > $APP_NAME.json <<EOF
diff --git a/GiteaPR.xcodeproj/project.pbxproj b/GiteaPR.xcodeproj/project.pbxproj
index 4d234f3..5d29b16 100644
--- a/GiteaPR.xcodeproj/project.pbxproj
+++ b/GiteaPR.xcodeproj/project.pbxproj
@@ -187,7 +187,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 2;
 				DEVELOPMENT_TEAM = "";
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_KEY_CFBundleDisplayName = "GiteaPR";
@@ -197,7 +197,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 1.0;
+				MARKETING_VERSION = 1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = com.bueso.giteapr;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_EMIT_LOC_STRINGS = YES;
@@ -211,7 +211,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 1;
+				CURRENT_PROJECT_VERSION = 2;
 				DEVELOPMENT_TEAM = "";
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_KEY_CFBundleDisplayName = "GiteaPR";
@@ -221,7 +221,7 @@
 					"$(inherited)",
 					"@executable_path/Frameworks",
 				);
-				MARKETING_VERSION = 1.0;
+				MARKETING_VERSION = 1.1;
 				PRODUCT_BUNDLE_IDENTIFIER = com.bueso.giteapr;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SWIFT_EMIT_LOC_STRINGS = YES;